summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)AuthorFilesLines
2017-08-09Annotate some more Timers and IdlesJan-Marek Glogowski1-0/+1
Reviewed-on: https://gerrit.libreoffice.org/40188 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Conflicts: sfx2/source/view/ipclient.cxx svx/inc/sdr/contact/objectcontactofpageview.hxx Change-Id: Ic8ca00db385ed59bb16744581f9d7cc0fcbb4f5b
2017-08-09Reorganize Scheduler priority classesJan-Marek Glogowski1-1/+1
This is based on glibs classification of tasks, but while glib uses an int for more fine grained priority, we stay with our enum. 1. Timers start with DEFAULT priority, which directly corresponds with the previous HIGH priority 2. Idles start with DEFAULT_IDLE priority instead of the previous HIGH priority, so idle default becomes "really run when idle". As RESIZE and REPAINT are special, and the DEFAULTS are set, there is just one primary decision for the programmer: should my idle run before paint (AKA HIGH_IDLE)? If we really need a more fine-grained classification, we can add it later, or also switch to a real int. As a result, this drops many classifications from the code and drastically changes behaviour, AKA a mail merge from KDE is now as fast as Gtk+ again. Conflicts: formula/source/ui/dlg/formula.cxx svx/source/sdr/event/eventhandler.cxx sw/source/uibase/docvw/srcedtw.cxx sw/source/uibase/utlui/unotools.cxx vcl/source/uitest/uno/uiobject_uno.cxx Change-Id: I498a73fd02d5fb6f5d7e9f742f3bce972de9b1f9
2017-08-09Change all Idle* LINKs to be Timer*Jan-Marek Glogowski9-12/+12
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Conflicts: avmedia/inc/mediacontrol.hxx avmedia/source/framework/mediacontrol.cxx avmedia/source/framework/soundhandler.cxx avmedia/source/framework/soundhandler.hxx basctl/source/basicide/baside2.hxx basctl/source/basicide/baside2b.cxx basctl/source/dlged/dlged.cxx basctl/source/inc/dlged.hxx chart2/source/view/charttypes/GL3DBarChart.cxx chart2/source/view/inc/GL3DBarChart.hxx cui/source/dialogs/cuigaldlg.cxx cui/source/dialogs/linkdlg.cxx cui/source/dialogs/thesdlg.cxx cui/source/inc/backgrnd.hxx cui/source/inc/chardlg.hxx cui/source/inc/cuigaldlg.hxx cui/source/inc/linkdlg.hxx cui/source/inc/macroass.hxx cui/source/inc/thesdlg.hxx cui/source/options/optjava.cxx cui/source/options/optjava.hxx cui/source/tabpages/backgrnd.cxx cui/source/tabpages/chardlg.cxx cui/source/tabpages/macroass.cxx dbaccess/source/ui/inc/JoinTableView.hxx dbaccess/source/ui/querydesign/JoinTableView.cxx dbaccess/source/ui/tabledesign/TEditControl.cxx desktop/source/app/app.cxx desktop/source/deployment/gui/dp_gui_dialog2.cxx desktop/source/deployment/gui/dp_gui_dialog2.hxx editeng/source/editeng/impedit.hxx editeng/source/editeng/impedit3.cxx extensions/source/bibliography/bibcont.cxx extensions/source/bibliography/bibcont.hxx extensions/source/bibliography/toolbar.cxx extensions/source/bibliography/toolbar.hxx extensions/source/update/ui/updatecheckui.cxx forms/source/component/ListBox.cxx forms/source/component/ListBox.hxx formula/source/ui/dlg/formula.cxx formula/source/ui/dlg/funcutl.cxx fpicker/source/office/iodlg.cxx framework/source/services/autorecovery.cxx include/formula/formula.hxx include/formula/funcutl.hxx include/sfx2/basedlgs.hxx include/sfx2/dinfdlg.hxx include/sfx2/dispatch.hxx include/sfx2/dockwin.hxx include/svtools/asynclink.hxx include/svtools/filechangedchecker.hxx include/svtools/treelistbox.hxx include/svtools/wizdlg.hxx include/svx/fontwork.hxx include/svx/graphctl.hxx include/svx/imapdlg.hxx include/svx/modctrl.hxx include/svx/numvset.hxx include/svx/sidebar/PanelLayout.hxx include/svx/svdpntv.hxx include/vcl/dockwin.hxx include/vcl/syswin.hxx include/vcl/texteng.hxx include/vcl/toolbox.hxx include/vcl/window.hxx linguistic/source/lngsvcmgr.cxx linguistic/source/lngsvcmgr.hxx reportdesign/source/ui/inc/DesignView.hxx reportdesign/source/ui/report/DesignView.cxx sc/inc/chartlis.hxx sc/inc/document.hxx sc/inc/scmod.hxx sc/source/core/data/documen2.cxx sc/source/core/tool/chartlis.cxx sc/source/ui/app/scmod.cxx sc/source/ui/dbgui/filtdlg.cxx sc/source/ui/dbgui/sfiltdlg.cxx sc/source/ui/docshell/autostyl.cxx sc/source/ui/inc/acredlin.hxx sc/source/ui/inc/anyrefdg.hxx sc/source/ui/inc/autostyl.hxx sc/source/ui/inc/conflictsdlg.hxx sc/source/ui/inc/filtdlg.hxx sc/source/ui/inc/navipi.hxx sc/source/ui/inc/tphfedit.hxx sc/source/ui/miscdlgs/acredlin.cxx sc/source/ui/miscdlgs/anyrefdg.cxx sc/source/ui/miscdlgs/conflictsdlg.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/pagedlg/tphfedit.cxx sd/inc/drawdoc.hxx sd/source/core/drawdoc4.cxx sd/source/ui/dlg/brkdlg.cxx sd/source/ui/dlg/filedlg.cxx sd/source/ui/framework/configuration/ConfigurationUpdater.cxx sd/source/ui/framework/module/ShellStackGuard.cxx sd/source/ui/framework/module/ShellStackGuard.hxx sd/source/ui/inc/BreakDlg.hxx sd/source/ui/inc/View.hxx sd/source/ui/slidesorter/controller/SlsAnimator.cxx sd/source/ui/slidesorter/inc/controller/SlsAnimator.hxx sd/source/ui/view/sdview4.cxx sfx2/source/appl/appcfg.cxx sfx2/source/appl/newhelp.cxx sfx2/source/appl/newhelp.hxx sfx2/source/control/dispatch.cxx sfx2/source/control/itemdel.cxx sfx2/source/dialog/basedlgs.cxx sfx2/source/dialog/dinfdlg.cxx sfx2/source/dialog/dockwin.cxx sfx2/source/dialog/filedlghelper.cxx sfx2/source/dialog/filedlgimpl.hxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/new.cxx sfx2/source/inc/templdgi.hxx sfx2/source/view/ipclient.cxx starmath/inc/edit.hxx starmath/source/edit.cxx svtools/source/contnr/imivctl.hxx svtools/source/contnr/imivctl1.cxx svtools/source/contnr/svimpbox.cxx svtools/source/contnr/treelistbox.cxx svtools/source/control/asynclink.cxx svtools/source/control/tabbar.cxx svtools/source/dialogs/wizdlg.cxx svtools/source/graphic/grfmgr.cxx svtools/source/inc/svimpbox.hxx svtools/source/misc/filechangedchecker.cxx svx/inc/sdr/overlay/overlaymanagerbuffered.hxx svx/inc/svdibrow.hxx svx/source/dialog/_contdlg.cxx svx/source/dialog/contimp.hxx svx/source/dialog/fontwork.cxx svx/source/dialog/graphctl.cxx svx/source/dialog/imapdlg.cxx svx/source/dialog/svxbmpnumvalueset.cxx svx/source/form/datanavi.cxx svx/source/form/formcontroller.cxx svx/source/inc/datanavi.hxx svx/source/inc/formcontroller.hxx svx/source/sdr/overlay/overlaymanagerbuffered.cxx svx/source/sidebar/PanelLayout.cxx svx/source/sidebar/media/MediaPlaybackPanel.cxx svx/source/sidebar/media/MediaPlaybackPanel.hxx svx/source/stbctrls/modctrl.cxx svx/source/svdraw/svdibrow.cxx svx/source/svdraw/svdpntv.cxx svx/source/tbxctrls/grafctrl.cxx sw/inc/doc.hxx sw/qa/extras/uiwriter/uiwriter.cxx sw/source/core/doc/DocumentStatisticsManager.cxx sw/source/core/doc/DocumentTimerManager.cxx sw/source/core/doc/docdesc.cxx sw/source/core/docnode/threadmanager.cxx sw/source/core/inc/DocumentTimerManager.hxx sw/source/core/inc/threadmanager.hxx sw/source/ui/dbui/mmoutputtypepage.cxx sw/source/ui/envelp/labfmt.cxx sw/source/ui/envelp/labfmt.hxx sw/source/ui/inc/mmresultdialogs.hxx sw/source/uibase/docvw/edtwin.cxx sw/source/uibase/docvw/srcedtw.cxx sw/source/uibase/inc/edtwin.hxx sw/source/uibase/inc/navipi.hxx sw/source/uibase/inc/srcedtw.hxx sw/source/uibase/inc/unotools.hxx sw/source/uibase/utlui/navipi.cxx sw/source/uibase/utlui/unotools.cxx vcl/backendtest/VisualBackendTest.cxx vcl/inc/svdata.hxx vcl/inc/unx/gtk/gtksalmenu.hxx vcl/source/app/svapp.cxx vcl/source/edit/texteng.cxx vcl/source/window/dockmgr.cxx vcl/source/window/dockwin.cxx vcl/source/window/paint.cxx vcl/source/window/syswin.cxx vcl/source/window/toolbox.cxx vcl/source/window/window.cxx vcl/unx/generic/print/genprnpsp.cxx vcl/unx/gtk/gtksalmenu.cxx Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-08-09Refactor Scheduler to add Task classJan-Marek Glogowski1-1/+1
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Conflicts: desktop/source/lib/init.cxx include/vcl/scheduler.hxx sfx2/source/control/itemdel.cxx sfx2/source/dialog/dockwin.cxx sfx2/source/dialog/filedlghelper.cxx svx/source/sdr/event/eventhandler.cxx svx/source/sidebar/PanelLayout.cxx svx/source/sidebar/media/MediaPlaybackPanel.cxx sw/source/uibase/docvw/srcedtw.cxx toolkit/source/awt/vclxtoolkit.cxx vcl/backendtest/VisualBackendTest.cxx vcl/source/app/scheduler.cxx vcl/source/window/window.cxx Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-13dbaccess: fix testCloneMovesPlusDeletions testMichael Stahl1-1/+6
JunitTest_dbaccess_complex spuriously fails 1% of the time with: 1) testCloneMovesPlusDeletions(complex.dbaccess.RowSet) java.lang.AssertionError: moving to the next record after |deleteRow| and clone moves failed at complex.dbaccess.RowSet.testCloneMovesPlusDeletions(RowSet.java:756) The problem is that line RowSet.java:750 deleteRow() manages to delete the last row in the set, because the positionRandom() is tricked to position itself on the last row (which it tries not to do), becuase the RowSet is currently positioned past-the-end on a deleted row and the ORowSetBase::impl_getRowCount() is a lying bastard that adds 1 to the result in this special case. Funnily both the ORowSetBase::impl_getRowCount() and the test using positionRandom() were added in CWS rowsetdel. Yay for randomized tests! Change-Id: Ic8c7bfa190f6a5269604cf5b3c338f2d0b64205e (cherry picked from commit ae8bd4267ac2da58f9e476d24e1e894202e92dea) Reviewed-on: https://gerrit.libreoffice.org/32991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-11Resolves: rhbz#1409634 crash on close storing clipboard of database tableCaolán McNamara1-2/+1
Change-Id: I8e692314b4ef278f7881780d51bcecb60ca80c3f (cherry picked from commit 6c2725038b627535ba97ead89dadb96e0ff69c3c) Reviewed-on: https://gerrit.libreoffice.org/32929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-03masses of MessBoxes not being disposed promptlyCaolán McNamara10-17/+17
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-07tdf#96516 fixup: when removing entry, entry count does not stay constantLionel Elie Mamane1-2/+1
Change-Id: I192a2d14787581545e66c46a84507f6dfd191c57 Reviewed-on: https://gerrit.libreoffice.org/25892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-31tdf#96516 do not increment position counter when an entry is removedLionel Elie Mamane1-1/+3
Change-Id: I81a4455df1fd5962d0362f4e5fa3396764a0ae5a (cherry picked from commit 0df3760bc2035a54454db9fe2774dca58c58593f) Reviewed-on: https://gerrit.libreoffice.org/25552 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-26Resolves: tdf#97854 crash on deleting inner join relationshipCaolán McNamara6-63/+64
seems to be a regression from... commit 356bc0f697299e5fb6156ce25dc69845eaa6f9e6 Author: Michael Meeks <michael.meeks@collabora.com> Date: Wed Jul 1 19:03:55 2015 +0100 tdf#92434 - fix iteration, and remember to disposeAndClear. which is part of the VclPtr stuff so hold the connection by VclPtr when removing it from m_vTableConnection and only call dispose on it when _bDelete is true, not always. Change-Id: I38e65c6928499dc1e8bbf6b71e9901a4eaa5d913 (cherry picked from commit e55f83e1731e1031c63d8463b57c434cceb126e3) plus (easier to read as individual commits) Related: tdf#97854 confirm that on !bDelete there's a ref to the connection so that its not deleted on removal from the vector Change-Id: I6c1f7691ee415abf0f419fdd7fcf2341fe2bd1f3 (cherry picked from commit 3185d9b8fbaad56fc7170a277569b5e441d946f4) Reviewed-on: https://gerrit.libreoffice.org/25509 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara10-39/+0
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin2-2/+2
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19Resolve: "TODO(Q1): Make GetSystemData method virtual"Caolán McNamara1-1/+1
and remove the casting silliness, allowing the removal of cairo_cairo.?xx If anything is to go wrong I'd guess it'll be the windows directx stuff. Change-Id: I3e22c07b9c26ade9b27a245fdd8408de540643f4
2016-05-19rename to two GetSystemData methods to find all call-sitesCaolán McNamara1-1/+1
anyplace calling GetSystemChildSystemData on a SystemChildWindow is definitely right anyplace calling GetWindowSystemData on a Window *might* have intended to call GetSystemChildSystemData on a Window casted back to an underlying SystemChildWindow. Change-Id: I7dcf3a50d0b7ed29bc08cfdb15cc0dcb86be8fa7 Reviewed-on: https://gerrit.libreoffice.org/25158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-19clang-tidy misc-unused-alias-declsNoel Grandin1-1/+0
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124 Reviewed-on: https://gerrit.libreoffice.org/25075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy clang-analyzer-alpha.core.IdenticalExprNoel Grandin1-1/+1
Change-Id: I110d8d63d5a6657c18aba97227c046027eb8f7f4 Reviewed-on: https://gerrit.libreoffice.org/25086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin15-116/+3
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin9-13/+13
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Fix typosAndrea Gelmini1-1/+1
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-13convert SHOWTRACK to scoped enumNoel Grandin1-2/+2
Change-Id: Ibf06f6c79f80d7265ae3239c1ea0088118e92e21 Reviewed-on: https://gerrit.libreoffice.org/24894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13Typo: ExcecuteContextMenuAction->ExecuteContextMenuActionJulien Nabet2-2/+2
Change-Id: Ifb121344a8f235d71bab33c03808e3f44d7bee7c Reviewed-on: https://gerrit.libreoffice.org/24942 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-12in non-debug build, leave sPath emptyStephan Bergmann1-3/+3
(avoid -Wimplicit-fallthrough with NDEBUG) Change-Id: I60332c4b05c805a7972189774283cdd518f77af0
2016-05-12dbaccess: replace boost::bind with C++11 lambdasMichael Stahl3-9/+10
Change-Id: I468f9c7af9c8c8189c51790e0301dd8c60a9f83c
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin4-12/+8
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Avoid some OUString temporariesMatteo Casalin1-9/+4
Change-Id: Icd7a63ac144c9ef365e64ab09d611cdfe3edf739
2016-05-10Avoid some OUString temporaries and constifyMatteo Casalin1-16/+9
Change-Id: I4789e9c0a4c2978e703ad4f8a088c8d267cd0972
2016-05-10Avoid some temporaries and constifyMatteo Casalin1-14/+6
Change-Id: Ie9ae7edb78e3c5768e4d253ab43a1dcdcf44078c
2016-05-10Fix typosAndrea Gelmini1-1/+1
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann22-49/+52
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann3-0/+5
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin8-17/+17
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin1-3/+1
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann2-6/+3
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann2-3/+3
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-03Remove unnecessary setBOOL, makeBoolAnyStephan Bergmann1-9/+9
Change-Id: Id82c3f352fcc2d4dafad877517098cb6f5d046d4
2016-05-01Fix typosAndrea Gelmini2-2/+2
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0 Reviewed-on: https://gerrit.libreoffice.org/24536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01Fix typosAndrea Gelmini1-1/+1
Change-Id: Ideafa411b53fe4a5f2e6559be10c4cb82b58a256 Reviewed-on: https://gerrit.libreoffice.org/24543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-30Fix typosAndrea Gelmini3-5/+5
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin2-6/+6
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-27-Werror,-WvarargsStephan Bergmann1-1/+1
"passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]" just drop the variadic overload and use the one taking a WizardPath (i.e., a vector) Change-Id: I6e389f60f8b7cb0633bf173bde69af1c5af86048
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin3-19/+19
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25Some more sal_Bool -> boolStephan Bergmann1-2/+2
Change-Id: I997d780abb5fc02156c2e6d7a3ecc34ca46b67cb
2016-04-25clang-tidy modernize-loop-convert in d*Noel Grandin24-131/+126
Change-Id: I0830a41b48e884ef63d32b5873c7007195659bb9
2016-04-22Avoid reserved identifiersStephan Bergmann10-54/+54
Change-Id: I56a0bbecf64b6f9a268a8c4b93aeab0acf54931f
2016-04-22Fix typosAndrea Gelmini1-1/+1
Change-Id: Iea11112a1bf1ff934de0e355b9e81979aa1966a3 Reviewed-on: https://gerrit.libreoffice.org/24286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-21aColumns is only used as a setStephan Bergmann1-8/+11
(cf. 40d6b81b9ee0a878d0dadb40941c50aa394a7501 "Replace map to sal_Bool with map to bool") Change-Id: I04bdd6c33793e277182fa80d187f212ab23c252e
2016-04-21tableNames_t is only used as a setStephan Bergmann1-10/+5
(cf. fde48126df56ede640499f24ac67f6754b84efbf "Replace map to sal_Bool with map to bool") Change-Id: I0bb24a78d15eb876565e64ce7ca0f4bb04dce2e2
2016-04-21comphelper::UStringMixLess defaults to bCaseSensitive = trueStephan Bergmann1-1/+1
...which then behaves the same as the default std::less<OUString> Change-Id: If18ef434a752bc77012e665d3621bc319f2897e8
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann72-261/+261
Change-Id: I5cd8fd979fd4caa3d7cde599096627bfdd0dec7e
2016-04-20Replace map to sal_Bool with map to boolStephan Bergmann1-8/+8
(Though this looks like it wants to use a set instead of a map, anyway.) Change-Id: I755581d3915dca902e7b96efea16d4d29cb0158a
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 16:31:16 +0000