summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)AuthorFilesLines
2020-10-18Database Wizard: show info label instead of empty list.Gülşah Köse3-7/+35
In Apple Store version or in case --without-java and disable-firebird-sdbc we cannot have Java based HSQLDB or Firebird. Instead of the empty list, there should be a static text label. Change-Id: I6034a749f28a3c29c9c9e50929cb42aa1312a46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104359 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104447 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-11disable dbaccess_hsqldb test on macosNoel Grandin1-0/+3
fails 50% of the time with a core dump, and we have no way of debugging that Change-Id: Ieda3a241a964327d3c70a6f519a032980ce312ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95487 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 8ad4ec9eea1224b9bfe1f7ce28393b234c083c89) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95871 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-18tdf#97416: fix Database password properties in ODB file not re-settable via UIJulien Nabet1-0/+1
Just call save_state() of the checkbox Change-Id: I3fa434b080efdcd284fba8e2f73d8e4846870576 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94363 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94374
2020-05-18tdf#129375: Avoid crash when inserting bibliography entry on iOSTor Lillqvist1-6/+9
I don't really know how the bibliography functionality works and how it is connected to database stuff. Until now the Library_bib for instance was excluded for iOS because it was seen to be part of the "DBCONNECTIVITY" feature. Change that now. Also, build the dba and dbahsql libraries also in the non-DBCONNECTIVITY case. This at least avoids the crash and avoids new warnings about missing constructors or factories. Change-Id: I8a8c62a895fcd43e7fa725a4707ac5ad428a64b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86043 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94213 Tested-by: Tor Lillqvist <tml@collabora.com>
2020-05-13[cp] Remove Help - Donate to LibreOffice menu itemAndras Timar5-15/+0
... and remove Help - Get Involved menu item, too Change-Id: I7a701173f596306ee628ae4a12ad81d2d756caca
2020-05-06Fix storage access after savingSamuel Mehrbrodt1-14/+3
Change-Id: I2cd664ac2ca5e80c566efee35bd34e7223501d75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92605 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 7dbff6fa55829e53be042e213b454d2466ff80fa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93190 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-06Fix macro signature getting lost when inserting data into tableSamuel Mehrbrodt3-90/+95
Change-Id: Iec514bfc0edd4f10a09809c68b8501667d978e52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92573 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 919bd3e78cce84a3338208e81d7056d8379d1bd5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93189
2020-05-06Related tdf#97694 Fix macro preservation on WindowsSamuel Mehrbrodt1-3/+6
Change-Id: Ief183c75e0c3ce6c42868b7c60c5f66f9684d743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91795 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 792c730f3cda4f5c312921a62ecae3d322ad9b72)
2020-05-06Related tdf#97694 Preserve macro signatures in BaseSamuel Mehrbrodt1-0/+90
Change-Id: I139ac003d1c95144e6cb1beec774f3cf142625b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91466 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 8d27d495a733cfc29753e2e78000b199632695f7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93187 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-06Related tdf#97694 Show dialog when signed macros are blockedSamuel Mehrbrodt1-1/+19
Change-Id: I7b9dd4872a58eff93ab8818f0286781c6ff4c9bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91385 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 6c89715b7d1e78a17b6c53cdb89f2f734500fd44) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93186 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-06Related tdf#97694 Check Base macro signatures on loadSamuel Mehrbrodt2-4/+54
Change-Id: I45c6eae633c41585c6c7e4c5fff0b187a6dc1f60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90908 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit f2f93434f4795646255e5d8edd31fa08b8b2ffab) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93133 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-31tdf#131576 Fields not displayed as expected in Base's Table WizardCaolán McNamara5-30/+40
this is similar to the problem of tdf#130623 "Base: Empty Field Properties" so take that solution and move it down the the shared component includes: tdf#131576 overlapping windows, move bottom one down a little Change-Id: I567c5a2519edd5921984a27405cddd6a4904fbba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91370 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-21fix test dependenciesLuboš Luňák1-0/+4
I'm not sure if this is the right dependency, but this test is paired in Module_dbaccess.mk with CppunitTest_dbaccess_hsqldb_test and that one uses this too, and it makes the dependencies work. Change-Id: Ib7d1dff99ed5e6f91f11d6a583475323a3307ad6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90835 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 5ef77a5af1ffa8f83fa6d803494bc0afe3742375) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90817
2020-03-17Set Firebird creation option experimentalJulien Nabet1-0/+6
See: http://document-foundation-mail-archive.969070.n3.nabble.com/About-putting-Firebird-creation-option-experimental-tt4274028.html http://document-foundation-mail-archive.969070.n3.nabble.com/ESC-meeting-minutes-2020-02-20-tt4274082.html for rationale Change-Id: I73d1563575252ebbcfb764753294bceb29e9bf12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89167 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit dc3c6e64650f0347648598dae0fa67c296ad36f5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89132 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-27tdf#130915 auto-select first entry when treeview filledCaolán McNamara1-0/+3
Change-Id: I3311e2e6f013de7adca5b473609b1dd64187a58f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89516 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-26tdf#130915 second treeview doesn't use its checkboxesCaolán McNamara1-22/+2
so we end up with blank lines under gtk Change-Id: I869c451dafe8dab0227ab8c914500ea059634c3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89435 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-26Resolves: tdf#130922 don't crash removing non-existing elementsCaolán McNamara1-1/+3
Change-Id: Id05faf6537ae096d563c57dcde71cd65ae04152d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89431 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-26Resolves: tdf130874 reversed logicCaolán McNamara1-2/+2
Change-Id: I2ccac01f271ec803547ab36359f2273312df87e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89436 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-14Resolves: tdf#130593 set correct range for spinbuttonCaolán McNamara1-2/+2
Change-Id: I6691f2709aa4053798fcc1744f9f41c3c3866a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88496 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-13tdf#126578: call ensureConnection to be able to call "Create as View"Julien Nabet1-0/+5
See https://bugs.documentfoundation.org/show_bug.cgi?id=126578#c8 Change-Id: I9eadb704214b1aad9573bcd89e3fd61213627a8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88329 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 57a5c0f04526fc05907334311db5727e665bdde2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88290 Tested-by: Jenkins
2020-02-13tdf#130623 owner of FieldControl needs to set its allocationCaolán McNamara2-1/+30
which works fine automatically when its in a dialog (copy table) but not automatically when hosted inside the design view this will make the gen case work in master, and the gen and gtk case work in 6-4 Change-Id: I530cfa0a7e1f5b62c6812ffde255c1edf478930d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88499 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-09Resolves: tdf#130484 controls become disabled on click final checkboxesCaolán McNamara1-2/+0
they always triggered disabled the current state in the roadmap, but disabling a roadmap step now really disables the associated window in vcl. These two particular toggles don't actually affect the current roadmap state, so don't call state-modified when changing them. That doesn't change the ye-old weird case that the logical state of this final step is disabled, but don't let the wizard find that out when toggling radiobuttons that don't contribute to the roadmap state Change-Id: I5927d20ea461a294e76014892c90ad0b5f39fb6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88281 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-21Resolves: tdf#130075 have to specify which column is the text columnCaolán McNamara1-1/+7
in this two column case Change-Id: Ia999a0540b2d0f7c03a54241c61bf4c2231b8460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87091 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-16Resolves: tdf#128972 limit width of combobox of recently-usedCaolán McNamara2-1/+5
in the wizard so that the end of the combobox is available and the dialog isn't oversized. the user can resize the window to see more of the text of the recently-used Change-Id: Ic0b8d6c6e8840052e8f20e9f9a13d44140efde85 Reviewed-on: https://gerrit.libreoffice.org/85070 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-12-10tdf#129210 don't assert with clear on already cleared mutexCaolán McNamara1-0/+1
reset it after load completes, seeing as the comment suggests that's why the clear exists in the first place Change-Id: I3af633c5a1f99b5d0dd754c21e220c6c94b66634 Reviewed-on: https://gerrit.libreoffice.org/84784 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-26tdf#126043 fetch the command properties just onceCaolán McNamara2-3/+7
Change-Id: Iaf343e9858be36ca8772d9c12eee772d93b4c394 Reviewed-on: https://gerrit.libreoffice.org/83668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/83763
2019-11-21tdf#128748 replace warning dialog with tooltipCaolán McNamara2-16/+13
so the TreeList does not get the mouse release it expects stolen from it by the dialog, leaving it stuck in "selecting" limbo Change-Id: If83dcdd8697b2a67e67fb062ae65ad947f49e8cd Reviewed-on: https://gerrit.libreoffice.org/83373 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14Resolves: tdf#128748 warning dialog appearing on focus changeCaolán McNamara2-29/+17
so can't use cancel because focus out of the entry happens on the effort to get to the cancel button instead only show the dialog on ok, next and selecting a new param in the treeview. Show an error indicator in the entry on focus-out instead. Change-Id: I5770142d7a1e7c62bb9ed89a171e72129a43f6c8 Reviewed-on: https://gerrit.libreoffice.org/82613 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e151c12a14c1a2536393c82fa6027f251be1a7d6) Reviewed-on: https://gerrit.libreoffice.org/82625
2019-11-14Resolves: tdf#128788 crash in autovalueCaolán McNamara2-15/+24
Change-Id: Ifeb3b3fcb464e1d6db7e1a4a557b34b3ee30c82a Reviewed-on: https://gerrit.libreoffice.org/82653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-11-13set parent for OParameterDialogCaolán McNamara1-1/+1
Change-Id: I614d596599ce55ef9940fbeedf0fca4052e64138 Reviewed-on: https://gerrit.libreoffice.org/82592 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-13set parent for message dialogCaolán McNamara1-1/+1
Change-Id: I0f885e79dd9fca2596e0190af996e9cae74692a6 Reviewed-on: https://gerrit.libreoffice.org/82591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-13receives_default without can_defaultCaolán McNamara1-0/+1
Change-Id: Ib1fb808876ab5f34951d55d8cd06b2ff01f44496 Reviewed-on: https://gerrit.libreoffice.org/82590 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06loplugin:unusedvariablecheck tweak to find more stuffNoel Grandin1-2/+0
but leave the tweak commented out, since it generates false positives Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c Reviewed-on: https://gerrit.libreoffice.org/82121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03loplugin:stringaddNoel Grandin4-11/+8
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-02New loplugin:conditionalstringStephan Bergmann1-1/+1
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3 Reviewed-on: https://gerrit.libreoffice.org/81946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-31avoid intermediate vcl::WindowsCaolán McNamara3-18/+17
Change-Id: I5d6a03baed2af5801132f3e3a0411867ba60186e Reviewed-on: https://gerrit.libreoffice.org/81760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31Fix StringAdd::isCompileTimeConstantStephan Bergmann2-6/+3
...to find StringLiteral on the RHS of +=. Which revealed that the VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that s += side_effect(); s += "literal"; s += side_effect(); only gets combined to s += side_effect() + "literal"; s += side_effect(); and not all the way to s += side_effect() + "literal" + side_effect(); Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4 Reviewed-on: https://gerrit.libreoffice.org/81804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-30remove some unnecessary includesCaolán McNamara4-4/+0
Change-Id: I5cad1142641587ef4393cbf73384f93540d61038 Reviewed-on: https://gerrit.libreoffice.org/81712 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-30don't need to include vcl/tabctrl.hxxCaolán McNamara1-1/+0
Change-Id: Idb1f6700c5012303e45587db653b62a90e331c17 Reviewed-on: https://gerrit.libreoffice.org/81710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29remove unnecessary includesCaolán McNamara2-3/+0
Change-Id: Ia4a622b34ff3f71963cff7a1aa8658a4df12f04f Reviewed-on: https://gerrit.libreoffice.org/81676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29weld fpicker clusterCaolán McNamara1-2/+2
Change-Id: I6566263809ff0032388a0b56571f0cf7428058d7 Reviewed-on: https://gerrit.libreoffice.org/81334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-26size some stringbuffer to prevent re-allocNoel Grandin2-3/+7
I started with 32 and kept doubling the size until the site did not need re-alloc, but clamped it at 512 (e.g. in emfio/). Change-Id: Ib7caf35a1b7e42b0e4ed8aa812493449e3eefc8f Reviewed-on: https://gerrit.libreoffice.org/81540 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-24This probably wants to generate a "1".."10" string representationStephan Bergmann1-1/+1
...instead of picking the OString(char) overload. (Was introduced with f62efe43a25770b8bcbe9b7bc681284b9a006ea0 "weld ODbAdminDialog".) Change-Id: Ia5225bbc16aedc71aea74ce1d004b29696f46f94 Reviewed-on: https://gerrit.libreoffice.org/81455 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-22loplugin:constantparamNoel Grandin2-9/+3
Change-Id: Ibfe70492683ff3ec208cee95d8a11155ec54f690 Reviewed-on: https://gerrit.libreoffice.org/81314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-22loplugin:virtualdead unused params in OCacheSetNoel Grandin5-47/+9
these methods do nothing except forward to their similar named variants, so just remove them Change-Id: I28d31bbe2c1e39fe5a9c2d7eaa9e14006213ab27 Reviewed-on: https://gerrit.libreoffice.org/81247 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-22loplugin:virtualdead unused param in IContainerApproveNoel Grandin6-12/+7
Change-Id: I59edede149d02085125ee946994b6088c3152e7b Reviewed-on: https://gerrit.libreoffice.org/81246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21loplugin:virtualdead unused param in IControlActionListenerNoel Grandin6-7/+7
Change-Id: I2ce8df6a9a1ac2e6d6c5de08b32fb671bf10cd17 Reviewed-on: https://gerrit.libreoffice.org/81244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21loplugin:virtualdead unused param in OTableRowViewNoel Grandin4-9/+9
Change-Id: Ice8d68284800e12af3e334722cc6109a1614e335 Reviewed-on: https://gerrit.libreoffice.org/81243 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-20cid#1453991 Wrapper object use after freeCaolán McNamara6-12/+28
Change-Id: I6476c765589cbb3996ad8832a0e159aa4d965d32 Reviewed-on: https://gerrit.libreoffice.org/81173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20cid#1453991 Wrapper object use after freeCaolán McNamara4-7/+15
Change-Id: I4ea3ed40deaf20e91e1a0a42ee115cf761853875 Reviewed-on: https://gerrit.libreoffice.org/81170 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 19:41:53 +0000