summaryrefslogtreecommitdiff
path: root/dbaccess/source
AgeCommit message (Collapse)AuthorFilesLines
2020-10-22long->tools::Long in dbaccess..drawinglayerNoel41-240/+241
Change-Id: I15760da167e7d0b4c410acccd1c8c90210e28b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104623 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-16Database Wizard: show info label instead of empty list.Gülşah Köse2-0/+16
In Apple Store version or in case --without-java and disable-firebird-sdbc we cannot have Java based HSQLDB or Firebird. Instead of the empty list, there should be a static text label. Change-Id: I6034a749f28a3c29c9c9e50929cb42aa1312a46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104359 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-10-14More fixes of uses of now-explicit OUString ctor taking raw sal_Unicode pointerStephan Bergmann1-2/+2
...in Windows-only code, after c927aab29ebfff1ce3ac0b2f27ae343025a9890c "Make the OUString ctors taking raw sal_Unicode pointer/non-const array explicit". Interestingly, these occurrences were accepted by MSVC and only cause errors with clang-cl, so happened to go unnoticed until now. Change-Id: I33e7653e28a21541ef793b4b0750abb6037752db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104314 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-06loplugin:const* make some params and methods constNoel16-24/+24
Change-Id: Idec482c21c270912f9bcaeb980077c1616f67c8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06move set_user_managed_scrolling to an initial weld argumentCaolán McNamara1-1/+1
gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-03use more TOOLS_WARN_EXCEPTIONNoel2-2/+2
Change-Id: Id83c478af5d04ad548c7cf4239fe2fb3ee154dc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103861 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-03use more TOOLS_WARN_EXCEPTIONNoel2-2/+4
Change-Id: I8b5cde993c13e0b7c8c830b1ff698933a6b7cfd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103863 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-02loplugin:reducevarscope in dbaccessNoel11-14/+14
Change-Id: I22163b3303ae0c2326d079a18fa8906f38aa1d4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103810 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-01Use the new single-instance="true" attribute in dbaccessStephan Bergmann2-22/+2
Change-Id: Idd42ae243859ee0a0798568f71460c93981c636f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103736 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-28Related: tdf#137016 check if subcontrol has the focusCaolán McNamara1-1/+1
Change-Id: I632188bc0512c9d8935bd0898c96e066881ebeb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-22OUStringLiteral/OStringLiteral coverity PARSE_ERROR workaroundCaolán McNamara1-1/+1
do more like commit 121771e37f7e2de41cd5643475861062bf25627b Date: Mon Sep 21 09:17:54 2020 +0200 Make some OUStringLiteral vars constexpr cause coverity can live with that Change-Id: I9efd7f848289c4865997a44c6780373068422227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uStringStephan Bergmann2-2/+3
...from which an OUString can cheaply be instantiated. This is the OUString equivalent of 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String". Most remarks about that commit apply here too (this commit is just substantially bigger and a bit more complicated because there were so much more uses of OUStringLiteral than of OStringLiteral): The one downside is that OUStringLiteral now needs to be a template abstracting over the string length. But any uses for which that is a problem (e.g., as the element type of a container that would no longer be homogeneous, or in the signature of a function that shall not be turned into a template for one reason or another) can be replaced with std::u16string_view, without loss of efficiency compared to the original OUStringLiteral, and without loss of expressivity. The new OUStringLiteral ctor code would probably not be very efficient if it were ever executed at runtime, but it is intended to be only executed at compile time. Where available, C++20 "consteval" is used to statically ensure that. The intended use of the new OUStringLiteral is in all cases where an object that shall itself not be an OUString (e.g., because it shall be a global static variable for which the OUString ctor/dtor would be detrimental at library load/unload) must be converted to an OUString instance in at least one place. Other string literal abstractions could use std::u16string_view (or just plain char16_t const[N]), but interestingly OUStringLiteral might be more efficient than constexpr std::u16string_view even for such cases, as it should not need any relocations at library load time. For now, no existing uses of OUStringLiteral have been changed to some other abstraction (unless technically necessary as discussed above), and no additional places that would benefit from OUStringLiteral have been changed to use it. Global constexpr OUStringLiteral variables defined in an included file would be somewhat suboptimal, as each translation unit that uses them would create its own, unshared instance. The envisioned solution is to turn them into static data members of some class (and there may be a loplugin coming to find and fix affected places). Another approach that has been taken here in a few cases where such variables were only used in one .cxx anyway is to move their definitions from the .hxx into that one .cxx (in turn causing some files to become empty and get removed completely)---which also silenced some GCC -Werror=unused-variable if a variable from a .hxx was not used in some .cxx including it. To keep individual commits reasonably manageable, some consumers of OUStringLiteral in rtl/ustrbuf.hxx and rtl/ustring.hxx are left in a somewhat odd state for now, where they don't take advantage of OUStringLiteral's equivalence to rtl_uString, but just keep extracting its contents and copy it elsewhere. In follow-up commits, those consumers should be changed appropriately, making them treat OUStringLiteral like an rtl_uString or dropping the OUStringLiteral overload in favor of an existing (and cheap to use now) OUString overload, etc. In a similar vein, comparison operators between OUString and std::u16string_view have been added to the existing plethora of comparison operator overloads. It would be nice to eventually consolidate them, esp. with the overloads taking OUStringLiteral and/or char16_t const[N] string literals, but that appears tricky to get right without introducing new ambiguities. Also, a handful of places across the code base use comparisons between OUString and OUStringNumber, which are now ambiguous (converting the OUStringNumber to either OUString or std::u16string_view). For simplicity, those few places have manually been fixed for now by adding explicit conversion to std::u16string_view. Also some compilerplugins code needed to be adapted, and some of the compilerplugins/test cases have become irrelevant (and have been removed), as the tested code would no longer compile in the first place. sal/qa/rtl/strings/test_oustring_concat.cxx documents a workaround for GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96878> "Failed class template argument deduction in unevaluated, parenthesized context". That place, as well as uses of OUStringLiteral in extensions/source/abpilot/fieldmappingimpl.cxx and i18npool/source/localedata/localedata.cxx, which have been replaced with OUString::Concat (and which is arguably a better choice, anyway), also caused failures with at least Clang 5.0.2 (but would not have caused failures with at least recent Clang 12 trunk, so appear to be bugs in Clang that have meanwhile been fixed). Change-Id: I34174462a28f2000cfeb2d219ffd533a767920b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102222 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-15Fix typo in codeAndrea Gelmini5-13/+13
It passed "make check" on Linux Change-Id: Ibb705ac92365b7f71e8e5561bd150142a65a50ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101807 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-09-13tdf#124176 Use #pragma once in dbaccess/source/uiGeorge Bateman181-635/+181
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: I7508acd84f2264ba807951d9b933b1ee76560c92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102552 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-13tdf#124176 Use #pragma once in dbaccess/source/coreGeorge Bateman78-287/+78
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: I44efd0f0536df127be57fafc193eeb985292cc22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102550 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-13tdf#124176 Use #pragma once in dbaccess/source/filterGeorge Bateman35-135/+35
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: Idd45e204ae80a33784e896c70d104aa1b22513ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102551 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-09improve loplugin:unusedvarsglobalNoel Grandin2-12/+0
to find any global variable, was checking the wrong property of VarDecl Change-Id: I454b4e0c1701bb0771768a1ee10cd738c4ab0726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-06treelist hidden in data browserCaolán McNamara2-3/+4
Change-Id: I1f01f4f57d9e711ead86d9d7abf9ef9c7f630fe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102104 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-05Drop some seemingly redundant OUString(OUString::getStr()) constructionStephan Bergmann1-1/+1
...assuming it was not chosen deliberately to cut of the input string at a potential embedded NUL (or for whatever other arcane reason). (This change is a prerequisite for making the OUString ctor taking a raw pointer explicit.) Change-Id: I74411e590cedc4394a240435a837a406dc18cfb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102079 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-04tdf#136442 a null return from GetEntryPosByName is allowedCaolán McNamara1-1/+4
Change-Id: Id3e5255f1551eaa3e2f2bbd314634bdf921bffac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02Do layout immediately in resizeCaolán McNamara2-3/+3
the wait for the idle is too long, keep idle for re-layout when the container size doesnt change but the contents do Change-Id: I6ed4806e96d10937e825192de86a3d602acf1689 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02drop some unused forward declsCaolán McNamara1-7/+0
Change-Id: Id8c3e726e0542dc9bdc36490aa10dde075617630 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101918 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02drop some unused methodsCaolán McNamara3-5/+0
Change-Id: I4da391591d30db9e51c1dd543bcf128f2e8621c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101914 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01Fix typoAndrea Gelmini1-1/+1
Change-Id: I03dc9ad3ad496524efbbb2f1a48f76fb95d1bfc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101781 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini8-11/+11
It passed "make check" on Linux Change-Id: I3482e32e3ce4a7ebfa04f9d54e2ab23c164f50c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101808 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini1-2/+2
It passed "make check" on Linux Change-Id: I8be2457de5018e1e764e378e609c3a41c3cb9d11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101802 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01FIx typo in codeAndrea Gelmini1-6/+6
It passed "make check" on Linux Change-Id: I055db4ca15e2e8c4c66d5970404c292255c15628 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101778 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01Fix typo in codeAndrea Gelmini2-3/+3
It passed "make check" on Linux Change-Id: Idf44d88678de415e38ddb542c198c0eac642aaae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101785 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-30use more fastparser in SvXMLStyleContext subclassesNoel Grandin2-7/+3
Change-Id: I6a1596bdbfa4db128730a663fc590c9e5bfa249d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-29Fix typo in codeAndrea Gelmini2-4/+4
It passed "make check" on Linux Change-Id: Ie6f03d64818ca88ada6e929dc061be851451a75c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-28move FixedLine into .uiCaolán McNamara2-15/+4
Change-Id: Ibc22de48f1ef92d8efbe0167aff3a434ecef9afb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101503 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-28weld OTableBorderWindowCaolán McNamara16-151/+101
Change-Id: I8008d9ea1e1c5418c960ec9c80b55602a11f15f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-28drop newly unused VertSplitViewCaolán McNamara3-235/+0
Change-Id: Ib70905dd22ddd7a5f529501be10bdbfb9164a65f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101549 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-28Change OUStringLiteral from char[] to char16_t[]Stephan Bergmann2-4/+4
This is a prerequisite for making conversion from OUStringLiteral to OUString more efficient at least for C++20 (by replacing its internals with a constexpr- generated sal_uString-compatible layout with a SAL_STRING_STATIC_FLAG refCount, conditionally for C++20 for now). For a configure-wise bare-bones build on Linux, size reported by `du -bs instdir` grew by 118792 bytes from 1155636636 to 1155755428. In most places just a u"..." string literal prefix had to be added. In some places char const a[] = "..."; variables have been changed to char16_t, and a few places required even further changes to code (which prompted the addition of include/o3tl/string_view.hxx helper function o3tl::equalsIgnoreAsciiCase and the additional OUString::createFromAscii overload). For all uses of macros expanding to string literals, the relevant uses have been rewritten as u"" MACRO instead of changing the macro definitions. It should be possible to change at least some of those macro definitions (and drop the u"" from their call sites) in follow-up commits. Change-Id: Iec4ef1a057d412d22443312d40c6a8a290dc6144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101483 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-27remove some unused includes and update pchesCaolán McNamara2-4/+0
Change-Id: I786548bef39fa711aabcff32b592b3fdc4a6f9fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-27weld dbu ui clusterCaolán McNamara18-504/+337
making the dbaccess a wholely welded hierarchy Change-Id: I87ea94d7775e38c8eb3342d91a730457481407f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101340 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26add focus rect to icon controlCaolán McNamara2-0/+37
Change-Id: I080dfb40db20626f99f93beab1baf2102d6695ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26weld OApplicationSwapWindowCaolán McNamara6-116/+215
Change-Id: I71d24494b5fe7dd2949876944ab9aff41330ad50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-26use fastparser in OTableStyleContextNoel Grandin2-25/+22
Change-Id: Ied05d161811c3b87d00cd99c56940a9f66cb4e59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-25use more fastparser in OReportStylesContextNoel Grandin1-0/+1
Change-Id: Ie8126206d9144ccba1fb120d47af9ebe35a345d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101320 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-23Fix typoAndrea Gelmini1-5/+5
Change-Id: I6f4544cb5174970af28fa0451a1f62a51e7bb78e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101221 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-20loplugin:unusedmethodsNoel Grandin3-49/+0
Change-Id: Ic3690d7f2a075d47ffed3db03ee6895ebdab441e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101070 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20loplugin:constantparamNoel Grandin3-4/+4
Change-Id: I59a37e1d37fa749cba5159daa23fe663bcc55435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-19weld OTitleWindowCaolán McNamara4-71/+51
Change-Id: I10996b1d927e6e8db913d04d975fda69669a2988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100984 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-19restore call to dragFinished on successful dropCaolán McNamara5-1/+33
Change-Id: Ib8a1e7f38d4e5f658ff55b645d39b0c521e21f87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100990 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-19put label inside another window to create the paddingCaolán McNamara2-26/+18
instead of using blank labels for spacing Change-Id: Ie3c7f761bccbaf916473e7ef92912bdb62e43c5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100979 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-19don't include syntax highlighting in undo/redoCaolán McNamara1-0/+11
Change-Id: I7d7560fe94a7c9748ddd1a5e5584ef3e4b1efea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-19weld OQueryTextViewCaolán McNamara9-441/+360
its plausible with the EditEngine replacement for the SQL editor that the undo could be integrated better than the current check-if-the-text-has-changed timeout method. But that's left unchanged with this commit. Change-Id: I9b9e373044a80ee94dab4ceaad0ef2801b0b1166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100950 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18Fix typosAndrea Gelmini1-2/+2
Change-Id: I85a91d24943430b42217ac91611f182059d8ec69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100919 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-18Fix typosAndrea Gelmini2-4/+4
Change-Id: I9d55e4478d8cf3047b4ccac88e06fdc87e68e6ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100871 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins