summaryrefslogtreecommitdiff
path: root/dbaccess/source
AgeCommit message (Collapse)AuthorFilesLines
2019-05-31dbaccess: fix more memory leaks caused by circular ReferenceMichael Stahl3-13/+18
Followup to 96ae2a3300811897c24cccb20f8c2faf382483df; more overridden acquire() creating cycles in dbaccess. (regression from 2660d24a07866e083c5135ea263030f3e3a2e729) Change-Id: I134343b3afbcd5ee3f71212ec18e551455eaee5b Reviewed-on: https://gerrit.libreoffice.org/73158 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-29tdf#114596 dbaccess: fix mysterious dataloss bug (part 2)Xisco Fauli2-4/+5
Same problem as in 96ae2a3300811897c24cccb20f8c2faf382483df Regression from 497e40ad03c27837978551ba15491c3fb2a0bf53 Change-Id: I00e7bf3559e688e7fbc5429ace2b5c18221c9890 Reviewed-on: https://gerrit.libreoffice.org/73146 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-05-22tdf#124951: Enable children depending on parentXisco Fauli1-0/+4
Change-Id: I221b7ae202d6dbd08d0496561652b2471b093b46 Reviewed-on: https://gerrit.libreoffice.org/72783 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-05-22tdf#125436: Do not disable type options listXisco Fauli1-2/+0
Change-Id: I2080f3c04a04cea626d4969b59e54612cbefe03b Reviewed-on: https://gerrit.libreoffice.org/72780 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-05-22New loplugin:dataStephan Bergmann1-1/+1
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-22tdf#42949 Fix IWYU warnings in include/svx/[h-r]*Gabor Kelemen4-0/+4
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib7e1d0f7483aa8b5cab320278714f2d5f36fdbd9 Reviewed-on: https://gerrit.libreoffice.org/72534 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-20split width/height to allow intercept of how width is calculatedCaolán McNamara2-2/+3
in order to possibly get width on demand Change-Id: I1e6fcb6849705f2b166821516ebe72b179e00ee7 Reviewed-on: https://gerrit.libreoffice.org/72513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-18tdf#124951 Open button on Database Wizard dialog is enabled..Noel Grandin2-20/+24
..when it should be disabled regression from commit 7df04009b98165f89c89f1e506ebafd2fecc8f5a Date: Fri Feb 8 11:55:18 2019 +0200 remove ControlDependencyManager Change-Id: Ic84d8c8a5f0615753e323d3aa1e9da0d0c76bb42 Reviewed-on: https://gerrit.libreoffice.org/72532 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-17tdf#125267: relax the requirement of fixed value of current filterKatarina Behrens1-1/+4
In a filepicker, user can select any file filter ('All files' for example) and still choose to open .odb file. Specific UIName of the current filter ('ODF Database' in this case) shouldn't therefore be a hard requirement, the correct file extension is enough. Change-Id: I641a267c545c66aa4d34954922783cc5ff7efd24 Reviewed-on: https://gerrit.libreoffice.org/72377 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-17Replace list by deque in dbfindex (dbaccess)Julien Nabet1-3/+3
Change-Id: I9503cce6eff31f08c2762940b881ba1dc8633288 goal: to get rid of std::list when not mandatory Reviewed-on: https://gerrit.libreoffice.org/72434 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-17tdf#125325: fix crash about index managements for dBaseJulien Nabet1-2/+1
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=151468 Pb is aSearch becomes invalid after _rList.erase(aSearch); line 101 so just test aReturn.GetIndexFileName() isn't empty Change-Id: Iae5b3a7f76fe565f890bd23bfb2ce5d9c6134986 Reviewed-on: https://gerrit.libreoffice.org/72427 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-16tdf#42949 Fix IWYU warnings in include/svx/[e-g]*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I861d3f0fa15ee3b7e0e830c4fac2e5794ea4071b Reviewed-on: https://gerrit.libreoffice.org/72213 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-16tdf#43157 Clean up OSL_VERIFY (replace with SAL_WARN)Jens Carl1-13/+34
Replace OSL_VERIFY with if-statement and SAL_WARN. Change-Id: Ib286a2151fe19a91b4e9db8db9f92ac0d5264d36 Reviewed-on: https://gerrit.libreoffice.org/72330 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-15Fix typoAndrea Gelmini1-1/+1
Change-Id: I407e8aa9c75fd5598321294437d9340f3f8e9456 Reviewed-on: https://gerrit.libreoffice.org/72325 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-15Fix typoAndrea Gelmini1-5/+5
Change-Id: I2b7f2d9eb1290c25c48867f17694fe5e6b1826bf Reviewed-on: https://gerrit.libreoffice.org/72324 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin32-68/+68
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-12Fix typoAndrea Gelmini1-1/+1
Change-Id: I66429d273adf969fb54d6e378021b1db6da28969 Reviewed-on: https://gerrit.libreoffice.org/72171 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-12Fix typoAndrea Gelmini1-2/+2
Change-Id: I6f6042e57821e4deeeb41ab4ce14ac355ddf432c Reviewed-on: https://gerrit.libreoffice.org/72175 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-12Fix typoAndrea Gelmini1-1/+1
Change-Id: I89f281b85a735847572e10f0622eb115f8615b24 Reviewed-on: https://gerrit.libreoffice.org/72176 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-12Fix typoAndrea Gelmini1-1/+1
Change-Id: Ib203bf75d44d5741ebeb107e2e672f00bf4211ff Reviewed-on: https://gerrit.libreoffice.org/72177 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-12Fix typoAndrea Gelmini1-2/+2
Change-Id: Ic575e060a6f4d19213182acc32e4e9e6374f2ae2 Reviewed-on: https://gerrit.libreoffice.org/72178 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-2/+2
Change-Id: I3292e784ff82c5e71d9b3b931f21db963d681016 Reviewed-on: https://gerrit.libreoffice.org/72170 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-3/+3
Change-Id: I572453ea9cac59f7dce0abe79e6f034960555081 Reviewed-on: https://gerrit.libreoffice.org/72169 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-1/+1
Change-Id: I988a205025cd62d479adc2fbc9c2c86f05414fb5 Reviewed-on: https://gerrit.libreoffice.org/72166 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-2/+2
Change-Id: If7ecd8501a6dfae0d56d98f6f5fa134ed7bbc60b Reviewed-on: https://gerrit.libreoffice.org/72168 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typosAndrea Gelmini1-4/+4
Change-Id: I5ea79480c097fb9d317303981021135a102d8c19 Reviewed-on: https://gerrit.libreoffice.org/72151 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-1/+1
Change-Id: I6af2b1ead6448be9b5a47fcd6ef3fb16acccc52b Reviewed-on: https://gerrit.libreoffice.org/72153 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-1/+1
Change-Id: Ic7973dc408ba7cd19b958675b5e27320dfea5c92 Reviewed-on: https://gerrit.libreoffice.org/72152 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-1/+1
Change-Id: I734bc89dc447e35fdd2a092448d98006ab1b570e Reviewed-on: https://gerrit.libreoffice.org/72154 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-1/+1
Change-Id: If4b7b256b913864c0916383ff6aee918a6f7bf38 Reviewed-on: https://gerrit.libreoffice.org/72158 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-1/+1
Change-Id: If3bf3f12aba80d4f3fb99867953fb046a86659fa Reviewed-on: https://gerrit.libreoffice.org/72156 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-1/+1
Change-Id: I49398e07d8d62d21bb9327fddbf589fc23a16720 Reviewed-on: https://gerrit.libreoffice.org/72161 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-2/+2
Change-Id: I80d1f60646803bc3a519c310671bb7062d503726 Reviewed-on: https://gerrit.libreoffice.org/72157 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-3/+3
Change-Id: I7dfc0835d54a67c2031af9726eb86831779cb0df Reviewed-on: https://gerrit.libreoffice.org/72163 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-11Fix typoAndrea Gelmini1-1/+1
Change-Id: I437da2bfedce39379fb6d482ca6341038df1f786 Reviewed-on: https://gerrit.libreoffice.org/72149 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-10an uno -> a unoCaolán McNamara2-3/+3
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10an is used before a vowel soundCaolán McNamara4-5/+5
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-09loplugin:unusedfieldsNoel Grandin4-43/+6
Change-Id: I8dc5a6ef84f43bad0bee26592b3a8e95c58e6f22 Reviewed-on: https://gerrit.libreoffice.org/72027 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-09avoid copying when placing items into SfxItemSetNoel Grandin1-1/+1
Change-Id: I05c627f590e7794c1ba11b66021dc30aa3285eb0 Reviewed-on: https://gerrit.libreoffice.org/71941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-09Fix typoAndrea Gelmini1-1/+1
Change-Id: I0c594c232a3004c83a33f0948593850dd924caad Reviewed-on: https://gerrit.libreoffice.org/72020 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-09Fix typoAndrea Gelmini1-1/+1
Change-Id: I88a32792c19a8d16c400dd2a189c4941149ff941 Reviewed-on: https://gerrit.libreoffice.org/72019 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-08Fix typoAndrea Gelmini1-5/+5
Change-Id: I7abab185624c5a6a6e28334dd680fafece7abfab Reviewed-on: https://gerrit.libreoffice.org/71940 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I05576d6da25c4d3fe50abc9b332d5d47ffad0ee9 Reviewed-on: https://gerrit.libreoffice.org/71821 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-05Fix typoAndrea Gelmini1-3/+3
Change-Id: I156ae9d89b79816ce9c96320280adb16140769e0 Reviewed-on: https://gerrit.libreoffice.org/71820 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-04Fix typoAndrea Gelmini1-1/+1
Change-Id: Id7303279e86f5c5303bfe32bc843c59a9d7e2813 Reviewed-on: https://gerrit.libreoffice.org/71778 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-04Fix typoAndrea Gelmini1-1/+1
Change-Id: Ia21f12ac5fc872ca7c04e61e795b9f9f049a3dbe Reviewed-on: https://gerrit.libreoffice.org/71777 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-04Fix typoAndrea Gelmini1-1/+1
Change-Id: I414fe36966ddcabad356f856c9285736ba089233 Reviewed-on: https://gerrit.libreoffice.org/71775 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-04Fix typoAndrea Gelmini1-1/+1
Change-Id: I3de19930394846273294e1574baf522ae1c1c3c9 Reviewed-on: https://gerrit.libreoffice.org/71776 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-02Fix typoAndrea Gelmini1-1/+1
Change-Id: I3e48cd90a636bd8d5eab9112a2c1827a31896bcb Reviewed-on: https://gerrit.libreoffice.org/71690 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-02Fix typoAndrea Gelmini1-1/+1
Change-Id: I20dcf6bc9520c3abfd021c9968916515429a7498 Reviewed-on: https://gerrit.libreoffice.org/71691 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>