summaryrefslogtreecommitdiff
path: root/dbaccess/qa
AgeCommit message (Collapse)AuthorFilesLines
2017-06-12cleanup unused css/frame/* includesJochen Nitschke1-3/+0
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-05require firebird 3.0 for build (don't allow 2.5)Lionel Elie Mamane1-4/+0
Keep firebird_integer_x64le.odb around for a future 3.x firebird that will allow opening Firebird 2.5 databases, so that we can test this capacity in our tests. Change-Id: I05dbef51284bdb25132ff6cb661659430eea6a92
2016-12-22Dispose component when doneStephan Bergmann1-0/+1
Change-Id: I3ea2004556b01ba992215b9142b9c8a6aabb63c0
2016-12-22Dispose document when doneStephan Bergmann1-0/+3
Change-Id: I73a1cb1c206a2f55ec0c8948fca29b3976a51e75
2016-12-12dbaccess: fix testCloneMovesPlusDeletions testMichael Stahl1-1/+6
JunitTest_dbaccess_complex spuriously fails 1% of the time with: 1) testCloneMovesPlusDeletions(complex.dbaccess.RowSet) java.lang.AssertionError: moving to the next record after |deleteRow| and clone moves failed at complex.dbaccess.RowSet.testCloneMovesPlusDeletions(RowSet.java:756) The problem is that line RowSet.java:750 deleteRow() manages to delete the last row in the set, because the positionRandom() is tricked to position itself on the last row (which it tries not to do), becuase the RowSet is currently positioned past-the-end on a deleted row and the ORowSetBase::impl_getRowCount() is a lying bastard that adds 1 to the result in this special case. Funnily both the ORowSetBase::impl_getRowCount() and the test using positionRandom() were added in CWS rowsetdel. Yay for randomized tests! Change-Id: Ic8c7bfa190f6a5269604cf5b3c338f2d0b64205e
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann1-5/+0
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-11-15Fix typosSamuel Mehrbrodt1-1/+1
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann1-2/+2
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann1-8/+1
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-09-02dbaccess: fix loplugin:cppunitassertequals warningsMiklos Vajna2-20/+20
Change-Id: Ia450aa3170a21424fce641d3c8dee43b49f8ef61 Reviewed-on: https://gerrit.libreoffice.org/28609 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand1-74/+2
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for dbaccessArmin Le Grand2-0/+252
One dialog makes the execution hang, seems to wait for some interaction Change-Id: I68ef4f9b2a1575a6c70238f82eb27ee87aaae336
2016-06-03connectivity: firebird: use ODS12 test database for Firebird 3Michal Kubecek2-0/+5
Firebird 3.0 uses new database file format (ODS, On Disk Structure) so that we need to use either ODS11 or ODS12 version of test database for dbaccess_firebird test, depending on whether building against Firebird 2.5 or 3.0 libraries. Change-Id: Idecdc35b0ac87ab7f46cb79b5c044c65423a2c7e Reviewed-on: https://gerrit.libreoffice.org/25846 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann1-1/+1
Change-Id: I5cd8fd979fd4caa3d7cde599096627bfdd0dec7e
2016-04-04tdf#97361 Refactor dbaccess test againslideon1-29/+29
Remove duplicate code, add helper functions and constants Change-Id: Ib8702e2ce9918b47a608f6eb6fd2af7fd4dd1d0d Reviewed-on: https://gerrit.libreoffice.org/23727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-01Remove erroneously added dbaccess/qa/unit/data/hsqldb_empty.odb.lckStephan Bergmann1-0/+0
...from 9e596250a6e968c5d1e2fb0de582ae242e02acf9 "tdf#97966 Drop static keywords" Change-Id: I04d3559bceb214743695e2a008c1a1383535a635
2016-04-01tdf#97966 Drop 'static' keywordsWastack1-0/+0
Including no keywords from extern "C" blocks Change-Id: Icff7c0308843d6a7608be24d7fcf11fa079c7b72 Reviewed-on: https://gerrit.libreoffice.org/23672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann4-4/+4
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin4-4/+4
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-10Fix typosAndrea Gelmini1-3/+3
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-05java: remove ((unnecessary)) parenthesesNoel Grandin1-1/+1
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05java: make inner classes static where possibleNoel Grandin1-1/+1
Change-Id: Icc6444ad15d9f4b50858d8c1b1d3adeaeac40926
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann1-1/+1
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-06Fix typosAndrea Gelmini3-6/+6
Change-Id: I54c32259750c0863a39f56fabaa1a0df7d208c9a
2015-09-17boost->stdCaolán McNamara1-3/+3
Change-Id: Idfbcfa1e5ba7bff92e98693c33c4b33a6beda08f
2015-06-22Fix typosAndrea Gelmini1-1/+1
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15java: 'final static' to 'static final'Noel Grandin1-2/+2
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin1-1/+1
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-09remove some unnecessary exception wrapping in the Java testsNoel Grandin1-1/+0
Modify createTestEnvironment so that it throws Exception. This is appropriate for unit testing. The wrapping adds no value and the calling method already has a catch(Exception) to handle anything. Change-Id: I430a414f63d2cbfc3b65ecfde0285509265e5192
2015-06-05Let JUnit take care of exceptionsNoel Grandin6-254/+148
Inspired by commit 4dd0ac62855c5b9382cac004c7eebb9bed983a2b Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960 Reviewed-on: https://gerrit.libreoffice.org/16094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04Let JUnit take care of exceptionsStephan Bergmann1-231/+134
Change-Id: Ic628e4eccab59dce5d6d5e77656cac1f0006a491
2015-06-02inline simple Java methodNoel Grandin1-7/+2
Change-Id: I496fa3223ed97d4d2cf8d64649ce30da22331dbd Reviewed-on: https://gerrit.libreoffice.org/16039 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-01minor simplificationStephan Bergmann1-2/+1
Change-Id: Iad908728d63b0dcf3bef0a76c9d2fa3c892bf986
2015-06-01Do not lose AssertionError from sub-threadsStephan Bergmann1-1/+11
Change-Id: I8ca7194be6d22b72b73e76e5067273090b087b96
2015-05-30tweaksLionel Elie Mamane1-4/+5
Change-Id: I84ca5d1f3247d3ba3ed76bf3d39be14b47613703
2015-05-30janitorialLionel Elie Mamane1-3/+3
Change-Id: I72cc8b84332442920eb5bb793474de0e9ec0fc86
2015-05-30tdf#82591 ORowSetBase::getRow handles insert row correctlyLionel Elie Mamane1-0/+21
and critically for this bug, modified row, too. Change-Id: I11c418d8926cabe81fcdb65d7293a4283e566f7a
2015-03-10V668 no sense in testing the result of new against nullCaolán McNamara1-10/+1
Change-Id: I85993df91bd14966f9175c356966fbd8eb1a927d
2015-02-09Fuck that left-behind .lck fileStephan Bergmann1-0/+0
Change-Id: I6ceab61500397cae687fb4356e5dcb48f8090a48
2015-02-09Adapt file URL hackery to WindowsStephan Bergmann2-1/+1
Change-Id: Icee10aae97e9bcef7a3db7e966c1c4ef6780fc1d
2015-02-03Fix PythonTest_dbaccess_pythonStephan Bergmann1-1/+2
Change-Id: Id1ab4496c5a8fa5bf97ac00e57cb89afe82b232b
2015-02-03copy test file to workdir to avoid overwritingLionel Elie Mamane1-1/+5
Change-Id: I2acc5cd6a57bb6a18f3f20177b3bcf2b8469a834 Reviewed-on: https://gerrit.libreoffice.org/14272 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-01-22fdo#88475 add UnitTestLionel Elie Mamane2-0/+148
Change-Id: Icc2b80cfdcb3ff6a8a4fa8d1fb30a8ce9c865c95
2015-01-12java: simplify sleeping and waiting in testsNoel Grandin1-7/+1
- remove the SHORT_WAIT test parameter, no-one is using it - inline the various independent shortWait() methods - use the util.utils.shortWait() utility method everywhere Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin1-1/+1
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-05java: these fields can become local variablesNoel Grandin1-5/+3
found by PMD Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
2015-01-05java: remove dead codeNoel Grandin1-10/+0
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-18dbaccess: Use appropriate OUString functions on string constantsStephan Bergmann1-2/+2
Change-Id: I1d63c9123ad985cb3424b0ac0ad30c12e39f8170
2014-12-15java: remove some unused fields and variablesNoel Grandin1-1/+1
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: reduce visibility of fields and methodsNoel Grandin1-3/+3
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>