summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2016-11-15Fix typosSamuel Mehrbrodt1-1/+1
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15tdf#34467 - FitToFrame: stretch text to fill drawing objJustin Luth1-3/+7
Help for Fit To Frame says "Resizes the text to fit the entire area of the drawing or text object". reverts commit b7628798ec1a966c97a64d7cf0aa9f3859b78bef and partially addresses the problem of "Shrink font automatically when text overflows" by treating text as "Autofit" while it is being edited. It's not WYSIWYG, but good enough, and maybe better. Since that part of the change prevents any way of setting ::Autofit, I also changed the default setting to Autofit instead of NONE, since there is no good reason why text should be allowed to spill outside of a textbox. For those who REALLY want that odd behaviour, they can use .uno:TextFitToSize (Ctrl-Shift-F8) to toggle between "stretch" and "none". Change-Id: I8313a82cbea82f11fad0f50d966fc77874977da9 Reviewed-on: https://gerrit.libreoffice.org/30727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-11-14Avoid unnecessary, wrong downcastStephan Bergmann1-1/+1
...as reported by -fsanitize=vptr when doing "Format - Paragraph... - Area - Color" in Writer: > cui/source/tabpages/tpcolor.cxx:65:19: runtime error: downcast of address 0x6030009782b0 which does not point to an object of type 'XOutdevItemPool' > 0x6030009782b0: note: object is of type 'SwAttrPool' > 20 01 80 1c 50 e8 e9 85 4d 7f 00 00 e0 28 48 86 4d 7f 00 00 c0 d7 11 00 30 61 00 00 80 29 54 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SwAttrPool' > #0 0x7f4b047cfd3a in SvxColorTabPage::SvxColorTabPage(vcl::Window*, SfxItemSet const&) cui/source/tabpages/tpcolor.cxx:65:19 > #1 0x7f4b0480ec04 in VclPtr<SvxColorTabPage> VclPtr<SvxColorTabPage>::Create<vcl::Window*&, SfxItemSet const&>(vcl::Window*&, SfxItemSet const&) include/vcl/vclptr.hxx:138:46 > #2 0x7f4b047f8567 in SvxColorTabPage::Create(vcl::Window*, SfxItemSet const*) cui/source/tabpages/tpcolor.cxx:326:12 > #3 0x7f4b0472132a in CreateFillStyleTabPage(unsigned short, vcl::Window*, SfxItemSet const&) cui/source/tabpages/tparea.cxx:319:42 > #4 0x7f4b0471ef8b in SvxAreaTabPage::SelectFillTypeHdl_Impl(Button*) cui/source/tabpages/tparea.cxx:330:41 > #5 0x7f4b047114b3 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, Button*) cui/source/tabpages/tparea.cxx:323:1 > #6 0x7f4df3eac737 in Link<Button*, void>::Call(Button*) const include/tools/link.hxx:84:45 > #7 0x7f4df3e93bb6 in Button::Click()::$_0::operator()() const vcl/source/control/button.cxx:127:85 Change-Id: I6259b100c535fa81b9f7452db84c22d5b10acb1e
2016-11-14Avoid -fsanitize=nullStephan Bergmann2-44/+44
...when doing "Format - Page..." in Writer (and eFillType is TRANSPARENT): > cui/source/tabpages/tparea.cxx:331:33: runtime error: reference binding to null pointer of type 'SfxTabPage' > #0 0x7f9f053e936f in SvxAreaTabPage::SelectFillTypeHdl_Impl(Button*) cui/source/tabpages/tparea.cxx:331:9 > #1 0x7f9f053e548c in SvxAreaTabPage::ActivatePage(SfxItemSet const&) cui/source/tabpages/tparea.cxx:157:13 > #2 0x7fa21be01676 in SfxTabDialog::ActivatePageHdl(TabControl*) sfx2/source/dialog/tabdlg.cxx:1126:19 > #3 0x7fa21bdf70e3 in SfxTabDialog::LinkStubActivatePageHdl(void*, TabControl*) sfx2/source/dialog/tabdlg.cxx:1035:1 > #4 0x7fa1f5efff37 in Link<TabControl*, void>::Call(TabControl*) const include/tools/link.hxx:84:45 > #5 0x7fa1f5ebbcaa in TabControl::ActivatePage() vcl/source/control/tabctrl.cxx:1601:19 Change-Id: I279f507038ab4bae1be4f02b6537e6d1aab76348
2016-11-14Avoid -fsanitize=enumStephan Bergmann1-1/+1
...when doing "Format - Page..." in Writer: > cui/source/tabpages/tparea.cxx:268:12: runtime error: load of value 4294967295, which is not a valid value for type 'FillType' > #0 0x7f89ff653a41 in SvxAreaTabPage::Reset(SfxItemSet const*) cui/source/tabpages/tparea.cxx:268:12 > #1 0x7f8d15524560 in SfxTabDialog::ActivatePageHdl(TabControl*) sfx2/source/dialog/tabdlg.cxx:1117:19 > #2 0x7f8d1551b0e3 in SfxTabDialog::LinkStubActivatePageHdl(void*, TabControl*) sfx2/source/dialog/tabdlg.cxx:1035:1 > #3 0x7f8cef623f37 in Link<TabControl*, void>::Call(TabControl*) const include/tools/link.hxx:84:45 > #4 0x7f8cef5dfcaa in TabControl::ActivatePage() vcl/source/control/tabctrl.cxx:1601:19 Change-Id: I19dd3ed9d362132daa3f3be9fb0e9702a62bdeb0
2016-11-14tdf#103228: Remember fill type when switching between tabsKatarina Behrens1-0/+2
This page used not to have exchange support, but it needs it now since it contains all the fill type subtabs Change-Id: Ibeefc0ae832b4d53727711a169f1765d28350ec1 Reviewed-on: https://gerrit.libreoffice.org/30843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-13coverity#1371441 Uninitialized pointer fieldCaolán McNamara1-0/+4
Change-Id: Icabed9a27be9e34552531997818afd202f31114c
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin4-4/+4
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann1-2/+2
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann1-8/+1
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-10loplugin:expandablemethods in cuiNoel Grandin22-141/+38
Change-Id: I3dae1d142874c767ec1e32401acba0bbca95df5f Reviewed-on: https://gerrit.libreoffice.org/30716 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin2-2/+2
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08Change new colour only, keep active one on the initial valueKatarina Behrens2-16/+24
Change-Id: Icfda455d275d0449725867fd7bf4ea3060e7dc26 Reviewed-on: https://gerrit.libreoffice.org/30691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin1-2/+2
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara33-600/+308
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-07style fix for cppcheck duplicateBreakJochen Nitschke1-15/+0
Change-Id: I42d4763db5a87741baa6b6d5ec58ea136394bf7a Reviewed-on: https://gerrit.libreoffice.org/30670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:oncevar in cui..connectivityNoel Grandin8-52/+26
Change-Id: Ibe9d04932b0a57040db4fee11886dc1701f6ea17 Reviewed-on: https://gerrit.libreoffice.org/30653 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-05Reverts a commit series that cripple windows ci.Norbert Thiebaud33-308/+600
Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
2016-11-04SvxShadowTabPage::Construct was removedCaolán McNamara3-3/+0
Change-Id: Iaaa303dac79556d43cda78363abbcdd03e977e8a
2016-11-04replace last ColorLB use with a listbox of colorsCaolán McNamara3-99/+49
Change-Id: Ia0058939faa63507b50c5ca70527850e59c0ba5d
2016-11-04simplify, its just a vector of colorsCaolán McNamara2-55/+15
Change-Id: I7d388739225d371090872a33d30aa3178b20ca6e
2016-11-04replace user draw with an Image of the colorCaolán McNamara1-52/+11
Change-Id: I0d301ba4082a45e7030c6956c18aa76e52bce216
2016-11-04strip down to the used piecesCaolán McNamara1-118/+2
Change-Id: I1d9eed2345f3d8a78f467d0fb5f7b7cd0211a160
2016-11-04move now combined ColorLB to location of last userCaolán McNamara3-1/+331
Change-Id: I5dc1204c28b65d5dca993bf38aea217bbb49e913
2016-11-04unify color selectorsCaolán McNamara28-576/+204
Note: this removes the use of auto-color from writer's asian text grid, because its always invisible as far as I can see in practice. Change-Id: Ie850790d740a4d56c43015e493e093678cef3b4e
2016-11-04customize dialog crashes, since...Caolán McNamara1-1/+10
commit 164d8e3b1aa660d65c1af9570e67b66520bd953a Date: Thu Nov 3 02:35:00 2016 +0200 tdf#91222 VclBuilder constructor cleanup so revert problematic bit of that. The impl is called SfxAccCfgTabListBox_Impl, but the widget name is SfxAccCfgTabListBox Change-Id: I8e800b376afa48090fde1074350c1c8ce39a27bf
2016-11-04loplugin:unusedmethodsNoel Grandin2-8/+0
Change-Id: Ie1f840c3ec9a2d5888f95cf05e531a8a9464bf2e Reviewed-on: https://gerrit.libreoffice.org/30524 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu8-118/+12
Change-Id: I53bca2a9113862b8e7058937e231721c5f81a9de Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30511 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03remove pParentFrame from SfxFrameNoel Grandin1-1/+1
Found by the singlevalfields loplugin. Dead as least as far back as commit 93a7b558588be1f12e137329548b706daccc07df Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Fri Nov 27 21:16:24 2009 +0100 [CWS autorecovery] merged SfxTopFrame into SfxFrame SfxTopFrame was the only class deriving from the abstract class SfxFrame, so both can effectively be treated as one class. Arguably when that commit was done, SfxFrame should also have been renamed to SfxTopFrame, since that it was it now seems to be. Expanding the nullptr value off that field means that: SfxFrame::GetTopFrame always return this SfxFrame::IsParent always returns false SfxViewFrame::GetTopFrame is now the same as SfxViewFrame::GetFrame SfxViewFrame::GetParentViewFrame now returns null Change-Id: Iac088fa485c3d7299d1553845ced2f5ced3c85f2 Reviewed-on: https://gerrit.libreoffice.org/30485 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02Improve some error reportingStephan Bergmann1-21/+7
Change-Id: Ibfdb0eeebec785438d46a0e8e6e9f4c847bfb807
2016-11-02tdf#41542 PaddingWithoutBorders: allow UI changes if...Justin Luth2-6/+14
If the compatibility option is set, allow the border dialog for frames to be able to adjust the spacing values without enabling the border lines. That means it is only true for .doc and .docx right now. Change-Id: I4004a849f7369c993089d1c7b5d856cbea4f7780 Reviewed-on: https://gerrit.libreoffice.org/28602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke1-1/+1
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-31Nonsensical OUString null checkStephan Bergmann1-1/+1
...ever since at least d32b3a714fe55892bdead03502c5a9b0e77fa61d "#i106421#: move svx/source/cui to cui". (That happened to redundantly check for non-empty url, too; maybe in the distant past GetScriptURL returned a pointer.) Change-Id: I6139db1d4b1fdcf5325895569de293dd89e36d9f
2016-10-31SvxBrushItem::GetGraphicLink no longer returns a pointerStephan Bergmann1-1/+1
...since cfb4463d2afd36ca6d0fbb9e374bf5387fee84df "convert include/editeng/brushitem.hxx from String to OUString", which boldly changed it from returning a pointer to returning a reference, probably not even taking into account that that broke the value set (from string+null to just string). However, that change appears to have worked OK in practice, and there maybe wasn't a need after all to distinguish a null value from an empty string. These two places here were missed in the change, and happened to keep working, as they picked the operator ==(sal_Unicode const *, OUString const &) overload, that happens to treat a null first argument like an empty string. Change-Id: If2d76951fa4bf6c7821321327ad653bd0a95a788
2016-10-30tdf#95014 initial support for 32 px icons in toolbarTomaž Vajngerl3-5/+22
This adds support for 32 pixel icons - mainly to get them into the toolbar. Most changes made are to change the behavior of having only small and large icons as a boolean choice, but not every code path was converted to non-boolean choice yet. Breeze icon theme has the 32px variants so it can be used already. Change-Id: Iadf832a87826c16b3a83522104dd6c35d61a0f87 Reviewed-on: https://gerrit.libreoffice.org/30398 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29tdf#33278: Enable UI for vertical left-to-rightKhaled Hosny1-1/+1
Used mainly for traditional Mongolian. This has been disable since 2010 (shortly after the code was merged): commit faf68cc7565cb2662d4ed5b5902ec52975d99865 Author: Mathias Bauer <mba@openoffice.org> Date: Fri Jun 25 11:10:43 2010 +0200 CWS mongolianlayout: disable new direction until problems are fixed No idea what the problems are, but lets enable it and see what happens (the actual layout code have been enabled all the time and one can always manually craft ODT files that use it anyway). Change-Id: Id38d1735013d451f9fe116876483df3484dec051 Reviewed-on: https://gerrit.libreoffice.org/30364 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-28reset border should clear all bordersJustin Luth1-0/+2
If no borders were originally defined, the reset button was failing to clear the last-selected border line. Eg. page border, click on two of the borders, then hit reset. One border remains defined, and didn't reset to the starting value of non-visible. Because one border was still "selected", it became visible again as SelStyleHdl_Impl reinitialized. Change-Id: I2d20ae1e02816d5b30fe126572b54e7083114fc3 Reviewed-on: https://gerrit.libreoffice.org/30365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara12-36/+35
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-28convert std::unique_ptr<VclAbstractDialog> to VclPtrNoel Grandin1-1/+1
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
2016-10-27Sub menus no longer need manual disposingMaxim Monastirsky2-16/+0
after: commit ee79a2dd7ea60e902cab3a9203e307b8a78fee23 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jul 29 14:33:22 2016 +0100 Resolves: tdf#101169 crash using column menu in base Change-Id: I7c6e54dd5574c61cffd5884d1cf1b63075073001 Reviewed-on: https://gerrit.libreoffice.org/30343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-27tdf#103464 Don't allow empty names in SvxNameDialogMuhammet Kara2-3/+7
Menus, context menus, toolbars, toolbar items... could be created with empty names, and could be renamed to have empty names before this patch. Change-Id: Ic383f16955746002aa3ad69406bac855cdd58d2d Reviewed-on: https://gerrit.libreoffice.org/30286 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-27make the AbstractDialog stuff extend from VclReferenceBaseNoel Grandin9-191/+229
Because some stuff wants to multiple-inherit from VclAbstractDialog and OutputDevice-subclasses, and we'd prefer to keep all the lifetime management through a single smart pointer class (VclPtr) The change in msgbox.cxx and window.cxx is to workaround a bug in VS2013 to do with virtual inheritance and delegating constructors. Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773 Reviewed-on: https://gerrit.libreoffice.org/29140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-25tdf#103160 Add 'Add Submenu' button in Customize dialogMuhammet Kara3-39/+57
And remove the 'Add Submenu' entry from Modify split button in Customize dialog Change-Id: I6ac940f5f1f41ac1f962f66f458c7e14d702b2be Reviewed-on: https://gerrit.libreoffice.org/30230 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2016-10-25screenshot annotation: More readable markupKatarina Behrens1-20/+27
this should placate clang too Change-Id: Ida2cceebd5870b5896fb125e51e4cb67ad253d92
2016-10-25screenshot annotation: put back removed fieldsKatarina Behrens1-4/+8
I hate you loplugin !!! Change-Id: I01067b04005a59b7ecb10a5a72ab6090b7f040a8
2016-10-25screenshot annotation: Make this a default buttonKatarina Behrens1-0/+2
Change-Id: I1a1db338696cf56062306a54a43c746a21a3431d
2016-10-25screenshot annotation: insert markup for annotated widgetsKatarina Behrens1-1/+22
Change-Id: I82b8c541239271e3acfa6d8ad45b752fa1554931
2016-10-25screenshot annotation: Display markup for embedding the imageKatarina Behrens1-2/+43
Change-Id: I06fd744fabd66ee02123790718a899d9e0dcb6b7
2016-10-25screenshot annotation: tweak dialog a bitKatarina Behrens1-31/+42
Add some descriptive labels Remove OK button (redundant in this context, Save Screenshot... does the job) Change-Id: I36e32986f777675f297390b691f2cd1681a0eaa2
2016-10-21tdf#103223 custom palette label and a11y improvementsYousuf Philips1-26/+49
In the color section of the Area fill tab, i've added a custom palette label above the add and delete buttons, moved the palette label and control on the same line and improved the accessibility of various controls by adding tooltips and associating labels. Change-Id: I4a8c9963fd23312190ba343dbb1a0db587b13d1e Reviewed-on: https://gerrit.libreoffice.org/29894 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>