summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2017-02-10convert SvtSaveOptions::EOption to scoped enumNoel Grandin1-11/+11
and remove unused E_SAVEUNPACKED, E_USESHA1INODF12, E_USEBLOWFISHINODF12 enumerators Change-Id: I7c384e0c30af5091a22beeda1c77e4b71fdde55e
2017-02-10convert SvtSecurityOptions::EOption to scoped enumNoel Grandin2-19/+19
and drop unused E_MACRO_DISABLE enumerator Change-Id: I0bd706d4d4e1d8b9004e68c9e77c11410c62a64a Reviewed-on: https://gerrit.libreoffice.org/34067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-10convert SvtSysLocaleOptions::EOption to scoped enumNoel Grandin1-3/+3
and drop unused E_UILOCALE enumerator Change-Id: Ic9bdac91fab15af45e7dbd613e6e44b73b5cf9de Reviewed-on: https://gerrit.libreoffice.org/34066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09tdf#98993 cui: Paragraph dialog: decimals in Line Spacing spinboxMichael Stahl1-0/+1
For whatever reason, this also makes the +/- buttons increment by 1pt instead of the previous 10pt, which is also an improvement. (presumably regression from 324141f21bf2280d7613c4056ee8cd997ea345f9) Change-Id: If47dd768b2faea760d9967a73453d3f714c65fe3
2017-02-07Revert "remove ugly operator* in DynamicErrorInfo"Michael Stahl2-4/+4
This reverts commit b5e3f8a5fa98a249ecd50021c33cf2a5c7a3b4fc. The problem is this: ==24217== Conditional jump or move depends on uninitialised value(s) ==24217== at 0x29A25FCE: SfxObjectShell::SetError(unsigned int, rtl::OUString const&) (objmisc.cxx:220) ==24217== by 0x29A35E6E: SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) (objstor.cxx:2300) ==24217== by 0x29A3705C: SfxObjectShell::DoLoad(SfxMedium*) (objstor.cxx:765) ==24217== by 0x29A6BC48: SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (sfxbasemodel.cxx:1802) The commit is bogus because it introduces a DynamicErrorInfo::GetErrorCode(), which overloads ErrorInfo::GetErrorCode(), which is used at least in DynamicErrorInfo_Impl::RegisterEDcr() and used to return a constructor argument of DynamicErrorInfo but now returns pImpl->lErrId, which is what this statement is trying to initialize. Ultimately this causes my clang+ASAN build to fail because the uninitialized error code happens to be detected as a mere Warning: Test name: testMathMalformedXml::Import assertion failed - Expression: !xComponent.is() - loading succeeded: sw/qa/extras/ooxmlimport/data/math-malformed_xml.docx Change-Id: I9141144e0bc356ee54279948f2fce036d1831a86
2017-02-07remove ugly operator* in DynamicErrorInfoNoel Grandin2-4/+4
I can see why you'd want to hide this horrible tunnelling of information with objects registering themselves in a global list. Urrgh. Change-Id: Ib151a0d2d5a4508dc456e52883e488ce56d9a095 Reviewed-on: https://gerrit.libreoffice.org/33984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06Add missing #includesStephan Bergmann5-0/+7
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06loplugin:unusedenumconstants in connectivity..cuiNoel Grandin1-1/+0
Convert ExpressionFunct to scoped enum and drop FUNC_CONST value. Convert MQueryExpressionBase::node_type to scoped enum and drop Unknown value. Dop PageType::Color value Change-Id: Icb1f5503c230fb91329acc7d9e1da665fa28d95e Reviewed-on: https://gerrit.libreoffice.org/33948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-05sal_uIntPtr to sal_uInt16Matteo Casalin1-1/+1
Change-Id: If463ae457f53a0a8b12cc0748afbc654f54ae3c3
2017-02-03Typo: progess->progressJulien Nabet2-6/+6
Change-Id: Ic13529f4bc9ac49059a59067c50d5f2c0f569822 Reviewed-on: https://gerrit.libreoffice.org/33902 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-03new loplugin:unusedenumconstantsNoel Grandin3-5/+1
These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin1-4/+4
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01Need <config_features.h> here, tooTor Lillqvist1-0/+2
Change-Id: I8bd752814994fedac17fe0d002b415902c276b20
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin1-3/+2
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01Resolves: tdf#100438 focus trapped in disabled toolbarCaolán McNamara1-9/+0
lets just leave the toolbar active the whole time, seems to make more sense anyway wrt being allowed to keyboard into it to paste/insert special character Change-Id: I174fb707c4c7fd21d95461cc93323eb6d8970818
2017-02-01loplugin:stringconstant handle calls to constructors with one argNoel Grandin1-1/+1
Change-Id: Ide9148a908bef46ba14640dfa6f556beaf6e3f60 Reviewed-on: https://gerrit.libreoffice.org/33772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin6-17/+12
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30convert toolbar config context menu to .uiCaolán McNamara5-299/+261
Change-Id: I8f8a9517680f02cb8efa3e6e46d3d4ebf7da1510
2017-01-30crash on exit from undisposed insert special character dialogCaolán McNamara1-1/+1
right click on style combobox in writer toolbar, insert character, esc, ctrl+f4 and crash Change-Id: I83c88584c6d772bf629121a2bcdc16076bee8003
2017-01-30tdf#103654: Make git hash clickable in the About dialogArnold Dumas3-3/+62
This doesn't affect the About Dialog if the build id is not a valid git hash. Change-Id: Ie44f455dbfd0191cf6953091f28a42bccb67a4cb Reviewed-on: https://gerrit.libreoffice.org/33652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-01-27use a define for invalid SfxPoolItemJochen Nitschke1-2/+2
and use helper function IsInvalidItem() more Change-Id: Ifd651a336a7bd4ef4f945219d765afb827465438 Reviewed-on: https://gerrit.libreoffice.org/33611 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-27Compatibility options refactoring. Part 1Vitaliy Anderson1-1/+1
It relate to reduce the nubmer of copy-paste the same code and simplify adding compability options. Also using enum class instead enum can eliminate to occurrence an error relate to access to out of range an array. Change-Id: I07b862aac5f88da4a98e2273cb14daa09e70eacb Reviewed-on: https://gerrit.libreoffice.org/33543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann6-47/+27
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25move Image ctor variant with mask color to callersCaolán McNamara2-2/+2
Change-Id: I81a52aeb855edca823881360831b26e252780053
2017-01-24Resolves: tdf#104552 table properties dialog drops previous border colorCaolán McNamara1-0/+2
Change-Id: Ie39ea17fe56cc88efc65f6916aaeb1bd1b77c51f
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski22-32/+30
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-23loplugin: unnecessary destructor: comphelper..desktopNoel Grandin5-18/+0
Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e Reviewed-on: https://gerrit.libreoffice.org/33453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-21coverity#704601 Dereference after null checkCaolán McNamara1-1/+2
Change-Id: Icfef8f4ded311790a90b61b37c08254592d979ab
2017-01-21coverity#704602 Dereference after null checkCaolán McNamara1-1/+2
Change-Id: I069716ad675a217ecd97aee6b07346cf838fd653
2017-01-21coverity#1399015 Logically dead codeCaolán McNamara1-1/+1
Change-Id: I4d5e2c7d2bbd4eba3eeb790d51a4a93c7ef40577
2017-01-21fix buildCaolán McNamara1-2/+2
Change-Id: I501edaf90794df2ba776241e73c8b844e205ca3c
2017-01-20warn about unused ImagesCaolán McNamara1-3/+0
Change-Id: I5502b28411282354019af51a09c860099c652006 Reviewed-on: https://gerrit.libreoffice.org/33348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-20restore missing RID_SVXBMP_LOCK graphicCaolán McNamara2-1/+7
wrong removed by commit fa3d5ca1f99fe253689004a45ec2888ebbe85fd3 Author: abdulmajeed ahmed <aalabdulrazzaq@kacst.edu.sa> Date: Thu May 30 12:33:32 2013 +0200 Convert Languages tab page to .ui Deleted the readonly images too,it was not used any where else and was just confusing. Change-Id: Ice8e59cffc3b3001216c7499da5cbefe74ce8d88
2017-01-19New loplugin:dynexcspec: Add @throws documentation, cuiStephan Bergmann2-0/+3
Change-Id: Ib4db87e67f39504f49b795e12476edbea5166800
2017-01-17Refactor Scheduler to add Task classJan-Marek Glogowski7-7/+7
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski1-6/+6
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-17tdf#105014: Disable related buttons when there is no menu to editMuhammet Kara1-1/+1
Clicking the "Add Separator" or the "Add Submenu" button, when there is no menu edit, causes LibreOffice to crash. So disable them properly. Change-Id: Ibf685145a87c9e4343d83e1bb5ef6f08136c8f31 Reviewed-on: https://gerrit.libreoffice.org/32987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-16Convert RID_MENU_NOTEBOOKBAR to xmlMaxim Monastirsky1-0/+8
Brings a lot of features (icons, keyboard shortcuts, customization, context menu interception etc.) Other changes: - Make SfxDispatcher::ExecutePopup take PopupMenuFlags arg, to be able to pass NoMouseUpClose, so that the menu won't close on mouse-up under anything != gtk3. - Make .uno:OpenFromWriter and .uno:OpenFromCalc async slots, to avoid crash under gtk3 when recycling the current frame. - Don't show the menu in customization dialog, if experimental mode disabled. Change-Id: Ieea2f73f6b48fbaf4bdfc4acf1a33d25422357cb Reviewed-on: https://gerrit.libreoffice.org/33101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-16SfxConfigGroupListBox leaks its resource containerCaolán McNamara2-12/+12
Change-Id: I02cf44bdc9032fdba9237083ef08da71b817e3af
2017-01-16drop an unused resourceCaolán McNamara2-6/+0
Change-Id: I062859bf5c03f2bf1ad7306b0ce2ab4164eae3bf
2017-01-16unwind resourceCaolán McNamara7-75/+21
Change-Id: I7a951548204745035bd69e4311e5fa1fe91b2d32
2017-01-16drop unused defineCaolán McNamara1-1/+0
Change-Id: I2c3bd011f91e79d3aed43a78e54f149f19909cc3
2017-01-16b*, c*: load BitmapEx resources instead of Image onesCaolán McNamara13-82/+77
Change-Id: Idbf99de17e5349712ef7c3da3ce8bb8b5f879ef7
2017-01-16new loplugin: useuniqueptr: cuiNoel Grandin3-12/+8
Change-Id: I9a72b0d3ca999e2f84c615515fafa90bc7f8f2b6 Reviewed-on: https://gerrit.libreoffice.org/33150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-14these bitmaps all have alpha channels, not replaceable magenta hackCaolán McNamara2-4/+4
Change-Id: I5e4a433262f17cf4b7e7966687561202960bafa4
2017-01-13tdf#105259 calculate sizes of all area tab pages on constructionTomaž Vajngerl1-0/+29
When we open dialog that contains the area tab, we need to calculate the size of area tab pages (that are triggered by clicking on a button) and set the page area to the appropriate combined size. Otherwise we don't account for the needed space correctly and some page will be squished or have overlapping controls. This change creates all pages at dialog construction, gets all the optimal sizes and sets the size of the page container box to the combined (minimal) size. Change-Id: Ie04a121810b96973f6e4502a52af675b2baacf25 Reviewed-on: https://gerrit.libreoffice.org/33040 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-13tdf#46552 fixing preview for bullets/numbering configurationpv2k1-0/+1
Change-Id: I959169428d4ed0498a2b78fc7a6ae0815e780648 Reviewed-on: https://gerrit.libreoffice.org/32816 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-13new loplugin: useuniqueptr: vclNoel Grandin1-1/+1
Change-Id: Idcbc8655108ff57c06c33bbcabd652387bf3c4ec Reviewed-on: https://gerrit.libreoffice.org/32948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-12tdf#103225 make AreaTab box fill to contentTomaž Vajngerl1-0/+2
Change-Id: I9900bab2bb4510352d191ee42c0fa83049d9cecc Reviewed-on: https://gerrit.libreoffice.org/33006 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-09tdf#103225 revert setting of a fixed size for the dialogTomaž Vajngerl1-3/+0
Setting fixed size of a dialog causes a mess with HiDPI and could also cause problems with certain languages because the translated strings could streach the dialog size. It is better to let the dialog calculate its ideal size depending on the content, which in some cases is not ideal but at least it shouldn't create a mess. The decision to revert this was done in design hangout on 2016-12-22. Change-Id: I0ad1e38e1625cdbbf65b846118995bd5d3ebb47e Reviewed-on: https://gerrit.libreoffice.org/32912 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 20:35:48 +0000