summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2017-09-11Fix typosAndrea Gelmini1-1/+1
Change-Id: I7bb62814c8cdf635d1c54f0a1cbb09a3d06a0d5d Reviewed-on: https://gerrit.libreoffice.org/42178 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-11tdf#108011: Customize dialog's commands list should respond to keyboardMuhammet Kara1-0/+1
Change-Id: I58cd779714624e7b37c7920df622aa454afb9f29 Reviewed-on: https://gerrit.libreoffice.org/42163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-09-11add missing context attributes to .ui filesAndras Timar1-17/+17
Change-Id: If66a4e867b3b406aed90ab2259637e536e236ea3 Reviewed-on: https://gerrit.libreoffice.org/42164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-09-11clang-tidy modernize-use-emplace in c*Noel Grandin8-81/+81
Change-Id: I419d1f67ba301050d05981db2a3d6178878684a9 Reviewed-on: https://gerrit.libreoffice.org/42110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-10tdf#112254: fix memory leak in optaboutconfig (cui)Julien Nabet2-2/+6
Store UserData objects in a member defined as vector of unique_ptr so we're sure UserData objects will be destroyed when out of the scope Change-Id: Ib5494ad563272adcf64035300f3213688437fcfc Reviewed-on: https://gerrit.libreoffice.org/42123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-10cppcheck: knownConditionTrueFalse 'bValid' is always trueJochen Nitschke1-17/+4
Change-Id: I3f73641286020a06a605867726d54376c47a06dc Reviewed-on: https://gerrit.libreoffice.org/42134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-09tdf#108406 offline help-images helpimg are no longer selectable as iconsetAndreas Brandner1-0/+4
Change-Id: I6733ed2a04c01c288de2cd6af938a6c6ff1b4481 Reviewed-on: https://gerrit.libreoffice.org/42117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-09tdf#112133: Polish the visual appearance of the Customize dialogMuhammet Kara4-33/+83
* Vertically align the dual list controls at top and bottom * Vertically center align small controls' captions (search, category) * Vertically top align captions of large controls (description) * Horizontally align captions at the keyboard tab For labels: * Drop all colons * Remove the bold font style at the keyboard tab * Provide mnemonics for all captions with focusable controls (add, remove, insert, modify, reset... but not description) * Take care of unique mnemonics (alt+C = category & cancel) Functional * Disable the description when nothing is to show there (no offline help installed), and inform the user via tooltips Change-Id: I5862f97ec8e5e866f5e56bcdaf386a793f6040d1 Reviewed-on: https://gerrit.libreoffice.org/42099 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-08set parent for file dialog helperCaolán McNamara13-22/+19
Change-Id: I3994ee48dcb5b2732cb27cb9ccb54926abf0828a Reviewed-on: https://gerrit.libreoffice.org/42048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-08loplugin:constantparamNoel Grandin2-3/+3
Change-Id: Ic87f0cc863490858b7cc7e74a7f90ec31992dd53 Reviewed-on: https://gerrit.libreoffice.org/42089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-07Don't use PostUserEvent to show message box in Customize dialogMuhammet Kara2-12/+3
Otherwise, it causes (I think) some clean-up issues, and causes the menu bar not to be refreshed on delete of a custom menu after trying to add an already existing command to the custom menu, and getting the warning message box. And clicking the non-existent menu causes the whole application to crash because of the dangling reference, I think. The exact error message on crash was an "out of range" error of a vector." And we don't need the D&D stuff any more. (At least for now.) Change-Id: I74b8b414e28349065b7408e21e07245fc40f2c75 Reviewed-on: https://gerrit.libreoffice.org/41930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-05tdf#39674 find / fix all German spellings in internal APIsAndreas Brandner1-8/+8
Change-Id: Idcbfe301c13ffa1260ba3ab0665570db5ccc8112 Reviewed-on: https://gerrit.libreoffice.org/41929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-05Polish the Customize dialogMuhammet Kara2-6/+28
with some padding, filling etc. on the .ui file, and some size modifications on the .cxx file Change-Id: I8fdfc298c06162fd847b338a523542bb1ce7ada9 Reviewed-on: https://gerrit.libreoffice.org/41923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-05cui: fix loplugin:constparams warningMiklos Vajna2-2/+2
Change-Id: Ibd61a5e3659b74c67909e351472acdee752a5abc
2017-09-05cui: fix loplugin:unnecessaryparen warningsMiklos Vajna2-2/+2
Change-Id: I7eaee88006c57bb063108aefe28b19ac72363076
2017-09-04Make the Modify button functional in the Customize dialogMuhammet Kara7-23/+337
By adding "rename", "change icon", "reset icon", and "restore default command" options to the Modify button at the bottom of the right (toolbar/menu entries) list. Change icon / Reset icon / Restore default command options are not supported in the menu/context menu tabs yet. Change-Id: Iade3d1aca722c7f8eddcadf251b9562c5366d8ad Reviewed-on: https://gerrit.libreoffice.org/41620 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Disable the individual reset button for the menubar menusMuhammet Kara3-15/+32
And: * Cut m_pDescriptionField's ties to the entries list on the right. * Disable Add and Remove buttons depending on current command selection * Display the description of the selected command Change-Id: I65a06f2f143c335f26de9007c6067f3116465c30 Reviewed-on: https://gerrit.libreoffice.org/41582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Make toolbar/menu addition/removal functional again in the Customize dialogMuhammet Kara8-2/+143
"+" and "-" buttons next to the menu/toolbar listbox can be used to add new toolbars/menus or remove existing toolbars/menus. Most of the code was borrowed from the previous implementation, and adapted to fit the current structure. Change-Id: I7e7f51a46251c2d010154f2a0bab3bb20280bf7c Reviewed-on: https://gerrit.libreoffice.org/41431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Implement "Reset" button in the Customize dialogMuhammet Kara8-3/+82
For now, it works for the Toolbar and the Context Menu tabs. Normal top-level menus cannot be reset individually at the moment because they are sharing a single xml file, and the removeSettings() mathod doesn't provide per-item removal from within a single file. Change-Id: I42d62dc26130e4c03cf75a1ce6dc9ff367a58d47 Reviewed-on: https://gerrit.libreoffice.org/41367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Implement "Insert" button in the Customize dialogMuhammet Kara7-4/+117
Now the Insert button allows the user to insert separators to the toolbars, and separators and submenus to the menus and context menus. Change-Id: Ic520c78dee2152a0294e86d3bc7098a29155e4b9 Reviewed-on: https://gerrit.libreoffice.org/41360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Implement Search/Filter feature in the Customize dialogMuhammet Kara7-10/+62
Now commands in the list (left box) are filtered/updated in the Menu, Context Menu, and the Toolbar tabs as you type. Instead of filling the box, and then removing non-matching items (as in the current search feature in the keyboard tab), we filter out items during the Fill process, and don't add them to the sequence att all. This should give a performance boost to the filter operations. Change-Id: I473596a2c897f1cd96a7d55fd3ab11ee3db39863 Reviewed-on: https://gerrit.libreoffice.org/41321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Implement "Remove" button in the Customize dialogMuhammet Kara4-10/+14
By using the already implemented DeleteSelectedContent function. Now toolbar and menu/context menu items can be removed by using the "Remove" (Left Arrow) button which is between the commands list and the enrtries list boxes. Change-Id: If445ec6d431bc10263d961563bdd204e7868b931 Reviewed-on: https://gerrit.libreoffice.org/41272 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Implement "Add" button in the Customize dialogMuhammet Kara6-8/+74
Now new commands can be added to Toolbars, Menus, and Context Menus by using the Add (right arrow) button which is between the commands list and the menu/toolbar entries list. Change-Id: I9c094a5142f82922c5e5bc3075a35442875a5fec Reviewed-on: https://gerrit.libreoffice.org/41240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Initialize and update command categories and functions for the Toolbar tabMuhammet Kara2-0/+16
Change-Id: I27a12fc9e337796fc153e1d243eeba37564ef5c1 Reviewed-on: https://gerrit.libreoffice.org/41104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Initialize and update Function list box properlyMuhammet Kara8-66/+175
* Add dispose methods to CommandCategortListBox * Cast the commands list to SfxConfigFunctionListBox * Update the glade catalog to include CommandCategoryListBox widget * Borrow and adapt FillFunctionsList method from SfxConfigGroupListBox * Create and setup proper SelectHDL(s) Now the command list box (Function box on the left) is properly populated and updated upon selection of a category from the categories list box. Implemented for the Menu and Context Menu tabs. Change-Id: I30ebe89e80bdb2c5b686a26acb7c1ab1178b7525 Reviewed-on: https://gerrit.libreoffice.org/40968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Add custom widget class: CommandCategoryListBoxMuhammet Kara7-1/+172
It now lists all command categories which can be added based on the current module (writer, calc etc.) This class will be expanded later with macros and styles handling stuff. It will also update the commands listbox when it is added. Change-Id: I4f50408641db067118f63fe0e9a1ee755873412f Reviewed-on: https://gerrit.libreoffice.org/40833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-04Convert UI of Customize Dialog to the new designMuhammet Kara9-1368/+365
* Elements of the old design have been removed from both the .ui file and the .cxx/.hxx files. * New elements for the new design have been added to the .ui file. * Menu, Toolbar and Context menu tabs now resemble the new design Change-Id: Ib602e0a4b9419d16adaa4ff6aa23b74097a3b88d Reviewed-on: https://gerrit.libreoffice.org/40468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-09-04loplugin:unnecessaryparen include c++ castsNoel Grandin2-3/+3
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-04new loplugin:redundantpointeropsNoel Grandin3-3/+3
Change-Id: I8428d86ea9628d69c2b40b36feee3da428a9fe1d Reviewed-on: https://gerrit.libreoffice.org/41787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-03Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: Id17744f8c2d48a04e1b5e64a11739605709fb6c3 Reviewed-on: https://gerrit.libreoffice.org/41865 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-02set parent for insert ole object file dialogCaolán McNamara1-3/+3
Change-Id: Iffa30802f65c950290d74a79c66d679b0ff9d5ea Reviewed-on: https://gerrit.libreoffice.org/41814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-25Get rid of need to use initial :: for ::opencl to avoid clash with sc::openclTor Lillqvist2-2/+2
Rename the global opencl namespace to openclwrapper. Its public API is after all declared in a file called openclwrapper.hxx. The confusion started when part of the OpenCL code was moved out from sc some years ago. Change-Id: I98ebd8498b2244804411e5de9169eb619f86070b
2017-08-25Allow non-modal Dialogs during FileImport/LoadArmin Le Grand1-2/+2
When opening a file that triggers Dialogs (e.g. cannot read/repair/FileType) the Frame from which it was initialized gets blocked. This irritates quite some people. Changed this to a non-modal Dialog so that the user can continue to work with all opened docs, open new ones, close and print/PDF/export these. Change-Id: I048d3de3369527cec20d26396b87439254764b8a Reviewed-on: https://gerrit.libreoffice.org/41534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-08-25tdf#111795 - Special character preview control background colorAkshay Deep1-0/+5
Change-Id: Id5c3448b0cf82e5ed3aa9afabc5bfb093eddf2e9 Reviewed-on: https://gerrit.libreoffice.org/41524 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-24tdf#87648 Spelling and Grammarheiko tietze1-1/+1
Renamed to just Spelling Change-Id: I4433d75a8fd697e8d4dd25fa5d26411ed15b6c1b Reviewed-on: https://gerrit.libreoffice.org/40717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-23tdf#111795 - Special character preview control should have borderAkshay Deep1-1/+1
Change-Id: Ic26888829c24f65b3d8039e74a632c14be338d44 Reviewed-on: https://gerrit.libreoffice.org/41356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-23convert message box style bits to scoped enumNoel Grandin8-15/+15
and fix harmless bug in ImpSVGDialog::ImpSVGDialog, which there since commit 6456f1d81090dd5fe44455c09ae3ede7ec6ac38a Date: Fri Feb 4 14:52:54 2011 +0100 ka102: added/removed files for SVG import and module cleanup Change-Id: I66b2ec2b029431ab453e54e962863e4ed7d78962 Reviewed-on: https://gerrit.libreoffice.org/41412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22convert WB_QUICK_SEARCH/WB_FORCE_MAKEVISIBLE to bool fieldsNoel Grandin4-7/+15
Change-Id: Ic297d97911a6c0356d24ffe4b58442dfe866139f Reviewed-on: https://gerrit.libreoffice.org/41407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21fix bogus always-true assertsMichael Stahl1-1/+1
Most of these were converted from OSL_ASSERT Change-Id: Ia95a758cdebf72ee80d00866644d92e6bb915071
2017-08-20Enable subset filter when not in search modeAkshay Deep1-1/+1
Change-Id: If8bb1471cb09599d514ca2fef963249309d6563a Reviewed-on: https://gerrit.libreoffice.org/41357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2017-08-20Fix 'make translations' runGabor Kelemen1-1/+1
Recent commits introduced strings in .ui files without context which makes 'make translations' fail with: [build POT] pot.done Traceback (most recent call last): File "/home/gabor/src/core/solenv/bin/uiex", line 30, in <module> keyid = entry.msgctxt + '|' + entry.msgid TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' Affected commits are: e74be9ad773c7769c5d8765bb2ac234967e420ec 213a83ce46edf1b81f2285fd59f1d04935760caa Change-Id: If7afc4bb157a6406cabba141d375e9b0dab5f3de Reviewed-on: https://gerrit.libreoffice.org/41322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-08-20drop unused SfxSpellCheckItemJochen Nitschke2-14/+6
last getter went with commit 215207f480258b37864a88e1b831055e148adf65 Date: Thu Mar 6 16:42:24 2014 +0000 coverity#708784 Unused pointer value don't put the item in any item sets anymore. delete SID_ATTR_SPELL and adjust SfxItemSet ranges. narrow ranges in OfaTreeOptionsDialog::CreateItemSet to actually used items. Change-Id: Ia5cc91fc62a0fccf87b2fd380e6bb2bef1f6f3e7 Reviewed-on: https://gerrit.libreoffice.org/41335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-19drop unused SfxSizeItemJochen Nitschke1-1/+0
unused since commit 48bf5e855ae02fd1bea87938978f29ee6147285c Date: Thu Nov 16 14:30:58 2000 +0000 Remove tests for INET_PROT_FILE Change-Id: I2dc134f529675204caad78c7e50417adb55e8e4f Reviewed-on: https://gerrit.libreoffice.org/41320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-19tdf#103275 Rename 'Spacing to Content' to 'Padding'Gabor Kelemen2-2/+2
Change-Id: Ib4bdc594f34761c5957e9fb803218946b54e23f7 Reviewed-on: https://gerrit.libreoffice.org/41306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-08-19convert to WB_SAVEAS to flags on SfxAcceleratorConfigPage::StartFileDialogNoel Grandin2-5/+7
Change-Id: I52ff0b4ba892a74d1dad9ce8c6c7638e3463affe Reviewed-on: https://gerrit.libreoffice.org/41303 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18loplugin:unnecessaryparenNoel Grandin3-3/+3
look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Fix typosAndrea Gelmini1-1/+1
Change-Id: If13c1408a3e597c6f9b21d209722ef6bc87c0c94 Reviewed-on: https://gerrit.libreoffice.org/41270 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-17drop unused SdrCustomShapeAdjustmentItemJochen Nitschke1-1/+0
unused since commit 935baf97a926baa50d985808736e0adb8837c716 Date: Tue May 19 09:32:45 2009 +0000 CWS-TOOLING: integrate CWS impress169 Change-Id: I1e8b0285ae1f6e8d92efd3f5a2463ff3126f1a0d Reviewed-on: https://gerrit.libreoffice.org/41248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin1-1/+1
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Clean up uses of OUString::fromUtf8 around string literalsStephan Bergmann1-2/+2
Change-Id: I9a2990e49c95a01ce505f13408be8c19db1cf5d1
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 14:52:22 +0000