summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2016-11-04loplugin:unusedmethodsNoel Grandin2-8/+0
Change-Id: Ie1f840c3ec9a2d5888f95cf05e531a8a9464bf2e Reviewed-on: https://gerrit.libreoffice.org/30524 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu8-118/+12
Change-Id: I53bca2a9113862b8e7058937e231721c5f81a9de Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30511 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03remove pParentFrame from SfxFrameNoel Grandin1-1/+1
Found by the singlevalfields loplugin. Dead as least as far back as commit 93a7b558588be1f12e137329548b706daccc07df Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Fri Nov 27 21:16:24 2009 +0100 [CWS autorecovery] merged SfxTopFrame into SfxFrame SfxTopFrame was the only class deriving from the abstract class SfxFrame, so both can effectively be treated as one class. Arguably when that commit was done, SfxFrame should also have been renamed to SfxTopFrame, since that it was it now seems to be. Expanding the nullptr value off that field means that: SfxFrame::GetTopFrame always return this SfxFrame::IsParent always returns false SfxViewFrame::GetTopFrame is now the same as SfxViewFrame::GetFrame SfxViewFrame::GetParentViewFrame now returns null Change-Id: Iac088fa485c3d7299d1553845ced2f5ced3c85f2 Reviewed-on: https://gerrit.libreoffice.org/30485 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02Improve some error reportingStephan Bergmann1-21/+7
Change-Id: Ibfdb0eeebec785438d46a0e8e6e9f4c847bfb807
2016-11-02tdf#41542 PaddingWithoutBorders: allow UI changes if...Justin Luth2-6/+14
If the compatibility option is set, allow the border dialog for frames to be able to adjust the spacing values without enabling the border lines. That means it is only true for .doc and .docx right now. Change-Id: I4004a849f7369c993089d1c7b5d856cbea4f7780 Reviewed-on: https://gerrit.libreoffice.org/28602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke1-1/+1
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-31Nonsensical OUString null checkStephan Bergmann1-1/+1
...ever since at least d32b3a714fe55892bdead03502c5a9b0e77fa61d "#i106421#: move svx/source/cui to cui". (That happened to redundantly check for non-empty url, too; maybe in the distant past GetScriptURL returned a pointer.) Change-Id: I6139db1d4b1fdcf5325895569de293dd89e36d9f
2016-10-31SvxBrushItem::GetGraphicLink no longer returns a pointerStephan Bergmann1-1/+1
...since cfb4463d2afd36ca6d0fbb9e374bf5387fee84df "convert include/editeng/brushitem.hxx from String to OUString", which boldly changed it from returning a pointer to returning a reference, probably not even taking into account that that broke the value set (from string+null to just string). However, that change appears to have worked OK in practice, and there maybe wasn't a need after all to distinguish a null value from an empty string. These two places here were missed in the change, and happened to keep working, as they picked the operator ==(sal_Unicode const *, OUString const &) overload, that happens to treat a null first argument like an empty string. Change-Id: If2d76951fa4bf6c7821321327ad653bd0a95a788
2016-10-30tdf#95014 initial support for 32 px icons in toolbarTomaž Vajngerl3-5/+22
This adds support for 32 pixel icons - mainly to get them into the toolbar. Most changes made are to change the behavior of having only small and large icons as a boolean choice, but not every code path was converted to non-boolean choice yet. Breeze icon theme has the 32px variants so it can be used already. Change-Id: Iadf832a87826c16b3a83522104dd6c35d61a0f87 Reviewed-on: https://gerrit.libreoffice.org/30398 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-29tdf#33278: Enable UI for vertical left-to-rightKhaled Hosny1-1/+1
Used mainly for traditional Mongolian. This has been disable since 2010 (shortly after the code was merged): commit faf68cc7565cb2662d4ed5b5902ec52975d99865 Author: Mathias Bauer <mba@openoffice.org> Date: Fri Jun 25 11:10:43 2010 +0200 CWS mongolianlayout: disable new direction until problems are fixed No idea what the problems are, but lets enable it and see what happens (the actual layout code have been enabled all the time and one can always manually craft ODT files that use it anyway). Change-Id: Id38d1735013d451f9fe116876483df3484dec051 Reviewed-on: https://gerrit.libreoffice.org/30364 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2016-10-28reset border should clear all bordersJustin Luth1-0/+2
If no borders were originally defined, the reset button was failing to clear the last-selected border line. Eg. page border, click on two of the borders, then hit reset. One border remains defined, and didn't reset to the starting value of non-visible. Because one border was still "selected", it became visible again as SelStyleHdl_Impl reinitialized. Change-Id: I2d20ae1e02816d5b30fe126572b54e7083114fc3 Reviewed-on: https://gerrit.libreoffice.org/30365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara12-36/+35
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-28convert std::unique_ptr<VclAbstractDialog> to VclPtrNoel Grandin1-1/+1
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
2016-10-27Sub menus no longer need manual disposingMaxim Monastirsky2-16/+0
after: commit ee79a2dd7ea60e902cab3a9203e307b8a78fee23 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jul 29 14:33:22 2016 +0100 Resolves: tdf#101169 crash using column menu in base Change-Id: I7c6e54dd5574c61cffd5884d1cf1b63075073001 Reviewed-on: https://gerrit.libreoffice.org/30343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-27tdf#103464 Don't allow empty names in SvxNameDialogMuhammet Kara2-3/+7
Menus, context menus, toolbars, toolbar items... could be created with empty names, and could be renamed to have empty names before this patch. Change-Id: Ic383f16955746002aa3ad69406bac855cdd58d2d Reviewed-on: https://gerrit.libreoffice.org/30286 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-27make the AbstractDialog stuff extend from VclReferenceBaseNoel Grandin9-191/+229
Because some stuff wants to multiple-inherit from VclAbstractDialog and OutputDevice-subclasses, and we'd prefer to keep all the lifetime management through a single smart pointer class (VclPtr) The change in msgbox.cxx and window.cxx is to workaround a bug in VS2013 to do with virtual inheritance and delegating constructors. Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773 Reviewed-on: https://gerrit.libreoffice.org/29140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-25tdf#103160 Add 'Add Submenu' button in Customize dialogMuhammet Kara3-39/+57
And remove the 'Add Submenu' entry from Modify split button in Customize dialog Change-Id: I6ac940f5f1f41ac1f962f66f458c7e14d702b2be Reviewed-on: https://gerrit.libreoffice.org/30230 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2016-10-25screenshot annotation: More readable markupKatarina Behrens1-20/+27
this should placate clang too Change-Id: Ida2cceebd5870b5896fb125e51e4cb67ad253d92
2016-10-25screenshot annotation: put back removed fieldsKatarina Behrens1-4/+8
I hate you loplugin !!! Change-Id: I01067b04005a59b7ecb10a5a72ab6090b7f040a8
2016-10-25screenshot annotation: Make this a default buttonKatarina Behrens1-0/+2
Change-Id: I1a1db338696cf56062306a54a43c746a21a3431d
2016-10-25screenshot annotation: insert markup for annotated widgetsKatarina Behrens1-1/+22
Change-Id: I82b8c541239271e3acfa6d8ad45b752fa1554931
2016-10-25screenshot annotation: Display markup for embedding the imageKatarina Behrens1-2/+43
Change-Id: I06fd744fabd66ee02123790718a899d9e0dcb6b7
2016-10-25screenshot annotation: tweak dialog a bitKatarina Behrens1-31/+42
Add some descriptive labels Remove OK button (redundant in this context, Save Screenshot... does the job) Change-Id: I36e32986f777675f297390b691f2cd1681a0eaa2
2016-10-21tdf#103223 custom palette label and a11y improvementsYousuf Philips1-26/+49
In the color section of the Area fill tab, i've added a custom palette label above the add and delete buttons, moved the palette label and control on the same line and improved the accessibility of various controls by adding tooltips and associating labels. Change-Id: I4a8c9963fd23312190ba343dbb1a0db587b13d1e Reviewed-on: https://gerrit.libreoffice.org/29894 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-20Handle link click directly in FixedHyperlinkSamuel Mehrbrodt4-83/+2
Change-Id: I5b5f0648b6e6432b0928351a17d285df8c9da811
2016-10-19loplugin:expandablemethodds in cuiNoel Grandin22-102/+25
Change-Id: I7b2321d45171f9b73965efea32832a3789f0dee7 Reviewed-on: https://gerrit.libreoffice.org/30011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18make area tab page of paragraph properties not crashCaolán McNamara3-6/+12
cause the parent dialog isn't a SvxAreaTabDialog Change-Id: I1a1311ca4b414c797d4b3e72208e64bffea863ca
2016-10-18Drop 'Human' icon themeSamuel Mehrbrodt1-2/+1
Was used in Ubuntu formerly, but they now switched to breeze. Human is mostly similiar to Tango, with some Ubuntu colors. So it should be enough to keep Tango. Change-Id: Ib44cbefb2953406c95dbb269ada663bce2503234 Reviewed-on: https://gerrit.libreoffice.org/29537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-18tdf#89307: Removed T* SvRef::opeartor &()Jacek Fraczek1-2/+2
Usage has been replaced with SvRef::get() or removed where applicable. Change-Id: I49f108910b668466134c40940b53fc3ab2acd816 Reviewed-on: https://gerrit.libreoffice.org/29780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-18loplugin:unusedmethodsNoel Grandin3-120/+0
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-15tdf#103223 Arrange buttons, add spacing and separator to Area tabYousuf Philips1-4/+17
Change-Id: I6aa6c1a43ac3f3ab468c28dbc298d60646c7dadb Reviewed-on: https://gerrit.libreoffice.org/29892 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-14coverity#1373664 Uninitialized scalar fieldCaolán McNamara1-1/+3
Change-Id: I011810bb7f40b27f940dafaf4454f9e3ab4fd804
2016-10-13flaten array of stringarrays by a levelCaolán McNamara4-133/+127
Change-Id: I44dfe258f2220c5063b1177b67dbef71608ecef8
2016-10-13convert SvxPageUsage to scoped enumNoel Grandin1-13/+13
and expand out the bit-tricks some of the code was playing to make it more obvious what is going on Change-Id: I9c98334393b939b1d900425f6133556ce88247ae Reviewed-on: https://gerrit.libreoffice.org/29734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12Avoid one more crash on switching to pattern tabKatarina Behrens1-0/+3
this one happens when selecting Format > Area with no shape selection or in Draw's page properties dialog Change-Id: I20c94d4ac0c0ad20a4ac3f28275d1ca7f9ccdeb9 Reviewed-on: https://gerrit.libreoffice.org/29726 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12Enlarge tabpage size so that even colour tab fits inKatarina Behrens1-2/+2
Change-Id: Ic768000d6710b14d117a3480a13c39efe9e330ea Reviewed-on: https://gerrit.libreoffice.org/29725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12tdf#101442 "hyperlink" to "link" - other words changeFederico Bassini1-2/+2
Changes to be committed: modified: cui/uiconfig/ui/securityoptionsdialog.ui modified: sw/uiconfig/swriter/ui/tocentriespage.ui Change-Id: Ie46281b4c15dad634bab870fbe50c749165a001d Reviewed-on: https://gerrit.libreoffice.org/29727 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-12-Werror,-Wunused-private-field, againStephan Bergmann2-2/+0
Change-Id: I1f1ab1e3fd1360111a48d68effd254277e220843
2016-10-12Avoid crash on switching to pattern tabKatarina Behrens1-4/+1
Change-Id: I8edeb1a92c20c88160109a904cdcec355a5ef998 Reviewed-on: https://gerrit.libreoffice.org/29599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12[GSoC] Remove fill style tabs from area fill dialogRishabh Kumar3-131/+21
Change-Id: I7409118cbbab1350dda169d5bdfef51b7354de9f Reviewed-on: https://gerrit.libreoffice.org/27864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12[GSoC] Move all fill style tabs inside area tabRishabh Kumar10-1444/+873
Change-Id: I89e84b7b3c7075ad4107e7bc444ea5c07bc90795 Reviewed-on: https://gerrit.libreoffice.org/27866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12loplugin:unnecessaryoverride in connectivity/cuiNoel Grandin4-20/+0
Change-Id: I5ec4eb2f74036e42851333e3d669dbea58c2490a Reviewed-on: https://gerrit.libreoffice.org/29687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11loplugin:constantfunctionNoel Grandin2-6/+0
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10tdf#101442 Change "hyperlink" to "link" for a modern vocabularyFederico Bassini3-5/+5
Change-Id: Ib1c067b6d45e959d6cd0fbf00cab167939554203 Reviewed-on: https://gerrit.libreoffice.org/29572 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-06I can't see any evidence of any remaining magenta mask using image resourcesCaolán McNamara3-32/+11
Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
2016-10-06ImageList just reads and discards the MaskColor, so drop itCaolán McNamara2-6/+0
Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
2016-10-06these other IMAGE_STDBTN_COLOR defines do nothingCaolán McNamara1-4/+0
Change-Id: If35bd52f973dc89b05afd283a4a89998c491b862
2016-10-05convert the last two lonely FixedInfos to FixedTextCaolán McNamara11-13/+0
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05convert MapUnit to scoped enumNoel Grandin38-157/+157
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann180-1315/+1315
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-25 22:11:02 +0000