summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2020-02-19Resolves: tdf#130658 there isn't a second column in non-exception modeCaolán McNamara1-1/+4
Change-Id: I35edf263251c087976aa9a2506bb23c083e1f7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88689 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-19Resolves: tdf#130486 setting distributed results that justified cannot be setCaolán McNamara1-4/+9
Change-Id: If80c935b7e33b5c7146eb562daf2303688160653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88274 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 818598e609ad9160af52ae8b02d772ca29f9ad7b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88396 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-02-11Resolves: tdf#130340 null deref when nothing selectedCaolán McNamara1-1/+1
Change-Id: Ie406006cbcca566ddd32fd86a7e88f0c754dd02e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88048 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 5cbaec2ffd289f6b3e1dce15c00d5b1d3c2f815e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88234 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-02-05Related: tdf#130143 freeze/thaw around bulk insertCaolán McNamara1-0/+8
Change-Id: Iedb1229b56b5e7f1af1779b830cf324bcc8735e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87864 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-04Revert "Add ODF 1.3 strings to Save options page"Michael Stahl1-14/+1
This reverts commit ef39938dea14666a5835b6ae85091c1010f8ae8d. Reason for revert: Nasty side effects if the user actually selects the new values because the dialog code isn't adapted, see https://gerrit.libreoffice.org/c/core/+/87900 Change-Id: Ie220974dcf58b23401b21e5fa43e7d2f5d7978ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87901 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2020-02-04Resolves: tdf#130364 let font treeview fit to available dialog spaceCaolán McNamara3-74/+95
Change-Id: Ia000f4cfa041733fc84b45c955e69251c3ce9bcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 49d8e5fb744534f4af7e5c7f08dee7a95bcc6ed5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87946 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-03Resolves: tdf#130061 numbering dialog adjustments missingCaolán McNamara1-0/+38
since... commit e82b10f21cb8b77f815be3bd7654e0de7e8ceab5 Date: Sun Oct 20 00:44:05 2019 +0200 tdf#128257 Bullet Dialog update so spinbuttons were disabled Change-Id: Id8d54bd6ba359447943832920fce5e0da271f405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87879 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-29Resolves: tdf#130164 background/border dialog should be modalCaolán McNamara1-1/+5
Change-Id: I763cc054b23d4f72e1dec175861f3062d6bda6fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87346 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-28tdf#127112 repair "sticky" levels in Customize numbering style dialogSeth Chaiklin2-5/+27
Change-Id: Ifa841e7b63b28d6e0f84f5cd6b1800481b36425b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87645 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-27Resolves: tdf#130143 crash in sorted font replacement tableCaolán McNamara2-23/+19
it was always sorted historically, just without showing the sort indicator. Fix that inconsistency which led to the error causing the crash, and use iterators when appending to the sorted list instead of indexes which is the crashing part. Change-Id: I4ea3028a334129bdeb8e1a1aa79f4ead8a0243e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87344 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-18gallery theme dialog should be modalCaolán McNamara1-0/+1
Change-Id: I3c32851cda40254c73b0040f92466eedb7427d6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87028 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-12Resolves: tdf#129904 use the current page as the page for helpCaolán McNamara2-0/+18
in the options dialog which has a non-standard organization for its contents vs an ordinary dialog Change-Id: I6a50652f5ae3fe2e8b4d32933bec6dc0217cbec1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86577 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-11Resolves: tdf#127417 delete-all tabs doesn't workCaolán McNamara1-1/+1
since... commit 1e2682235cded9a7cd90e55f0bfc60a1285e9a46 Date: Thu Apr 18 19:25:06 2019 +0200 WIP: Further preparations for deeper Item changes because since then aNewTabs is cloned, but on delete-all aNewTabs is reset to a SvxTabStopItem with a 0 WhichId so its clones are useless Change-Id: I725bec90d8915b3546afeed590f21ebdbbdaa355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86579 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-08Resolves tdf#129622 - Layout problem in Options-LibreOffice-ViewHeiko Tietze1-7/+3
horizontal fill set for the questionable controls Change-Id: Iab194709ec3ad4881ace36a605ebb4a0d37fe8a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86275 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit beed7183ac6323eb052e7c586d6a807fcb32eb1f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86427
2020-01-08Fix SfxPoolItem use-after-freeStephan Bergmann1-6/+6
...as observed with -fsanitize=address in Draw, after drawing some rectangle (so that there is at least one marked object) doing "Format - Area... - Area - Bitmap": > ERROR: AddressSanitizer: heap-use-after-free on address 0x6030004aca50 at pc 0x7f14d0ef5fe1 bp 0x7ffd966c6cb0 sp 0x7ffd966c6ca8 > READ of size 4 at 0x6030004aca50 thread T0 > #0 in CntUInt32Item::GetValue() const at include/svl/cintitem.hxx:163:42 > #1 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:278:124 > #2 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21 > #3 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9 > #4 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5 > #5 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1 > #6 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45 > #7 in weld::ToggleButton::signal_toggled() at include/vcl/weld.hxx:1130:42 [...] > 0x6030004aca50 is located 16 bytes inside of 24-byte region [0x6030004aca40,0x6030004aca58) > freed by thread T0 here: > #0 in operator delete(void*, unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:172:3 > #1 in SfxUInt32Item::~SfxUInt32Item() at include/svl/intitem.hxx:113:21 > #2 in SfxItemPool::Remove(SfxPoolItem const&) at svl/source/items/itempool.cxx:710:13 > #3 in SfxItemSet::~SfxItemSet() at svl/source/items/itemset.cxx:252:42 > #4 in SvxBitmapTabPage::Reset(SfxItemSet const*) at cui/source/tabpages/tpbitmap.cxx:276:9 > #5 in SvxAreaTabPage::CreatePage(int, SfxTabPage*) at cui/source/tabpages/tparea.cxx:448:21 > #6 in SvxAreaTabPage::SelectFillType(weld::ToggleButton&, SfxItemSet const*) at cui/source/tabpages/tparea.cxx:381:9 > #7 in SvxAreaTabPage::SelectFillTypeHdl_Impl(weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:364:5 > #8 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, weld::ToggleButton&) at cui/source/tabpages/tparea.cxx:358:1 > #9 in Link<weld::ToggleButton&, void>::Call(weld::ToggleButton&) const at include/tools/link.hxx:111:45 This appears to be broken ever since d543d66a4ee34d3b0088f45951b56c150f7206ec "tdf#104615: there's no mpView when opening odc directly". Change-Id: Id0b3991f3e953ca5b10f466daab890383b0428ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86368 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 4d59436258702251a881a007ccc52ffd5a3eeb38) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86423 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-08Bump copyright year to 2020Adolfo Jayme Barrientos1-1/+1
Change-Id: I6fb736591f32907c8977fbac8fbf1dcbaef1bb97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86092 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit a526e85a0d6371781482a9b7de4e05b8b2578de2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86093 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-01-07halign 'Start'->'start'Caolán McNamara1-3/+3
Change-Id: Ia8547ffd08cc60ec8e6f791fcccaab35784de9aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86333 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-02missing previews in line comboboxesCaolán McNamara3-0/+15
since... commit 6cdc0dbfadfcbfa4f53a3c21a494ab225ba5d955 Date: Tue Nov 5 01:53:23 2019 +0100 linetab dialog page update and similar Change-Id: Iafb2933434d76472bab7297962e0803a6568e61b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86077 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-17Fix macro security UI usability problemsJan-Marek Glogowski1-14/+0
* Don't hide the option dialogs "Macro security" push button. I don't see any reason, why these settings should be hidden, if macros are disabled or settings locked. At least a user can now check, what is going on (still nothing shows disabled macros for a document in the UI AFAIK). * Don't scale the lock icons of the trusted list boxes. This just uses the same alignments, which the macro security level lock image uses, otherwise the image is scaled to fit the whole space of its layout cell. * Don't disable the trusted list boxes. If the setting is locked, it's sufficient to disable all the buttons, which allow modification (so View can stay enabled). This way you can still scroll the list. Correct button handling is already implemented and works for me. * Catch exceptions of broken certificate data. If your config contains certificates, which can't be correctly decoded, the NSS backend will throw an exception, which kills the dialog, but not the nested loop, resulting in a locked LO. Also show an error dialog with the broken base64-encoded data. Change-Id: I79002e0ce85cf9a9017caf858407f2f635a3a074 Reviewed-on: https://gerrit.libreoffice.org/85056 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit b3348ce498b3d54b3e5e6518954ad9d5e917b8f2) Reviewed-on: https://gerrit.libreoffice.org/85282
2019-12-17ui: show wait mouse pointer on operations in Expert ConfigurationVasily Melenchuk2-1/+8
Expert Configuration is loading, resetting and searching values very slowly, so will be great to indicate busy status to user. Change-Id: Ic0d428d01a9f71ff899979162e1b307cd7cd7401 Reviewed-on: https://gerrit.libreoffice.org/85242 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 99783d0edc2405f351322dfa2479c7fb36527878) Reviewed-on: https://gerrit.libreoffice.org/85272
2019-12-16tdf#127294 replace one section tip of the day with 4 new section tipsSeth Chaiklin1-2/+5
Also adjusted wording on another section tip. Change-Id: I8e24656f2cbf86a5da3bc2b8e204b2bc8d29b33c Reviewed-on: https://gerrit.libreoffice.org/84965 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 6c844f9bbc76f615d9a49526670538f045d82e0b) Reviewed-on: https://gerrit.libreoffice.org/85216 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2019-12-14size group is ignoring hidden widgets, leading to labels overlapping entriesCaolán McNamara3-0/+13
https://developer.gnome.org/gtk3/stable/GtkSizeGroup.html#gtk-size-group-set-ignore-hidden "Measuring the size of hidden widgets ... they will report a size of 0 nowadays, and thus, their size will not affect the other size group members" Which is unfortunate. So before we hide any labels, take the size group width and set it as explicit preferred size. Change-Id: If7c0f1ebd9f03914c74fde85b876549de76853c2 Reviewed-on: https://gerrit.libreoffice.org/85098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-12tdf#127294 one new tip of the day; clarification of three existing tipsSeth Chaiklin1-3/+4
1. It seems that inserting images in shapes only works in Writer, so added correction to make this tip Writer-specific. 2. Added a tip about how to insert images and photos to shapes in Draw and Impress. 3. Small wording adjustment in two other tips Change-Id: Ife6d7164af294803ca0ec50487b1e2d7b6a9d75a Reviewed-on: https://gerrit.libreoffice.org/84830 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit d115fabdc6927bfcc48e7e7be5bad546c66b11ad) Reviewed-on: https://gerrit.libreoffice.org/84958 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2019-12-11tdf#129300 If it would create no change, don't force itCaolán McNamara1-0/+5
otherwise a bogus "change" from the parent style is shown in the organizer this dates to... commit 755ad6834625488c5d31d4bacc9370eae7ffd8f3 Date: Tue Oct 5 11:15:56 2010 -0400 Ported calc-distributed-cell-text-*.diff from ooo-build. Change-Id: I49fc654a232d3c0f43f8add9a9f9fee34a6c5add Reviewed-on: https://gerrit.libreoffice.org/84895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-10tdf#127294 five new tips Seth Chaiklin1-0/+5
including one from comment #20 and one from comment #34 Change-Id: I7d3ded6d986a548d7a9c88f0036e734b4b5ccb87 Reviewed-on: https://gerrit.libreoffice.org/84604 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 55204db25234e22ea00d9bef2fc1a062e942e84d) Reviewed-on: https://gerrit.libreoffice.org/84804
2019-12-09Resolves: tdf#129243 check return to see if results validCaolán McNamara1-2/+4
Change-Id: Ia4169cda3c1a596ceedd074dd0e59898f9c72ff9 Reviewed-on: https://gerrit.libreoffice.org/84696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-07tdf#127305 display selected text in URL field QR Code Dialogshubham goyal1-0/+8
Change-Id: Ic0d36225cc2c509c706a4599d45b92c6b9fea40e Reviewed-on: https://gerrit.libreoffice.org/78879 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 704a558b8689beb1a83a3e2d21481e0ea118e134) Reviewed-on: https://gerrit.libreoffice.org/84613 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-12-07Resolves: tdf#128923 should be able to change attributes of multiple lines...Caolán McNamara1-0/+1
without changing color Change-Id: I76cf21af4611afc11bf1861abe7d0b903362e798 Reviewed-on: https://gerrit.libreoffice.org/84638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-07tdf#121658 Add option to not hyphenate words in CAPSSamuel Mehrbrodt3-6/+36
* Add checkbox to pagraph dialog * Store property in paragraph model * Move docx import/export from grabbag to paragraph model * Add ODF import/export * Add ODF unit test * Add layout test Change-Id: Id4e7c5a0ad145c042f862995d227c31ae2aa0abd Reviewed-on: https://gerrit.libreoffice.org/83979 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 72bd0df107ee47c4d54fa88b4960d32ea03e9f69) Reviewed-on: https://gerrit.libreoffice.org/84620
2019-12-06tdf#128712 clarification and addition of Draw tipsSeth Chaiklin1-1/+4
Split one tip into two different tips. Added two more Draw tips Change-Id: Idbb9b5ba0c136a8cb110eb8b7ed8f8d2855c9221 Reviewed-on: https://gerrit.libreoffice.org/84161 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 6e70a98b15c97ad2a3714aae5a5bfa22d307f236) Reviewed-on: https://gerrit.libreoffice.org/84594 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2019-12-03tdf#129134 ApplicationColors Scrolled List moves too littleCaolán McNamara1-3/+14
Change-Id: I5cb6ac017f1d2a916297676724d523634afb2020 Reviewed-on: https://gerrit.libreoffice.org/84254 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-03tdf#128924 VBA Properties Options remove 97/2000/XPandreas kainz1-8/+8
Change-Id: I52e0e132e752eb90bb50f292b0ee08cfa167a9c7 Reviewed-on: https://gerrit.libreoffice.org/84268 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-12-02Fix regex in tip of the dayIlmari Lauhakangas1-1/+1
Change-Id: Ib4e3cd80c0103fe3cf63cf7849805725a8a5ec63 Reviewed-on: https://gerrit.libreoffice.org/84053 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit a3d353e0b645fe177e24c6c93d29191cd7162633) Reviewed-on: https://gerrit.libreoffice.org/84201 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2019-12-01Resolves: tdf#129119 no SfxViewFrame in startcenterCaolán McNamara1-2/+5
Change-Id: I16d8207314146df3dd7f5b11182650066cc97fde Reviewed-on: https://gerrit.libreoffice.org/84149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-01tdf#127294 correct tip about removing multiple hyperlinksSeth Chaiklin1-1/+1
Change-Id: I40c23170ebb0b7fc9386efc1983eacef79a37f37 Reviewed-on: https://gerrit.libreoffice.org/83648 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 39d0fe2dda13b57c39cd96945df52b3b51b9c214) Reviewed-on: https://gerrit.libreoffice.org/84143
2019-11-30tdf#127294 add tip about removing multiple hyperlinksSeth Chaiklin1-0/+1
Change-Id: I465d459dce8bd279cb3052d4563340efc3092ec7 Reviewed-on: https://gerrit.libreoffice.org/82691 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit e95f32217b074e320d79bb6c35b445099b998cf0) Reviewed-on: https://gerrit.libreoffice.org/84065
2019-11-29simplification of existing tipSeth Chaiklin1-1/+1
Change-Id: I2936b64a3543f8b88fb7a44bd60871d4ec22f45c Reviewed-on: https://gerrit.libreoffice.org/82622 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit cc5483c3a3657b1b3c249d1ab039feda4bc50cfe) Reviewed-on: https://gerrit.libreoffice.org/84042
2019-11-28tdf#126043 use another bulk_insert_for_eachCaolán McNamara4-42/+65
Change-Id: I05c3fc6e708d000ba955981dbd8d11371ea99da2 Reviewed-on: https://gerrit.libreoffice.org/83686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 05734503ed36cff64cfaac8afb7c6df5eced8873) Reviewed-on: https://gerrit.libreoffice.org/83983
2019-11-28tdf#126043 use bulk_insert_for_eachCaolán McNamara2-30/+26
Change-Id: I68b5a7805a2e0a76d1871448a011fdde7f7cdb1e Reviewed-on: https://gerrit.libreoffice.org/83685 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9b6b134b3e605236e90aca089867f08d659a6076) Reviewed-on: https://gerrit.libreoffice.org/83967
2019-11-28tdf#126043 load the xml just onceCaolán McNamara2-14/+17
Change-Id: I98cfeeeddf2fb2d86259a11368bf3db752f5e556 Reviewed-on: https://gerrit.libreoffice.org/83656 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7c949066e6aae6ffe3b88d6500e70cdb7cc03b69) Reviewed-on: https://gerrit.libreoffice.org/83902
2019-11-27tdf#43021 WIN opt-out of OS recent folder usageJan-Marek Glogowski1-8/+0
The Microsoft documentation for SetFolder explicitly mentiones "In general, we do not recommended the use of this method. [...] SetDefaultFolder is the better method." If SetDefaultFolder is used the recently-used folder overwrites the value passed to SetDefaultFolder, which is shared between all file pickers. With this patch we rely on the LO internal mechanism to show the last used directory in the file picker. Regina's workaround basically does the same, as it just sets oRegistryKeyContent.WorkPathChanged, which triggers the internal path to use SetFolder instead of SetDefaultFolder. If you're wondering about the GetFolder() handling, the MS API docs have this: "Gets either the folder currently selected in the dialog, or, if the dialog is not currently displayed, the folder that is to be selected when the dialog is opened." So the call to GetFolder(), after the dialog is closed, returns the folder set by the SetFolder call, not the folder selected by the user, in case of the save dialog at least. Change-Id: Ia24f47848501df82727bfb2a99db723468bfe5b1 Reviewed-on: https://gerrit.libreoffice.org/83409 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit ffa636ba74b04b3258ec9a696bc4eac33581fa24) Reviewed-on: https://gerrit.libreoffice.org/83839 Tested-by: Jenkins
2019-11-27Resolves: tdf#128979 crash/freeze on selecting last theme in listCaolán McNamara1-11/+3
Change-Id: Ie47feb34cfbd6af0788a679ca2b5985ad6f9cbbf Reviewed-on: https://gerrit.libreoffice.org/83928 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-27tdf#126043 don't bother converting to OUStringCaolán McNamara1-3/+3
Change-Id: I179354659e4ee118138b994c7848c1dda39317bb Reviewed-on: https://gerrit.libreoffice.org/83678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f54a8c6aafac53902b144f5125665644e9a50497) Reviewed-on: https://gerrit.libreoffice.org/83865
2019-11-27tdf#126043 module identifier already knownCaolán McNamara2-4/+2
Change-Id: I710180ed125bbea250694cfb5f7d12cb1b07f782 Reviewed-on: https://gerrit.libreoffice.org/83675 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 380b322b986720f155edac62b70b0d7aa40c16b7) Reviewed-on: https://gerrit.libreoffice.org/83866 Tested-by: Jenkins
2019-11-27tdf#126043 freeze/thaw around bulk insertCaolán McNamara1-0/+6
Change-Id: I2dd9aedc305a4fe1992fe8c52fee85ade8589a5b Reviewed-on: https://gerrit.libreoffice.org/83674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 300ffc649aaa555bba19a0475d74067c9574fc04) Reviewed-on: https://gerrit.libreoffice.org/83833
2019-11-27tdf#126043 identify the frame module just onceCaolán McNamara2-11/+11
Change-Id: I7f68cf67838bb08672975e7a38cf213022e39ed8 Reviewed-on: https://gerrit.libreoffice.org/83672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6e6233a5d0940e5bbdb346142091b0ae2e54e640) Reviewed-on: https://gerrit.libreoffice.org/83832
2019-11-27tdf#126043 drop intermediate OUStringCaolán McNamara1-4/+2
Change-Id: I96906737bfe0f40b8a4c0b2f88dde7cc40daeab0 Reviewed-on: https://gerrit.libreoffice.org/83677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit df701c92f3f8071d1dd6df70898c33d99e905e7e) Reviewed-on: https://gerrit.libreoffice.org/83834
2019-11-26use a better conversion to OUStringCaolán McNamara1-6/+1
Change-Id: I4a133c054700f72770380214cc794a691edac54e Reviewed-on: https://gerrit.libreoffice.org/83741 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 use CommandInfoProvider::GetModuleIdentifierCaolán McNamara1-11/+1
which probably already has a cached ModuleManager Change-Id: Id653e57ecf40061ace086881344a85d7413a5afc Reviewed-on: https://gerrit.libreoffice.org/83671 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9426162a3b24732167e4fa7aa2fa6ee19d33e7e9) Reviewed-on: https://gerrit.libreoffice.org/83788
2019-11-26tdf#126043 fetch the command properties just onceCaolán McNamara2-6/+10
Change-Id: Iaf343e9858be36ca8772d9c12eee772d93b4c394 Reviewed-on: https://gerrit.libreoffice.org/83668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/83763
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 06:26:21 +0000