summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2021-06-10tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)1-7/+3
In this case, avoid single, re-used local variable. It gets newly processed at locations used anyways. Change-Id: I89463736cbc28925adc304adb4624ab2740bdfbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116936 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-09tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)1-6/+6
See task, slowly trying to reduce usages of that flag Change-Id: I50dc8e21e2f5e82e21bf335d63d07cee1ee18d01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116913 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2021-06-08tdf#109388: Mouseover effect added to palettes in the Area tabBayram Çiçek5-2/+12
In 'Format > Page Style... > Area' Tab, Mouseover effect added to the palettes on Color, Gradient, Bitmap, Pattern and Hatch sections. Change-Id: Idf036adc01b6b2ef6d62d2dd670ed6fb432bfbf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116395 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-06-08Simplify Sequences initializations (cui)Julien Nabet2-7/+5
Change-Id: Iaf6a27f3a8dd156e91751a2fe242e8388f8d6b6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116829 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-08Addendum to: Remove SfxItemState::READONLYArmin Le Grand (Allotropia)2-15/+0
unfortunately forgot to remove some of the out-commented lines in f3b737ab76efaf1a70dfb22c6b60b08b340cf343, thanks to Julien for hinting me to that. So this is no semantic change at all, just syntax. Change-Id: If45b0cf1aeed870723914c2c02f6060d8f1bbfb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116838 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-08editengine-columns: Create document model and dialog pageMike Kaganski8-0/+290
Change-Id: I056aad9474ca18134d1f1686a53618cc9ab3d525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116038 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-08Remove SfxItemState::READONLYArmin Le Grand2-17/+17
As I experimented with redesigning the whole Item/ItemSet/ItemPool paradigm, I alredy checked that SfxItemState::READONLY is not used (and no one really knows what it should do or stands for). Since a removal of complexity is needed to get forward with that redesign and I already made some experiences in branch item_refactor2, I propose to remove this state. It is not really used (gets never set). It is mirrored/used in the UNO API in css::frame::status::ItemState as 'READ_ONLY', but also not used in the office's code. ItenmState itself is used in three places, but all set the Item involved by using a SfxVoidItem to state SfxItemState::DISABLED, which I described in ItemState.idl. This means that no state of READ_ONLY in UNO API is ever imported to office code as DISABLED state at all, so not used. I also marked it as deprecated in the *.idl file. I think - including the experimenting in the mentioned branch - that this is safe for now. I already run a full 'make check' on the changed stuff. Change-Id: I8c15cf7b4f803076ecaaea67659f6e022ac7ef70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-06enforce indicator consistencyCaolán McNamara1-0/+1
so there is either a standard indicator shown or one of a small subset of named icons a) adds an indicator to show the MenuButton provides a dropdown to the spelling dialog when there are multiple user dictionaries the word could be added to b) use open-menu-symbolic instead of gear icon for the sidebar menu Change-Id: If4f0842fb0f805dde45e375061f23d2aaea0990c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-06use open-menu-symbolic where sfx2/res/menu.png was previously usedCaolán McNamara1-1/+1
Change-Id: I5030afe7d370b49b24f6a590bf9ce6e2a7a428e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-06use open-menu-symbolic for menubutton gear menusCaolán McNamara1-2/+2
https: //wiki.gnome.org/Initiatives/GnomeGoals/GearIcons Change-Id: Ia95451f950728c4174887a042a6666e1dd7cc1ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03no need to allocate these on the heapNoel Grandin3-19/+19
Change-Id: Ic4b16e776a731e5e9bea61e99acb7257c5220322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-02only one of the group should be activeCaolán McNamara2-5/+1
Change-Id: Ibbd8d5e3a1ca78c632997e1372eb0c88ff0cd954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02resave with latest gladeCaolán McNamara2-168/+162
Change-Id: Ia623b9bd51aad6772f3c109eb22e8388c5ca1cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-02tdf#115282 Add KEY_QUOTELEFT entries to the Shortcut keys listGabor Kelemen1-0/+8
Change-Id: Id9667a8191c3ccaaad5b1a2f72f0a1f57721bec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116563 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-06-02tdf#116491: Customize: Add indication for experimental commandsMuhammet Kara2-1/+10
Change-Id: Id485f86598aa89cbce6d742c0207c178e5208ee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116014 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-05-31GtkLabel:track-visited-links was removedCaolán McNamara2-2/+0
but we have some uses of it, which all look accidental Change-Id: Iccb12d904e8dc7410205735e49526b73bb81083e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31no need for always-show-image if there is just an image and no textCaolán McNamara4-8/+0
and reenable hyperlink dialog for gtk4 Change-Id: Id7e487dd64e102af80bb90279682a0636b887f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31no need to allocate SvxNumRule separately in SvxNumBulletItemNoel Grandin1-12/+12
Change-Id: I7903565a468fc0fbec603c88b92cca6560a86728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31no-zxing: Unused GenerateQRCode functionJan-Marek Glogowski1-10/+4
... and while at it fix (new?) [loplugin:stringviewparam]. Change-Id: I4b991e58040df8082e141ba3c7a0d1968871d517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116436 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-31Clean redundant SvxBackgroundColorItem and use SvxColorItem instead.Gülşah Köse2-6/+6
SvxBackgroundColorItem is just copied from SvxColorItem. There is nothing special to SvxBackgroundColorItem class. SvxColorItem is a generic item and it's used on many places related with colors. We can use SvxColorItem for background colors too. Change-Id: Iacea31a7557b806e95f5859ff60add9a2626ec05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116282 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins
2021-05-30Drop GtkSalPrinter bits from option dialogJan-Marek Glogowski3-57/+0
After commit ed07ec7606cb24cccaf6b7b81b2bd308debaa2e6 ("drop never completed GtkSalPrinter"), there is still the experimental option left, depending on ENABLE_GTK3. We can't drop the whole PrinterCapType::ExternalDialog, because the osx code actually uses it. Change-Id: Ibc4654d8c1ce1de7ee1c9dc7700bb8775af2f678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116408 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-30tdf#136292: Fix crash on invalid JSON from the extensions APIMuhammet Kara1-1/+10
Change-Id: I91ed555f93173dee10e87025b231560693be50b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116390 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-05-28image-position set, but there are no images for this buttonCaolán McNamara1-2/+0
Change-Id: Ida66830d992d4b779994b745def0c380d02263da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116343 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-28no need to allocate these SfxItemSet on the heapNoel Grandin1-5/+5
use std::optional where the code needs to control the lifetime of the object explicitly Change-Id: Ia550ce051360f68911abc68c945a97d62a637b06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116291 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix leak in SvxConfigPageNoel Grandin1-0/+6
Change-Id: I6b95d33cfbad455692c8047968a2581fe4610260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix leak in SvxLineTabDialogNoel Grandin2-7/+7
Change-Id: I4cbf0990fcc8db63f1160f1997d425c5681c47c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116150 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26add privacy URL to crashreport dialog & updatecheck tab in optionsChristian Lohmaier3-0/+23
Change-Id: I35cda87c35876469bf581be223bc608e29f07b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116105 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-05-23tdf#116491: Customize: Hide experimental commands when not in experimental modeMuhammet Kara1-3/+11
Change-Id: Ibc88e9c90b261b5294fab8041e0b530016f45f33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116006 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-05-21Don't upcast only to downcast immediatelyMike Kaganski1-5/+5
Change-Id: I6d331708c281851f28e9800b7deeaee634310c21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115848 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara95-275/+275
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21move hangul/hanja previews outside radiobuttonsCaolán McNamara2-94/+215
not possible in gtk4 to put an image in here anymore AFAICS, this was always an odd case anyway Change-Id: I0525720f53046bf8d234e4beb85096c90235ea10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115920 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21resave in latest gladeCaolán McNamara1-155/+152
Change-Id: I8c734b808b9b62cffa5b18455672c8f7b183f45d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21we want the max width here, not the sum of widthsCaolán McNamara1-1/+1
Change-Id: Ie17c062a3e031b85a5784176895c08c9a1638bea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115918 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara2-12/+9
Change-Id: I4f91a6f0fb1628a8907848d9d8dffd92d382ecaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115865 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for CheckButtonCaolán McNamara4-9/+9
Change-Id: I6a80946481ee6fc40b2ee207a64287d1a5f96110 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115864 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara4-12/+12
Change-Id: I2a01d78e2e98b35d2cd24dd7d7d2efda41e35ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara2-5/+7
Change-Id: Ib256324f9d14cc2473e62ec4ffe0a18431e2c9cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara4-21/+27
Change-Id: Ice24a1b823301834a6bf7d7956df2e804657f6e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115855 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara2-6/+7
doesn't seem sensible to listen to the prop checkbox in this handler Change-Id: If514b5a9072e789b6b2cbfc990714e236335d99c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for CheckButtonCaolán McNamara26-66/+72
Change-Id: I73ffd66a6e5eed1f95882e874d9319ecad5550f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115853 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara2-25/+31
Change-Id: I8de3daf3799a78c63be2c560afa4a7cc02d63daa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19use toggle instead of click for RadioButtonCaolán McNamara4-6/+6
only listen for one toggle for the button grouping Change-Id: I0c1866c25793ffce50bcf5f5a07fcdc98f64aacc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19use toggle instead of click for RadioButtonCaolán McNamara2-4/+3
only listen for one toggle for the button grouping Change-Id: I937331aebc2391e4026f69f16f9c7c9216981d0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115817 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19tdf#142317 chardlg UI: show approx auto-esc % based on EscPropJustin Luth1-2/+2
Subscripts and Superscripts normally have "automatic" enabled. The value shown (in the greyed out raised/lowered by field) was showing 8%. Well, that value is true only for default nProp of 58%. If nProp is a non-default value, it is better to show (an approximation) of the actual percentage that is used to raise/lower the character. [Note: this only affects the initial view when the dialog is first opened. After any changes, it will show the value in the saved user settings.] Change-Id: Ife26e0c4f99a41e7568591f0a60cc7068dc3fd90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115739 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-05-19ImplPlayWithRenderer never checks its OutputDevice against nullptrCaolán McNamara4-9/+9
just pass a reference instead and spread that around to some similar cases Change-Id: Ifb2dee8c7bf02a9f01982b928c90666cbbdd84fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115759 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-18tdf#112369 allow to disable the add command button in menu customizebaltasarq3-25/+71
Instead of showing an alert dialog reporting that a command is already present in a given menu, enable or disable the add command button when needed. Change-Id: I52b9477896d4775ae2033c057fa1b5bfccb6a749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115057 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-05-18tdf#127533 Make Tip-of-the-Day dialog non-modal and allow multiple tips to openMatt K5-4/+63
The Tip-of-the-Day dialog is made non-modal and stays on-top of the main window while allowing the user to interact with the rest of application. Change-Id: I51e1a3488ab74d8371b71a8585d1512ce051f637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113782 Reviewed-by: Matt K <mattkse@gmail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-05-17gtk4: reenable buttonCaolán McNamara3-3/+3
rename label_line_wrap to label_wrap while I'm at it Change-Id: I3964c4b40d86fb6ef1fd3733088ffd80e57415ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115714 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-17tdf#142303 connect adjustments to spinbuttonsCaolán McNamara1-6/+9
missing since commit 87e21946fa9a81c403a146d03579691537c1352c Date: Sat Aug 17 20:41:26 2013 -0300 Convert text animations tab page to widget UI Change-Id: I8eba96030a1f5060ba60166d462130eb2cef1298 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-14gtk4: advertise as gtk4 not gtk3Caolán McNamara1-1/+1
Change-Id: I7f38238109f79cc8b87d41999a8355879761a894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-18 08:35:58 +0000