summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2018-10-14drop now unused orienthelperCaolán McNamara1-1/+0
Change-Id: I6a33104002ecb304a65e930320595a082049faa9 Reviewed-on: https://gerrit.libreoffice.org/61750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12tdf#120506: Get rid of unnecessary accentcolor parsing for personasMuhammet Kara2-19/+8
Change-Id: I64534fd3d7de90debb9e49e8c636c5fbfac787bf Reviewed-on: https://gerrit.libreoffice.org/61668 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-11Resolves: tdf#120503 fix border paddingCaolán McNamara2-22/+38
a) SetFirst doesn't imply SetMin b) ModifyFlag and SaveValue are orthogonal Change-Id: Ibe637ec5d33af030af068fcf8690191a775a6460 Reviewed-on: https://gerrit.libreoffice.org/61670 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-10weld FmShowColsDialogCaolán McNamara5-52/+84
Change-Id: I31f3a787e6f835f576c02b5831508fa78340bf22 Reviewed-on: https://gerrit.libreoffice.org/61629 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-10optimize adding a block of entries at one timeCaolán McNamara4-14/+14
Change-Id: I9a59154fa445cf3c44ede3ceb1d09f408d906530 Reviewed-on: https://gerrit.libreoffice.org/61618 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-10font lists come presortedCaolán McNamara1-1/+0
Change-Id: I0559ed99971bd83d9d09321a12ce64e7bbd1f339 Reviewed-on: https://gerrit.libreoffice.org/61608 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-10tdf#99776: Preload a persona category initiallyMuhammet Kara2-0/+8
Change-Id: Ib47470fed9251611cce043790cb2c1255495524a Reviewed-on: https://gerrit.libreoffice.org/61609 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-09tdf#101629: Handle invalid urls and search strings for PersonasMuhammet Kara2-0/+22
Change-Id: I9666aa9f323e53ef394121acdef146866d2cc696 Reviewed-on: https://gerrit.libreoffice.org/61529 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann4-5/+5
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-09loplugin:unusedmethodsNoel Grandin4-124/+0
Change-Id: Icd7a0f9909f36363b307b4fe7ee920183881afbb Reviewed-on: https://gerrit.libreoffice.org/61576 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:unusedfieldsNoel Grandin1-6/+0
Change-Id: Iacce8e12a85f857192dc0520b795e1990a3612db Reviewed-on: https://gerrit.libreoffice.org/61575 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09use unique_ptr in SfxUndoManager::AddUndoActionNoel Grandin3-29/+27
Change-Id: I11483e3cece12a7373f4276972b4c899edf1ce15 Reviewed-on: https://gerrit.libreoffice.org/61566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09Resolves: tdf#120370 should check gradientgrid sensitivityCaolán McNamara1-1/+1
rather than whether listbox first entry is not selected Change-Id: Ic3dc574f6f1a476929e89e695849756437024cee Reviewed-on: https://gerrit.libreoffice.org/61559 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09tdf#111718 Fix interaction between bitmap and pattern settingsJim Raykowski2-14/+33
Change-Id: I1c68b9f1f51cb15a30f56eef08dc384d10355bf1 Reviewed-on: https://gerrit.libreoffice.org/58805 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-10-08tdf#120363: try to avoid asking user to enable JVM when looking ...Mike Kaganski1-32/+2
... for a provider for an operation. When another provider actually handles an operation, it's useless to ask user to enable disabled JVM just to learn that it doesn't handle the request. So, this patch does the MasterScriptProvider operations in two steps: first with "Enable JVM" interaction disabled, and if failed, again with the interaction enabled to try disabled providers. This shouldn't typically give performance penalties in case when JVM is enabled, and when it's disabled and the operation is addressed to another provider. A context class designed to disable "Enable JVM" interaction is moved from cui/source/customize/cfgutil.cxx to a new comphelper header, which is supposed to hold similar helper context classes in needed. Change-Id: I21be922bfd80a276d9c8f1215d62a47bb3c225f5 Reviewed-on: https://gerrit.libreoffice.org/61468 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-08Try to manage without curl on non-desktop platforms (iOS, for me)Tor Lillqvist1-2/+4
We don't build curl for iOS. (Don't remember why exactly, but anyway, this persona thing is surely a feature relevant for desktop platforms only, and certainly not a good reason to start building curl.) Change-Id: Ia2acebe77a0acb9dbf5858e6524c444e772ac8c8 Reviewed-on: https://gerrit.libreoffice.org/61520 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-10-08Fix typoAndrea Gelmini1-1/+1
Change-Id: I204fb88d7c5e45efd97dc8e3f6e584b12fba879b Reviewed-on: https://gerrit.libreoffice.org/61521 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-08tdf#120362: Don't ask user to enable JVM when enumerating scriptsMike Kaganski1-0/+35
Since it wasn't an explicit user's intention to run something that requires JVM, asking to enable it in case it's disabled is nonsense, and it happened every first time in a LO session when user wanted to start e.g. Basic macro using Tools->Macros->Run Macro... tool. Change-Id: I5afae804e183c185472d41a2d419ec80b7955110 Reviewed-on: https://gerrit.libreoffice.org/61465 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-08Modernize personas under-the-hood - The searchMuhammet Kara2-205/+345
* Upgrade the used mozilla API from v1.5 to v3 * Ditch Neon for curl * Get rid of the get-HTML-then-search-within craziness It is much faster and smarter now: * Fetches the search results at once in JSON format, instead of repetitively making http calls for each persona, and relying on an ever-changing HTML design * Doesn't redownload and overwrite files each time, so it is much faster for the second time of the same search query This patch handles the search part. A follow-up patch will handle the apply part. Change-Id: I703fc7b510799e8c205566cf5ffad2a81f12c4ea Reviewed-on: https://gerrit.libreoffice.org/61449 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-08tdf#119266: Nodes don't expand on double click in the Customize dialogMuhammet Kara1-1/+5
Change-Id: I8b6667dc631df2fd38a8a2d99668b4a2336801b6 Reviewed-on: https://gerrit.libreoffice.org/61504 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-07flatten some impls in SvxBackgroundTabPageNoel Grandin2-80/+63
having not one, but two separate impl classes and then a whole bunch of data members? Change-Id: Icd2d4017015d277b55770aea1495366401008ed9 Reviewed-on: https://gerrit.libreoffice.org/61443 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-07use std::unique_ptr in SvxBackgroundTable_Impl and SvxBackgroundPage_ImplNoel Grandin1-45/+23
Change-Id: I823e4ab434ac41865c8faf513769f7a985c199ea Reviewed-on: https://gerrit.libreoffice.org/61442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-06drop some now unnecessary includeCaolán McNamara9-38/+2
Change-Id: I9db3d9a172a41c70ed343efd76f4c7c8f88b3a3f Reviewed-on: https://gerrit.libreoffice.org/61471 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-06Resolves: tdf#120334 crash on ESC in position and sizeCaolán McNamara2-0/+11
Change-Id: I50421f01ca368ec4d074db4b0add2f08b7b3fc0d Reviewed-on: https://gerrit.libreoffice.org/61448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-05Resolves: tdf#120345 wrong text model column used for line GtkComboBoxCaolán McNamara3-0/+5
Change-Id: I6804fea72e105b118c8ef0228ca295ddfc0b1454 Reviewed-on: https://gerrit.libreoffice.org/61427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04Select the current format if multiple instead of first matching format codeEike Rathke1-1/+1
This never worked.. Change-Id: I79b8687dde4faac383121abeda70931d0192b33d Reviewed-on: https://gerrit.libreoffice.org/61290 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-04weld SbaSbAttrDlgCaolán McNamara1-0/+2
Change-Id: Ic1478d92fcf829bebdf8ada1051a4373d47077cf Reviewed-on: https://gerrit.libreoffice.org/61330 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Resolves: tdf#120265 assert on moving item via customization dialogCaolán McNamara1-1/+1
Change-Id: I435409a1e16ad138519fb31e873dcb4f500b3734 Reviewed-on: https://gerrit.libreoffice.org/61319 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Related: tdf#120277 inherit from SfxDialogControllerCaolán McNamara8-11/+10
where the dialog originally inherited from SfxModalDialog. Change-Id: Ibe0006de93b0a9f05fb3b6181baf3ba1b4cf04c8 Reviewed-on: https://gerrit.libreoffice.org/61313 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03Resolves: tdf#120277 special character dialog not appearing in OnlineCaolán McNamara2-2/+2
the magic smoke connecting the dialog to the viewshell was in SfxModalDialog, so not inheriting from that drops the connection add a SfxDialogController to enable setting up the connection Change-Id: I29c45cd43e05295309fc647b039db0c6565ca0d1 Reviewed-on: https://gerrit.libreoffice.org/61304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03use ScopedVclPtr hereCaolán McNamara1-2/+2
Change-Id: I5780dfbb751ad24d815ac6526b26d633768b6030 Reviewed-on: https://gerrit.libreoffice.org/61302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03make position and options level treeview match in sizeCaolán McNamara1-1/+0
Change-Id: I3e9216e95c845a319fc7315f80e926023ddd911b Reviewed-on: https://gerrit.libreoffice.org/61292 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: I9e583df920657ab401162db79decb192c4f69f90 Reviewed-on: https://gerrit.libreoffice.org/61283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03rename cui::NumberingPreview back to SvxNumberingPreviewCaolán McNamara2-10/+6
Change-Id: I5c8b9ac10babd0535fa55f490a5478f88fc76222 Reviewed-on: https://gerrit.libreoffice.org/61264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03weld SwSvxNumBulletTabDialogCaolán McNamara4-17/+41
Change-Id: I8ea74dc15bba04c0615e61c069407160a7b95c4c Reviewed-on: https://gerrit.libreoffice.org/61242 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03loplugin:unusedfieldsNoel Grandin2-3/+0
Change-Id: Idf6f7f2946eecada64d2a586194533840ec8cc63 Reviewed-on: https://gerrit.libreoffice.org/61248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-02weld SvxNumOptionsTabPageCaolán McNamara5-569/+430
Change-Id: Ie2ae18b1722e91996887162b4a8ff02d2d812341 Reviewed-on: https://gerrit.libreoffice.org/61228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02tdf#120055 line dialog notebook should be can-focusCaolán McNamara1-1/+1
Change-Id: I3993f726f433503173c27c68be40936bc03aaf6e Reviewed-on: https://gerrit.libreoffice.org/61227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02rename PresetListBox back to SvxPresetListBoxCaolán McNamara5-24/+24
Change-Id: If65c3a9b529d2173f9795c038c877d4e4423a883 Reviewed-on: https://gerrit.libreoffice.org/61217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02consistent 3.18 version require in .uisCaolán McNamara5-5/+5
Change-Id: I5102c218c969cf9302405e4146f92e187c1998ce Reviewed-on: https://gerrit.libreoffice.org/61215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02make all notebooks scrollable and enable_popupCaolán McNamara12-0/+21
Change-Id: I16a6d556ca4c6b3f876dc0c8380d01fe3022209e Reviewed-on: https://gerrit.libreoffice.org/61195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02weld SvxLineTabDialogCaolán McNamara12-101/+279
Change-Id: Icb13a6eb2e8c6f6dbd3cf477051bc0bd682e2e7a Reviewed-on: https://gerrit.libreoffice.org/61193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-01rename XLinePreview back to SvxXLinePreviewCaolán McNamara1-3/+3
Change-Id: I833c4ae6e2944b484bb32532c20f5ef09917e712 Reviewed-on: https://gerrit.libreoffice.org/61190 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-01weld SvxLineTabPageCaolán McNamara3-899/+825
Change-Id: I91d7ec8a51ce935db40c57feeeed7b160cf4dad8 Reviewed-on: https://gerrit.libreoffice.org/61172 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30weld SvxLineDefTabPageCaolán McNamara4-383/+332
Change-Id: I7a7f421190c89cec8e1a772015b7544d60b26298 Reviewed-on: https://gerrit.libreoffice.org/61158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30weld SvxLineEndDefTabPageCaolán McNamara4-193/+184
Change-Id: I3e947511bbffae4cd48388b17a8fb9a13d453bab Reviewed-on: https://gerrit.libreoffice.org/61139 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30rename XRectPreview back to SvxXRectPreviewCaolán McNamara1-8/+8
Change-Id: I5d684a651c075104cfb2f2bd73303a2e7f5a7fdd Reviewed-on: https://gerrit.libreoffice.org/61138 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30weld SwTestAccountSettingsDialogCaolán McNamara2-2/+2
Change-Id: Idead8d63dc472403e15eb9adf3cb82467e4d6721 Reviewed-on: https://gerrit.libreoffice.org/61106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-30Separate persona download threadMuhammet Kara2-163/+189
And do not re-download the already existing images Change-Id: I1b9c6b85aec6ffa448f56d4250317c3d6a50db1d Reviewed-on: https://gerrit.libreoffice.org/61148 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-09-29weld SvxJSearchOptionsDialogCaolán McNamara5-43/+34
Change-Id: I18f2ad69daff376c8f09c7bd1cbc8c1f9079f63e Reviewed-on: https://gerrit.libreoffice.org/61105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>