summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2018-08-08Resolves: tdf#118281 control positions always in cmCaolán McNamara1-0/+5
Change-Id: I7803f673e835bd4575616d4e4b465ca144e282c8 Reviewed-on: https://gerrit.libreoffice.org/58727 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-06tdf#117892 Blue Area/Background Bitmap tabpage Preview fixJim Raykowski1-0/+2
Change-Id: Iaef3651407d1df85b1cb221821d47c33e111016e Reviewed-on: https://gerrit.libreoffice.org/58206 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 10b865fc00a97e5ad0bf76cb9bad774933e25461) Reviewed-on: https://gerrit.libreoffice.org/58365 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-03tdf#118976 Make area pattern tab page display pattern previewJim Raykowski1-0/+2
Change-Id: If30b83ec93897b85784d66c699ece377f47f68d4 Reviewed-on: https://gerrit.libreoffice.org/58265 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 623cb7a1299386f8d8f7c53b0369a40cae51b752) Reviewed-on: https://gerrit.libreoffice.org/58366 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26tdf#118816 recover initial intent of enabled possibility of tristate as a flagCaolán McNamara2-14/+32
Change-Id: I0150b96e063818cc20e2404081b906ccc5ff0be6 Reviewed-on: https://gerrit.libreoffice.org/57712 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9f01dca60e6539f48cd529180f0d64c2131e0ea1) Reviewed-on: https://gerrit.libreoffice.org/57713 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-25tdf#118777 cui: use right XText in SignatureLineDialogMichael Stahl1-1/+3
Writer has multiple nested XText and we have to call insertTextContent on the one that corresponds to the xCursor, so use the convenient getText() instead of hard-coding the body text. Change-Id: I86bce48e97730917aa8c4b093bb74c03e3f0dd36 Reviewed-on: https://gerrit.libreoffice.org/57969 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 7213a583f5c1d42c05dc4f19b4d4d2f9dded7733) Reviewed-on: https://gerrit.libreoffice.org/57978 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-20tdf#118304 reselect current glyph on changing fontCaolán McNamara1-11/+11
preview glyph will rerender the glyph if its there, or the glyph description changes to "missing glyph" if its not there anymore. Don't auto select first entry of the subset when font changes, leave it as unselected and let the glyph determine what's ends up there Change-Id: I33d7dd3a071100175ac9bc7c7e9d44684a1aff28 Reviewed-on: https://gerrit.libreoffice.org/57724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e8bf2cb72dbe55f4e9ac7ace48e644a934cfc503) Reviewed-on: https://gerrit.libreoffice.org/57764 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-07-19tdf#117038 set button width to max possible content widthCaolán McNamara1-1/+9
Change-Id: I97e7c27523d213cb06cdf87a8ed0124d1ea8d5ba Reviewed-on: https://gerrit.libreoffice.org/57718 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19Resolves: tdf#118115 add missing help response idCaolán McNamara1-0/+1
Change-Id: Ie050285cc10d82cf80e560be3f1766c50dd1527c Reviewed-on: https://gerrit.libreoffice.org/57716 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-18Related: tdf#118681 use a case insensitive compare for hex digitsCaolán McNamara1-3/+3
Change-Id: I7b177d2772a86cada37c20056794bc1d8ab50991 Reviewed-on: https://gerrit.libreoffice.org/57565 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-17tdf#118549 crash on dialog teardownCaolán McNamara1-0/+2
only an issue for the current partially complete interim case Change-Id: Iaf1ef4dabca1cdd5d2d90028edf5793cf45feb20 Reviewed-on: https://gerrit.libreoffice.org/57502 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-17tdf#118681 make sure we're using the right font char mapCaolán McNamara1-6/+3
Change-Id: I64265dac5d0d18b092d64ef656997d7177a425a4 Reviewed-on: https://gerrit.libreoffice.org/57505 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-13SvTreeListBox::DoubleClickHdl: DbRegistrationOptionsPage more, tdf#115950 rel.Eike Rathke1-1/+3
Change-Id: I820ce28a4df108f17cbb65210834acae6b0f8946 (cherry picked from commit 1a5ef55b7de60131efa7a831309186b29cb6214e) Reviewed-on: https://gerrit.libreoffice.org/57355 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-07-06Writer: Insert signature line at current cursor positionSamuel Mehrbrodt1-4/+9
Reviewed-on: https://gerrit.libreoffice.org/57026 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 8905ae9f0fc8b0e4a95113fd81e88d4e7db57bcc) Change-Id: Ic7cbcd409372a2d8222f57e67e1109a74f6f5ce3 Reviewed-on: https://gerrit.libreoffice.org/57035 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-29tdf#118429 Provide unsigned signature imageSamuel Mehrbrodt1-0/+1
when creating signature line. OOXML Export expects this. Change-Id: Ib6ab1f879c5ef27e8347002576ba95104117cadd Reviewed-on: https://gerrit.libreoffice.org/56576 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit b80207f5ac67ff585ce10f741803df12d3a308a7) Reviewed-on: https://gerrit.libreoffice.org/56587 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-28tdf#117866 cui personalization: fix a possible raceMiklos Vajna1-0/+6
The case when the thread is re-scheduled exactly after checking for m_bExecute but before taking the solar mutex. (cherry picked from commit f4c73f90da2a2c31f0d29572180aa97e10c3dbad) Change-Id: I494c123a6225da60407391771622208c055ae49b Reviewed-on: https://gerrit.libreoffice.org/56593 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-27tdf#118309 freeze/thaw adding large amounts to ComboBoxTextCaolán McNamara1-1/+5
Change-Id: I3072630c769224be730e6ec16b1a02fa4f1b10e6 Reviewed-on: https://gerrit.libreoffice.org/56503 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-26tdf#109269 very slow loading of user-defined dictionary word listNoel Grandin1-8/+23
this is about 10x faster for me Reviewed-on: https://gerrit.libreoffice.org/56378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a07bb28d3199542c0b90884a947c2bac02bad07d) Change-Id: I1d308c78dbdd04beaa432b546ba3b89bd617d57e Reviewed-on: https://gerrit.libreoffice.org/56385 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-22use Application::GetFrameWeld to tunnel weld::Window through XWindowCaolán McNamara1-2/+1
Change-Id: I137afe61acfb71337a45bedbe539b0096080e6cc Reviewed-on: https://gerrit.libreoffice.org/56302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21move SvColorDialog to welded argumentsCaolán McNamara1-5/+5
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a Reviewed-on: https://gerrit.libreoffice.org/56174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20fix new a11y warningCaolán McNamara1-0/+2
Change-Id: I637c48335bb8e532bb8bad3b05e60fb1c06f6414 (cherry picked from commit 0929a98acca8ec4d86caa97d3090a39f89f35f90)
2018-06-20weld SvxColorTabPageCaolán McNamara3-396/+359
Change-Id: I5dc6f949edcb34aa110dfa9415e2ac886d0dfa4c Reviewed-on: https://gerrit.libreoffice.org/56155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18set explicit parent for signing warning messagesCaolán McNamara1-2/+2
Change-Id: Ifbd1aaec13e2f3a51963c4942face64847eefc07 Reviewed-on: https://gerrit.libreoffice.org/56027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-17weld SvxPageDescPageCaolán McNamara3-630/+485
Change-Id: I5e2457b51a294cbdacc5c78db4ec0a048567b93d Reviewed-on: https://gerrit.libreoffice.org/55952 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-15weld SvxStdParagraphTabPageCaolán McNamara3-387/+374
Change-Id: I02b0f2e4f049b407a3ac0c7f304cbcd0cc652749 Reviewed-on: https://gerrit.libreoffice.org/55827 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxParaAlignTabPageCaolán McNamara3-260/+204
Change-Id: I843b264d44266213e91b7e75bf35e4f6cf41dd88 Reviewed-on: https://gerrit.libreoffice.org/55809 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxExtParagraphTabPageCaolán McNamara3-398/+363
Change-Id: I6836bc659f28ebae35ed0ca33ffd9425212c3622 Reviewed-on: https://gerrit.libreoffice.org/55791 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxAsianTabPageCaolán McNamara2-56/+30
Change-Id: Ib1e229a9780dd0959ce847a2d4c15eab7fb92c33 Reviewed-on: https://gerrit.libreoffice.org/55781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxCharTwoLinesPageCaolán McNamara3-117/+153
Change-Id: I54a8963cd8b12f5fd51bf6b3bb791a4a15fbd13d Reviewed-on: https://gerrit.libreoffice.org/55766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-13weld SvxCharPositionPageCaolán McNamara3-282/+345
Change-Id: I2084702798e5b01eae5905dc54ad8413e6d5fae6 Reviewed-on: https://gerrit.libreoffice.org/55765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12weld SvxTransparenceTabPageCaolán McNamara3-269/+310
Change-Id: If8c8a6cf74664f9acd360d877c57e8dd9de2f2b5 Reviewed-on: https://gerrit.libreoffice.org/55694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-05tdf#117866 cui: avoid deadlock in personalization dialogMiklos Vajna2-4/+8
The deadlock happened as the main thread wanted to join SearchAndParseThread (while owning the solar mutex), but SearchAndParseThread wanted to take the solar mutex to import a graphic. Fix the deadlock by checking for the termination flag earlier, so we don't take any new mutexes if termination was requested already. (cherry picked from commit 766c85a4f67f5d50645340e31cebd5956998c6fc) Related: tdf#117866 cui: use std::atomic for thread termination flag (cherry picked from commit f4ac7b5a084a7cf483bb89a2fa411f9df70df4d0) Change-Id: Idddaadadc693610d9f31a14300b22aff8d452756 Reviewed-on: https://gerrit.libreoffice.org/55334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-04weld SwSectionFootnoteEndTabPageCaolán McNamara1-81/+0
Change-Id: Ib4246a2f90780a005e79e2d071b43a5629a3242c Reviewed-on: https://gerrit.libreoffice.org/55216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit cd08397eedbe347784a3ac569481a17a8391e7b2) Reviewed-on: https://gerrit.libreoffice.org/55236
2018-05-31Fix conditionSamuel Mehrbrodt1-1/+1
Change-Id: I977eae208bd12886d25679d4c75308d51245766a Reviewed-on: https://gerrit.libreoffice.org/55057 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 29f0c9d344bfe2e09727fd9b9aa88e8c7bf361e2) Reviewed-on: https://gerrit.libreoffice.org/55067 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-29these spinbuttons should be focusableCaolán McNamara3-15/+14
Change-Id: I5af98ef0815f91b8c615441299eb43d602ebf57b Reviewed-on: https://gerrit.libreoffice.org/55026 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxTransformTabDialogCaolán McNamara5-102/+207
Change-Id: Ib6dabd04e3f834b61363d5a620de7f0219a1e644 Reviewed-on: https://gerrit.libreoffice.org/55018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29fix pow by digitsCaolán McNamara1-0/+4
Change-Id: I715b85fa1c1e3f6c391c742f861e3791a505a570 Reviewed-on: https://gerrit.libreoffice.org/55013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxSwPosSizeTabPageCaolán McNamara3-477/+430
Change-Id: I51c83ec801884a07f7920309535a58b55171b0be Reviewed-on: https://gerrit.libreoffice.org/54979 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxAngleTabPageCaolán McNamara4-119/+142
Change-Id: I03bd0a6a0805d549570ce44030a0f58ca2b98d05 Reviewed-on: https://gerrit.libreoffice.org/54987 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxSlantTabPageCaolán McNamara3-104/+101
Change-Id: Ib3b1bf1fa434c63b66f388a1f1815787b642fb88 Reviewed-on: https://gerrit.libreoffice.org/54967 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxPositionSizeTabPageCaolán McNamara3-344/+310
Change-Id: Ic642d6ab2470a14b3a1d83284407fc690d5eba88 Reviewed-on: https://gerrit.libreoffice.org/54975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28fix up position of anchor widgetCaolán McNamara1-3/+1
Change-Id: I35823a4c84f6134bf9b005fb1ab6df12d716d14e Reviewed-on: https://gerrit.libreoffice.org/54942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28loplugin:unusedfieldsNoel Grandin1-1/+1
Change-Id: I625b73152c0c277c6e0ce3e24e4704094fc4e8ff Reviewed-on: https://gerrit.libreoffice.org/54822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 96d7c67d98527b1ccc1cfba3ca817238e582d63b) Reviewed-on: https://gerrit.libreoffice.org/54943 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28loplugin:passstuffbyrefNoel Grandin3-4/+4
Change-Id: I785e96599bbda029adf4698d11d7f981750dec07 Reviewed-on: https://gerrit.libreoffice.org/54802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit ff3bdde2527123fc9e011ff0d93e958174632186) Reviewed-on: https://gerrit.libreoffice.org/54914 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-24rework custom widget welding to enable inheritenceCaolán McNamara5-275/+305
Change-Id: I0d391b3fe9d2d610ae41e2a03cd2e195a866e103 Reviewed-on: https://gerrit.libreoffice.org/54681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-24Remove unnecessary includeMuhammet Kara2-2/+0
Change-Id: I660bc8efd441e9fc5b6f83f69dc632a26add193b Reviewed-on: https://gerrit.libreoffice.org/54712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-05-23tdf#104086 cui: enable OpenGL when ignoring its blacklistMiklos Vajna2-0/+10
"Ignore OpenGL blacklist" is called "force OpenGL" in the code, so it make sense that OpenGLHelper::isVCLOpenGLEnabled() returns true in that case. But the UI suggested that enabling ignore doesn't enable OpenGL itself. Fix this by auto-checking the parent UI widget when enabling the blacklist. Change-Id: I16bec69aebd645858260850f15ea8e687566fd0e Reviewed-on: https://gerrit.libreoffice.org/54720 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-22Related tdf#83877 Select certificate ok button label doesn't matchSamuel Mehrbrodt1-1/+1
Change the button to "Select" instead of sign when we only want to select a certificate. Change-Id: Ifa896e502c8680497d71912ddd1058ab0b71542b Reviewed-on: https://gerrit.libreoffice.org/52823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Don't try to sign when no certificate is selectedSamuel Mehrbrodt1-0/+1
Change-Id: I30f8f5970538db25ae678dc5b32afb292fd3983a Reviewed-on: https://gerrit.libreoffice.org/54652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22tdf#83877 Use Signer comments as signature descriptionSamuel Mehrbrodt1-1/+1
Change-Id: Ia9f18addeee9cf86989c873419113ddbd07c219f Reviewed-on: https://gerrit.libreoffice.org/54551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22tdf#83877 Add valid/invalid images to signaturesSamuel Mehrbrodt2-40/+40
Change-Id: I958c1bad2f32383ebaaeb7d42c761f0d1dfefc35 Reviewed-on: https://gerrit.libreoffice.org/54513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>