summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2017-02-10tdf#98993 cui: Paragraph dialog: decimals in Line Spacing spinboxMichael Stahl1-0/+1
For whatever reason, this also makes the +/- buttons increment by 1pt instead of the previous 10pt, which is also an improvement. (presumably regression from 324141f21bf2280d7613c4056ee8cd997ea345f9) Change-Id: If47dd768b2faea760d9967a73453d3f714c65fe3 (cherry picked from commit d22377ab55675135776d94213ef06f608b71669e) Reviewed-on: https://gerrit.libreoffice.org/34109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-01crash on exit from undisposed insert special character dialogCaolán McNamara1-1/+1
right click on style combobox in writer toolbar, insert character, esc, ctrl+f4 and crash Change-Id: I83c88584c6d772bf629121a2bcdc16076bee8003 (cherry picked from commit cfdfe1be91101654456bdf1f16d92461e1e5dbfa) Reviewed-on: https://gerrit.libreoffice.org/33701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-13Resolves: tdf#101588, do not prevent color de-selection tdf#96382 follow-upEike Rathke1-2/+6
Comparing colors to determine whether to set one in the result item set does not work if the color previously was set before SaveValue() was called unconditionally even for the "undetermined" color state. Actually we want to know whether the user selected a color instead. Change-Id: I508f791684ebd79ba4af9cb654f9aa0bb25bff5d (cherry picked from commit 429be969b39867d6d9f36978c9ac15b601e78ba6) Reviewed-on: https://gerrit.libreoffice.org/31923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-29tdf#34467 - FitToFrame: stretch text to fill drawing objJustin Luth1-3/+7
Help for Fit To Frame says "Resizes the text to fit the entire area of the drawing or text object". reverts commit b7628798ec1a966c97a64d7cf0aa9f3859b78bef and partially addresses the problem of "Shrink font automatically when text overflows" by treating text as "Autofit" while it is being edited. It's not WYSIWYG, but good enough, and maybe better. Since that part of the change prevents any way of setting ::Autofit, I also changed clearing of Fit To Frame to Autofit instead of NONE, since there is no good reason why text should be allowed to spill outside of a textbox. For those who REALLY want that odd behaviour, they can use .uno:TextFitToSize (Ctrl-Shift-F8) to toggle between "stretch" and "none". NONE is still the original default if "Fit to Frame" is never touched. So it can look a little inconsistent. 1. Turn off "frame height expands with text" and Fit2Frame defaults to NONE - text can spill out of the textbox. 2. Turn on "Fit to Frame" and Fit2Frame is PROPORTIONAL - the text stretches to fill the frame. 3. Turn off "Fit to Frame" and Fit2Frame is AUTOFIT - the text will shrink to fit nicely inside of the frame. Change-Id: I8313a82cbea82f11fad0f50d966fc77874977da9 Reviewed-on: https://gerrit.libreoffice.org/30727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/30869 Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-11-28respect read-only config items in Options - Load/Save - General dialogAndras Timar1-5/+15
Change-Id: I110e8eb2b858c8b86b01d46bec40873939ae53d8 Reviewed-on: https://gerrit.libreoffice.org/31237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 5f9bd7677047abfc9d3bde0db78f74ff23204f0d) Reviewed-on: https://gerrit.libreoffice.org/31239 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-06Resolves: tdf#101953 controls become wider/smaller switching to/from graphicsCaolán McNamara1-0/+20
Change-Id: I20a82d1ff2f3a11b0f327eecc90a2bb30bd4df3d (cherry picked from commit d2e69a61a3e3b962cddf576558f1412c7baacd06) Reviewed-on: https://gerrit.libreoffice.org/29513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-01Resolves: tdf#101475 adjacent cells text is still too wideCaolán McNamara1-1/+1
Change-Id: I8fae7197b191de4346a4fb0f2226c63bc615b29d Reviewed-on: https://gerrit.libreoffice.org/29346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-09-21Resolves: tdf#100795 SAL_MIN_INT32 32bit overflows on finding min limitCaolán McNamara1-4/+4
for control points, so halve it to the practical limit Change-Id: I1285631bebebf86e257a2fdd804c0c81dcefac96 (cherry picked from commit 25e4708c1f49986f3f082beb2e940aa2d7fb4d81) Reviewed-on: https://gerrit.libreoffice.org/29132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-06a11y: fix missing labels in sw paragraph dialog textflow tabYousuf Philips1-1/+4
Change-Id: I3173cf240131788013345aa864156286affa476d Reviewed-on: https://gerrit.libreoffice.org/28657 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9ea5483d9bd44b136c89e45ef96bbf3df0a7cdef) Reviewed-on: https://gerrit.libreoffice.org/28696 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-05Resolves: tdf#101795 restore hiding on end of Gtk fpicker executeCaolán McNamara1-7/+6
but don't hide it at the end of every RunDialog::run so that the dialog still exists and is visible if the "sure you want to overwrite" dialog needs to be displayed and restore the cui options stuff to its original state as well, undoing the earlier efforts of... commit c1bd3156cf66318023f36d81ce809a38072588e4 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 21 21:44:06 2016 +0100 Resolves: tdf#101054 crash on options->path with non-native file picker and commit 3bbc0574d78d129359638b74612de2f93419eeb0 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jul 5 10:16:51 2016 +0100 Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker Change-Id: I5d6bcee9fb0a73a95cc29e8f3f2ee2aea91a135a (cherry picked from commit 696e83b663d4f3e00f23947613f9f3916a4dd14d) Reviewed-on: https://gerrit.libreoffice.org/28642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-09-05Gallery submenu was missing from native menusMaxim Monastirsky2-5/+3
... for both OS X and gtk3. The reason is that it was filled in item highlight handler, which isn't implemented for native menus. Instead use the menu activation handler, like for the similar button in SvxLineTabPage. To test this patch open Writer, Format > Bullets and Numbering... > Options. Switch "Number" to "Graphics", and click on the "Select" button. (cherry picked from commit c780c6726dca5e2fe33297e44f25ae3e00703294) Change-Id: I437fd6536dbd9e6ba51282eaacc8b43c3a2d6cbf Reviewed-on: https://gerrit.libreoffice.org/28670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-02Resolves: tdf#97055 hyphenation claims its already active after closingCaolán McNamara1-3/+6
cancel button works, hyphen all works, but closing it via wm close skips the cancel callback. simplest thing seems to be to call SpellEnd when necessary, flagging that its not necessary by disabling the close button on the RET_OK case Change-Id: Ib0a67c4395e9d20941e735ebb14f6bd7f7ddb66c (cherry picked from commit c7fd6532682a12d8981e6b19b4fbb75d6d3c412c) Reviewed-on: https://gerrit.libreoffice.org/28503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-03Resolves: tdf#101196 line wrap very long checkbox contentCaolán McNamara2-1/+13
Change-Id: Ie451b88240f755a0d64dd3db14d7981b8ed2a2a2 (cherry picked from commit 1c33b3f5f693d432f74c795a87f87bd487b09d47) Reviewed-on: https://gerrit.libreoffice.org/27811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-03masses of MessBoxes not being disposed promptlyCaolán McNamara14-27/+27
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-02Resolves: tdf#96677 effects page didn't link labels to what they labelledCaolán McNamara1-0/+20
(cherry picked from commit b3b7669e7fb74b04d925f21a7f0b048434eeffa3) Change-Id: I29503324f221c42208267f4f0d36922e89119fdd Reviewed-on: https://gerrit.libreoffice.org/27677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-22Resolves: tdf#101054 crash on options->path with non-native file pickerCaolán McNamara1-1/+0
regression from... commit 3bbc0574d78d129359638b74612de2f93419eeb0 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jul 5 10:16:51 2016 +0100 Resolves: rhbz#1352835 path options doesn't promptly destroy folder picker only clear the xFolderPicker immediately in the non-async case Change-Id: Id6a411424d41262a9379ad3eb7976c8dd666a5cf (cherry picked from commit c1bd3156cf66318023f36d81ce809a38072588e4) Reviewed-on: https://gerrit.libreoffice.org/27417 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-20Revert "Addition of new controls and their rearrangement in gradient tab"Rishabh Kumar5-219/+283
Unfinished GSoC: Area Fill project feature. Introduces regression in LibreOffice-5-2. This reverts commit fe3d9ac20b0f27b8beca7e54efa8ba571e76101d. Change-Id: Ic1a9e2d7279e0b06e19b5d1020b37b44d28060b4 Reviewed-on: https://gerrit.libreoffice.org/27336 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-20Revert "Addition of new controls and their rearrangement in hatch tab"Rishabh Kumar5-274/+335
Unfinished GSoC: Area Fill project feature. Introduces regression in LibreOffice-5-2. This reverts commit 7a4bd998e900c7f7a28f9068b97707ef76c99b85. Change-Id: I94c24b252983732161b8f2f0de51780a4d5c13bd Reviewed-on: https://gerrit.libreoffice.org/27331 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-18Resolves: tdf#99963 line wrap very long checkbox contentCaolán McNamara2-1/+11
Change-Id: I11ab52b8c6600d5d479ac3d4d2cd78d1957d8676 (cherry picked from commit ea3f74ba0a9d291f26a79f2568d59f1a030d0585) Reviewed-on: https://gerrit.libreoffice.org/27292 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-07-13make sure that the thread has joined before disposing UI elementsMarkus Mohrhard1-0/+3
See e.g. http://crashreport.libreoffice.org/stats/crash_details/80884848-16e7-4512-be4a-74c53bfce34b#allthreads The thread can run while the UI elements have already been disposed. The StopExecute call is not enough to prevent that from happening. Reviewed-on: https://gerrit.libreoffice.org/27087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 4ebbb996ac159f57e0730c938667535af148cae1) Change-Id: Iab4209776e1403a6520c106f3521476ee50848a4 Reviewed-on: https://gerrit.libreoffice.org/27183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-11Resolves: rhbz#1352835 path options doesn't promptly destroy folder pickerCaolán McNamara1-10/+9
Change-Id: I5133f63fd92f384221fa2812c6e2a0e7f3b37ac1 (cherry picked from commit 3bbc0574d78d129359638b74612de2f93419eeb0) Reviewed-on: https://gerrit.libreoffice.org/26941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-07-07cui: add calculation mode to Help->About.Michael Meeks1-0/+13
Reviewed-on: https://gerrit.libreoffice.org/26964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit adc3932dfc4fe763b7db0af8843b01614bdc6aa2) Change-Id: I4765436bed8a58c5097afcf7dce768d3ec325015 Reviewed-on: https://gerrit.libreoffice.org/27003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-27tdf#100222: Show the dialog just once even if both toggles were changedTor Lillqvist1-6/+4
Change-Id: If6058d68f80ebc3e235f0a681cfe3240985e2429 Reviewed-on: https://gerrit.libreoffice.org/26693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-26tdf#100222: Inform user that a restart is needed after toggling OpenCL useTor Lillqvist1-0/+3
(cherry picked from commit c7c27b9b191291cf36e4940aef3e3e7371855797) Change-Id: Ic33cb02440276bc0601c86f2c9eab7d74a6b9874 Reviewed-on: https://gerrit.libreoffice.org/26610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-09Resolves: tdf#93135 can't resize shape with "resize shape to fit text"Caolán McNamara1-3/+3
These are regressions from... commit 4a847bb4a2002d7f8f5854b7276ac67d369bdd3b Date: Sun Aug 2 21:20:48 2015 +0200 tdf#93079: "resize shape to fit text" state can't be disabled Wrong copy-paste and commit b2bae9b940fc34d2eecd7839e3cba1f41d111e87 Date: Thu Apr 9 23:38:47 2015 +0200 Related tdf#34467: Fit to Frame for text boxes is broken Wrong Copy-paste Its turns out that there is *no* SDRATTR_TEXT_AUTOGROWSIZE property. Only a SDRATTR_TEXT_AUTOGROWHEIGHT property e.g. see CustomShapeProperties::UpdateTextFrameStatus of svx/source/sdr/properties/customshapeproperties.cxx "change TextFrame flag when bResizeShapeToFitText changes (which is mapped on the item SDRATTR_TEXT_AUTOGROWHEIGHT for custom shapes, argh)" So the inconsistency between getting the itemstate of SDRATTR_TEXT_AUTOGROWSIZE and then setting/getting SDRATTR_TEXT_AUTOGROWHEIGHT is better resolved by getting the itemstate of SDRATTR_TEXT_AUTOGROWHEIGHT will have a follow up patch to remove SDRATTR_TEXT_AUTOGROWSIZE to show its not used by anything Change-Id: I8b8abde17c15761c621815ed2be62d6a8a5cd69a (cherry picked from commit d1df071c3fc452817746a8daa13000d2df667aba)
2016-05-29Resolves: tdf#97839 a single character may be more than 1 utf-16 code pointsCaolán McNamara1-1/+1
Change-Id: Iba2460bfb9335615796db3f5e233b870a8d63339 (cherry picked from commit 847cdd8efd0662d61d288a4d944edc30e864d145)
2016-05-25Window::SetData and Window::GetData are nearly unused nowCaolán McNamara1-13/+2
except for.. a) one use in sw which we can replace with a map b) one use in svx which didn't do anything c) one amusing piece of crazy in cui Change-Id: If66d9f7eab1eaddfb2bdab7815c3a6f22f4d7745
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara3-16/+0
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-24Convert SnapType to scoped enumNoel Grandin1-5/+5
Change-Id: I3980c2999bab191bb9357c883868db17db79e81f Reviewed-on: https://gerrit.libreoffice.org/25353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23Addition of new controls and their rearrangement in hatch tabRishabh Kumar5-335/+274
1. Removal of rectangle hatch angle dial widget 2. Addition of slider widget for changing angle in hatch tab. 3. Move hatch background color control from area tab to hatch tab. 4. Rearrangement of controls 5. Removal of hatch controls from Area tab Change-Id: I596098b328fc183d2fdd5259e90013dbf74d9ad7 Reviewed-on: https://gerrit.libreoffice.org/25147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-23tdf#89329: use unique_ptr for pImpl in optsaveXisco Fauli2-5/+4
Change-Id: Ia442a6a5c570c45b03fc878099f1c50005ee7538 Reviewed-on: https://gerrit.libreoffice.org/25331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23Resolves: tdf#99981 make ScriptSelectorDialog modal for its parentCaolán McNamara3-15/+6
Change-Id: Ia522b36cd1f5d47d08afa74a22cec11de465f567
2016-05-23tdf#89329: use unique_ptr for pImpl in optpathXisco Fauli2-6/+5
Change-Id: If9e627e2f0f091e8411d0c6f16f29b583723419a Reviewed-on: https://gerrit.libreoffice.org/25327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23tdf#99211 Use the restart dialog for notifications about restartirem1-6/+9
Change-Id: I97a10cddafc464ccbdd37902c5d24b73246f5c3f Reviewed-on: https://gerrit.libreoffice.org/24877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-22Convert HYPERDLG_EVENT to scoped enumNoel Grandin2-9/+9
Change-Id: I8a0248bb91ee67596aa44d11ca862d2e127a65ad Reviewed-on: https://gerrit.libreoffice.org/25197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin3-20/+22
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18Addition of new controls and their rearrangement in gradient tabRishabh Kumar5-283/+219
1. Addition of increment spin box and slider in gradient tab. 2. Addition of slider for border controls in gradient tab. 3. Rearrangement of controls. 4. Removal of gradient controls from Area tab. Change-Id: I56c3767a0d54990338982cd45ed10a10dd8a94c1 Reviewed-on: https://gerrit.libreoffice.org/24910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-18convert TAB to scoped enumNoel Grandin2-16/+16
and rename the SID constant to something more meaningful Change-Id: Ic07888936df3d537158fd2fb671b0df11350d676 Reviewed-on: https://gerrit.libreoffice.org/24986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin10-85/+3
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin1-8/+8
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-17tdf#88502 Added error box to denote connection errors instead of progress barSusobhan Ghosh2-16/+24
Change-Id: I8217fa487ed58f5d396e8769c76dd2d16f390472 Reviewed-on: https://gerrit.libreoffice.org/24757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-16Convert LB flags to scoped enumNoel Grandin1-120/+131
Change-Id: I6bce097e803ece5ddf7764651900e0d14a2d0393 Reviewed-on: https://gerrit.libreoffice.org/24985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara2-0/+2
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-12mpDefDialogParent is not used since 2002Caolán McNamara2-10/+1
i.e. commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39 Author: Stephan Schäfer <ssa@openoffice.org> Date: Tue Oct 22 08:39:05 2002 +0000 #103442# choose DefDialogParent on-the-fly and so calling SetDefDialogParent doesn't achieve anything Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin14-22/+20
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert MESS_BTN to scoped enumNoel Grandin8-21/+18
Change-Id: I9332216f58268b20b3b8e9488471279d70c519ad
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann6-7/+7
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann1-0/+1
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-10convert WINDOWSTATE_MASK to scoped enumNoel Grandin1-1/+1
Change-Id: Ic8259d81d8080c518aa07697e253a59cd6efaa4b
2016-05-09fix windows and android buildNoel Grandin1-1/+1
Change-Id: I4644c1e5ac143efc6b1e75d041f71fe7d9156f0c
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-28 04:57:28 +0000