summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2018-07-02tdf#117866 cui: avoid deadlock in personalization dialogMiklos Vajna2-4/+14
The deadlock happened as the main thread wanted to join SearchAndParseThread (while owning the solar mutex), but SearchAndParseThread wanted to take the solar mutex to import a graphic. Fix the deadlock by checking for the termination flag earlier, so we don't take any new mutexes if termination was requested already. (cherry picked from commit 766c85a4f67f5d50645340e31cebd5956998c6fc) Related: tdf#117866 cui: use std::atomic for thread termination flag (cherry picked from commit f4ac7b5a084a7cf483bb89a2fa411f9df70df4d0) tdf#117866 cui personalization: fix a possible race The case when the thread is re-scheduled exactly after checking for m_bExecute but before taking the solar mutex. (cherry picked from commit f4c73f90da2a2c31f0d29572180aa97e10c3dbad) Change-Id: Idddaadadc693610d9f31a14300b22aff8d452756 Reviewed-on: https://gerrit.libreoffice.org/55347 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins (cherry picked from commit ec8e973f7e681b0ae25e4b781918dd98ea0e8176)
2018-06-27tdf#109269 very slow loading of user-defined dictionary word listNoel Grandin1-8/+23
this is about 10x faster for me Reviewed-on: https://gerrit.libreoffice.org/56378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a07bb28d3199542c0b90884a947c2bac02bad07d) Change-Id: I1d308c78dbdd04beaa432b546ba3b89bd617d57e Reviewed-on: https://gerrit.libreoffice.org/56385 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit a054308741ebae0b65a425be1ab30d3b9e1af871) Reviewed-on: https://gerrit.libreoffice.org/56452 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-01tdf#104086 cui: enable OpenGL when ignoring its blacklistMiklos Vajna2-0/+10
"Ignore OpenGL blacklist" is called "force OpenGL" in the code, so it make sense that OpenGLHelper::isVCLOpenGLEnabled() returns true in that case. But the UI suggested that enabling ignore doesn't enable OpenGL itself. Fix this by auto-checking the parent UI widget when enabling the blacklist. (cherry picked from commit 8118a5d2eb1524768784adc0b143b8cc1b9f3f61) Conflicts: cui/source/options/optgdlg.cxx Change-Id: I16bec69aebd645858260850f15ea8e687566fd0e Reviewed-on: https://gerrit.libreoffice.org/54763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6e37f748096a7fd7d7a3a07b2393c5f8960cfeb5)
2018-05-15tdf#113377 cui personalization: fix calling into VCL without necessary lockingMiklos Vajna1-2/+4
We assume the SolarMutex is always taken when doing GL calls, but putting DBG_TESTSOLARMUTEX() into WinOpenGLContext::makeCurrent() pointed out two places in the persona code where this invariant wasn't hold, fix those. Opening the dialog and downloading previews of one category, then clicking on an other button to download previews of an other category no longer results in a crash while calling glBindFramebuffer() with this. (cherry picked from commit 336d91a6f2bc12ff0342f984cdbb2cf64abd0b56) Change-Id: Ib8148a709f89c2dc44da102e2023cc61ba890744 Reviewed-on: https://gerrit.libreoffice.org/53434 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 980e19ddddaf46dae68c800d55582e8f6b2c7fdd)
2018-04-26tdf#116725: justify selection to handle right-to-left selectionsMike Kaganski1-10/+11
Change-Id: I6298a87170236059ff08a1f891ead21236be663a Reviewed-on: https://gerrit.libreoffice.org/52979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit f7de9473b2fddd84d03fb521709d805486292800) Reviewed-on: https://gerrit.libreoffice.org/53044 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-04-17Resolves: tdf#116138 insert special char problem in chapter numberingCaolán McNamara1-1/+1
Change-Id: If79d23d7c5e99a88d0026295db002c25c1b07ff3 Reviewed-on: https://gerrit.libreoffice.org/52944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit cc34e1c5d6a10d5a7dc315080b26bce848d3aa32)
2018-04-17After Java settings have changed, restart LibO for realKatarina Behrens4-12/+47
Previously restart LibO dialog was shown, but did nothing. I haven't found an easy way to close all frames with 3 modal dialogs opened, so now restart dialog simply pops up later (after user bonks OK button on Tools > Options dialog) Change-Id: I6e61fa1fc41199c2f16cb80da771202c255f3810 Reviewed-on: https://gerrit.libreoffice.org/50566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 683a68cb5106e99db0fbe892b5784d837cf8cb27) Reviewed-on: https://gerrit.libreoffice.org/50829 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit f8d654bba844050a01a232eb8013561da57ed6e0)
2018-04-12Make color scheme dropdown in Options span the window’s widthAdolfo Jayme Barrientos1-1/+2
It was minuscule before. Props to Andreas for reporting the issue. Change-Id: If8ecbe39321c56018e2366147481dcefab4326dc (cherry picked from commit cb5a55adbb67d9515f0048d1b2b595c04f2e2736) Reviewed-on: https://gerrit.libreoffice.org/52238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 74362ac38814872d49de9d5ae32e7e61ae04a544)
2018-04-06tdf#116733: Fix expanding in the entries in "Open expert configuration".Jan Holesovsky1-1/+1
The DoubleClickHdl()'s return value does not mean "was handled", but actually "is there anything more to be done". Change-Id: Ideeee31db648829546a713148124e3d366941b9a Reviewed-on: https://gerrit.libreoffice.org/52292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 3af6be55ae1dabb1b72cbb4c57cca33c28b347f8) Reviewed-on: https://gerrit.libreoffice.org/52305 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2018-04-03tdf#116241 Customizing value highlighting colorsSzymon Kłos2-33/+129
Available in: Tools->Options->Application colors Change-Id: I6e4f7a0dcad9a6ee222275019596853f0cbd3ab0 Reviewed-on: https://gerrit.libreoffice.org/51791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/51976 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-03-28lokdialog: Set parent for AutoCorrect Options... so that it can be tunneled.Jan Holesovsky2-3/+3
To get this dialog: Right-click on a mis-spelled word, and it's in the tunneled context menu. Still it should be converted to async though. Change-Id: Ia8f2aaf0d04f144c74999107de98e52cd51876e7 Reviewed-on: https://gerrit.libreoffice.org/51441 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 7b83827d7b5d07401878fe552c421331629a7880) Reviewed-on: https://gerrit.libreoffice.org/51548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 67a023ef9b251c1e6e2a46521a51ad829c417451)
2018-03-25tdf#116020: use actual whichIds in dialogs for character propertiesMike Kaganski4-13/+32
... instead of converting back and forth between character-specific whichIds and generic. This eliminates creating duplicate properties in the set passed to dialog. A temporary GrabBag entry "DialogUseCharAttr" is used to indicate that dialogs should use character-specific Ids. This simplifies and unifies preparation of the set for different dialogs. Reviewed-on: https://gerrit.libreoffice.org/50339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 074fc4a1499aac6eb67cd0b2dca00a51071cff0e) Change-Id: I41b982ff05d54b0dfc283c07aef806f51c87209c
2018-03-25tdf#115938: Properly detect shadow size control's changed stateMike Kaganski1-1/+6
This change makes sure that only if the shadow size edit box' text is changed, it is converted to the size in twips. It sets wrapper's default value on each SetControlValue, to return proper initial size when the size text wasn't modified. Also both ExampleSet and OutSet in SfxTabDialog's Reset handler are processed to set relevant items back to initial value; otherwise, as the restored item (marked as unchanged) will be absent in tab's result set, it would not modify the old items in the two, and they would keep previous modified values. Change-Id: Ie4362811968c6e6cbe0f9229bd3c9b29462f5704 Reviewed-on: https://gerrit.libreoffice.org/50196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit b37a46fdf91dbc66f6ddc1c070aec70716d94a01)
2018-03-25tdf#115892: properly get the box' saved valueMike Kaganski1-8/+2
Previously textual value like "10,5 pt" was converted to int as simply 10 (multiplied by 10, it became 100), which compared as different from unchanged value of 105. This made the fractional values to be treated as always changed. This patch uses the same code to convert saved value as is used for current edit box value. Reviewed-on: https://gerrit.libreoffice.org/50066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit f00e891f3369f7b8c2532634d9ff4ab19da17c33) Change-Id: I09a84a6bf33b17e0192b79b31af21ef14d7e9c63
2018-03-25lokdialog: Handle dialog items' invalidation in generalTamás Zolnai1-20/+0
Change-Id: Ib7b178fe97964bc5fd6ac173a143ba8ba089e237 Reviewed-on: https://gerrit.libreoffice.org/49240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit b33287cde2d270d83e2658529be768a99dba98f0)
2018-03-25lokdialog: Color/font picker in dialogs don't show previewTamás Zolnai1-0/+22
Invalidation needs to be passed upward to the right parent window. It should work similar to other dialog items, but this preview class is not derived from the Control class. Change-Id: I5fb2b6438b8be92d55609c8d3c25110b49d0e6d7 Reviewed-on: https://gerrit.libreoffice.org/49101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 974ea04ddd1b82e5d5c0171bd8ad29310e3f2bd7)
2018-03-22lokdialog: Convert the Format -> ... -> Position and Size... to async exec.Jan Holesovsky1-1/+6
Change-Id: Idcdbfb1366db61e247c31eab5cb27a39978b0fd9 Reviewed-on: https://gerrit.libreoffice.org/48055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit d3dbbdce4eb71ae848e7682374e011c4a6129b15)
2018-03-21svx: chain up correctly for SvxCharacterMap::Execute()Pranav Kant1-1/+1
Change-Id: I2ff70f7b2ade8e2aad96cff31bd313822779094c (cherry picked from commit f1ec1b1f6e24fce5e496fd7c97c93884068dfba2)
2018-03-20lokdialog: Allow switching language of some of the ResMgr's.Jan Holesovsky1-2/+1
This way, it is possible to have all the strings translated in dialogs even when different users use different languages. [It was already possible to have different languages previously, but not everything in the dialog has switched - like the buttons at the bottom of the dialogs etc.] Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9 Reviewed-on: https://gerrit.libreoffice.org/46417 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/46979 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 101a79cc4d13a1f566c1b97c1329813eb7c61bcf)
2018-03-19loplugin:unusedindex Remove useless outer loopMike Kaganski1-10/+7
Change-Id: I6e5e7162b1e0ea2b9f33866ea76e2614acdffb06 Reviewed-on: https://gerrit.libreoffice.org/46606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit ccb6a1c6d59859467f9d9a6d954501e9329ee202)
2018-03-19lokdialog: Make hyperlink dialog workPranav Kant1-1/+1
Change-Id: Ifd8c721b001b09ddab8d4fe06ae6818980d6ee76 (cherry picked from commit 7bcb9a8416d61bdd3c7fc345f87de5aa8c3054f9)
2018-03-19Use SfxModalDialog class as Hyperlink dialog's basePranav Kant2-2/+3
Change-Id: I1f592fdb5825896ad8fbe55c182936ed4ed98efc (cherry picked from commit 2d508dcc9d6e9d589af32a76468ef3247f8c6674)
2018-03-15Calling ActivatePage directly is unnecessaryTamás Zolnai4-10/+0
After this commit: b426b026b79a342c41f6f148bf17d5df66b22927 Change-Id: I15d491d4cf63db4436ad8d3db0320cd2e26bb3ea Reviewed-on: https://gerrit.libreoffice.org/47078 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 2b5589f4ee47ccadc625877bc970010c2abd36a9)
2018-03-15Related tdf#111739: Don't insert special character into the documentTamás Zolnai2-3/+3
When it's only needed to be applied inside a dialog. Change-Id: I7d61cfb49f80ab43511c9fc6cc6733a990dcae55 Reviewed-on: https://gerrit.libreoffice.org/45436 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 67eeab179a7e1d8b479d08a38093172531d4c3c9)
2018-03-15do not localize Collabora Office URLAndras Timar1-1/+1
Change-Id: I1eb33d3ce649ff8ca1158e96fe6c6bc1a3ab75ea (cherry picked from commit 9189450fa042526ee5380a2b9004b8a1a32a9e48) (cherry picked from commit b36267edb632577ca5e6deb219d5da4d5b8e9bef)
2018-03-09tdf#115084: fix sloppy mnemonic IDKatarina Behrens1-1/+1
Change-Id: I8f9df0baa2862eefada8fafeb384e0129df3f7e9 Reviewed-on: https://gerrit.libreoffice.org/50839 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 74a027f927289911b3b712c1ea0f350cf631b0ae) Reviewed-on: https://gerrit.libreoffice.org/50981 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-09tdf#115015: make crypto settings better fit allocated spaceKatarina Behrens3-3/+25
Oh dear how much do I dislike fixed size dialogs. Everytime they are enlarged to fit new content (esp. gtk3 is rather space-greedy there) someone starts to whine the dialog is now too large Doing what e6d7d7375221 does is not really an option, since there are some 30+ tabpages to try and test for optimal size here. And two more squashed commits: tdf#1155015: Make sure checkbox text really wraps for :wrap property to be effective, a reasonable height request is needed so the text is not forced into single line again tdf#115994: Extensions' option pages need fixed pref. size as they are fixed size .xdl-based dialogs mostly But because of tdf#115015 calculate this preferred size as approx. 14 text edits + some padding to make sure crypto settings will fit the allocated space Change-Id: I3ffb2d794f76781eb62186093b928289593585cf Reviewed-on: https://gerrit.libreoffice.org/50596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-07Resolves: tdf#113805 insert special character fails in insert footnote...Caolán McNamara3-4/+18
etc. dialogs i.e. since commit 710a39414569995bd5a8631a948c939dc73bcef9 Date: Thu May 11 13:27:38 2017 +0530 GSoC: Glyph View and Recent Characters Control in Special Characters dialog Change-Id: Ia55f3fefe7c14327cff2e996ab0038dc52f9b017 it inserts into the document, extend the fix of commit 4020945651b4f3c636980e2103db440b5c55459c Author: Daniel <danielfaleirosilva@gmail.com> Date: Sun Sep 24 17:55:19 2017 -0300 tdf#111739 fix Selecting a custom character as a bullet symbol insertion to do the old thing that existing code depends on if this is not an "insert" dialog, and bubble that setting around from the callers Change-Id: Id8acf16955d0167beffae43e3b201e500ee7a929 Reviewed-on: https://gerrit.libreoffice.org/50781 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/50799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-13tdf#115506: Crash when trying to set pattern fill for tables in ImpressTamás Zolnai2-0/+3
Setting pattern list was missed in this specific dialog. Change-Id: I9f47e9e0dd4f99bf5403c70685508b0f14a5bd61 Reviewed-on: https://gerrit.libreoffice.org/49361 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit de8a1b4f6c8fcca9fc9cc5ad83c393ecd7292f76) Reviewed-on: https://gerrit.libreoffice.org/49404 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-06tdf#114731: persona html can contain &quot; instead of &#34;Julien Nabet1-1/+4
So let's replace all &quot; with &#34 in the retrieved html Change-Id: I4a90ecc51e7ce6d1e080e6c1b17b82fe9a29d65e Reviewed-on: https://gerrit.libreoffice.org/49179 Tested-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 2e6bbc04d906ed308fc5ca769bad7b8b4676594e) Reviewed-on: https://gerrit.libreoffice.org/49285 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-04Resolves: tdf#115369 wrong cell shadow iconsCaolán McNamara1-1/+1
regression from... commit 910f91a3e5228f26f0692f870a3fd3919835eb27 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Dec 21 13:04:30 2016 +0000 unwind IL_SDW_BITMAPS ImageList Change-Id: I9ecb5c45c240af0214666c56401abb07eb99e5f1 Reviewed-on: https://gerrit.libreoffice.org/49167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-01-08tdf#114818 hold the mutex before executing the error dialogXisco Fauli1-0/+4
Also add an assert to ErrorBox to ensure the mutex is acquired Change-Id: I3e426024dad6ddfc5cffc7861b0cba9e8989c018 Reviewed-on: https://gerrit.libreoffice.org/47388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 0ddd15c1134dde249552ebe763c1cd005e8b4591) Reviewed-on: https://gerrit.libreoffice.org/47570 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-04tdf#113357 cui: fix duplicate 'Formatted text [Richtext]' paste optionMiklos Vajna4-0/+77
Prefer RTF when we have both RICHTEXT and RTF. (cherry picked from commit dba3cd508116780cf5d115f964b7311dd61e180d) Change-Id: Ib4133ae4fdecc32429d89b56b0c9466dd3451522 Reviewed-on: https://gerrit.libreoffice.org/47339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-01tdf#106784 Also handle automatic icon sizeMaxim Monastirsky1-2/+2
... like before b1426b5b502fd591402d666994e3f1fb3a8ad959 ("tdf#95014 initial support for 32 px icons in toolbar"). The original code used SvtMiscOptions::AreCurrentSymbolsLarge() which calls GetCurrentSymbolsSize() internally, thus properly resolves the icon size, when the current setting is "automatic". Change-Id: Iabcbbcff666eecc2e7534eb1533610f08ac28bf1 Reviewed-on: https://gerrit.libreoffice.org/46899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 1d55c1baed9977bad449691012807c6f09e2fca8) Reviewed-on: https://gerrit.libreoffice.org/47027 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-12-26Avoid crash without GPGTor Lillqvist1-7/+10
Change-Id: I5489012544fdf736784608b274359ea99f9ffe45 (cherry picked from commit 1b73ed91e1cce20b3b552a36d449fb96cc57bf4f) Reviewed-on: https://gerrit.libreoffice.org/46977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-19Read/write 'encrypt to self' bitKatarina Behrens1-2/+7
use some template functions to avoid duplicate code Change-Id: Ia178ea3a0561e34e0431749262f5f8f1f49b4fe7 Reviewed-on: https://gerrit.libreoffice.org/46693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/46762
2017-12-19Read/write preferred GPG signing/encryption keysKatarina Behrens1-2/+31
Reviewed-on: https://gerrit.libreoffice.org/46692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit df4fac1dbce087bbd01bbec242b93c72edcef74b) Change-Id: I3e21469c5f4c4f199407bbe9faba2e2ddca531b3 Reviewed-on: https://gerrit.libreoffice.org/46760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-19List private GPG keys in crypto config dialogKatarina Behrens3-16/+73
Change-Id: I7cb6a14adcc5424b432589120c66deeddf86b652 Reviewed-on: https://gerrit.libreoffice.org/46691 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit e0c3e356fd9151819db13d844f87ec200e2dbee3) Reviewed-on: https://gerrit.libreoffice.org/46758 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-16tdf#114484 - Make internal file and print dialogs obsoleteheiko tietze1-2/+1
Checkbox hidden in options dialog Change-Id: I918b328dec1a4fbb4ebbcc538ffa902160ee0b9b Reviewed-on: https://gerrit.libreoffice.org/46546 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 65ee299a0c0e9044d809e58c3c5e75d05ad76f0e) Reviewed-on: https://gerrit.libreoffice.org/46551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-12-10gpg4libre: rename GPGME_HAVE_GPGME to HAVE_FEATURE_GPGMEThorsten Behrens1-4/+4
Change-Id: I6f085b67c3477f427bd1efd96db93cbb89e20647 Reviewed-on: https://gerrit.libreoffice.org/46050 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 1e71870034c9e180f856f51dc2c183d2a6ba9ccd) Reviewed-on: https://gerrit.libreoffice.org/46069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-07Restore GPG SEInitializer serviceKatarina Behrens1-0/+22
user config now needs it to collect user's private GPG keys Change-Id: Ia4ad4133b621160cf37281750cafa9f3c5c3c231 Reviewed-on: https://gerrit.libreoffice.org/45562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 1c58b047d117bb087abc571b74c06cdf7499b1a0)
2017-12-05tdf#114091: Customize dialog: Rename 'All categories' to 'All commands'Muhammet Kara2-2/+6
And put a separator before the 'Macros' category. Change-Id: Ibcff6b6c6d3a4f72d5e06b519fe8245d9602ad3c Reviewed-on: https://gerrit.libreoffice.org/45843 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com> (cherry picked from commit cdb9e338f1e410fe968df3193369a1b516c50c35) Reviewed-on: https://gerrit.libreoffice.org/45872 Tested-by: Jenkins <ci@libreoffice.org>
2017-12-04tdf#112207: Allow assigning macros to ui elementsMuhammet Kara3-11/+211
* Adds "Macros" category to the categories list * Search/filter feature now works also on the macros category * Since macros category has multiple trees and subtrees, and many leaf elements (macros). I chose to implement the behavior like this: If there is no filter/search term, the trees will be presented as in the old macro selector dialog (collapsed), but if user types a search term, then filtering happens: non-matching elements and empty containers/(sub)trees are removed and everything is expanded so that user easily sees what (s)he is looking for. Change-Id: I1a93f156a7293c7e61baac882a10ff631961e2af Reviewed-on: https://gerrit.libreoffice.org/44938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 3f2915c40fcc42ac91f2019fd506bfbdd1e5933f) Reviewed-on: https://gerrit.libreoffice.org/45779
2017-12-03tdf#98211 make last line default value language neutralYousuf Philips1-2/+2
Change-Id: Ieccb174debbfb00e8165c5928ea9786d55bffab3 Reviewed-on: https://gerrit.libreoffice.org/43224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> (cherry picked from commit b0ca7c2e8122f7f3445835ef51d8396eb0969412) Reviewed-on: https://gerrit.libreoffice.org/45707 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-11-29tdf#113859 Make it possible to select every widget with tabgeri12451-16/+1
On the shadowtab page of a figure (eg. rectangle, ellipse) the widgets that modify the shadow can now be selected using the tab button. Removed an "invisible" alignment from the ui file that caused the problem. Change-Id: Id833302d42b9c1f2df640135473f159c0a3af4f7 Reviewed-on: https://gerrit.libreoffice.org/45444 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 2f26765e2dc8b7e6752a2cf6fbde3c45ab293f65) Reviewed-on: https://gerrit.libreoffice.org/45532 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-11-28Add comment to translators of "Grammar By" text entry boxLászló Németh1-0/+14
Change-Id: Ifea74df8f113967c9df9703cf6582360ffdfa78d Reviewed-on: https://gerrit.libreoffice.org/45410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 217b1e8e94859e06af66023f042c53cf329f5232) Reviewed-on: https://gerrit.libreoffice.org/45442 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-11-23Resolves: tdf#113962 save detected filter outside file dialogCaolán McNamara1-1/+1
different file dialog impls work differently so store the detected filter outside the file dialog Change-Id: I144d8df06e5265fed8f11b284a2f40c17c3e09ef Reviewed-on: https://gerrit.libreoffice.org/45166 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23gpg4libre: UI and config for adding GPG keys to user's identityKatarina Behrens1-585/+694
Change-Id: I1a176ca998f49b68c6ca8129fba4eb56445892a2 Reviewed-on: https://gerrit.libreoffice.org/45145 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-23Make loplugin:unnecessaryparen look through implicitStephan Bergmann1-1/+1
...similar to how <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent" does for loplugin:simplifybool Change-Id: I23eef400af71c582d380c9bae6546ce06e8a1e18 Reviewed-on: https://gerrit.libreoffice.org/45122 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin1-1/+1
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>