summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2019-11-27tdf#126043 freeze/thaw around bulk insertCaolán McNamara1-0/+6
Change-Id: I2dd9aedc305a4fe1992fe8c52fee85ade8589a5b Reviewed-on: https://gerrit.libreoffice.org/83674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 300ffc649aaa555bba19a0475d74067c9574fc04) Reviewed-on: https://gerrit.libreoffice.org/83833
2019-11-27tdf#126043 identify the frame module just onceCaolán McNamara2-11/+11
Change-Id: I7f68cf67838bb08672975e7a38cf213022e39ed8 Reviewed-on: https://gerrit.libreoffice.org/83672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6e6233a5d0940e5bbdb346142091b0ae2e54e640) Reviewed-on: https://gerrit.libreoffice.org/83832
2019-11-27tdf#126043 drop intermediate OUStringCaolán McNamara1-4/+2
Change-Id: I96906737bfe0f40b8a4c0b2f88dde7cc40daeab0 Reviewed-on: https://gerrit.libreoffice.org/83677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit df701c92f3f8071d1dd6df70898c33d99e905e7e) Reviewed-on: https://gerrit.libreoffice.org/83834
2019-11-26use a better conversion to OUStringCaolán McNamara1-6/+1
Change-Id: I4a133c054700f72770380214cc794a691edac54e Reviewed-on: https://gerrit.libreoffice.org/83741 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 use CommandInfoProvider::GetModuleIdentifierCaolán McNamara1-11/+1
which probably already has a cached ModuleManager Change-Id: Id653e57ecf40061ace086881344a85d7413a5afc Reviewed-on: https://gerrit.libreoffice.org/83671 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9426162a3b24732167e4fa7aa2fa6ee19d33e7e9) Reviewed-on: https://gerrit.libreoffice.org/83788
2019-11-26tdf#126043 fetch the command properties just onceCaolán McNamara2-6/+10
Change-Id: Iaf343e9858be36ca8772d9c12eee772d93b4c394 Reviewed-on: https://gerrit.libreoffice.org/83668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/83763
2019-11-26Resolves: tdf#129025 options dialog should be modalCaolán McNamara1-0/+1
Change-Id: I57c0887aaccbde2424b856d2b0d20ac7c00e8172 Reviewed-on: https://gerrit.libreoffice.org/83737 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-26tdf#126043 cache the appname and filenameCaolán McNamara3-17/+14
Change-Id: I10987f8a447785eb0d9887f94ee0ffb0da99649a Reviewed-on: https://gerrit.libreoffice.org/83716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-25don't just truncate the unicode chars of the pathCaolán McNamara3-39/+31
instead convert to a systempath like we do for other uses of xmlParseFile drop the manual memory management Change-Id: I8c3329db4b47a2d212770297c96f066ccbe1ec77 Reviewed-on: https://gerrit.libreoffice.org/83692 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-25constifyCaolán McNamara1-3/+3
Change-Id: I912ec27312a65bf065887af26b42122b5276d69f Reviewed-on: https://gerrit.libreoffice.org/83652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-25fix leakCaolán McNamara1-2/+0
Change-Id: I486fad57766c1314fde7c580fd06b2c5d225241a Reviewed-on: https://gerrit.libreoffice.org/83650 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-24linetab dialog page updateandreas kainz1-322/+355
Change-Id: I6e152f69850d1fd3671660decd4186d8cd29465e Reviewed-on: https://gerrit.libreoffice.org/82047 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 6cdc0dbfadfcbfa4f53a3c21a494ab225ba5d955) Reviewed-on: https://gerrit.libreoffice.org/83310 Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-24Line Shadow Dialog updateandreas kainz1-149/+149
Change-Id: I59294e8de213059cb0bdc28b5006ee202019210a Reviewed-on: https://gerrit.libreoffice.org/83234 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 0cbcb4b7eb87d947cb99fbb11d132dfad2e47060) Reviewed-on: https://gerrit.libreoffice.org/83260 Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-22Add ODF 1.3 strings to Save options pageThorsten Behrens1-1/+14
Change-Id: Ice0980ff09c575bc109773d215e74dcee901a9f6 Reviewed-on: https://gerrit.libreoffice.org/83453 Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-11-22tdf#128677 Adding the wording as discussed in bugSeth Chaiklin1-1/+1
Change-Id: I5c327e86cd39a1d625831d27b763a59b32064360 Reviewed-on: https://gerrit.libreoffice.org/82630 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 01d01d6e21b360888db9a58a93dc24caad46d4c9) Reviewed-on: https://gerrit.libreoffice.org/83481
2019-11-21tdf#128775 Writer Hyperlink dialog: fix encoding of inserted target URL Tünde Tóth1-0/+3
text, also its preview in the dialog window, when the URL contains anchor at the end. Change-Id: Ibedb86238f660177b3dd476cd6a13f1ca5f05e12 Reviewed-on: https://gerrit.libreoffice.org/82654 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 79a1fafadb1ac54b8212bc164d8b85d798c74937) Reviewed-on: https://gerrit.libreoffice.org/83414 Tested-by: Jenkins
2019-11-20Resolves: tdf#128811 Alignment option "Distributed" not working in calcCaolán McNamara1-0/+2
Change-Id: I605b62ef0dfa29db93e4d7df8285a05a12bda8e3 Reviewed-on: https://gerrit.libreoffice.org/83271 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-20Options - Language Aid Dialog make usefull section namesandreas kainz1-230/+236
Change-Id: I1afc30d7d1a52e8b862bcbfb3632a193ee3253e6 Reviewed-on: https://gerrit.libreoffice.org/83129 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit fa1fa095039f0d4acdab6cf689a6637cb3019054) Reviewed-on: https://gerrit.libreoffice.org/83235 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-20Options - User Data Dialog labels left alignandreas kainz1-18/+48
Change-Id: If18abdb3e6d23ada149a9cfc7b2744db9ec3b5f8 Reviewed-on: https://gerrit.libreoffice.org/83124 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit ec93706a9eea072e25f5caad47505cb5293e7071) Reviewed-on: https://gerrit.libreoffice.org/83247 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-19tdf#125449 Fix custom gradient fill settings being lostGabor Kelemen1-2/+2
Change-Id: Ia2377274e0fc9da5873bf55735af25ed6ae3d65c Reviewed-on: https://gerrit.libreoffice.org/82393 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 53c474633c4e658f096669fb0225d751a5701aaf) Reviewed-on: https://gerrit.libreoffice.org/83186 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-19Paragraph Align Tab fixandreas kainz1-69/+52
Change-Id: Ied02b9db154bd007399b8b3d567d692d4973d382 Reviewed-on: https://gerrit.libreoffice.org/83040 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit bc9b046fbd1d68016ae6c53c990fce97b57eb663) Reviewed-on: https://gerrit.libreoffice.org/83058 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-19tdf#127927 Character Dialog effect preview Alignmentandreas kainz1-0/+2
Change-Id: If4bf99711b09c61d00dafb65ba76f4673c99246b Reviewed-on: https://gerrit.libreoffice.org/83019 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 52d0027332ecd9ea9d941113c7fbe66ebc3cf48a) Reviewed-on: https://gerrit.libreoffice.org/83057 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-18tdf#128257 Bullet and Numbering Dialogandreas kainz1-74/+63
Change-Id: I0931f7207e1533d6cb552cecbcf2872024f2bafe Reviewed-on: https://gerrit.libreoffice.org/82973 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 559fa1016928bf2bc1259f026a9a3d101a0131f0) Reviewed-on: https://gerrit.libreoffice.org/83009 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-18tdf#127807 Border Dialog updateandreas kainz1-507/+492
Change-Id: I35219c6c59d1bb6614ad1fa64cc0689f2019c986 Reviewed-on: https://gerrit.libreoffice.org/81115 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 6c4e6fc1d3a74c2840bf5a41ce1cde1debb07f24) Reviewed-on: https://gerrit.libreoffice.org/83014 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-18tdf#128721 Options -> View Dialog updateandreas kainz1-328/+375
Change-Id: I3e769846c1dd5d57e62276a624fb209ca6bd7673 Reviewed-on: https://gerrit.libreoffice.org/82473 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit 342a759dae8c58f2256e5aa92e1d27fd4a3601c7) Reviewed-on: https://gerrit.libreoffice.org/83011 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-18tdf#128725 Options Update Dialog changeandreas kainz1-209/+341
Change-Id: If0fa8dddfc0c431b89fad071388f3f9c4fcb40c7 Reviewed-on: https://gerrit.libreoffice.org/82475 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit cb1de02b1223ebe0f0e2b90c3ca5f5da630d5296) Reviewed-on: https://gerrit.libreoffice.org/83013 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-15Resolves: tdf#128802 manage dnd ourselfCaolán McNamara8-9/+63
instead of relying on the built-in dnd which is allowing toplevel entries to be dropped on other ones to become children of another entry, which is not what we want here. Change-Id: I8c5528d9b26e994b7eda9d2972af0b3783187f3e Reviewed-on: https://gerrit.libreoffice.org/82770 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-15Revert "tdf#126128 Reduce page properties dialog's height."Heiko Tietze8-300/+245
Discussion in BZ. This reverts commit 80109586e6cb6d3e2e0a53a9079c3125ec9b8368. Change-Id: I01e23a7eeaa78d60f106dfa67a54ff9d7904cb19 Reviewed-on: https://gerrit.libreoffice.org/82698 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 687c6761e84101f8a798ac7f622c2eab4f84d7b2) Reviewed-on: https://gerrit.libreoffice.org/82763 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-15Revert "ensure gtk creates a default label widget for the MenuButtons"Heiko Tietze3-6/+0
Discussion on BZ, have to revert this patch first. This reverts commit 3937d3d035a03530b78acc648c07b6e099fb6770. Change-Id: I8ab49e7296bc403f2706f986b2711025f468c4be Reviewed-on: https://gerrit.libreoffice.org/82699 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit d3756b274a23cb208ddd03de34a1312d4ada1a91) Reviewed-on: https://gerrit.libreoffice.org/82748
2019-11-15Options Dialog MSO Tab updateandreas kainz1-18/+32
Change-Id: I3bc0b2f5a42f6e01e0f78ef7d1b80a2bbe8ba7cc Reviewed-on: https://gerrit.libreoffice.org/82558 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com> (cherry picked from commit f7e53fe4912218afa531b2062431b6e20528ec54) Reviewed-on: https://gerrit.libreoffice.org/82743
2019-11-12Options Proxy Dialog updateandreas kainz1-1/+0
Change-Id: I6ec7b5588b9a5ba0120c8e81a248594b755426f1 Reviewed-on: https://gerrit.libreoffice.org/82478 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-12Options Save Dialog page updateandreas kainz1-5/+5
Change-Id: Ib0e8a9a8b1e9231f7d876a7e16ac1571b1bbdeba Reviewed-on: https://gerrit.libreoffice.org/82476 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-12Options Email Dialog fix alignment and paddingandreas kainz1-132/+141
Change-Id: I470d8fea036683c76badb856e2d6acc214734cb7 Reviewed-on: https://gerrit.libreoffice.org/82479 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-11Hyperlink Dialog Alignment similar in each tabandreas kainz4-18/+10
Change-Id: I670e94541e246ce8a71d2b45b598e924a43592a5 Reviewed-on: https://gerrit.libreoffice.org/82400 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-10About Dialog add 6px border as everywhere elseandreas kainz1-3/+4
Change-Id: Ic1cd5006bdaeb4e057aab145e9c511aabceda9a4 Reviewed-on: https://gerrit.libreoffice.org/82361 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-09tdf#128010: Don't ask to enable JRE when populating available scriptsMike Kaganski1-2/+10
It was user's intention to not use JRE, so omitting the JRE-dependent scripts in dialogs is just consistent with user's configuration. Change-Id: Ic551f5dd1d797fbaa2dc6d7e443e23d46b0ac5d3 Reviewed-on: https://gerrit.libreoffice.org/82353 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-09tdf#80731: Only check closing parenthesis when in IDEMike Kaganski2-8/+4
This reinstates the fix by Pierre Lepage, which was reverted in 351dead74b4c213b13102f81b5ae9bb47ad8ca39, and makes sure it only has effect when the compilation is started from IDE. The idea is that the IDE is used primarily for development, and that's a good opportunity to detect any error in the code. When the code is compiled from outside of the IDE (like running an extension), the error is tolerated to allow users run the legacy code having this error. Hopefully this is enough for tdf#106529. This re-uses comphelper's NoEnableJavaInteractionContext class, which is converted into general-purpose SetFlagContext class to avoid code duplication. Change-Id: Ie290019cb190b8d1d590699ec13bd63eac478d09 Reviewed-on: https://gerrit.libreoffice.org/81616 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-08Fix tdf#128004: Customize: chosen category does not filter function listMuhammet Kara4-3/+3
Change-Id: I69b1defda33f22c38377aed559147c880b292ed8 Reviewed-on: https://gerrit.libreoffice.org/82319 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-07tdf#127773 AutoCorrect Dialog Buttons on topandreas kainz2-5/+3
Change-Id: Ie26c2ef0abd126b6731eeb90100d27359bc77011 Reviewed-on: https://gerrit.libreoffice.org/82235 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06Text Animation Dialog updateandreas kainz1-195/+188
Change-Id: I260210400688ca47d3019d16a4ec0c7e12112de8 Reviewed-on: https://gerrit.libreoffice.org/82113 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05Connector Dialog updateandreas kainz1-0/+11
Change-Id: I16fd1c8b06c91c6d8dd88313756f8d85249e7236 Reviewed-on: https://gerrit.libreoffice.org/82063 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05Position Dialog updateandreas kainz2-9/+9
Change-Id: I2dcffd1d95e259e0c348aca037ba3c41e3b9b6ab Reviewed-on: https://gerrit.libreoffice.org/82048 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05line dialog alignment updateandreas kainz2-3/+5
Change-Id: I656885dfd158a114c5ec61551aedfb6c625c1971 Reviewed-on: https://gerrit.libreoffice.org/82046 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-04tdf#128257 Bullet Dialog update 2andreas kainz1-76/+49
Change-Id: Icf52eed719172960c3c7e0dc257f11e0b5f8eb4f Reviewed-on: https://gerrit.libreoffice.org/82037 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-03loplugin:stringaddNoel Grandin2-6/+4
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03tdf#127927 Writer Character Dialog Font Tab updateandreas kainz1-0/+11
Change-Id: I7f2b02393cdda40c07459a83c32d3ebf5569ef12 Reviewed-on: https://gerrit.libreoffice.org/81543 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-03tdf#128257 Bullet Dialog updateandreas kainz1-499/+515
Change-Id: I86414cbdef60663e72fe422adce081ae1ce6aaa5 Reviewed-on: https://gerrit.libreoffice.org/81144 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-03ensure gtk creates a default label widget for the MenuButtonsCaolán McNamara3-0/+6
removed by... commit 80109586e6cb6d3e2e0a53a9079c3125ec9b8368 Date: Fri Nov 1 20:33:09 2019 +0300 tdf#126128 Reduce page properties dialog's height. Change-Id: I03b960046657483deafc16a3819a9b8579fb9413 Reviewed-on: https://gerrit.libreoffice.org/81951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-03unnecessary forward declaresCaolán McNamara2-3/+0
Change-Id: I086340ef46c3a4663867c0d0c3d14f223209a4c6 Reviewed-on: https://gerrit.libreoffice.org/81952 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02New loplugin:conditionalstringStephan Bergmann1-1/+1
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3 Reviewed-on: https://gerrit.libreoffice.org/81946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>