summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2019-10-14loplugin:stringadd look for unnecessary temporariesNoel Grandin2-2/+3
which defeat the *StringConcat optimisation. Also make StringConcat conversions treat a nullptr as an empty string, to match the O*String(char*) constructors. Change-Id: If45f5b4b6a535c97bfeeacd9ec472a7603a52e5b Reviewed-on: https://gerrit.libreoffice.org/80724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-13move ToolBoxButtonSize into vclenumCaolán McNamara1-1/+1
Change-Id: I684d192296642bc507a6f75dd52a5ce72b028157 Reviewed-on: https://gerrit.libreoffice.org/80721 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-13rename FontPrevWindow back to SvxFontPrevWindowCaolán McNamara2-2/+2
Change-Id: Ife6f7bbc64f397e502d50c629769a8b637a591c8 Reviewed-on: https://gerrit.libreoffice.org/80718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-11Resolves: tdf#123265 hide show-icons under gtk3Caolán McNamara3-40/+68
because there the menus are native gtk menus and follow the global gtk settings for showing icons Change-Id: Id1d679ce12cc031289b73aa7e91f9c16f8db8c0c Reviewed-on: https://gerrit.libreoffice.org/80649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-10Picture can be in anonymous namespaceCaolán McNamara1-18/+21
Change-Id: I484443e70b6465a98851aede32df1975d55d75d0 Reviewed-on: https://gerrit.libreoffice.org/80604 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09this dialog should be modalCaolán McNamara1-4/+5
Change-Id: Id0d0ebea15bd8f6f842927391ea09b18870cdbf9 Reviewed-on: https://gerrit.libreoffice.org/80559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09name all Notebooks 'tabcontrol'Caolán McNamara2-2/+2
Change-Id: I5159ed77c2b3ba2f06e381a738a49dbe17a6a4dd Reviewed-on: https://gerrit.libreoffice.org/80542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09Related: tdf#123765 fix up some screenshottingCaolán McNamara8-14/+84
and add in two special cases for the mentioned cui dialogs Change-Id: Ibd2bf8e9e5bff131f2c009c784652f4500842326 Reviewed-on: https://gerrit.libreoffice.org/80488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09no need to include vcl.dialog here anymoreCaolán McNamara2-1/+1
Change-Id: Ic902f09be90ec3989a20333a13562b3af679ff92 Reviewed-on: https://gerrit.libreoffice.org/80489 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-08Resolves tdf#127903 - Allow customization with equal keyHeiko Tietze1-2/+10
Change-Id: Ie5e1fc23412d13a868e021addb0de47d9e84f80b Reviewed-on: https://gerrit.libreoffice.org/80436 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-08implement gtk dialog screenshottingCaolán McNamara5-88/+44
Change-Id: If4e570f775bd1e29dfb75cb7e5dd9d9dfc35e654 Reviewed-on: https://gerrit.libreoffice.org/80416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-08Tip of the day randomizedHeiko Tietze1-192/+185
Necessary because of serial presentation after I69b72b80d6d6afa25a1c4f01fa05bc60b5741db8 Change-Id: I26d2a08442b91c11ec7d9c4addaaad764e7f3ba9 Reviewed-on: https://gerrit.libreoffice.org/80371 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-08loplugin:redundantpointerops simplify *p.get()Noel Grandin2-4/+4
Change-Id: I12517651fb3f777fd08e384992bb3e84b340ad85 Reviewed-on: https://gerrit.libreoffice.org/80382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07use FileDialogHelper which is able to set parent easilyCaolán McNamara1-9/+15
Change-Id: I0389311323175fbbc58ee0b9fbb6353061b21e2f Reviewed-on: https://gerrit.libreoffice.org/80395 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07weld ScreenshotAnnotationDlgCaolán McNamara5-163/+178
Change-Id: I94e42c1d10922170f53af917bba6848c9f006a11 Reviewed-on: https://gerrit.libreoffice.org/80383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07drop comment referencing ModalDialogCaolán McNamara1-1/+1
Change-Id: I887b0371309a897848eed5d72c55458f78ed1f68 Reviewed-on: https://gerrit.libreoffice.org/80361 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-06Related: tdf#127935 set default activate handler to toggle row expansionCaolán McNamara40-66/+61
Change-Id: I2bbfb1445b8d2e748f642cdf4723d41b7f072e2b Reviewed-on: https://gerrit.libreoffice.org/80305 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-06improve SfxPoolItem operator== implementationsNoel Grandin3-11/+6
(*) make them all call the superclass operator== (*) make the base class check which and typeid to ensure we are only comparing the safe subclasses together (*) remove a couple of operator== that were not doing anything useful Change-Id: Ia6234aed42df04157a5d6a323dc951916a9cb316 Reviewed-on: https://gerrit.libreoffice.org/80308 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05tdf#127935 Make double click expand/collapse entry in option treeJim Raykowski2-0/+10
Also makes keyboard use to expand/collapse work Change-Id: I5b9d065ebe4a612ebe9658feb9ff71c504de7982 Reviewed-on: https://gerrit.libreoffice.org/80173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05Convert SID_PAPER_START/END to SfxUInt16ItemNoel Grandin1-3/+3
Change-Id: I62067075853b1d5c893c14d72a247b07a3cc5585 Reviewed-on: https://gerrit.libreoffice.org/80248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Convert SID_ENUM_PAGE_MODE to SfxUInt16ItemNoel Grandin1-2/+2
Change-Id: I5cffa31b45b7752ba3ff18c8a92da9766fcf8de6 Reviewed-on: https://gerrit.libreoffice.org/80241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05use SfxUInt16Item for SID_ATTR_TRANSFORM_SIZE_POINTNoel Grandin2-2/+2
Change-Id: Id7762047a17a1652c91761d3c910eadd3393040b Reviewed-on: https://gerrit.libreoffice.org/80237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-04drop unnecessary includesCaolán McNamara2-2/+0
Change-Id: I2d6828734cfdf795499d54e1b1e8ba9fc4b5a4d1 Reviewed-on: https://gerrit.libreoffice.org/80197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04button icons are always left align not top changedandreas kainz1-1/+0
Change-Id: I28156de7d9adc74b02bfcecec82f282b7b1a35bf Reviewed-on: https://gerrit.libreoffice.org/79593 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-04use SfxUInt16Item for SID_METRIC_ITEMNoel Grandin1-2/+2
because we aren't using the array of values in SfxAllEnumItem Change-Id: I67ccb7737c52f9949495c53881e052d5005882aa Reviewed-on: https://gerrit.libreoffice.org/80165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-03drop some unnecessary includesCaolán McNamara1-3/+1
Change-Id: I656ed2e29988fe47e4db8fa2ea8edec022bd56c2 Reviewed-on: https://gerrit.libreoffice.org/80098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02update cui pchCaolán McNamara1-49/+45
Change-Id: Ia14ed249615417248a8c784b5aa2cbb46c008084 Reviewed-on: https://gerrit.libreoffice.org/80063 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02drop some unnecessary includesCaolán McNamara1-5/+1
Change-Id: Ibbf459284a1555ad8ff836a610901844c82a6871 Reviewed-on: https://gerrit.libreoffice.org/80062 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02tdf#127711 - A runtime-switch for the MiniCrashDumpJuergen Funk2-2/+6
- in soffice.ini (sofficerc) the entry "CrashDumpEnable" default is "true" - when false then the Dump.ini and the dump-file are not written - when the switch --disable-crashdump is set, then the switch "CrashDumpEnable" set to "false" - when the entry "CrashDumpEnable" is missing, in this case is the default true, too - the checkbox under Options-General "Send crash reports to ..." is deactive and shows off (only view, not change the config) - when set the environment variable "CRASH_DUMP_ENABLE" to any char then the switch "CrashDumpEnable=false" are overrules with true and the Dump.ini and dump-file are write Change-Id: I34e7795640eb95d111e18b0ad46ec67b2c126b19 Reviewed-on: https://gerrit.libreoffice.org/79273 Tested-by: Jenkins Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-10-01remove empty GtkSizeGroupsCaolán McNamara2-2/+0
Change-Id: I848fc4a9f97b4cc7cd5243bcf328fb6f8fbdd5be Reviewed-on: https://gerrit.libreoffice.org/79861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01loplugin:loopvartoosmall (clang-cl)Stephan Bergmann1-5/+7
Change-Id: I682fccecd94d1d1524fcb12e93f5d53b0c94ea03 Reviewed-on: https://gerrit.libreoffice.org/79935 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:stringconstant (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Id1a82cea4444255fdb693e126b7571a406094624 Reviewed-on: https://gerrit.libreoffice.org/79916 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01Resolves tdf#127756 - Tip of the day not localizedHeiko Tietze2-42/+54
Introduced %LANGUAGENAME token being replaced with BCP47 for pt, en, zh or ISO otherwise Change-Id: Iaa7168731e0f6a8e0dd1e906ff0ef646534d9f4b Reviewed-on: https://gerrit.libreoffice.org/79564 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-01add activates_default to GtkEntries in dialogsCaolán McNamara10-36/+70
activates-default of True means pressing return activates the default button of the action area, which is typically what vcl Edit did by default. Change-Id: I60bc1634b04a486af86526d887d0ada961b08076 Reviewed-on: https://gerrit.libreoffice.org/79860 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01autocorrect dialog width grows on change of new to replaceCaolán McNamara2-9/+10
the sizegroup isn't working as I'd expect, so just make the replace button visible, get the preferred width of the buttonbox, lock that down then hide the place button and the container will stay at the max width that will be wanted Change-Id: Idfe632aa5af404abb92fc8f7267f0dda5cdbe295 Reviewed-on: https://gerrit.libreoffice.org/79862 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-01loplugin:stringadd in basctl..cuiNoel Grandin6-12/+6
Change-Id: I2fdeb7eb3ead3512ad6d3fe793305038ab3aa7ae Reviewed-on: https://gerrit.libreoffice.org/79886 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-01Removed duplicated includesAndrea Gelmini1-2/+0
Change-Id: Ic195353d4750895d0884ac1dec3dca136ab48155 Reviewed-on: https://gerrit.libreoffice.org/79885 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-09-30weld CuiAboutConfigTabPageCaolán McNamara6-350/+398
Change-Id: I7bc83277503b7981b05fd358b0fd68e19d8232ae Reviewed-on: https://gerrit.libreoffice.org/79819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-30Resolves: tdf#127450 max_content_[width|height] isn't available in gtk 3.18Caolán McNamara1-2/+0
so this crashes Change-Id: Ie9b2607e4c4290f9745b8bc5f36b80d8970018b1 Reviewed-on: https://gerrit.libreoffice.org/79875 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-30drop gtk2 supportCaolán McNamara2-3/+3
Change-Id: Ie838cabfecfef7e3225c1555536d5c9cf3b43f15 Reviewed-on: https://gerrit.libreoffice.org/77405 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-30return should activate okCaolán McNamara1-0/+1
Change-Id: Id9bfa9badb6b4661d6ad4c0a04323c60c4a3c749 Reviewed-on: https://gerrit.libreoffice.org/79845 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-29drop some unnecessary includesCaolán McNamara1-2/+1
Change-Id: I2ea014aab7463d7127df73a6efba0e06270bd756 Reviewed-on: https://gerrit.libreoffice.org/79755 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-29constmethod for accessor-type methodsNoel Grandin1-4/+4
Apply the constmethod plugin, but only to accessor-type methods, e.g. IsFoo(), GetBar(), etc, where we can be sure of that constifying is a reasonable thing to do. Change-Id: Ibc97f5f359a0992dd1ce2d66f0189f8a0a43d98a Reviewed-on: https://gerrit.libreoffice.org/74269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-27add translator comments to [L] [S]Caolán McNamara1-4/+4
Change-Id: Id4943a906fe412aab2250fc7ddbc5fb34fa669f7 Reviewed-on: https://gerrit.libreoffice.org/79722 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27cid#1453996 Unchecked return valueCaolán McNamara1-4/+3
Change-Id: I0b5010aec8ad941d662e851833923a8b6b0a383d Reviewed-on: https://gerrit.libreoffice.org/79672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27Deduplicate O(U)StringNumber definitions; add toAsciiUpperCaseMike Kaganski1-3/+3
Change-Id: I00e7ce62940907b5f4efc2b7f23f355c3e43ed6b Reviewed-on: https://gerrit.libreoffice.org/79686 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-27cid#1453994 Uninitialized pointer fieldCaolán McNamara1-8/+0
Change-Id: Ife94e1e8861f108cd6db54694232c7686f47dc6e Reviewed-on: https://gerrit.libreoffice.org/79671 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27Fix Typo SvxMenuConfigPage -> SvxConfigPageStephan Bergmann1-1/+1
...introduced with ccb2b0078f07194befa61f1e3fd88e53ff236871 "weld SvxMenuConfigPage/SvxToolbarConfigPage", causing -fsanitize=dynamic-type- mismatch during UITest_writer_demo: > include/tools/link.hxx:163:10: runtime error: downcast of address 0x613000204b40 which does not point to an object of type 'SvxMenuConfigPage' > 0x613000204b40: note: object is of type 'SvxConfigPage' > 83 01 00 4e b0 a1 bb 2e f6 7f 00 00 20 c4 56 00 e0 60 00 00 50 f8 a4 00 40 60 00 00 e8 49 38 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SvxConfigPage' > #0 in SvxMenuConfigPage* tools::detail::castTo<SvxMenuConfigPage*, SvxConfigPage*>(SvxConfigPage*) at include/tools/link.hxx:163:10 > #1 in SvxConfigPage::SvxConfigPage(weld::Container*, weld::DialogController*, SfxItemSet const&) at cui/source/customize/cfg.cxx:997:41 [...] Change-Id: Ie36ebabd3075cade590cc504fb06b5319b346dcf Reviewed-on: https://gerrit.libreoffice.org/79666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27cid#1453993 Unchecked return valueCaolán McNamara1-1/+3
Change-Id: Ie30e1b40b8867246c793294b7b34b38a86f9ad01 Reviewed-on: https://gerrit.libreoffice.org/79670 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26TODO rename to GetFrameWeldCaolán McNamara29-111/+111
Change-Id: I28527b6773075fe682682a4812cf86bb7ac13180 Reviewed-on: https://gerrit.libreoffice.org/79560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-20 08:12:23 +0000