summaryrefslogtreecommitdiff
path: root/cui/source
AgeCommit message (Collapse)AuthorFilesLines
2017-07-19Separate SvxMenuConfigPage from cfg.cxxMuhammet Kara4-457/+669
Change-Id: I6e56756628bbbf3900f946715ce8b95bbe78ae03 Reviewed-on: https://gerrit.libreoffice.org/39341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 091a7f474adac69b1808e5c812952586d253a809) Reviewed-on: https://gerrit.libreoffice.org/39956
2017-07-19Favourites feature in Special charactersAkshay Deep4-5/+247
Change-Id: I8273b95132d48a51e841ec3792139007b4e7b55a Reviewed-on: https://gerrit.libreoffice.org/39752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-18remove unused CntWallpaperItemCaolán McNamara1-1/+0
Change-Id: I47cf9fc37bb64a80a21ed805bff2bb3ac3eb6da5 Reviewed-on: https://gerrit.libreoffice.org/40148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-18Change nonsense non-const Date* GetNullDate() to const Date&Eike Rathke1-2/+2
* first, a non-const Date* may leave the impression that one could change the NullDate through the pointer, which is only partly successful; luckily no one did that * second, there is always a NullDate so checking for nullptr is superfluous * third, the pointer was dereferenced (maybe after a check) everywhere to obtain the NullDate, luckily.. Change-Id: I3c3a788ba0336596ac6bde4c96e77a0cdb7a4a95
2017-07-18merge last entry of cntids.hrc into sfxsids.hrcCaolán McNamara1-1/+0
Change-Id: I78ba63d5d455ef9fe2e4c6cf2f67d88c921100d1 Reviewed-on: https://gerrit.libreoffice.org/40143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-18SID_VIEW_FLD_PIC looks like a StarOffice < 6.0 holdoverCaolán McNamara2-139/+0
that can't exist anymore Change-Id: If94801fe854bc8ccf4307fce2674944f63e95d4c Reviewed-on: https://gerrit.libreoffice.org/40142 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-15tdf#109103 Non-standard font color in About dialogheiko tietze1-13/+0
Wallpaper in dialogs with fix font colors isn't a good idea Change-Id: Ie97ebe6fd7ed3a52bcdc78204d7190b0e5683eb3 Reviewed-on: https://gerrit.libreoffice.org/39990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-07-14tdf#96505 Get rid of cargo cult "long" integer literalsIvan Safonov7-41/+41
Remove unnecessary "Long" literals in cui/source/tabpages. Change-Id: Ia46cc027e2225ab7dcfdab2828f1fb4a60f4619a Reviewed-on: https://gerrit.libreoffice.org/39881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-13Reorganize Scheduler priority classesJan-Marek Glogowski1-1/+0
This is based on glibs classification of tasks, but while glib uses an int for more fine grained priority, we stay with our enum. 1. Timers start with DEFAULT priority, which directly corresponds with the previous HIGH priority 2. Idles start with DEFAULT_IDLE priority instead of the previous HIGH priority, so idle default becomes "really run when idle". As RESIZE and REPAINT are special, and the DEFAULTS are set, there is just one primary decision for the programmer: should my idle run before paint (AKA HIGH_IDLE)? If we really need a more fine-grained classification, we can add it later, or also switch to a real int. As a result, this drops many classifications from the code and drastically changes behaviour, AKA a mail merge from KDE is now as fast as Gtk+ again. Change-Id: I498a73fd02d5fb6f5d7e9f742f3bce972de9b1f9
2017-07-13loplugin:oncevar: empty strings: cuiStephan Bergmann3-6/+3
Change-Id: Id00cf5f78ef59520065587691c85f2e1a7e96a9c
2017-07-13use more OUString::operator== comphelper..cuiNoel Grandin13-43/+43
Change-Id: Ib5f3037249152be2b66acf347d1a0c236dc7adfa Reviewed-on: https://gerrit.libreoffice.org/39888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-11simplify calls OUString::copy in foo.copy(x, foo.getLength() - x)Noel Grandin2-5/+5
Change-Id: I20318c77dcc3bc2a64336541ef5a3f412bfd9483 Reviewed-on: https://gerrit.libreoffice.org/39803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10simplify some OUString compareTo callsNoel Grandin1-1/+1
to either startsWith or == or != Change-Id: Ie4b4662f5b8e4532cbc1ab36910389e0b3d41ef0 Reviewed-on: https://gerrit.libreoffice.org/39750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10teach unnecessaryparen loplugin about identifiersNoel Grandin3-15/+15
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-08Related tdf#108925: Use 5% steps for relative size number fieldTamás Zolnai1-0/+1
Change-Id: Ieb89a2e69ae44fe1cfbe99e843239cf25e97463a Reviewed-on: https://gerrit.libreoffice.org/39712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-07-07tdf#108925: Too small bullet size confuses the userTamás Zolnai1-0/+1
Add a constraint for bullet relative size to avoid too small bullets which are hardly recognizable. Use the same 25% lower limit what MSO uses. Change-Id: Id956ecf3ec831c569188b944be58da03bf30a55e Reviewed-on: https://gerrit.libreoffice.org/39696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-07-07loplugin:unnecessaryparen handle parens inside call exprNoel Grandin1-1/+1
stick to single-arg function calls, sometimes parens in multi-arg calls might be there for clarity Change-Id: Ib80190c571ce65b5d219a88056687042de749e74 Reviewed-on: https://gerrit.libreoffice.org/39676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06GSoC: Recent Charaters Toolbar Dropdown ControlAkshay Deep3-270/+1
Change-Id: Ib04d26fa5556e5c32db6799c16d0bbedc45504ec Reviewed-on: https://gerrit.libreoffice.org/38944 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-06use more begin()/end() for SequenceNoel Grandin2-6/+4
Change-Id: I399be6b6ef7a6ce01e883569a177c0969bc29c69
2017-07-05new loplugin unnecessaryparenNoel Grandin1-2/+2
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec Reviewed-on: https://gerrit.libreoffice.org/39549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:unusedfields in cui..idlNoel Grandin7-23/+15
Change-Id: Icb393cc0b2f79ded154e186ab6975b95e5126903 Reviewed-on: https://gerrit.libreoffice.org/39496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:unusedfields in sfx2Noel Grandin1-2/+0
Change-Id: I9f57545ca4ee5159a095f9b35267d298ccc7fb4e Reviewed-on: https://gerrit.libreoffice.org/39476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04loplugin:casttovoidStephan Bergmann2-6/+2
...cases that were initially missed due to the broken containsProcessingConditionalInclusion() Change-Id: Ib7d801ab5173ee590ef35a9e075d3ce4d4aa06da
2017-07-04loplugin:casttovoid in VCL_BUILDER_DECL_FACTORYStephan Bergmann5-8/+5
Change-Id: I4b0dd08963cf50daa41901975c6f92fe21db2048
2017-07-02loplugin:casttovoid: cuiStephan Bergmann6-28/+13
Change-Id: Id8c4baf8c22cde50c22e4dcbcb475d78294baf5d
2017-07-02nMinPasswdLen is "currently not supported" ever sinceStephan Bergmann3-8/+5
...the code's introduction with 7cd3ea794099e257d99748908855e61aa9df89eb "#i109634# password to open/modify dialog", and demonstrated to be always passed in as 0 with 673b436c3592c5747f3dce4947168d6fa3ba45ea "loplugin:constantparam in vcl" Change-Id: Ic7eee77b114f39a0c016148e9176f58dcfc53ebc
2017-06-30Hexcode amd decimal code should be updated while switching to recent viewAkshay Deep1-0/+17
Change-Id: Iecde38cf076a5c3d862912ff042bd51864b89a0c Reviewed-on: https://gerrit.libreoffice.org/39401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>
2017-06-28Use SvTreeListBox's own method: RemoveEntryMuhammet Kara1-1/+1
Change-Id: I3d0c605450dc2b847ac3fa46b9d050720a7a1a03 Reviewed-on: https://gerrit.libreoffice.org/39350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr> (cherry picked from commit 8cf31f15b3c8af2c5453c980e23cfc31cf34f519) Reviewed-on: https://gerrit.libreoffice.org/39372
2017-06-28Implement search feature in the Kayboard tabMuhammet Kara2-31/+109
of the Customize dialog. Once you type a search term in the box, non-matching functions are filtered out in the current category. The filter operation takes place, and updates as you type. If user changes category while there is still a search term in the box, the filter is also applied to the newly selected category. Change-Id: I5ef086af60e0f339af6a113fa6a52555d4f765d9 Reviewed-on: https://gerrit.libreoffice.org/38814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 3667beb986e8c03c925566a585b0504c7943fede) Reviewed-on: https://gerrit.libreoffice.org/39356 Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-06-26Fix typosAndrea Gelmini2-3/+3
Change-Id: I2ce725f87ee6f8ebcffbac268cc7e7f8850023e5 Reviewed-on: https://gerrit.libreoffice.org/39232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-23silence some unique_ptr warningsCaolán McNamara1-8/+14
Change-Id: Ibf3a8d00e8b91be79117d9c060b4cb2a7bafe651
2017-06-23loplugin:unusedfields in cuiNoel Grandin43-181/+14
Change-Id: I6d3ef43ab915d65794f1052f1f184eda10d39e1a Reviewed-on: https://gerrit.libreoffice.org/39136 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-22Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: Ibbd83a7d69a27ab96b99d28e1d4a1f65af63b82f Reviewed-on: https://gerrit.libreoffice.org/39037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-21loplugin:unusedfields in svtoolsNoel Grandin2-3/+0
Change-Id: Ic8f67d40825d9843fd57535bd61bef51b470a8be Reviewed-on: https://gerrit.libreoffice.org/39016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21loplugin:unusedfields in svx part2Noel Grandin2-51/+6
Change-Id: Ie9fd55b71a152f428a397d9917918f0e9de39aaf Reviewed-on: https://gerrit.libreoffice.org/39014 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21loplugin:unusedfields in svx part1Noel Grandin1-1/+0
Change-Id: I6621e0dda5a5dc3e68c7b1613975c075e2879912 Reviewed-on: https://gerrit.libreoffice.org/39006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21convert ErrCode to strong typedefNoel Grandin2-3/+3
would have preferred to re-use o3tl::strong_int, of which this is a modified copy, but there are lots of convenience accessors which are nice to define on the class. Change-Id: I301b807aaf02fbced3bf75de1e1692cde6c0340a Reviewed-on: https://gerrit.libreoffice.org/38497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21Resolves: tdf#105740 select without selecting.. tdf#101588 b0rkEike Rathke2-6/+7
The initial color, if determined, must result in being selected. Differentiate between pre-selected and user-selected. Regression of commit 429be969b39867d6d9f36978c9ac15b601e78ba6 Date: Mon Dec 12 21:24:20 2016 +0100 Change-Id: I928af131d03c61a8e474e5cd356aea8b766112fa
2017-06-20loplugin:oncevar in cuiNoel Grandin20-71/+32
Change-Id: I1bbd37a82f238327b5e52110c62cdd2a9b0a9c14 Reviewed-on: https://gerrit.libreoffice.org/39001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-19Fix screenshot missing quotes in code snippetOlivier Hallot1-5/+5
The code snippet suggested has no quotes in atttributes values. Change-Id: I604fb34827da3bebf3f6759b491d719a96854754 Reviewed-on: https://gerrit.libreoffice.org/38893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-19GSoC: Glyph View and Recent Characters Control in Special Characters dialogAkshay Deep5-202/+598
Change-Id: Ia55f3fefe7c14327cff2e996ab0038dc52f9b017 Reviewed-on: https://gerrit.libreoffice.org/37496 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-19Make SfxItemSet ranges correct by construction: Fix static casesStephan Bergmann1-14/+19
...with the aid of an extended compilerplugins/clang/store/sfxitemsetrewrite.cxx (which in turn needed a small addition to compilerplugins/clang/check.hxx). Enable svl::detail::validGap check for the static case, but keep it disabled for now for the dynamic case. Change-Id: I4846ba8e99aff94a86518e2cb5044e575093386e
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke3-3/+0
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-16Make SfxItemSet ranges correct by constructionStephan Bergmann6-32/+26
This is a follow-up to 45a7f5b62d0b1b21763c1c94255ef2309ea4280b "Keep WID ranges sorted, and join adjacent ones". While SfxItemSet::MergeRange relies on the m_pWhichRanges being sorted (and, under DBG_UTIL, asserts if they are not), the various SfxItemSet constructors curiously only check (via assert or DBG_ASSERT) that each individual range has an upper bound not smaller than its lower bound. Arguably, all SfxItemSet instances should fulfill the stronger guarantees required and checked by MergeRange. And in many cases the ranges are statically known, so that the checking can happen at compile time. Therefore, replace the two SfxItemSet ctors taking explicit ranges with two other ctors that actually do proper checking. The (templated) overload taking an svl::Items struct should be used in all cases where the range values are statically known at compile time, while the overload taking a std::initializer_list<Pair> is for the remaining cases (that can only do runtime checking via assert). Most of those latter cases are simple cases with a single range covering a single item, but a few are more complex. (At least some of the uses of the existing SfxItemSet overload taking a const sal_uInt16* pWhichPairTable can probably also be strengthened, but that is left for another day.) This commit is the first in a series of two. Apart from the manual changes to compilerplugins/clang/store/sfxitemsetrewrite.cxx, include/svl/itemset.hxx, and svl/source/items/itemset.cxx, it only consists of automatic rewriting of the relevant SfxItemSet ctor calls (plus a few required manual fixes, see next). But it does not yet check that the individual ranges are properly sorted (see the TODO in svl::detail::validGap). That check will be enabled, and the ensuing manual fixes will be made in a follow-up commit, to reduce the likelyhood of accidents. There were three cases of necessary manual intervention: * sw/source/core/unocore/unostyle.cxx uses eAtr of enum type RES_FRMATR in braced-init-list syntax now, so needs explicit narrowing conversion to sal_uInt16. * In sw/source/uibase/uiview/formatclipboard.cxx, the trailiing comma in the definition of macro FORMAT_PAINTBRUSH_FRAME_IDS needed to be removed manually. * In svx/source/svdraw/svdoashp.cxx, svx/source/svdraw/svdotext.cxx, sw/source/uibase/app/docstyle.cxx, sw/source/uibase/shells/frmsh.cxx, sw/source/uibase/shells/grfsh.cxx, and sw/source/uibase/shells/textsh1.cxx, some comments had to be put back (see "TODO: the replaced range can contain relevant comments" in compilerplugins/clang/store/sfxitemsetrewrite.cxx). A few uses of the variadic form erroneously used nullptr instead of 0 for termination. But this should have been harmless even if promoted std::nullptr_t is larger than promoted sal_uInt16, assuming that the part of the nullptr value that was interpreted as sal_uInt16/promoted int was all-zero bits. Similarly, some uses made the harmless error of using 0L instead of 0. Change-Id: I2afea97282803cb311b9321a99bb627520ef5e35 Reviewed-on: https://gerrit.libreoffice.org/38861 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-06-14use ERRCODE_NONE instead of 0Noel Grandin3-3/+3
peeling off a small chunk of my ErrCode strong_int conversion Change-Id: Idc89e8496083beed7608cba705cd981139eb7111 Reviewed-on: https://gerrit.libreoffice.org/38777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-14Let CreateItemSet return unique_ptrStephan Bergmann2-19/+23
...and address resulting loplugin:useuniqueptr Change-Id: Ia79eb8d59ce5092b2d93b656eab687096baedf17
2017-06-13Use unique_ptr for SvxHpLinkDlg::mpItemSetStephan Bergmann2-5/+11
Change-Id: I6ad2669afe3853196bb1fce9c7c81af640831116
2017-06-13remove TDE integration (vclplug, address book, config backend)Michael Stahl1-8/+0
It has ~no users, can't even be built on modern Linuxes, and it annoys folks who want to refactor VCL. Per ESC decision from 2017-06-08, remove --enable-tde and --enable-tdeab. Change-Id: I51ce4786f29f8fcac2e2bb2a654c41fbfbbd8afd Reviewed-on: https://gerrit.libreoffice.org/38718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-12Get rid of last remainders of SetPos nonsenseKatarina Behrens4-18/+3
Change-Id: I6ebff09322e40adfc616a9003424fd1d4ff748ce Reviewed-on: https://gerrit.libreoffice.org/38629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-12cleanup unused css/frame/* includesJochen Nitschke10-13/+3
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>