summaryrefslogtreecommitdiff
path: root/cui/source
AgeCommit message (Collapse)AuthorFilesLines
2017-11-28Use SfxModalDialog class as Hyperlink dialog's basePranav Kant2-2/+3
Change-Id: I1f592fdb5825896ad8fbe55c182936ed4ed98efc
2017-08-11Resolves: tdf#62702 allow ole objects to be inserted as iconsCaolán McNamara2-0/+17
under windows on "create new", "further objects" you get the native windows insert object dialog which has the "Display As Icon" option, but on Linux etc (or using our own dialog) there isn't that option so add a "Display as icon" checkbox in our own dialog and generate an icon through SvFileInformationManager::GetImage Change-Id: I0a400189031900bd1e387465ec4ba57847cb5394 (cherry picked from commit f505f95d466d4d3348f41dfd93e5c243d15c6c71) Reviewed-on: https://gerrit.libreoffice.org/41021 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2017-08-11tdf#109863: use SID_PATTERN_LIST after bitmap tab convertingJulien Nabet1-1/+1
instead of SID_BITMAP_LIST Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=76585ae33f3ca75c05c0ccbf6a621b6e2d42bc00 Change-Id: I880ca149d5865ed5b80c57d7c5b390cc5606d66c Reviewed-on: https://gerrit.libreoffice.org/40798 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-on: https://gerrit.libreoffice.org/40806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 7529bbb238e932a35e5790a038e3cb6af4493393)
2017-07-31Resolves: tdf#109289 add SvxColorListBox::IsValueChangedFromSavedCaolán McNamara2-15/+21
and remove PushButton::IsValueChangedFromSaved (cherry picked from commit 39fd7e97c253153a10161ef3694b64e90e65e80a) Related: tdf#109289 move PushButton::IsValueChangedFromSaved to consumer inheriting the IsValueChangedFromSaved from PushButton has allowed undesirable behaviour to be selected (cherry picked from commit 247607727986df0fd0fef198459eb6646e056ea3) Change-Id: Ib1c51e27fd708c5d4811c90ef5659b4d55dd8860 fccb1657d2565005e6f9e239c6118f2e5ae7970c Reviewed-on: https://gerrit.libreoffice.org/40486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit d747a00f550cc8556e29b29b08c57f84afb4078f)
2017-07-12Resolves: tdf#105740 select without selecting.. tdf#101588 b0rkcp-5.3-19Eike Rathke2-6/+7
The initial color, if determined, must result in being selected. Differentiate between pre-selected and user-selected. Regression of commit 429be969b39867d6d9f36978c9ac15b601e78ba6 Date: Mon Dec 12 21:24:20 2016 +0100 Change-Id: I928af131d03c61a8e474e5cd356aea8b766112fa (cherry picked from commit aee66aa85e75f67135e5c6079a281e18402d261a) Reviewed-on: https://gerrit.libreoffice.org/39026 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 1096d1c237a2c4fc7497dd073d0f62bb01ffe925)
2017-07-08tdf#108925: Too small bullet size confuses the userTamás Zolnai1-0/+1
Add a constraint for bullet relative size to avoid too small bullets which are hardly recognizable. Use the same 25% lower limit what MSO uses. Reviewed-on: https://gerrit.libreoffice.org/39696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 11652be4071ef6d1d89b2c397aa1a32476e03bf6) Change-Id: Id956ecf3ec831c569188b944be58da03bf30a55e Reviewed-on: https://gerrit.libreoffice.org/39708 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-06-21Fix screenshot missing quotes in code snippetOlivier Hallot1-5/+5
The code snippet suggested has no quotes in atttributes values. Change-Id: I604fb34827da3bebf3f6759b491d719a96854754 Reviewed-on: https://gerrit.libreoffice.org/38895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 4be3f2b3a9294c22de68b586d84328ec08906b84)
2017-05-30tdf#107877: Don't crash if all bitmaps are deletedXisco Fauli1-12/+20
Change-Id: Ie21f8cf1ead7c75017ee09436102f87f5d5dc04c Reviewed-on: https://gerrit.libreoffice.org/37673 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 9d55ce72b69934d17360142f88a699397e0aa41f) Reviewed-on: https://gerrit.libreoffice.org/37724 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 221de7cfdb6c6b6a4879162652bf842c4358f9eb)
2017-05-22tdf#107811: expert config, deal no parent caseJulien Nabet1-0/+6
bt part: 3 0x00007ffff73c7ee2 in __GI___assert_fail (assertion=0x7ffff7ba5107 "false", file=0x7ffff7ba4ef8 "/home/julien/lo/libreoffice/sal/rtl/strtmpl.cxx", line=1399, function=0x7ffff7ba6d00 <rtl_uString_newFromSubString::__PRETTY_FUNCTION__> "void rtl_uString_newFromSubString(rtl_uString**, const rtl_uString*, sal_Int32, sal_Int32)") at assert.c:101 4 0x00007ffff7b6a28b in rtl_uString_newFromSubString (ppThis=0x7ffffffef1b0, pFrom=0x55555e122230, beginIndex=1, count=-2) at /home/julien/lo/libreoffice/sal/rtl/strtmpl.cxx:1399 5 0x00007fffa6e69136 in rtl::OUString::copy (this=0x7ffffffef1f8, beginIndex=1, count=-2) at /home/julien/lo/libreoffice/include/rtl/ustring.hxx:2223 6 0x00007fffa6fed67b in CuiAboutConfigTabPage::InsertEntry (this=0x55555bda0b20, pEntry=0x55555e13eb40) at /home/julien/lo/libreoffice/cui/source/options/optaboutconfig.cxx:874 7 0x00007fffa6fed415 in CuiAboutConfigTabPage::SearchHdl_Impl (this=0x55555bda0b20) at /home/julien/lo/libreoffice/cui/source/options/optaboutconfig.cxx:848 Change-Id: Id9d1003a0e5e52abb878229e710e3fd4612789a1 Reviewed-on: https://gerrit.libreoffice.org/37568 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 8aee79e35208dd263928d7f5daa3f931fd3de99d) Reviewed-on: https://gerrit.libreoffice.org/37570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 24201323b6f25f62947d5e788e8444993920472c)
2017-05-16fix gdi resource leak with unreleased virtual deviceJulien Nabet1-1/+1
(copycat Markus https://cgit.freedesktop.org/libreoffice/core/commit/?id=289711c2a469bfbe06aef3b3870b65f9c788f56d) Change-Id: I3974609559dd44257d7c3e9e9544348d622953f6 Reviewed-on: https://gerrit.libreoffice.org/37586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 11c4cc15fdd491e15ffd4e7d9fb5d4082898f926) Reviewed-on: https://gerrit.libreoffice.org/37591 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 6eb0df62aaa00f2c1508b1650e8df3145822f84f)
2017-05-04tdf#105841: Avoid REGRESSION!!!Tor Lillqvist2-56/+49
Let's reinstate the name charade instead. Pitäkää tunkkinne. This reverts commit 5941496601600269296dde3e4ff8b615a8bb45ca. This reverts commit db231633af4667e24281e0be69ab63ad3081fdc3. Change-Id: Iaa6d43b38645bf90c5b83a8002448bd64048d600 Reviewed-on: https://gerrit.libreoffice.org/37101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit dc19bd9224850e8dd8ca873bc86a7e7945f95b08)
2017-04-18tdf#105286: Implement text rotation for Impress tablesTamás Zolnai1-2/+2
Typo: TopToBotton -> TopToBottom Change-Id: I1b4d3ab9ec1d1383d76a56c9662ffeeb9fe69655 Reviewed-on: https://gerrit.libreoffice.org/36014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 334e6e2f1ad3da319be0849ec426aa64b18cb599) Add SvxTextRotateItem inherited from SvxCharRotatItem I will be use it later for text rotation inside a table. Change-Id: I4cbaf05953b0e71331d2f3fdb45b7c4254a2b8cc Reviewed-on: https://gerrit.libreoffice.org/36021 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 1e30d2aface12a31687e5a27126e2061efd4b0cd) Introduce text rotation for Impress tables * Introduce new table property for text rotation * Support only two rotation angle (270° and 90°) * Implement editing and rendering of 270° rotated text (90° rotation was already implemented) (cherry picked from commit c671094154ecec6f3ba5beea9d26ff0d2d4d86ad) Change-Id: Ifc2e0f171e9c840e86b365e9af2c30aa97ecd92e Implement RotateAngle API property for Impress table cells (cherry picked from commit a0755ab8772d01797f4945016a978a2bbd8fdf20) Change-Id: I01379c0fc21e8fe294bc882bf824f64502863ff4 tdf#100926: PPTX import of table with rotated text (cherry picked from commit 2436cf17304f25c7d34da52a321d6da0e9011d19) Change-Id: I05a8e979ac11b179e15784023032a56edc5b569b ODF import / export of rotated text in Impress table (cherry picked from commit bcb371b1a830442610ad7fda476eda5271427a50) Change-Id: I57136e32ed2db5e405a45e8e4bad1b8d459b7ae8 Fix vertical text and bitmap bullet rendering Change-Id: I881fce0511c81b164516d68f72c7e750687d4e0e (cherry picked from commit 15ac3f9f4dc65fc0c6020284064e3725956f5d0a)
2017-04-12prev/next buttons start invisible in the .uiCaolán McNamara1-5/+2
Change-Id: Iec577adb469109a11188e83d95de6ed3960bc1c4 (cherry picked from commit 4a84cbaa3786e6ef9fa91c7eb3a6a49a9010456b) Reviewed-on: https://gerrit.libreoffice.org/36157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 2e716c24a628b2da2de365eb338ccc5b72960f9e)
2017-04-12tdf#106943 Lock down Experimental features and Macro recordingGabor Kelemen1-0/+6
Visually disable these features if they are locked by system administrators Change-Id: Ib35840312ad9c506e689ec6c9d432a88c07a5c28 Reviewed-on: https://gerrit.libreoffice.org/36095 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/36319 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 75c1af593e94c049972fd929c810a9b0be23cb20)
2017-04-07Related: tdf#106515 show OpenSymbol if unavailable StarSymbol requestedCaolán McNamara1-0/+7
Change-Id: I442df1c44839642bd1f91afedee577214032466b (cherry picked from commit 011e1cdbf33e50626f1fefa8b7b4031fa368f3e8) Reviewed-on: https://gerrit.libreoffice.org/35974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 7bb46f684ca939fbbbe67bdb1e427e37eec430a7)
2017-04-07Resolves: tdf#106080 fix explicitly setting automatic in search by formatCaolán McNamara2-7/+21
this is still somewhat broken in that what you see is not what you get if you don't explicitly set automatic, but clears the regression part of things in that the old broken behavior is restored instead of the new broken behavior Change-Id: I8f53a276ee60f5c9f2f28d3b92a13990cc20314a (cherry picked from commit d7f1a1689d70b2d66d0f727b6a898ef1a971da9d) Reviewed-on: https://gerrit.libreoffice.org/35894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit f75cf4c772279f680839e288b3f6104f9f98c13c)
2017-03-06tdf#77111 cui,sw: fix page number offset on paragraph dialog "Text Flow"Michael Stahl2-23/+65
Commit c2ccd20c0fd92bddfff76447754541705e3eb8f3 introduced 0 as a valid value for page number offset in sw core. Unfortunately the paragraph dialog was not changed then; previously page number 0 would do automatic numbering, but since then 0 was set as the offset, and once you have a 0 offset there's no easy way to remove it, you have to remove the whole page break. * change the label before the text number edit widget to a checkbox that disables the edit widget * keep the id "labelPageNum" so that translations still work * adapt SfxToSwPageDescAttr so it can not just set but also clear the page number * set initial value to 1; 0 is a really bad default since we can't export it to ODF (see tdf#91306) Change-Id: Ic4ca9e2562bb65ac359b305a2202f782e8598307 (cherry picked from commit d36fa0589ab822dc617c65b4d0d3bf68c092ad37) Reviewed-on: https://gerrit.libreoffice.org/34745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit a5104f575a5acf8aea957cb79aa0fd67bc74f141)
2017-02-20do not localize Collabora Office URLAndras Timar1-1/+1
Change-Id: I1eb33d3ce649ff8ca1158e96fe6c6bc1a3ab75ea (cherry picked from commit 9189450fa042526ee5380a2b9004b8a1a32a9e48) (cherry picked from commit b36267edb632577ca5e6deb219d5da4d5b8e9bef)
2017-02-18loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin5-8/+8
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e6ffb539ee232ea0c679928ff456c1cf97429f63)
2017-02-17respect read-only config items in Basic IDE Options dialogAndras Timar1-13/+12
Change-Id: I4a23b347c5fed948045427bc440e7a821b95b63c Reviewed-on: https://gerrit.libreoffice.org/31242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit d5be8dddc43e8a880d546fb9a6e8fbb45278eeca)
2017-02-02Resolves: tdf#100438 focus trapped in disabled toolbarCaolán McNamara1-9/+0
lets just leave the toolbar active the whole time, seems to make more sense anyway wrt being allowed to keyboard into it to paste/insert special character Change-Id: I174fb707c4c7fd21d95461cc93323eb6d8970818 (cherry picked from commit 4bd53cd880ecfa9af27735344bf57fb45de20c25) Reviewed-on: https://gerrit.libreoffice.org/33785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-01crash on exit from undisposed insert special character dialogCaolán McNamara1-1/+1
right click on style combobox in writer toolbar, insert character, esc, ctrl+f4 and crash Change-Id: I83c88584c6d772bf629121a2bcdc16076bee8003 (cherry picked from commit cfdfe1be91101654456bdf1f16d92461e1e5dbfa) Reviewed-on: https://gerrit.libreoffice.org/33700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-26Resolves: tdf#104552 table properties dialog drops previous border colorCaolán McNamara1-0/+2
Change-Id: Ie39ea17fe56cc88efc65f6916aaeb1bd1b77c51f (cherry picked from commit e2eaaa8a578fff5770a99e3f8ee2a7c95c460891) Reviewed-on: https://gerrit.libreoffice.org/33502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-18tdf#105014: Disable related buttons when there is no menu to editMuhammet Kara1-1/+1
Clicking the "Add Separator" or the "Add Submenu" button, when there is no menu edit, causes LibreOffice to crash. So disable them properly. Change-Id: Ibf685145a87c9e4343d83e1bb5ef6f08136c8f31 Reviewed-on: https://gerrit.libreoffice.org/32987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit ce0f9962d1d1d5a4f6301be18c23b2d14efd9d6b) Reviewed-on: https://gerrit.libreoffice.org/33246 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-13tdf#105259 calculate sizes of all area tab pages on constructionTomaž Vajngerl1-0/+29
When we open dialog that contains the area tab, we need to calculate the size of area tab pages (that are triggered by clicking on a button) and set the page area to the appropriate combined size. Otherwise we don't account for the needed space correctly and some page will be squished or have overlapping controls. This change creates all pages at dialog construction, gets all the optimal sizes and sets the size of the page container box to the combined (minimal) size. Change-Id: Ie04a121810b96973f6e4502a52af675b2baacf25 Reviewed-on: https://gerrit.libreoffice.org/33040 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit e6d7d737522124350a17a3cfdee055f03200a274) Reviewed-on: https://gerrit.libreoffice.org/33048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-01-10tdf#103225 revert setting of a fixed size for the dialogTomaž Vajngerl1-3/+0
Setting fixed size of a dialog causes a mess with HiDPI and could also cause problems with certain languages because the translated strings could streach the dialog size. It is better to let the dialog calculate its ideal size depending on the content, which in some cases is not ideal but at least it shouldn't create a mess. The decision to revert this was done in design hangout on 2016-12-22. Change-Id: I0ad1e38e1625cdbbf65b846118995bd5d3ebb47e Reviewed-on: https://gerrit.libreoffice.org/32912 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 62a94dcf0c750e335d6ce272d8a5df9813910d5a) Reviewed-on: https://gerrit.libreoffice.org/32913 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-01-03WaE: unused variableDavid Tardon1-1/+1
Change-Id: Ib701d3adf1e79554e2ddcefb5943092e3a886041 (cherry picked from commit 99f3f180034b78900e9ff6953b9866fde3da01d6) Reviewed-on: https://gerrit.libreoffice.org/32694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-19tdf#104221: Make up for non-existent FillItemSetKatarina Behrens1-0/+8
for fill:none option Change-Id: I12ada9276a613f157976650148f2389126d16f08 Reviewed-on: https://gerrit.libreoffice.org/32050 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 4c5079791f5d985151ebc090c5a07705e76a728e) Reviewed-on: https://gerrit.libreoffice.org/32053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-16coverity#1397204 Dereference null return valueCaolán McNamara1-1/+1
Change-Id: Ief4b455b316b55ebf012a8650c96da037df0135c (cherry picked from commit f74cad45681cc0ea5706a112a0e17f14a3197e39)
2016-12-14tdf#104615: there's no mpView when opening odc directlyJulien Nabet1-8/+17
2 parts changed for these bts: 0 SdrEditView::GetGeoAttrFromMarked (this=0x0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdedtv1.cxx:1278 1 0x00002aaadf70ae97 in SvxBitmapTabPage::Reset (this=0x55555b2eb8b0, rAttrs=0x55555afa0310) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:278 See https://bugs.documentfoundation.org//show_bug.cgi?id=104615#c1 0 SdrPaintView::GetModel (this=0x0) at /home/julien/lo/libreoffice/include/svx/svdpntv.hxx:256 1 0x00002aaadf90ba0f in SvxBitmapTabPage::ModifyBitmapHdl (this=this@entry=0x55555b2e7950) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:526 2 0x00002aaadf90bcc7 in SvxBitmapTabPage::ClickBitmapHdl_Impl (this=this@entry=0x55555b2e7950) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:457 3 0x00002aaadf90c9d8 in SvxBitmapTabPage::Reset (this=0x55555b2e7950, rAttrs=<optimized out>) at /home/julien/lo/libreoffice/cui/source/tabpages/tpbitmap.cxx:441 See https://bugs.documentfoundation.org//show_bug.cgi?id=104615#c2 Thank you to Katarina Behrens for her help on this. See http://nabble.documentfoundation.org/About-opening-odc-file-and-mpView-null-td4202317.html Change-Id: Ibbca868f33ca3292e0d3f787df87876bc9464e0b Reviewed-on: https://gerrit.libreoffice.org/31924 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit d543d66a4ee34d3b0088f45951b56c150f7206ec) Reviewed-on: https://gerrit.libreoffice.org/32008 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-13Resolves: tdf#101588, do not prevent color de-selection tdf#96382 follow-upEike Rathke1-2/+6
Comparing colors to determine whether to set one in the result item set does not work if the color previously was set before SaveValue() was called unconditionally even for the "undetermined" color state. Actually we want to know whether the user selected a color instead. Change-Id: I508f791684ebd79ba4af9cb654f9aa0bb25bff5d (cherry picked from commit 429be969b39867d6d9f36978c9ac15b601e78ba6) Reviewed-on: https://gerrit.libreoffice.org/31922 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-27Handle cases where last-used palette disappearedStephan Bergmann1-2/+4
...so PaletteManager::SetPalette(LISTBOX_ENTRY_NOTFOUND) would set PaletteManager::mnCurrentPalette to 65535, and PaletteManager::GetSelectedPalettePath would do out-of-bounds access into PaletteManage::m_Palettes. That the last-used palette (as stored under in the configuration under /org.openoffice.Office.Common/UserColors/PaletteName) may become more common with pending changes like <https://gerrit.libreoffice.org/#/c/31199/> "tdf#104047 Remove dispensable palettes". Change-Id: I5641bae04f50fea8aa69027a75de08c22394c281 (cherry picked from commit 8b718e3774f1ffb69f9aad565216556c798e95f4) Reviewed-on: https://gerrit.libreoffice.org/31209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-26respect read-only config items in Options - Load/Save - General dialogAndras Timar1-5/+15
Change-Id: I110e8eb2b858c8b86b01d46bec40873939ae53d8 Reviewed-on: https://gerrit.libreoffice.org/31237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-22loplugin:countusersofdefaultparams in include/sfx2Noel Grandin1-1/+1
Change-Id: I8b5e3ebbfb715d0b6aec2c4137f0ff524b63227e Reviewed-on: https://gerrit.libreoffice.org/31065 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21convert inventorId to scoped enumNoel Grandin3-3/+3
SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18svx: assert SfxPoolItem::operator==Michael Stahl1-1/+1
Change-Id: I7a5898f0dffb4d25b6e1bb916b3c6b36374f9912
2016-11-16screenshotannotation: Trim the textfield, add scrollbarKatarina Behrens1-1/+2
to prevent it from growing too large and thus distorting the dialog Change-Id: Iaa27d3085ec314246565cae79ab7d627a94a3bff Reviewed-on: https://gerrit.libreoffice.org/30898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-16screenshotannotation: Fix bookmark snippetsKatarina Behrens1-2/+2
Change-Id: I245000b48775955dcf72f362829df7594e8b637b Reviewed-on: https://gerrit.libreoffice.org/30880 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-16loplugin:countusersofdefaultparams in include/svx..unotoolsNoel Grandin2-6/+6
Change-Id: I02e933da66241e99e3b81d90d679f1502bab3fef Reviewed-on: https://gerrit.libreoffice.org/30866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15screenshotannotation: include image size in XML markupKatarina Behrens1-7/+12
Change-Id: I1c02055280b929ddd3ad12e6f6562c95bfe2a48a Reviewed-on: https://gerrit.libreoffice.org/30870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-15tdf#34467 - FitToFrame: stretch text to fill drawing objJustin Luth1-3/+7
Help for Fit To Frame says "Resizes the text to fit the entire area of the drawing or text object". reverts commit b7628798ec1a966c97a64d7cf0aa9f3859b78bef and partially addresses the problem of "Shrink font automatically when text overflows" by treating text as "Autofit" while it is being edited. It's not WYSIWYG, but good enough, and maybe better. Since that part of the change prevents any way of setting ::Autofit, I also changed the default setting to Autofit instead of NONE, since there is no good reason why text should be allowed to spill outside of a textbox. For those who REALLY want that odd behaviour, they can use .uno:TextFitToSize (Ctrl-Shift-F8) to toggle between "stretch" and "none". Change-Id: I8313a82cbea82f11fad0f50d966fc77874977da9 Reviewed-on: https://gerrit.libreoffice.org/30727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-11-14Avoid unnecessary, wrong downcastStephan Bergmann1-1/+1
...as reported by -fsanitize=vptr when doing "Format - Paragraph... - Area - Color" in Writer: > cui/source/tabpages/tpcolor.cxx:65:19: runtime error: downcast of address 0x6030009782b0 which does not point to an object of type 'XOutdevItemPool' > 0x6030009782b0: note: object is of type 'SwAttrPool' > 20 01 80 1c 50 e8 e9 85 4d 7f 00 00 e0 28 48 86 4d 7f 00 00 c0 d7 11 00 30 61 00 00 80 29 54 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SwAttrPool' > #0 0x7f4b047cfd3a in SvxColorTabPage::SvxColorTabPage(vcl::Window*, SfxItemSet const&) cui/source/tabpages/tpcolor.cxx:65:19 > #1 0x7f4b0480ec04 in VclPtr<SvxColorTabPage> VclPtr<SvxColorTabPage>::Create<vcl::Window*&, SfxItemSet const&>(vcl::Window*&, SfxItemSet const&) include/vcl/vclptr.hxx:138:46 > #2 0x7f4b047f8567 in SvxColorTabPage::Create(vcl::Window*, SfxItemSet const*) cui/source/tabpages/tpcolor.cxx:326:12 > #3 0x7f4b0472132a in CreateFillStyleTabPage(unsigned short, vcl::Window*, SfxItemSet const&) cui/source/tabpages/tparea.cxx:319:42 > #4 0x7f4b0471ef8b in SvxAreaTabPage::SelectFillTypeHdl_Impl(Button*) cui/source/tabpages/tparea.cxx:330:41 > #5 0x7f4b047114b3 in SvxAreaTabPage::LinkStubSelectFillTypeHdl_Impl(void*, Button*) cui/source/tabpages/tparea.cxx:323:1 > #6 0x7f4df3eac737 in Link<Button*, void>::Call(Button*) const include/tools/link.hxx:84:45 > #7 0x7f4df3e93bb6 in Button::Click()::$_0::operator()() const vcl/source/control/button.cxx:127:85 Change-Id: I6259b100c535fa81b9f7452db84c22d5b10acb1e
2016-11-14Avoid -fsanitize=nullStephan Bergmann2-44/+44
...when doing "Format - Page..." in Writer (and eFillType is TRANSPARENT): > cui/source/tabpages/tparea.cxx:331:33: runtime error: reference binding to null pointer of type 'SfxTabPage' > #0 0x7f9f053e936f in SvxAreaTabPage::SelectFillTypeHdl_Impl(Button*) cui/source/tabpages/tparea.cxx:331:9 > #1 0x7f9f053e548c in SvxAreaTabPage::ActivatePage(SfxItemSet const&) cui/source/tabpages/tparea.cxx:157:13 > #2 0x7fa21be01676 in SfxTabDialog::ActivatePageHdl(TabControl*) sfx2/source/dialog/tabdlg.cxx:1126:19 > #3 0x7fa21bdf70e3 in SfxTabDialog::LinkStubActivatePageHdl(void*, TabControl*) sfx2/source/dialog/tabdlg.cxx:1035:1 > #4 0x7fa1f5efff37 in Link<TabControl*, void>::Call(TabControl*) const include/tools/link.hxx:84:45 > #5 0x7fa1f5ebbcaa in TabControl::ActivatePage() vcl/source/control/tabctrl.cxx:1601:19 Change-Id: I279f507038ab4bae1be4f02b6537e6d1aab76348
2016-11-14Avoid -fsanitize=enumStephan Bergmann1-1/+1
...when doing "Format - Page..." in Writer: > cui/source/tabpages/tparea.cxx:268:12: runtime error: load of value 4294967295, which is not a valid value for type 'FillType' > #0 0x7f89ff653a41 in SvxAreaTabPage::Reset(SfxItemSet const*) cui/source/tabpages/tparea.cxx:268:12 > #1 0x7f8d15524560 in SfxTabDialog::ActivatePageHdl(TabControl*) sfx2/source/dialog/tabdlg.cxx:1117:19 > #2 0x7f8d1551b0e3 in SfxTabDialog::LinkStubActivatePageHdl(void*, TabControl*) sfx2/source/dialog/tabdlg.cxx:1035:1 > #3 0x7f8cef623f37 in Link<TabControl*, void>::Call(TabControl*) const include/tools/link.hxx:84:45 > #4 0x7f8cef5dfcaa in TabControl::ActivatePage() vcl/source/control/tabctrl.cxx:1601:19 Change-Id: I19dd3ed9d362132daa3f3be9fb0e9702a62bdeb0
2016-11-14tdf#103228: Remember fill type when switching between tabsKatarina Behrens1-0/+2
This page used not to have exchange support, but it needs it now since it contains all the fill type subtabs Change-Id: Ibeefc0ae832b4d53727711a169f1765d28350ec1 Reviewed-on: https://gerrit.libreoffice.org/30843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-13coverity#1371441 Uninitialized pointer fieldCaolán McNamara1-0/+4
Change-Id: Icabed9a27be9e34552531997818afd202f31114c
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin4-4/+4
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10loplugin:expandablemethods in cuiNoel Grandin22-141/+38
Change-Id: I3dae1d142874c767ec1e32401acba0bbca95df5f Reviewed-on: https://gerrit.libreoffice.org/30716 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin2-2/+2
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08Change new colour only, keep active one on the initial valueKatarina Behrens2-16/+24
Change-Id: Icfda455d275d0449725867fd7bf4ea3060e7dc26 Reviewed-on: https://gerrit.libreoffice.org/30691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-13 03:17:18 +0000