summaryrefslogtreecommitdiff
path: root/cui/source/tabpages/numpages.cxx
AgeCommit message (Collapse)AuthorFilesLines
2021-05-31no need to allocate SvxNumRule separately in SvxNumBulletItemNoel Grandin1-12/+12
Change-Id: I7903565a468fc0fbec603c88b92cca6560a86728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara1-4/+4
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19ImplPlayWithRenderer never checks its OutputDevice against nullptrCaolán McNamara1-5/+5
just pass a reference instead and spread that around to some similar cases Change-Id: Ifb2dee8c7bf02a9f01982b928c90666cbbdd84fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115759 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09defer getting toplevel for color picker until we need itCaolán McNamara1-1/+2
Change-Id: I60f4ded47f7d80b397647ea3344e83a5dfd1b11e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-07Use o3tl::temporary in calls to OUString::iterateCodePointsStephan Bergmann1-2/+3
...that are not interested in the updated *indexUtf16 value Change-Id: Iaaa0fe45dcb54c4a8a347bcdb6fca6041218d009 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108941 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-24tdf#138430 scrolled windows need to have auto scrolling disabledCaolán McNamara1-3/+3
Change-Id: I8a622f00238d3d20d21d2439d6fc4fb13358f0c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106485 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-23tdf#138430 toolbar bullet dropdown should have a scrolledwindowCaolán McNamara1-3/+3
as should the matching dialog pages Change-Id: Ib327d3c02d1bc5ae11a6a76d52c9e17803f05534 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106427 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-21use tools::Long in comphelper..cuiNoel1-55/+55
Change-Id: I65167999c6049038f8f5d530a0c5cb0552ab0e06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06move set_user_managed_scrolling to an initial weld argumentCaolán McNamara1-1/+1
gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-22Related: tdf#132970 handle more places with potentially utf16 bulletsCaolán McNamara1-1/+2
Change-Id: Iac6b319700d610b5a1debff0a633172b2411c40e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103161 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-22tdf#132970 SMP bullets mangledCaolán McNamara1-3/+4
working: a) bullet preview b) writer rendering c) save to odt a) load from odt Change-Id: I2f85576389fe4f0437f81799c14dfd98c8c40b2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103129 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-14rhbz#1878275 should use value_changed for spinbutton changesCaolán McNamara1-1/+6
Change-Id: I8d042eb9c288e9db69a49cb9e097b23cf765aae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: cuiStephan Bergmann1-1/+1
Change-Id: I403229592145d6e126f5a3f4c8b788d2deb70a8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97551 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-25rename SvtValueSet back to ValueSetCaolán McNamara1-8/+8
Change-Id: I51ab96ffef7acc0d416d13ac8e380e49381f4d1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-17loplugin:flatten in cuiNoel Grandin1-356/+353
Change-Id: I0ea0784ab8c4542747da1e15fa7c60c60bccb602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-09unnecessary usingCaolán McNamara1-1/+0
Change-Id: I3009edf99f6626a518941131a57b11e868622485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91952 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28tdf#127112 repair "sticky" levels in Customize numbering style dialogSeth Chaiklin1-5/+24
Change-Id: Ifa841e7b63b28d6e0f84f5cd6b1800481b36425b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-13rename NumValueSet back to SvxNumValueSetCaolán McNamara1-3/+3
Change-Id: I05cd8e336f818e80de40abb40cf739a7cbb540d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86665 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-06tdf#42949 Fix IWYU warnings in cui/Gabor Kelemen1-1/+0
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I41ae36eb535cc64f4c4fa73333dbc8aa728865b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85791 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-20loplugin:unusedmethodsNoel Grandin1-5/+0
Remove a filtering step in the python script that was hiding some results Change-Id: Id94268f150902405ab197c077f18aaedf98845fc Reviewed-on: https://gerrit.libreoffice.org/83256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-04use SfxUInt16Item for SID_METRIC_ITEMNoel Grandin1-2/+2
because we aren't using the array of values in SfxAllEnumItem Change-Id: I67ccb7737c52f9949495c53881e052d5005882aa Reviewed-on: https://gerrit.libreoffice.org/80165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26TODO rename to GetFrameWeldCaolán McNamara1-4/+4
Change-Id: I28527b6773075fe682682a4812cf86bb7ac13180 Reviewed-on: https://gerrit.libreoffice.org/79560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26now drop TabPageParent intermediateCaolán McNamara1-25/+25
Change-Id: I47328f76342ac023628d9042bdfa8213a1c93d0c Reviewed-on: https://gerrit.libreoffice.org/79469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26disinherit OWizardPage and SfxTabPage from vcl TabPageCaolán McNamara1-48/+12
Now that there's no need to support weld/unwelded mixes of pages in dialog any more. inherit from a BuilderPage which contains a Builder and Toplevel container BuilderPage Activate and Deactivate replace TabPage ActivatePage and DeactivatePage, allowing disambiguation wrt SfxTabPage ActivatePage and DeactivatePage. Change-Id: I5706e50fd92f712a25328ee9791e054bb9ad9812 Reviewed-on: https://gerrit.libreoffice.org/79317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-03Resolves: tdf#127120 double selection in B&N dialogCaolán McNamara1-5/+23
because the list wants to ensure that at least one thing is selected and the multiselect is implemented with two events of deselect-all followed by select. post a user event on getting either deselect or select and process it once when the dust has settled Change-Id: I553bf23d7a8c4625a8706fb2df4b169d91b7ad32 Reviewed-on: https://gerrit.libreoffice.org/78541 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-29tdf#42949 Fix IWYU warnings in cui/source/{options,tabpages}/*cxxGabor Kelemen1-14/+2
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9b6fda67ef7de65cc7b468dded862cd47dfd4269 Reviewed-on: https://gerrit.libreoffice.org/78078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-19loplugin:constvars in cppuhelper..desktopNoel Grandin1-1/+1
Change-Id: Iaf42114ab98875c4bc1545684f1893540b998ef2 Reviewed-on: https://gerrit.libreoffice.org/77723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29Resolves: tdf#126485 remove max limitCaolán McNamara1-0/+4
Change-Id: Ieda7b500c1c08d169bfbfa995b42d3761d2427d7 Reviewed-on: https://gerrit.libreoffice.org/76526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-27tdf#42949 Fix IWYU warnings in include/svx/[sS][a-h]*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I84fc75e06e61e5391aef6e237c36daad95dedb84 Reviewed-on: https://gerrit.libreoffice.org/72550 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-23Add new customize and position merged dialogGülşah Köse1-1/+1
Change-Id: I898fb0830a9f53da4a7917cb5900f082e3a9d6b7 Reviewed-on: https://gerrit.libreoffice.org/71944 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-14Resolves: tdf#120423 dispatch against the correct FrameCaolán McNamara1-1/+1
Change-Id: I5ea2e5d7b79efbd2b14d0b528e5a5c3e44e643bc Reviewed-on: https://gerrit.libreoffice.org/72284 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27tdf#42949 Fix IWYU warnings in include/svx/[a-D]*Gabor Kelemen1-0/+2
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9770343f31f882427c9ae13e363b59cd1fb47e98 Reviewed-on: https://gerrit.libreoffice.org/71295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09drop some unneeded includesCaolán McNamara1-2/+0
Change-Id: I8e41e28313a22148033c566edce50f5bfa58d065 Reviewed-on: https://gerrit.libreoffice.org/70452 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-16clarify that set_visible(true/false) is just show/hideCaolán McNamara1-51/+51
ditch duplicate method Change-Id: Iea35d6437f48809a06e093241bddf301f00c502b Reviewed-on: https://gerrit.libreoffice.org/69302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-08loplugin:indentation in cppu..cuiNoel Grandin1-1/+1
Change-Id: If625e5bf38ca8e1f12686038c7c9be8d0303b6f6 Reviewed-on: https://gerrit.libreoffice.org/67536 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-25tdf#122951: Fix insertion of graphics as bulletsXisco Fauli1-4/+6
Regression from 81260c448911069ce8cb051d3a973ec52b9b43a3 Change-Id: Iecf00ea8310a767ff7945e7c1a0efe9dca5edd20 Reviewed-on: https://gerrit.libreoffice.org/66903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24loplugin:constparams in connectivity..cuiNoel Grandin1-1/+1
Change-Id: Ia2ae97498a9aad8638c4b77ce20143eeec616751 Reviewed-on: https://gerrit.libreoffice.org/66792 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-23Bullets: Use relative size when it's supportedTamás Zolnai1-4/+7
In Writer it might cause a problem to use relative size with text based numberings. Change-Id: Id19b5e45f0f932d1b69028f343daad7dec34ae23 Reviewed-on: https://gerrit.libreoffice.org/66811 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-12-10tdf#42949 Fix IWYU warnings in include/vcl/s*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152 Reviewed-on: https://gerrit.libreoffice.org/64479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-12-03tdf#121620 Opening Image tab of Bullets and Numbering dialog resets selectionNoel Grandin1-1/+1
regression from commit 39e6bae2c4be24a3aad5ef8cd37d3d83c41a4abe loplugin:useuniqueptr in cui numpages Change-Id: I77e16880d0590793545da38b7a3c8c5d2626d8f5 Reviewed-on: https://gerrit.libreoffice.org/64441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-02weld ScShareDocumentDlgCaolán McNamara1-2/+2
Change-Id: I790f957c9ebc6d87a94a355c30215245aaabeb30 Reviewed-on: https://gerrit.libreoffice.org/64345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21improve function-local statics in basic..cuiNoel Grandin1-11/+10
Change-Id: If737e8478f6f1c8fffb060ce132d80e0f07ef8ee Reviewed-on: https://gerrit.libreoffice.org/63701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-20tdf#120563 Improve the preview of numbering with relative sizeRéka Csékei1-5/+15
Fixes the preview on Customize tab page Change-Id: If918522bda573c0f312b04592b4b7de957c9416b Reviewed-on: https://gerrit.libreoffice.org/63649 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-08Convert FieldUnit to scoped enumMike Kaganski1-19/+19
Change-Id: Id2df31daa596a18c79af5fc6ea162deb6e24d5af Reviewed-on: https://gerrit.libreoffice.org/62958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-24Resolves: tdf#120862 double-click in bullets and numberingCaolán McNamara1-8/+8
Change-Id: I3d8aa529fc5ac8a8f80eb1fd6728786680f2aee2 Reviewed-on: https://gerrit.libreoffice.org/62277 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld AdvancedSettingsDialogCaolán McNamara1-1/+1
make run virtual and fold executes into it, so GenericUnoDialog can call run on tabdialogs to do the right thing, and allows Start_Impl to be private again Change-Id: Ic457edfbdc7457f4c49d4e8ad679903f38ad9b42 Reviewed-on: https://gerrit.libreoffice.org/62227 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-23clang-tidy performance-unnecessary-copy-init in canvas..cuiNoel Grandin1-1/+1
Change-Id: I08c137d852b5f1f817c171ee4f1cee7971417dc4 Reviewed-on: https://gerrit.libreoffice.org/62214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03rename cui::NumberingPreview back to SvxNumberingPreviewCaolán McNamara1-2/+2
Change-Id: I5c8b9ac10babd0535fa55f490a5478f88fc76222 Reviewed-on: https://gerrit.libreoffice.org/61264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-03weld SwSvxNumBulletTabDialogCaolán McNamara1-7/+9
Change-Id: I8ea74dc15bba04c0615e61c069407160a7b95c4c Reviewed-on: https://gerrit.libreoffice.org/61242 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-02weld SvxNumOptionsTabPageCaolán McNamara1-449/+254
Change-Id: Ie2ae18b1722e91996887162b4a8ff02d2d812341 Reviewed-on: https://gerrit.libreoffice.org/61228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>