summaryrefslogtreecommitdiff
path: root/cui/source/options
AgeCommit message (Collapse)AuthorFilesLines
2021-06-09tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWNArmin Le Grand (Allotropia)1-6/+6
See task, slowly trying to reduce usages of that flag Change-Id: I50dc8e21e2f5e82e21bf335d63d07cee1ee18d01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116913 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2021-06-03no need to allocate these on the heapNoel Grandin1-1/+1
Change-Id: Ic4b16e776a731e5e9bea61e99acb7257c5220322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-30Drop GtkSalPrinter bits from option dialogJan-Marek Glogowski2-23/+0
After commit ed07ec7606cb24cccaf6b7b81b2bd308debaa2e6 ("drop never completed GtkSalPrinter"), there is still the experimental option left, depending on ENABLE_GTK3. We can't drop the whole PrinterCapType::ExternalDialog, because the osx code actually uses it. Change-Id: Ibc4654d8c1ce1de7ee1c9dc7700bb8775af2f678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116408 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26add privacy URL to crashreport dialog & updatecheck tab in optionsChristian Lohmaier2-0/+9
Change-Id: I35cda87c35876469bf581be223bc608e29f07b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116105 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara22-46/+46
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for CheckButtonCaolán McNamara16-29/+35
Change-Id: I73ffd66a6e5eed1f95882e874d9319ecad5550f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115853 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19ImplPlayWithRenderer never checks its OutputDevice against nullptrCaolán McNamara1-1/+1
just pass a reference instead and spread that around to some similar cases Change-Id: Ifb2dee8c7bf02a9f01982b928c90666cbbdd84fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115759 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-17gtk4: reenable buttonCaolán McNamara2-2/+2
rename label_line_wrap to label_wrap while I'm at it Change-Id: I3964c4b40d86fb6ef1fd3733088ffd80e57415ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115714 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-14gtk4: advertise as gtk4 not gtk3Caolán McNamara1-1/+1
Change-Id: I7f38238109f79cc8b87d41999a8355879761a894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-02throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewriteStephan Bergmann2-8/+8
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-22no need to create temporaries when appending number to O[U]StringBufferNoel Grandin1-4/+4
Change-Id: I36d82423b5f75010552696a66cec7e53ee265ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-22Resolves: tdf#141721 text from 1st col not clipped if 2nd col is emptyCaolán McNamara1-1/+1
Change-Id: I07257c59c20c3a2aeb789bbb370955e9e70226ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-19use more string_view in comphelper::stringNoel Grandin1-3/+3
Change-Id: I5d27824694e38de540e5f1fcd8704f8777f65140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-09-Werror,-Wreorder-ctor (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I3c5fd8e875c6c0d36e97d76b0c51308799eeb351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-01tdf#45735 New UI dialog at app startup to check default file formatsMatt K2-25/+19
On Windows only, and only on a non-admin installation, check on application startup whether the file formats ".ods", ".odt", and ".odp" are registered to be opened by LibreOffice by default. If any of the formats are not default, show a UI dialog informing the user which formats are not default and ask the user to set the defaults. If the user selects "OK" to set defaults then the Windows UI corresponding to the user's Windows version is opened for selecting defaults per program. There is also a checkbox on the dialog to select whether checking is performed on application startup. Also, in Tools -> Options -> General, add a UI checkbox for performing this check on application startup, and refactor the existing button "Windows Default apps" to use the same Windows UI Launch APIs. Change-Id: I5e7258d111ff7da8f68805e60405aec064ddcf7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112370 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-26loplugin:flattenNoel1-14/+14
Change-Id: Ib7a895fba66f8dc9b6501e61631c02694053b7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-17Use COMReference hereMike Kaganski1-7/+10
Change-Id: Ic9a12de597724e17c575336bb313f50ad1cecfa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112612 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-09defer getting toplevel for color picker until we need itCaolán McNamara1-1/+1
Change-Id: I60f4ded47f7d80b397647ea3344e83a5dfd1b11e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-24drop unneeded includeCaolán McNamara1-3/+0
Change-Id: I6d58ca8565f8de2d76482e24af1e027f900c5373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111496 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-23loplugin:refcounting in cuiNoel1-3/+2
Change-Id: I09b71657f9f5fef733cbaae8a2eda457735b50cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111368 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in cuiNoel2-3/+3
Change-Id: Id73971bdd986101eeb53bf0b140ef6a7c72191a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-25Revert "tdf#138865 don't set ColumnToggleType::Check"László Németh1-0/+1
This reverts commit 4cabfc30bf2db873930cef4f7f1b0243ae2fde28 because the clean-up in commit 3d2a431da1126f4924f6cd7e5abac6488cd480e7 (tdf#139115 vcl tree list: add new toggle behaviors). Change-Id: Ieb57c035837e7740d105fa688fdf2b1bffcb88d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-18tdf#139332 reduce height of expert config dialogCaolán McNamara1-1/+1
to about the height of help, options Change-Id: Icf2bebb2f2cc5aabea3e1f702d7095de8c31d726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-16make the Color constructors explicitly specify transparencyNoel1-1/+1
to reduce the churn, we leave the existing constructor in place, and add a clang plugin to detect when the value passed to the existing constructor may contain transparency/alpha data. i.e. we leave expressions like Color(0xffffff) alone, but warn about any non-constant expression, and any expression like Color(0xff000000) Change-Id: Id2ce58e08882d9b7bd0b9f88eca97359dcdbcc8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-09fix coverity parse errorsCaolán McNamara3-15/+15
Change-Id: I3a1179947704452e3ffec02be59d0f7bf0b75ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-29loplugin:stringviewparam: operator +Stephan Bergmann1-6/+10
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-26New loplugin:stringliteralvarStephan Bergmann3-15/+15
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for details. (Turned some affected variables in included files into inline variables, to avoid GCC warnings about unused variables.) Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-22replace margin-left with margin-start and margin-right with margin-endCaolán McNamara1-1/+1
Change-Id: Iee3cc8c22b393ca420d0ed68673c61fe7ef240ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108113 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-18tdf#138865 don't set ColumnToggleType::CheckJan-Marek Glogowski1-1/+0
We don't want any hidden, magic checkbox for this table, as the user explicitly has to toggle the desired replacement modes, which isn't in any way related to a row selection. Change-Id: I3f9a73d41cc8727aa6380172221ea07068ef74c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107920 Reviewed-by: Attila Szűcs <szucs.attila3@nisz.hu> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org>
2020-12-14tdf#138874 restore sort on first column of paths treeviewCaolán McNamara1-0/+10
Change-Id: I7cd831de30523a61631be5cc2f1f3b8a001d9e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-13tdf#138857 fix font replacement table GUIJan-Marek Glogowski1-26/+19
- fix the get_text calls missed in tdf#136534, so combo box entry and table selection are synced again - unselect the table row, if the combo box entry doesn't match anymore the selected table row. - empty the combo box entries on multiple selection (allowd for mass delete only) - move the "apply replacement table" checkbox before the table - also change the comboboxes's sensitivity when toggling the "apply replacement table" checkbox. Change-Id: Ib509e46e3a468ece6ab20e6be41c04caec3265ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107642 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-12-07remove OpenGL VCL backend codeLuboš Luňák1-10/+0
It is by now practically unmaintained, even bugreports in bugzilla have been already closed for it. AFAICT this used to be really used only on Windows, where it's no longer the default. There's still some OpenGL code left, because there are still two other places that use OpenGL. One is OpenGL slideshows, which reuse some of the base OpenGL code (and I've checked they still work even after this removal). Second one is OpenGL canvas, which it seems has never been finished or enabled (or so it most probably should be dumped too). Change-Id: I7ea5aef77ec252eb8e712d167db591209be84a13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107290 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-07remove SID_BASIC_ENABLED and BasicEnabled optionNoel1-1/+1
which has never been used since creation in commit fd069bee7e57ad529c3c0974559fd2d84ec3151a Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: I018b1f734c8263167dab3d5c6f98a400666f01d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107047 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-03convert SvtPathOptions::Paths to scoped enumNoel1-52/+53
Change-Id: I2e6cab798309a1bc2ade00661bc95dd5ae20f748 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-02tdf#138596 don't destroy SfxItemSet that are still in useCaolán McNamara1-5/+10
update the existing ones instead Change-Id: I67fd6c4ecb5d4294efae0262d558281e6840b5dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107079 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-01drop the needless and broken SkiaConfig abstraction (tdf#137935)Luboš Luňák2-98/+8
I originally copy&pasted this from the OpenGL setting, but this appears to be just an unnecessary complication. Both the option and writing is in fact simple, and trying to make it abstract and complicated doesn't provide much, and it causes the options not saved if only 'Apply' is used in the config dialog. Change-Id: Ibd55052467988b54429358567d70cbfbb0a34653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106900 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-01OSL_FAIL.*exception -> TOOLS_WARN_EXCEPTIONNoel2-4/+6
Change-Id: I6800e23ead2767d245d5da71d2d40e0f8a6d7e1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-30loplugin:stringviewparam include comparisons with string literalsNoel2-12/+12
Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-25clean up enabling/disabling GUI options related to SkiaLuboš Luňák2-21/+27
This should properly enable/disable 'force Skia software rendering' and 'use hardware acceleration' checkboxes when Skia is enabled or disabled. Technically the two options are duplicates, since 'use hardware acceleration' is the exact opposite of 'force Skia software rendering'. But the implementation of the hw accel option is so tied to the implementation of the canvas module that it's simpler to ignore it for Skia. Change-Id: Ia7c54140aec72d6ef75b7ba53ce83037311f0caf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106491 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel6-37/+37
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-17tdf#137930 Apply button changes values to previous onesCaolán McNamara1-14/+25
Change-Id: I374b4f448715db9563f6073c433b82caf3482874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105953 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-16tdf#138049 different parents for restart dialog depending on ok vs applyCaolán McNamara1-3/+13
and in ok case hide the to-be-dismissed dialog before putting up the next dialog Change-Id: Ie9c0dfc1a7c10f8fd1d7a70749e07db123de2bf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-13tdf#123936 Formatting files in module cui with clang-formatPhilipp Hofer1-12/+14
Change-Id: I473e2950bb9bd53043feeae31a27ae0c2fc7801d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105659 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-11-06tdf#42949 Fix new IWYU warnings in directories c*Gabor Kelemen1-1/+0
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iac1e7802dbe1efa01c2befdd10406231788d4fc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105315 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-04negative returnsCaolán McNamara1-1/+1
Change-Id: I6f710f1aecc2e242b6006a3360e31bf2a9438fe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105286 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-02use officecfg or MacroRecorderModeNoel Grandin1-6/+5
Change-Id: I2a8d4f401ddfd4368a7b50b4c3c8a72724f9afa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105154 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for UseSystemFileDialogNoel Grandin1-5/+6
Change-Id: I1419af229a67d6ebb1cf2c63757656beb3f512db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105142 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for UseSystemPrintDialogNoel Grandin1-3/+5
Change-Id: I0e0bdc925f106884cbcede6405cc6ef7152ad405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for Experimental flagNoel Grandin3-8/+8
move IsShowOutlineContentVisibilityButton out of header to avoid having to add extra include paths to all the unit test makefiles. Change-Id: I2763390e07cd85b8f09b6f2ad7702039daecb22f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-29have just the one handler for ok/apply optionsCaolán McNamara1-25/+30
'apply' is only really working the first time it is pressed in a page, I want to be able to apply to change e.g. notebookbar icon size and then change that again and apply and get the expected display size Change-Id: I7f051ad4063f0e99f822cc06fbe4a0ab49588fbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105020 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>