summaryrefslogtreecommitdiff
path: root/cui/source/options/optgdlg.cxx
AgeCommit message (Collapse)AuthorFilesLines
2021-07-26use officecfg for menu optionsNoel Grandin1-21/+21
Change-Id: I94c9cf310ed6975f158548913439445faf6d178f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119483 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg for drawing optionsNoel Grandin1-5/+4
Change-Id: Idba40d9816f29c0e4bc4a468b8c0a2cbb74d09d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119481 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-25use officecfg for help optionsNoel Grandin1-14/+5
Change-Id: I2d19541cff07bf8159715d8f32d771cbf201ece4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-24use officecfg to retrieve offlinehelppopupNoel Grandin1-2/+6
Change-Id: I2441dc1c508ceb4805a98b7e45863bbda4af0b18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-23use officecfg to retrieve SidebarIconSizeNoel Grandin1-4/+7
Change-Id: Id1cc4b8e3e28d942b44deacafbc514bbcd95874c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119411 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-23use officecfg to retrieve NotebookbarIconSizeNoel Grandin1-4/+7
Change-Id: I1e76e8369b4a0448a62cd72bc9a1ee492fae91b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119410 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-23tdf#140107 Remove all collect usage data code.Jeff Huang1-11/+3
Remove all collect usage data code because we don't really use them. Change-Id: I8d83d57220bed8f8c15bd012584943cd0913500d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119166 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-06-29Added a UI dialog box for running the VCL backend testshomeboy4451-0/+8
The UI dialog box will allow the user to run the VCL graphics tests and will allow them to view the results as well. Change-Id: Ice289444ff425496a3e400a4c2bc06c307168c62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117384 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-30Drop GtkSalPrinter bits from option dialogJan-Marek Glogowski1-22/+0
After commit ed07ec7606cb24cccaf6b7b81b2bd308debaa2e6 ("drop never completed GtkSalPrinter"), there is still the experimental option left, depending on ENABLE_GTK3. We can't drop the whole PrinterCapType::ExternalDialog, because the osx code actually uses it. Change-Id: Ibc4654d8c1ce1de7ee1c9dc7700bb8775af2f678 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116408 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara1-4/+4
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-14gtk4: advertise as gtk4 not gtk3Caolán McNamara1-1/+1
Change-Id: I7f38238109f79cc8b87d41999a8355879761a894 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09-Werror,-Wreorder-ctor (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I3c5fd8e875c6c0d36e97d76b0c51308799eeb351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-01tdf#45735 New UI dialog at app startup to check default file formatsMatt K1-25/+18
On Windows only, and only on a non-admin installation, check on application startup whether the file formats ".ods", ".odt", and ".odp" are registered to be opened by LibreOffice by default. If any of the formats are not default, show a UI dialog informing the user which formats are not default and ask the user to set the defaults. If the user selects "OK" to set defaults then the Windows UI corresponding to the user's Windows version is opened for selecting defaults per program. There is also a checkbox on the dialog to select whether checking is performed on application startup. Also, in Tools -> Options -> General, add a UI checkbox for performing this check on application startup, and refactor the existing button "Windows Default apps" to use the same Windows UI Launch APIs. Change-Id: I5e7258d111ff7da8f68805e60405aec064ddcf7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112370 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-17Use COMReference hereMike Kaganski1-7/+10
Change-Id: Ic9a12de597724e17c575336bb313f50ad1cecfa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112612 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-09fix coverity parse errorsCaolán McNamara1-5/+5
Change-Id: I3a1179947704452e3ffec02be59d0f7bf0b75ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-26New loplugin:stringliteralvarStephan Bergmann1-5/+5
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for details. (Turned some affected variables in included files into inline variables, to avoid GCC warnings about unused variables.) Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-07remove OpenGL VCL backend codeLuboš Luňák1-10/+0
It is by now practically unmaintained, even bugreports in bugzilla have been already closed for it. AFAICT this used to be really used only on Windows, where it's no longer the default. There's still some OpenGL code left, because there are still two other places that use OpenGL. One is OpenGL slideshows, which reuse some of the base OpenGL code (and I've checked they still work even after this removal). Second one is OpenGL canvas, which it seems has never been finished or enabled (or so it most probably should be dumped too). Change-Id: I7ea5aef77ec252eb8e712d167db591209be84a13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107290 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-01drop the needless and broken SkiaConfig abstraction (tdf#137935)Luboš Luňák1-93/+8
I originally copy&pasted this from the OpenGL setting, but this appears to be just an unnecessary complication. Both the option and writing is in fact simple, and trying to make it abstract and complicated doesn't provide much, and it causes the options not saved if only 'Apply' is used in the config dialog. Change-Id: Ibd55052467988b54429358567d70cbfbb0a34653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106900 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-25clean up enabling/disabling GUI options related to SkiaLuboš Luňák1-21/+26
This should properly enable/disable 'force Skia software rendering' and 'use hardware acceleration' checkboxes when Skia is enabled or disabled. Technically the two options are duplicates, since 'use hardware acceleration' is the exact opposite of 'force Skia software rendering'. But the implementation of the hw accel option is so tied to the implementation of the canvas module that it's simpler to ignore it for Skia. Change-Id: Ia7c54140aec72d6ef75b7ba53ce83037311f0caf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106491 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-11-01use officecfg for UseSystemFileDialogNoel Grandin1-5/+6
Change-Id: I1419af229a67d6ebb1cf2c63757656beb3f512db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105142 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for UseSystemPrintDialogNoel Grandin1-3/+5
Change-Id: I0e0bdc925f106884cbcede6405cc6ef7152ad405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01use officecfg for Experimental flagNoel Grandin1-1/+1
move IsShowOutlineContentVisibilityButton out of header to avoid having to add extra include paths to all the unit test makefiles. Change-Id: I2763390e07cd85b8f09b6f2ad7702039daecb22f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-28cid#1468666 'Constant' variable guards dead codeCaolán McNamara1-6/+15
Change-Id: Ie27df6c7e4a10d943d0a2e2a6880a5fe2c34fbcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104922 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-20clean up handling of the UI Skia optionsLuboš Luňák1-39/+31
Disable the sub-option when the main option is disabled. Enable it for the proper VCL backends ("win" and "gen"). Change-Id: I38c2f605c10eb0f3cfae3f05cd4bada4877cdc2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104426 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-20remove ui for 'forceskia' AKA 'ignore skia denylist' (tdf#137159)Luboš Luňák1-40/+0
I originally copy&pasted this from the OpenGL code, but now that I think of it, having an easy checkbox to make LO use drivers that LO decides are faulty is a bad idea. There's still the expert configuration if somebody insists (and if they're not expert enough to find the expert setting then they better not mess with it), but this is asking for unnecessary trouble. This also solves the problem that the UI option is misleading. As the description in Common.xcs says, "This one forces the use of Skia even if the denylist would block the driver.", so the option is independent of the 'enable skia' option, but the UI didn't make it appear so. Change-Id: I74bf3574f16899405272dbb3aec54580a5e3f0bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104425 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-14Resolves tdf#137447 - Access icon themes via tight extensionsHeiko Tietze1-0/+13
Button and code added to optgdlg Change-Id: Ib4aa0883a6af2844ab68ed3c0b7f0e21bc655d94 Signed-off-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104233 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-02loplugin:reducevarscope in cuiNoel1-2/+2
Change-Id: Iedfda307d149fe2a5a196c83d3ea02b618e7dd23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-29replace and drop SvtPrintWarningOptionsCaolán McNamara1-6/+3
Change-Id: I17fd4156eb940fbdc925d9761301096e5349135f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-28drop use of SvtFontOptionsCaolán McNamara1-5/+4
Change-Id: Ib3ef6ec415d5e61d484e338290030fac2ed7b215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99647 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-10replace usage of blacklist with denylistThorsten Behrens1-1/+1
.. and a few cases of instead doing blacklist->excludelist where that made more sense. Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 [API CHANGE] officecfg::Office::Canvas::DeviceBlacklist -> DeviceDenylist [API CHANGE] officecfg::Office::Canvas::BlacklistCurrentDevice -> DenylistCurrentDevice [API CHANGE] officecfg::Office::Common::Misc::OpenCLBlackList -> OpenCLDenyList Change-Id: Ia35e25496bf0cc0692d5de4cb66bfc232d3a869e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98180 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-02currency combobox doesn't have a selected entryCaolán McNamara1-2/+4
possibly since... commit 5326d238d7f98b11886eb4be01f19db73f8eda39 Date: Tue Feb 4 00:14:17 2020 +0300 tdf#114694: Make default value in language settings the first element Change-Id: I6a543ee6bf59d6dfcaee47252cf8008e840e47e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: cuiStephan Bergmann1-5/+5
Change-Id: I403229592145d6e126f5a3f4c8b788d2deb70a8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97551 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-23show Skia UI controls only on Windows for now (tdf#133166)Luboš Luňák1-0/+13
Windows is now more or less the only platform where Skia gets used. There's also the 'gen' VCL backend on Linux, but that one gets used rarely and it's Skia options are still accessible in the expert configuration. Change-Id: Ibec9b8b15e9200f003367b4568432ce93ec63893 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94708 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-22Prefer CoInitializeEx instead of CoInitializeJulien Nabet1-1/+1
As https://docs.microsoft.com/fr-fr/windows/win32/api/objbase/nf-objbase-coinitialize?redirectedfrom=MSDN advised. Moreover, it'll make concurrency model explicit Change-Id: I247a49248bf45beb64a7985a7c0d078ee48efe2d Change-Id: I6e755fd516d9fb2dd2a9df0c66d9afd6070447ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94669 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-04remove checkboxes for enabling OpenGLLuboš Luňák1-141/+0
The expert options still stay, but the checkboxes are a bit confusing when also the Skia checkbox is there, Skia is for now the default, and if Skia drawing goes well then the OpenGL drawing method can be slowly phased out. Change-Id: Iaea7e471f27010291abedb644d4728189345e3b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93408 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-17loplugin:flatten in cuiNoel Grandin1-28/+28
Change-Id: I0ea0784ab8c4542747da1e15fa7c60c60bccb602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-25no reason for the FontAntiAliasing setting being UNX-only (tdf#107744)Luboš Luňák1-18/+0
This dates back to the ancient times where no revision control history dares, so no idea why this was so, but it doesn't make sense, as at least Windows can disable AA for fonts too. And if some platform really wants to hide the setting, it should be enough just to hide the UI element, no reason for '#if defined( UNX )' all over the place. Change-Id: I76fc9ad157358321904573079ace5a3fe556f86a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91041 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-11tdf#114694: Make default value in language settings the first elementYusuf Keten1-23/+57
For Languages, to make the default value ​​the first element in the list, I've added 3 parameters to SvxLanguageBox::SetLanguageList(). With this parameters, function adds default value according to its existence before other values. For sorting User Interface and Currency, I removed the make_sorted function. I added std::sort with lambda expressions for both of them. Change-Id: Iae37bfe09aaac4d8ecde1caad7a14e11df551eae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87926 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-10in case of Skia problems force raster mode, don't disable it allLuboš Luňák1-2/+41
Skia's CPU-based raster mode should be safe (at least from driver problems), so it should be enough to make the failsafe mechanism just disable Vulkan use. Also add UI option controlling forced raster rendering. Change-Id: I6be1745782816e5468e55635ae5613b6a6afded6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88206 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-06Add include guards - follow-up for 0c4033a9c69da439b97378b0dc61e867953649ebMike Kaganski1-0/+4
Change-Id: I2910ac7e063b785c845723a2eb265cce96c94ea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06Fix Windows build with HAVE_FEATURE_BREAKPADMike Kaganski1-0/+2
This partially reverts commit ed1ece19d4983ea47b296086aaa0ea91fe11935d Change-Id: Ie945676f0618f80c3258f041fea9b91ee01031d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86263 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-06tdf#42949 Fix IWYU warnings in cui/Gabor Kelemen1-2/+0
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I41ae36eb535cc64f4c4fa73333dbc8aa728865b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85791 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-10missing include (Windows --disable-pch; Translate::ExpandVariables)Stephan Bergmann1-0/+1
Change-Id: Iab20b7e8d7975615c128deb8d02940ede1e8ddd7 Reviewed-on: https://gerrit.libreoffice.org/84862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-10force vclcanvas use with Skia, like it's with OpenGL (tdf#129076)Luboš Luňák1-4/+9
Related to tdf#93870. Change-Id: Ie0cb64c05c0fde6a774ce8558d06943870e775fe Reviewed-on: https://gerrit.libreoffice.org/84758 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-09drop newly unused SfxFloatingWindowCaolán McNamara1-0/+1
Change-Id: I8ac3957579c76a89b9692bdb50cbe7a56e1693e3 Reviewed-on: https://gerrit.libreoffice.org/84444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-27Resolves: tdf#128979 crash/freeze on selecting last theme in listCaolán McNamara1-11/+3
Change-Id: Ie47feb34cfbd6af0788a679ca2b5985ad6f9cbbf Reviewed-on: https://gerrit.libreoffice.org/83927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-27add GUI and configuration options for SkiaLuboš Luňák1-0/+139
Pretty much a copy&paste of OpenGL. There are no settings for choosing which backend Skia should use, as the plan is that simply the "best" one will be selected. Change-Id: I44fa876ab85de98de482a6ed9f814024334686ce
2019-11-26loplugin:staticmethods (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Ie3b1e7d8a048bc161770bfb01f4d94e14a3fdea9 Reviewed-on: https://gerrit.libreoffice.org/83768 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-26loplugin:nullptr (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I2e74a01c3500c1ac646479c571b6806c0fc566c1 Reviewed-on: https://gerrit.libreoffice.org/83769 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-16tdf#44462: add a link to Windows Default apps settings appletMike Kaganski1-0/+39
Add "Windows Default apps" button to Options->General to run system applet to control file associations, in accordance to recommendation from MS [1]. On Windows 10, though, the call to LaunchAdvancedAssociationUI would only bring a system-modal infobanner suggesting the user to go to Settings > Apps > Default apps, as documented at [2]. Since this is what MS considers the correct way to manage application associations, the infobanner should be enough. [1] https://docs.microsoft.com/en-us/windows/win32/shell/default-programs [2] https://docs.microsoft.com/en-us/windows/win32/api/shobjidl/nf-shobjidl-iapplicationassociationregistrationui-launchadvancedassociationui Change-Id: I79cccdd00afac998c028b8e151db66bbd75be985 Reviewed-on: https://gerrit.libreoffice.org/82777 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>