summaryrefslogtreecommitdiff
path: root/cui/source/factory
AgeCommit message (Collapse)AuthorFilesLines
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara2-4/+4
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara2-2/+2
Change-Id: I2a01d78e2e98b35d2cd24dd7d7d2efda41e35ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-18tdf#127533 Make Tip-of-the-Day dialog non-modal and allow multiple tips to openMatt K2-2/+25
The Tip-of-the-Day dialog is made non-modal and stays on-top of the main window while allowing the user to interact with the rest of application. Change-Id: I51e1a3488ab74d8371b71a8585d1512ce051f637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113782 Reviewed-by: Matt K <mattkse@gmail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-04-06remove Application::GetDefDialogParent call in editengCaolán McNamara2-2/+2
and pass in an explicit parent to use Change-Id: I1aa768ec5ac13b2097b78499f964a3590a0ac14e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-01tdf#45735 New UI dialog at app startup to check default file formatsMatt K2-0/+17
On Windows only, and only on a non-admin installation, check on application startup whether the file formats ".ods", ".odt", and ".odp" are registered to be opened by LibreOffice by default. If any of the formats are not default, show a UI dialog informing the user which formats are not default and ask the user to set the defaults. If the user selects "OK" to set defaults then the Windows UI corresponding to the user's Windows version is opened for selecting defaults per program. There is also a checkbox on the dialog to select whether checking is performed on application startup. Also, in Tools -> Options -> General, add a UI checkbox for performing this check on application startup, and refactor the existing button "Windows Default apps" to use the same Windows UI Launch APIs. Change-Id: I5e7258d111ff7da8f68805e60405aec064ddcf7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112370 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-15use GetPopupParent for editeng transient dialogsCaolán McNamara2-4/+4
Change-Id: Ie799643b68ea41b4c4d0d0493755d09d3983d9e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-18lok: run async the Macro Selector DialogHenry Castro2-3/+9
Required to be called by the client side Change-Id: I9c9d22dd249839009bdc6a701553f3b9d776347a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107246 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-11-13tdf#123936 Formatting files in module cui with clang-formatPhilipp Hofer2-15/+8
Change-Id: I473e2950bb9bd53043feeae31a27ae0c2fc7801d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105659 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-11-13Make Split Table Cell dialog asyncSzymon Kłos1-1/+1
Change-Id: I4efbb24f721aa50cc4dbbe78ae1e7e6087f8c876 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103670 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105594 Tested-by: Jenkins
2020-11-06tdf#42949 Fix new IWYU warnings in directories c*Gabor Kelemen1-2/+0
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iac1e7802dbe1efa01c2befdd10406231788d4fc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105315 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-21use tools::Long in comphelper..cuiNoel2-6/+6
Change-Id: I65167999c6049038f8f5d530a0c5cb0552ab0e06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-07Resolves tdf#117463 - Dialog to show UI optionsHeiko Tietze2-0/+10
* New dialog to pick and apply one of the UI variants * Tip-of-the-Day enhanced to execute UNO commands in order to advertise the UI chooser on first start Change-Id: I5e5c4a8e0fb11d11bafc99cc37b7ec244a993781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99957 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-09-18Resolves tdf#97918 - Individual UNO commands for distribution optionsHeiko Tietze2-39/+0
New UNO commands added, SID_DISTRIBUTE_DLG bend to dropdown, ui removed Menus and toolbars adjusted Change-Id: Ic0a3cc299f745a1a0cd18edead1f410ff57a1f1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102272 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-09-13tdf#124176 Use #pragma once in cuiGeorge Bateman1-4/+1
This commit was carried out by a Python script, source of which is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97. Change-Id: Ia0099ecd621f008e497260f26e5754d55d0f09aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102549 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-20Fix typo in codeAndrea Gelmini1-2/+2
Change-Id: Iebaf6a6d31a9819494205f7c838b78bcda1f7c52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101007 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-08Clean-up of abstdlgHeiko Tietze2-22/+3
Unnecessary functions regarding the about dialog removed Change-Id: I739a6b1383a0096ec46e2316da3c5327dafe1675 Follow-up to 39e83e2e4257c56adef13ed1dfeee013a4f45376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99985 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-08-03Clean-up of abstdlgHeiko Tietze2-22/+4
Unnecessary functions removed Change-Id: I32dab4b4c5fe8ff351277cbbd32e0b462443d031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99959 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-07-23Fix Android build, no extension dialog in this partJulien Nabet1-1/+2
Change-Id: If531bcc84eaa15642d9e304a05dac4484f34f511 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99284 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-21tdf#133026: Additions - Parameter support to UNO CommandYusuf Keten2-4/+4
After this patch, parameter support to uno command(.uno:AdditionsDialog) will be available. To use parameter, add "?AdditionsTag:string=YourParameter" to UNO command. Parameters are the tags of extensions on webpage. Change-Id: I0072c7340bda14ee13c21c347e06a04545cba69a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99007 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-06-28No need for the AdditionsDialog if --disable-extensionsTor Lillqvist1-0/+7
Change-Id: If1ed6c860256e656846a1516e8170fb0dbd20499 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97346 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-25tdf#133026: Tight integration of extensions - Additions Dialog first iterationYusuf Keten2-0/+29
- Add the uno command .uno:AdditionsDialog - Add the necessary commands to cui makefiles. - Add the dialog AdditionsDialog for only test - Implement the basic functionality to show up when clicked on the menu/toolbar item. Change-Id: I89dd74e49f5ff246ca355d2f8d1397621b26dea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95593 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-06-09remove the fake SvxScriptErrorDialog codeNoel Grandin2-3/+3
which just forwards to an async real dialog. Change-Id: I61936c4d105b9829042817e6a3cf5e60c451fb6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-21Make Impress Insert Table dialog asyncSzymon Kłos2-3/+3
Change-Id: If8b48cfe983819387c066d3bd81a42dad8947489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94591 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94612 Tested-by: Jenkins
2020-04-28loplugin:makeshared in cuiNoel Grandin2-25/+25
Change-Id: I018df0fc3ee6e07d48d9f30544e7aa8492a6ade0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15Related tdf#130778: New About dialogHeiko Tietze2-8/+30
More flexible dialog logo & about images as SVGs Change-Id: Icefa035893e241a7dee6aa28236e6b89b38477de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91908 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-03-11tdf#125440 Allow raising text import dialog for pasteSamuel Mehrbrodt2-0/+6
This adds an entry to the "Paste special" dialog to raise the Text Import Dialog. This way, users can correctly import CSV/TSV, even when pasting just one line of formatted input. Change-Id: Ic09d7d60a05b14906f166668b38ec0eb8ead2d19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89886 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-17Resolves tdf#129032 - Missing warning when renaming pageHeiko Tietze2-0/+17
Edit field has type normal or error now Edit field and okay button return feedback per tooltip Change-Id: Ib2caf3280227cb00af25889ed111503745b471dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85101 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-03loplugin:constantparamNoel Grandin1-1/+1
Change-Id: If2dee122bf07dc179fd8f6e766442ec1891a5f3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87845 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-21weld gallery panelCaolán McNamara2-8/+9
Change-Id: I4aebb3f90e9943044d106a507972c39434988f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-12-16Related tdf#105225: Remove old background tab page codeJim Raykowski1-4/+0
All uses of SvxBackgroundTabPage have been replaced by a new background tab page derived from the SvxAreaTabPage. This patch removes the SvxBackgroundTabPage code and code used only by it. Change-Id: I83a2a04c0bf908cdc630fa091cd5ccdfb5d9381d Reviewed-on: https://gerrit.libreoffice.org/85194 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-12tdf#105225 New UNO and Writer Web background tab pagesJim Raykowski1-1/+3
Change-Id: Id3e7d1c24d086624f053085e3134792b95188c23 Reviewed-on: https://gerrit.libreoffice.org/64991 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann1-0/+4
...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend loplugin:external to warn about enums". Cases where free functions were moved into an unnamed namespace along with a class, to not break ADL, are in: filter/source/svg/svgexport.cxx sc/source/filter/excel/xelink.cxx sc/source/filter/excel/xilink.cxx svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx All other free functions mentioning moved classes appear to be harmless and not give rise to (silent, even) ADL breakage. (One remaining TODO in compilerplugins/clang/external.cxx is that derived classes are not covered by computeAffectedTypes, even though they could also be affected by ADL-breakage--- but don't seem to be in any acutal case across the code base.) For friend declarations using elaborate type specifiers, like class C1 {}; class C2 { friend class C1; }; * If C2 (but not C1) is moved into an unnamed namespace, the friend declaration must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither qualified nor a template-id and the declaration is a function or an elaborated-type-specifier, the lookup to determine whether the entity has been previously declared shall not consider any scopes outside the innermost enclosing namespace.") * If C1 (but not C2) is moved into an unnamed namespace, the friend declaration must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882> "elaborated-type-specifier friend not looked up in unnamed namespace". Apart from that, to keep changes simple and mostly mechanical (which should help avoid regressions), out-of-line definitions of class members have been left in the enclosing (named) namespace. But explicit specializations of class templates had to be moved into the unnamed namespace to appease <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of template from unnamed namespace using unqualified-id in enclosing namespace". Also, accompanying declarations (of e.g. typedefs or static variables) that could arguably be moved into the unnamed namespace too have been left alone. And in some cases, mention of affected types in blacklists in other loplugins needed to be adapted. And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is not moved into an unnamed namespace (because it is declared in sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler doesn’t give this warning for types defined in the main .C file, as those are unlikely to have multiple definitions." (<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The warned-about classes also don't have multiple definitions in the given test, so disable the warning when including the .cxx. Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4 Reviewed-on: https://gerrit.libreoffice.org/83239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-21loplugin:virtualdead unused param in CreateSvxFormatCellsDialogNoel Grandin2-2/+2
Change-Id: I8455c10d62ae8c3c3e6e543301f8c69a1189456a Reviewed-on: https://gerrit.libreoffice.org/81179 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-09Related: tdf#123765 fix up some screenshottingCaolán McNamara2-1/+26
and add in two special cases for the mentioned cui dialogs Change-Id: Ibd2bf8e9e5bff131f2c009c784652f4500842326 Reviewed-on: https://gerrit.libreoffice.org/80488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-08implement gtk dialog screenshottingCaolán McNamara2-5/+3
Change-Id: If4e570f775bd1e29dfb75cb7e5dd9d9dfc35e654 Reviewed-on: https://gerrit.libreoffice.org/80416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07weld ScreenshotAnnotationDlgCaolán McNamara2-7/+16
Change-Id: I94e42c1d10922170f53af917bba6848c9f006a11 Reviewed-on: https://gerrit.libreoffice.org/80383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20weld OfaTreeOptionsDialogCaolán McNamara2-31/+20
including ability to host a vcl::Window based XWindow hierarchy inside a native widget, e.g. the dictionary extensions have option pages Change-Id: I17d933bac12679e10164214a9045b677291a6557 Reviewed-on: https://gerrit.libreoffice.org/79070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23SmartArt: add Edit Diagram dialogGrzegorz Araminowicz2-0/+34
Currently it displays only text representation of diagram. Change-Id: I3ff12c4abf2ed32f68ea9d7437905afc13279e62 Reviewed-on: https://gerrit.libreoffice.org/77873 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-01Make QR Code callable in calc and writerShubham Goyal2-0/+31
Change-Id: I73793100478c34a7721821cec1f8ccec0174d20c Reviewed-on: https://gerrit.libreoffice.org/74598 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-31tdf#42949 Fix IWYU warnings in cui/source/{c-f}*/*cxxGabor Kelemen2-40/+0
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie5e070d13b771cf3e114c2454d49d77d95934160 Reviewed-on: https://gerrit.libreoffice.org/76506 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-25tdf#42949 Fix IWYU warnings in cui/*hxxGabor Kelemen1-0/+33
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia1b6e58623b64b11cb1a5ac5c7fba73e8cc04d07 Reviewed-on: https://gerrit.libreoffice.org/75522 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-19Move static into the getter functionMike Kaganski1-3/+1
Change-Id: I6a4ed20cc8f208fa59f12d65d3ff8287726db594 Reviewed-on: https://gerrit.libreoffice.org/75939 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-11lokdialog: Convert the Paste Special dialog to async exec for swMuhammet Kara2-1/+7
Change-Id: I0c75def6ea09bcb191a8023421b371b49205e712 Reviewed-on: https://gerrit.libreoffice.org/75378 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-07-10Prepare PasteSpecial for Async-ness (sw, basesh.cxx)Muhammet Kara2-0/+12
This change is needed to make the paste special dialog async exec because the current design relies on return values of inner functions/methods while moving on. After this patch, the dialog creation and execution will not be so deep, so that it will be able to be converted to async exec in the usual way. The duplication in SvPasteObjectDialog::PreGetFormat() coming from SvPasteObjectDialog::GetFormat() will go away when the conversion is complete for all modules. It is only temporarily needed. Change-Id: I55e8aee39c41be6035c89f217f90f79720f32196 Reviewed-on: https://gerrit.libreoffice.org/75016 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-25weld HyperLink DialogCaolán McNamara2-15/+21
Change-Id: Ic861b0a593505828a900fe2163125d6f5584a956 Reviewed-on: https://gerrit.libreoffice.org/74634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-21weld SpellDialogCaolán McNamara3-17/+30
a) use EditEngine instead of TextEngine as the former can be hosted in a foreign widget b) use a SfxGrabBagItem to hold the custom spellchecking info inside the EditEngine c) in longer paragraphs the current word is now auto-scrolled into view d) rename Invalidate to InvalidateDialog Change-Id: Ic6db019c32cdfd5f354c58ee7394fdaa040b86e1 Reviewed-on: https://gerrit.libreoffice.org/74119 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-14weld ExtMgrDialog and UpdateRequiredDialogCaolán McNamara2-3/+3
Change-Id: I97e5cda847fd7f98990a87d0b1ca6d6b8b3f9d0f Reviewed-on: https://gerrit.libreoffice.org/73899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06weld AboutDialogCaolán McNamara2-5/+7
use a native GtkAboutDialog on that platform and refactor the current cui about dialog body to form the body of a vcl AboutDialog use add_button to add the buttons to whichever is preferred of the headerbar or action-area Change-Id: I67e0b36dcb8d3fa08ec4f0397b0f6185b0778675 Reviewed-on: https://gerrit.libreoffice.org/73439 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-01weld SvxThesaurusDialogCaolán McNamara2-10/+25
Change-Id: I09a7b4dcd43af061d0e4be42a7b6a2ebf2331d0d Reviewed-on: https://gerrit.libreoffice.org/73282 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-27tdf#42949 Fix IWYU warnings in include/svx/[sS][a-h]*Gabor Kelemen2-0/+2
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I84fc75e06e61e5391aef6e237c36daad95dedb84 Reviewed-on: https://gerrit.libreoffice.org/72550 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>