summaryrefslogtreecommitdiff
path: root/cui/source/dialogs
AgeCommit message (Collapse)AuthorFilesLines
2021-06-03no need to allocate these on the heapNoel Grandin1-5/+5
Change-Id: Ic4b16e776a731e5e9bea61e99acb7257c5220322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31no-zxing: Unused GenerateQRCode functionJan-Marek Glogowski1-10/+4
... and while at it fix (new?) [loplugin:stringviewparam]. Change-Id: I4b991e58040df8082e141ba3c7a0d1968871d517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116436 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-31Clean redundant SvxBackgroundColorItem and use SvxColorItem instead.Gülşah Köse1-1/+1
SvxBackgroundColorItem is just copied from SvxColorItem. There is nothing special to SvxBackgroundColorItem class. SvxColorItem is a generic item and it's used on many places related with colors. We can use SvxColorItem for background colors too. Change-Id: Iacea31a7557b806e95f5859ff60add9a2626ec05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116282 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins
2021-05-30tdf#136292: Fix crash on invalid JSON from the extensions APIMuhammet Kara1-1/+10
Change-Id: I91ed555f93173dee10e87025b231560693be50b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116390 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-05-28no need to allocate these SfxItemSet on the heapNoel Grandin1-5/+5
use std::optional where the code needs to control the lifetime of the object explicitly Change-Id: Ia550ce051360f68911abc68c945a97d62a637b06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116291 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara14-35/+35
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21move hangul/hanja previews outside radiobuttonsCaolán McNamara1-8/+18
not possible in gtk4 to put an image in here anymore AFAICS, this was always an odd case anyway Change-Id: I0525720f53046bf8d234e4beb85096c90235ea10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115920 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21we want the max width here, not the sum of widthsCaolán McNamara1-1/+1
Change-Id: Ie17c062a3e031b85a5784176895c08c9a1638bea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115918 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara1-9/+9
Change-Id: I2a01d78e2e98b35d2cd24dd7d7d2efda41e35ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara1-4/+6
Change-Id: Ib256324f9d14cc2473e62ec4ffe0a18431e2c9cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara2-18/+25
Change-Id: Ice24a1b823301834a6bf7d7956df2e804657f6e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115855 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara1-5/+6
doesn't seem sensible to listen to the prop checkbox in this handler Change-Id: If514b5a9072e789b6b2cbfc990714e236335d99c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for CheckButtonCaolán McNamara2-6/+6
Change-Id: I73ffd66a6e5eed1f95882e874d9319ecad5550f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115853 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for RadioButtonCaolán McNamara1-24/+29
Change-Id: I8de3daf3799a78c63be2c560afa4a7cc02d63daa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19use toggle instead of click for RadioButtonCaolán McNamara2-4/+4
only listen for one toggle for the button grouping Change-Id: I0c1866c25793ffce50bcf5f5a07fcdc98f64aacc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19ImplPlayWithRenderer never checks its OutputDevice against nullptrCaolán McNamara1-2/+2
just pass a reference instead and spread that around to some similar cases Change-Id: Ifb2dee8c7bf02a9f01982b928c90666cbbdd84fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115759 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-18tdf#127533 Make Tip-of-the-Day dialog non-modal and allow multiple tips to openMatt K1-0/+31
The Tip-of-the-Day dialog is made non-modal and stays on-top of the main window while allowing the user to interact with the rest of application. Change-Id: I51e1a3488ab74d8371b71a8585d1512ce051f637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113782 Reviewed-by: Matt K <mattkse@gmail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-05-11fix leak in SvxHpLinkDlgNoel Grandin2-7/+6
Change-Id: Idefd194a81585efc09d38593a6e40f77733d06ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29remove support for BITMASK in vcl backendsNoel Grandin1-1/+1
Rather use a proper alpha channel if we need transparency. This is another small step towards merged alpha in our vcl layer. I suspect the intent in a lot of this code was to save memory. Which have been a thing way back then, but these days our backends mostly end up doing a copy-and-convert to a real alpha channel anyway, so the existing code is actually now a pessimisation. Change-Id: I4a2bcbb2f76b841f05bc00580f364492829c69de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29tdf#135997: make sure that the two lists are same lengthMike Kaganski1-35/+58
This fixes the strange assumption that when searching the two lists (character names and font names) independently, the two found positions will necessarily correspond to each other. Instead, the positions of the match must be the same, which is implemented now. Also the input from configuration is sanitized. Change-Id: I920de7414387e181e11183b8a22776a72b6be419 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114722 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-28use string_view in INetURLObject::encodeNoel Grandin3-3/+3
Change-Id: Ib686c6872388b02c8939d3b65f6bd25cda348bc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27tdf#137470 use a more proper URL for the extensionsChristian Lohmaier1-2/+2
also hide the download-count, since those numbers are completely made up by the script Change-Id: I15b53a8a023c34ecc6a544b88ad35800891e4327 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114740 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-04-09remove vcl/waitobj.hxxCaolán McNamara1-0/+2
create vcl/locktoplevels.hxx for the utility to set all toplevel windows modally locked Change-Id: I964484d238852e830e1e5c0b86b3bebb3b41a6b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09Recheck include/ with IWYUGabor Kelemen1-0/+1
See tdf#42949 for motivation Change-Id: Ifc253bf800bb1468b5774663a93f4fb30bec81d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113657 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-07lok: async exception dialog messages for VBA macrosHenry Castro1-3/+11
Change-Id: Ia713343541f8102de85f7ac57202780afba3da00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111855 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113686 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-04-06remove Application::GetDefDialogParent call in editengCaolán McNamara1-1/+1
and pass in an explicit parent to use Change-Id: I1aa768ec5ac13b2097b78499f964a3590a0ac14e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-05Related: tdf#141499 don't grab focus during teardown of dialogCaolán McNamara1-0/+2
Change-Id: Ib55825294b4276cf36d7ce13562dc52b71f2a5bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-02vcl: remove GetBitCount and GetColorCount from Bitmap{Ex}Tomaž Vajngerl1-1/+1
We can cast the PixelFormat enum to int for the same information and we can use the enum to reduce ambiguity when possible. Change-Id: I6ea648139465568cdeb12e5f5f75c7b609365bf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113188 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-04-01tdf#141333 use a vertical step increment of one row heightCaolán McNamara1-2/+15
for font feature scrolled window Change-Id: I000d53af7128377930644591a096c94366da281b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-01tdf#45735 New UI dialog at app startup to check default file formatsMatt K1-0/+55
On Windows only, and only on a non-admin installation, check on application startup whether the file formats ".ods", ".odt", and ".odp" are registered to be opened by LibreOffice by default. If any of the formats are not default, show a UI dialog informing the user which formats are not default and ask the user to set the defaults. If the user selects "OK" to set defaults then the Windows UI corresponding to the user's Windows version is opened for selecting defaults per program. There is also a checkbox on the dialog to select whether checking is performed on application startup. Also, in Tools -> Options -> General, add a UI checkbox for performing this check on application startup, and refactor the existing button "Windows Default apps" to use the same Windows UI Launch APIs. Change-Id: I5e7258d111ff7da8f68805e60405aec064ddcf7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112370 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-30tdf#140839 - TotD image sizeHeiko Tietze1-1/+1
Previous size of 100x120 has shown to be too small for thumbnails so we agreed on 150x150 Change-Id: Ia43bc424a164024e8a4ecf851cad3fab4f342e67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113343 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-03-25const OUString -> const OUStringLiteralMike Kaganski1-3/+3
Mostly automated rewrite Change-Id: Ie020a083f898bc126b8fb039d4ecb2e687172da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112965 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-24QR Code Dialog: Change term 'border' to 'margin'homeboy4451-1/+1
This adds a margin around the qr code (white space), not a border. Change-Id: If3e74dfe19dd7f9c063eaa6439810d617a99cb45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112831 Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-03-21Fix GenerateQRCode when ENABLE_ZXING is not definedChristophe JAILLET1-1/+1
Since commit 562d7767f987, 'GenerateQRCode()' returns a OString, not a OUString. Fix the case where ENABLE_ZXING is not defined. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Change-Id: I29d9c559401b49caceb8a8941bbe9962b489e3f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112830 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-21Avoid OUString-to-OString conversion: just generate OStringMike Kaganski1-52/+53
Change-Id: Ied47aa0ca42a73715678482424d7d593d18d25aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112824 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-20tdf#139778 Switch to ZXing for generating QR codehomeboy4451-30/+68
Change-Id: Ief944266d5183bb862afe99ec6b0bdaca4956938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112534 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-18Drop duplicate 'using namespace' directiveMike Kaganski1-1/+0
Change-Id: If235c37cf52cfbfd171a6d1784cf5940c162332a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112618 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-13merge the various SetPointFont via DefaultDevice callsCaolán McNamara2-5/+4
Change-Id: I769bb95c588c7222ff0dc6c4b845dfc3f0d7cbc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112390 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-10tdf#140839 - Scale TotD imageHeiko Tietze1-1/+11
Fix preview size of 100x120px Margin added Change-Id: If1caad336f2c3ce492aa9551a170b9b20a9b8b50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112152 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-03-05Avoid float-cast-overflowStephan Bergmann1-1/+3
...during UITest_sw_options UITEST_TEST_NAME=optionsDialog.optionsDialog.test_moreIconsDialog, > /cui/source/dialogs/AdditionsDialog.cxx:641:17: runtime error: nan is outside the range of representable values of type 'int' > #0 0x2b73f252fab6 in AdditionsItem::AdditionsItem(weld::Widget*, AdditionsDialog*, AdditionInfo const&) /cui/source/dialogs/AdditionsDialog.cxx:641:17 > #1 0x2b73f2562963 in void __gnu_cxx::new_allocator<AdditionsItem>::construct<AdditionsItem, weld::Container*, AdditionsDialog*&, AdditionInfo&>(AdditionsItem*, weld::Container*&&, AdditionsDialog*&, AdditionInfo&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/ext/new_allocator.h:136:23 > #2 0x2b73f25618f8 in void std::allocator_traits<std::allocator<AdditionsItem> >::construct<AdditionsItem, weld::Container*, AdditionsDialog*&, AdditionInfo&>(std::allocator<AdditionsItem>&, AdditionsItem*, weld::Container*&&, AdditionsDialog*&, AdditionInfo&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/alloc_traits.h:475:8 > #3 0x2b73f2560ea0 in std::_Sp_counted_ptr_inplace<AdditionsItem, std::allocator<AdditionsItem>, (__gnu_cxx::_Lock_policy)2>::_Sp_counted_ptr_inplace<weld::Container*, AdditionsDialog*&, AdditionInfo&>(std::allocator<AdditionsItem>, weld::Container*&&, AdditionsDialog*&, AdditionInfo&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr_base.h:526:4 > #4 0x2b73f2560222 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count<AdditionsItem, std::allocator<AdditionsItem>, weld::Container*, AdditionsDialog*&, AdditionInfo&>(std::_Sp_make_shared_tag, AdditionsItem*, std::allocator<AdditionsItem> const&, weld::Container*&&, AdditionsDialog*&, AdditionInfo&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr_base.h:637:18 > #5 0x2b73f255fc3d in std::__shared_ptr<AdditionsItem, (__gnu_cxx::_Lock_policy)2>::__shared_ptr<std::allocator<AdditionsItem>, weld::Container*, AdditionsDialog*&, AdditionInfo&>(std::_Sp_make_shared_tag, std::allocator<AdditionsItem> const&, weld::Container*&&, AdditionsDialog*&, AdditionInfo&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr_base.h:1294:14 > #6 0x2b73f255f9bb in std::shared_ptr<AdditionsItem>::shared_ptr<std::allocator<AdditionsItem>, weld::Container*, AdditionsDialog*&, AdditionInfo&>(std::_Sp_make_shared_tag, std::allocator<AdditionsItem> const&, weld::Container*&&, AdditionsDialog*&, AdditionInfo&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr.h:344:4 > #7 0x2b73f255f5b7 in std::shared_ptr<AdditionsItem> std::allocate_shared<AdditionsItem, std::allocator<AdditionsItem>, weld::Container*, AdditionsDialog*&, AdditionInfo&>(std::allocator<AdditionsItem> const&, weld::Container*&&, AdditionsDialog*&, AdditionInfo&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr.h:690:14 > #8 0x2b73f253e5b1 in std::shared_ptr<AdditionsItem> std::make_shared<AdditionsItem, weld::Container*, AdditionsDialog*&, AdditionInfo&>(weld::Container*&&, AdditionsDialog*&, AdditionInfo&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr.h:706:14 > #9 0x2b73f2510e97 in SearchAndParseThread::Append(AdditionInfo&) /cui/source/dialogs/AdditionsDialog.cxx:317:20 > #10 0x2b73f2517167 in SearchAndParseThread::Search() /cui/source/dialogs/AdditionsDialog.cxx:357:17 > #11 0x2b73f251c5fe in SearchAndParseThread::execute() /cui/source/dialogs/AdditionsDialog.cxx:426:9 > #12 0x2b6ecdd21dd7 in salhelper::Thread::run() /salhelper/source/thread.cxx:40:9 > #13 0x2b6ecdd2401f in threadFunc /include/osl/thread.hxx:189:15 > #14 0x2b6ebabcdda8 in osl_thread_start_Impl(void*) /sal/osl/unx/thread.cxx:264:9 > #15 0x2b6ebca70ea4 in start_thread (/lib64/libpthread.so.0+0x7ea4) > #16 0x2b6ebd3a696c in clone (/lib64/libc.so.6+0xfe96c) (<https://ci.libreoffice.org/job/lo_ubsan/1939/>) in code introduced with 48a796c5bbdf897228eb4125512e4f80527f4b55 "tdf#133026: Additions: Rating image implementation", when additionInfo.sName is "Colibre Icon Theme Legacy" and additionInfo.sRating is "NaN". (All those additionInfo strings are apparently obtained from remote JSON data in parseResponse, cui/source/dialogs/AdditionsDialog.cxx.) Change-Id: I073990870c432591ee66fe5ec9580e46ea7e716a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112017 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-02tdf#114567 tdf#138934 Hyperlink-Target in Doc Headings expand/collapseJim Raykowski1-1/+47
Provides parent child expand/collapse for Headings in the Hyperlink- Target in Document dialog target treeview Change-Id: I8cc57b4cbf3830cec76d64a0ef587e199c39e360 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109930 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-02-23loplugin:refcounting in cuiNoel1-4/+2
Change-Id: I09b71657f9f5fef733cbaae8a2eda457735b50cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111368 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-18tdf#57667 Add to autocorrect button should fix the wrong word when clickedQuan Nguyen1-0/+2
Add ChangeHdl to ExtClickHdl if handle m_xAutoCorrPB in SpellDialog Change-Id: Iea47c64a932479e6af3e3f2482527bb6cf8a324f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110618 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-17loplugin:referencecasting in cuiNoel1-1/+1
Change-Id: Id73971bdd986101eeb53bf0b140ef6a7c72191a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-15use GetPopupParent for editeng transient dialogsCaolán McNamara2-2/+2
Change-Id: Ie799643b68ea41b4c4d0d0493755d09d3983d9e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-13tdf#137779 Add info about Jumbo sheets status into About dialogdipanshu1241-0/+6
Since Jumbo sheets is an experimental feature, user enabling it might get problems. It will be good to specify Jumbo sheets status (if enabled) in the About Dialog. Change-Id: I1238d15ea8e32a418754b4323ba9771b63337301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110800 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-01-28add string_view variants of methods to O[U]StringBufferNoel1-2/+2
and update the stringview loplugin to detect cases where we can use these new methods. Change-Id: I998efe02e35c8efcb3abfb4d7186165bbe6dfb2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-26loplugin:passstuffbyrefNoel1-1/+1
Change-Id: I330e0ab6c9955939dad313f9d472f93e39dbd313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-18Revert "Try to fix Windows TB"Julien Nabet1-4/+3
Try to apply Stephan's suggestion in https://gerrit.libreoffice.org/c/core/+/109464: "Instead of explicitly specifying the std::min template argument, it would be better to cast the '300L' to the appropriate type. (And do not change the std::max at all, which should be working fine?) That way, if the type of Height() should ever change to a type larger than tools::Long, the std::min call wouldn't silently truncate the first argument." This reverts commit 648edf96cde392545749923dc0c748e0bb31b5f6. Change-Id: I1e3cb70750d979468556ced7e7942abcb17fca98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109544 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-17Try to fix Windows TBJulien Nabet1-3/+4
by using std::max<tools::Long> and std::min<tools::Long> Change-Id: I07c93227cf040f159d1977ca94988169ecd6dc14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109464 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 06:25:20 +0000