summaryrefslogtreecommitdiff
path: root/cui/source/dialogs
AgeCommit message (Collapse)AuthorFilesLines
2016-10-24screenshot annotation: More readable markupfeature/screenshotannotationKatarina Behrens1-20/+27
this should placate clang too Change-Id: Ida2cceebd5870b5896fb125e51e4cb67ad253d92
2016-10-24screenshot annotation: put back removed fieldsKatarina Behrens1-4/+8
I hate you loplugin !!! Change-Id: I01067b04005a59b7ecb10a5a72ab6090b7f040a8
2016-10-24screenshot annotation: insert markup for annotated widgetsKatarina Behrens1-1/+22
Change-Id: I82b8c541239271e3acfa6d8ad45b752fa1554931
2016-10-24screenshot annotation: Display markup for embedding the imageKatarina Behrens1-2/+43
Change-Id: I06fd744fabd66ee02123790718a899d9e0dcb6b7
2016-10-20Handle link click directly in FixedHyperlinkSamuel Mehrbrodt1-28/+0
Change-Id: I5b5f0648b6e6432b0928351a17d285df8c9da811
2016-10-19loplugin:expandablemethodds in cuiNoel Grandin3-15/+14
Change-Id: I7b2321d45171f9b73965efea32832a3789f0dee7 Reviewed-on: https://gerrit.libreoffice.org/30011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18tdf#89307: Removed T* SvRef::opeartor &()Jacek Fraczek1-2/+2
Usage has been replaced with SvRef::get() or removed where applicable. Change-Id: I49f108910b668466134c40940b53fc3ab2acd816 Reviewed-on: https://gerrit.libreoffice.org/29780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-12[GSoC] Move all fill style tabs inside area tabRishabh Kumar1-4/+0
Change-Id: I89e84b7b3c7075ad4107e7bc444ea5c07bc90795 Reviewed-on: https://gerrit.libreoffice.org/27866 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-12loplugin:unnecessaryoverride in connectivity/cuiNoel Grandin1-5/+0
Change-Id: I5ec4eb2f74036e42851333e3d669dbea58c2490a Reviewed-on: https://gerrit.libreoffice.org/29687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10tdf#101442 Change "hyperlink" to "link" for a modern vocabularyFederico Bassini1-3/+3
Change-Id: Ib1c067b6d45e959d6cd0fbf00cab167939554203 Reviewed-on: https://gerrit.libreoffice.org/29572 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-06I can't see any evidence of any remaining magenta mask using image resourcesCaolán McNamara2-30/+11
Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
2016-10-05convert MapUnit to scoped enumNoel Grandin7-12/+12
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann31-188/+188
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-25tdf#96505 Get rid of cargo cult "long" integer literalsRosen1-7/+7
Change-Id: Ic1602a57d1662cb30b2339de9eeb6483fdfbef37 Reviewed-on: https://gerrit.libreoffice.org/29242 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-22loplugin:unusedmethods in chart2..svxNoel Grandin1-13/+0
Change-Id: Ifb6045885049733415895f58cdd911256f48323c Reviewed-on: https://gerrit.libreoffice.org/29187 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22loplugin:unusedmethods unused returnsNoel Grandin1-8/+1
Change-Id: I4da3374e31d3c7407b401d66275da7f56ae83d30 Reviewed-on: https://gerrit.libreoffice.org/29178 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22convert UPDATE constants to typed_flagsNoel Grandin1-42/+43
Change-Id: If32ec675678acf08febc82a48ae43f2358026f76
2016-09-22convert COLORMODE_RGB constants to scoped enumNoel Grandin1-49/+48
Change-Id: I41d13e08d721402442fe807181bac19f5853debe
2016-09-20loplugin:unusedfieldsNoel Grandin1-10/+3
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16loplugin:singlevalfields in basic..idlNoel Grandin1-2/+0
Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14loplugin:constantparam in chart2..connectivityNoel Grandin4-36/+11
Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d Reviewed-on: https://gerrit.libreoffice.org/28834 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann3-7/+7
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-04cppcheck: redundantIfRemoveJulien Nabet1-5/+1
Change-Id: I8576c5042265399de6d9c72ffd67bce0fb256923 Reviewed-on: https://gerrit.libreoffice.org/28661 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-02boost::intrusive_ptr->tools::SvRefCaolán McNamara1-2/+2
Change-Id: I4c913dc62efe3f3747e78670f4efb0216d95c4ad Reviewed-on: https://gerrit.libreoffice.org/28585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-30Resolves: tdf#97055 hyphenation claims its already active after closingCaolán McNamara1-3/+6
cancel button works, hyphen all works, but closing it via wm close skips the cancel callback. simplest thing seems to be to call SpellEnd when necessary, flagging that its not necessary by disabling the close button on the RET_OK case Change-Id: Ib0a67c4395e9d20941e735ebb14f6bd7f7ddb66c
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (cui)Stephan Bergmann1-3/+3
Change-Id: I75013800fca4475ff2cb93a1f5c34cd37b93bc6e
2016-08-30convert RECT_POINT to scoped enumNoel Grandin1-11/+11
Change-Id: I3f0304d69d5d638230b64135c73497192dc00cb3
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann1-1/+1
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-29loplugin:vclwidgetsStephan Bergmann1-1/+1
Change-Id: Icce2f463d9263de4c0e40b38600677dbe74d83b3
2016-08-29loplugin:unreffunStephan Bergmann1-5/+0
Change-Id: If65f8ef5accad8d6317b07938ec97c7b129763b5
2016-08-28loplugin:salboolJochen Nitschke1-1/+1
Change-Id: Icfc96f978a0fd73ceadbe3a4d57b9758e244ff2b Reviewed-on: https://gerrit.libreoffice.org/28436 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-28loplugin:implicitboolconversionJochen Nitschke1-1/+1
Change-Id: I6fa51f65e75ca84f746ff5d1c7dcf97a5225d2d2 Reviewed-on: https://gerrit.libreoffice.org/28435 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-28loplugin:defaultparamsJochen Nitschke1-3/+2
Change-Id: I9e6b81855e421186af92e53c71f5ba9bd8005319 Reviewed-on: https://gerrit.libreoffice.org/28433 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-08-28screenshot: fixup some details for screenshot dlgArmin Le Grand1-24/+41
Edge-rounding and linewidth for selection/cursor, default filename for save dialog. Code cosmetics. Change-Id: I8a76d68f4f3070458ec4ba51a81bb046057218ab
2016-08-28screenshot: added functionality to dialogArmin Le Grand2-0/+599
Moved code to cui, added abstraction for AbstractDialog, adapted rendering, changed selection, added better selection visualization, added save ressources and dialog, creating pure screenshot with annotation display Change-Id: I533d9f559ee17cd46105b934bcf4beef87b96168
2016-08-25convert FmSearchProgress::State to scoped enumNoel Grandin1-7/+7
Change-Id: I7ca1afedd6ca9b626c1e61322bffc66016ec7d58
2016-08-18convert PageType to scoped enumNoel Grandin1-1/+1
and move it inside CUI, since it's only used there Change-Id: I83ac1afaa60da9fb34480363a351608b133154cb
2016-08-16Remove unnecessary UcbStreamHelper::CreateStream overloadStephan Bergmann1-2/+1
...with an explicit XInteractionHandler, but which was only ever called with a null XInteractionHandler, so could just as well call the overload that doesn't specify one (but internally uses a special SimpleFilaAccessInteraction handler since f60eaab748add19683e66c7e4bc073c9ce7887f7 "Related: tdf#99312, add specialized interaction handler", which is probably also what is wanted for these two calls to UcbStreamHelper::CreateStream in cui and sd). Change-Id: I2bf7bebd32f1c06b7414a4646631a19b689ee52f
2016-08-11loplugin:constantparamNoel Grandin1-22/+18
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05loplugin:countusersofdefaultparams in chart2..desktopNoel Grandin1-1/+1
Change-Id: Iaca94acd6ef91f07ed0c0085390500c418099dee Reviewed-on: https://gerrit.libreoffice.org/27896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04tdf#100726: Improve readability of OUString concatenationnadith7-52/+18
module cui and dbaccess fixed Change-Id: Ief6fca46622fe4e0da804c9a874f7ec93a0fd7af Reviewed-on: https://gerrit.libreoffice.org/27770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01[GSoC] Add functionality to disable buttons in SvxMessDialogRishabh Kumar1-0/+13
Change-Id: Ib25b65a6d1fd760d2a8535c1a97cfbb889d7a824 Reviewed-on: https://gerrit.libreoffice.org/27715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-28cui: fix Android buildMiklos Vajna1-0/+4
Change-Id: I6396d7702de42ad2cec3843e919cca084e92c008
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara4-7/+7
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-18Resolves: tdf#100896 crash in hyperlink dialogCaolán McNamara1-1/+11
regression from... commit 98747742b20c82382ed16b193e7bec175e905978 Author: Noel Grandin <noel@peralex.com> Date: Fri Jun 24 13:12:25 2016 +0200 loplugin:singlevalfields in cui which cut too deep Change-Id: I0e42eed48196c9e037ba343eea93c2c854c0991c
2016-07-15new loplugin unnecessary overrideNoel Grandin2-28/+0
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-11removed deprecated FileDialogHelper::SetDisplayDirectoryNoel Grandin1-2/+4
and convert usage of it Change-Id: I2e3a71ec94492e5482bdf720d256e67adaf3f095 Reviewed-on: https://gerrit.libreoffice.org/26951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-10Remove redundant SvxGet* wrappers around LinguMgr functionsStephan Bergmann2-12/+12
Change-Id: Ic431ce4880d0c1277ddb411ca59b3c8e8ca36518
2016-07-08SvxGetOrCreatePosDic parameter is unusedStephan Bergmann1-1/+1
...ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import", so kill the equally old "TODO: remove argument or provide SvxGetIgnoreAllList with the same one" comment for good now Change-Id: Ie7b64306b8d06fc72d0bb49cc1e5fa3b00f59d6b
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2-2/+2
Change-Id: I51957af512cae8ec838fd9b14bd576356edd2611