summaryrefslogtreecommitdiff
path: root/cppuhelper/source
AgeCommit message (Collapse)AuthorFilesLines
2015-08-17tdf#84323: Make osl::Thread::wait more readableStephan Bergmann1-2/+2
Change-Id: I33eb6970050a103404344c7f16dd33349c154347 Reviewed-on: https://gerrit.libreoffice.org/15018 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-07-29com::sun::star-css in cppu,cppuhelperNoel Grandin6-132/+132
Change-Id: I84a412f587fd66f6c0610f083e61cf0fa079d4d9 Reviewed-on: https://gerrit.libreoffice.org/17384 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-08Fix typosAndrea Gelmini1-1/+1
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-03Fix typosAndrea Gelmini1-1/+1
Change-Id: Ideb5688a8c9e7cf10038f2e9d00991e8653b1875 Reviewed-on: https://gerrit.libreoffice.org/16706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-29Revert "return and use std::vector from OInterfaceContainerHelper"Noel Grandin2-51/+63
This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
2015-06-29return and use std::vector from OInterfaceContainerHelperNoel Grandin2-63/+51
since most of the time we don’t need a heavyweight uno::Sequence. Adds a new method getElementsAsVector(). Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a Reviewed-on: https://gerrit.libreoffice.org/15747 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann1-2/+1
Change-Id: I5fe4002c3c0065dfe93be0d8f47df90d57af898b
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe4-13/+13
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-09cppcheck: noExplicitConstructorCaolán McNamara7-12/+12
Change-Id: Ic33ee6936f40bec4f3a82aea39a180ae6e9a0928
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann3-8/+8
Change-Id: I4eea017d429945cdd8636c0f06cb18f5887a0d78
2015-05-15tdf#62475: partial handmade fixesAndrea Gelmini1-4/+0
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4 Reviewed-on: https://gerrit.libreoffice.org/15712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-02cppuhelper: Allow logging the used services / constructors.Jan Holesovsky1-0/+2
Change-Id: I9090561032e2f6e97eb74b8f1e8cd1698171e6ea
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann5-0/+5
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin3-10/+10
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-09convert RegError to scoped enumNoel Grandin1-12/+12
Change-Id: I55977c38578cb59deb195d91f8948da2e0905b6a
2015-04-09convert RegValueType to scoped enumNoel Grandin1-1/+1
Change-Id: Ic672e75db4d7323760577b19490ffa28d38965b6
2015-04-09convert REG_ constants to scoped enumNoel Grandin1-1/+1
Change-Id: I11d92218c5e0678d497f8964723033e2bd8b3300
2015-04-01Add support for cppu::UnoType<void>Stephan Bergmann1-1/+1
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann10-55/+48
Change-Id: I620bf5d46c19f0182e822265eadf8eb11001855e
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann4-8/+8
Change-Id: I0392b2fc9e48aab4a20849d8203cae96b1ef2d2c
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann5-52/+52
Change-Id: I92c0a6c602e473b796df43b88c98b823de8d9399
2015-03-27loplugin:staticfunctionNoel Grandin1-2/+2
Change-Id: Id796b799f8e2fcc3eae98d43800c5e31fec27fef
2015-03-15Typo: constarined->constrainedJulien Nabet1-1/+1
Change-Id: I3326843195e6a3b030409ac3b20bbea55e739366
2015-03-12CppCheck cleanlyness : reduce variable's scopeMichaël Lefèvre1-3/+2
Change-Id: I5bd18b1a93f7197121eb42f6b82d2d8d87e7671f Reviewed-on: https://gerrit.libreoffice.org/14843 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-18TyposJulien Nabet1-3/+3
Change-Id: I845a85e1aad4a0708f2b43f7d94606b4b5513ee4
2015-01-28Use vector::dataStephan Bergmann1-2/+2
...in some places where it is obvious that it does not hurt that for an empty vector the obtained pointer is not necessarily a nullptr. Change-Id: Id5d66b1559ca8b8955d379bcdbfae6986ef46a51
2015-01-27Get rid of std::auto_ptr in stable URE interfaceStephan Bergmann2-41/+35
...the deprecation-warning noise is getting ever louder, and eventually auto_ptr will just disappear. Just surrender and use good-old plain pointer and deletion in dtor---it's probably the best to do in this stable interface. The change is backwards compatible. For one, in all relevant standard libraries (libstdc++, even in debug mode; libc++; msvcrt) sizeof(auto_ptr<T>) equals sizeof(T*). And for another, the removed UnoUrlDescriptor ctor was only called from within cppuhelper and had deliberately been left out of cppuhelper/source/gcc3.map (so isn't exported at least on Linux)---marking it SAL_DLLPRIVATE had probably just been forgotten when retrofitting cppuhelper with CPPUHELPER_DLLPUBLIC annotations. Change-Id: Ic8bce29d93938f2b2e0a264baee85132668e1294
2015-01-25coverity#1266445 Explicit null dereferencedCaolán McNamara1-5/+7
Change-Id: I2d62d6972d085fe818ec6767a0660afb010bece8
2015-01-20Some more loplugin:cstylecast: cppuhelperStephan Bergmann3-7/+7
Change-Id: Ifc11a0ea20a4eec40544cd931d0f94e0db3e3288
2015-01-16Variadic cppu::WeakComponentImplHelperStephan Bergmann1-5/+4
Change-Id: I79371b4ad9d29a5ab8fd01244c3f80db92b07f97
2015-01-16Fix getTypes() of OPropertySetHelper and derivedStephan Bergmann1-6/+4
...broken with 60d60caf99a40ca0c3891bf230c5a1fdbae5f49c "Renamed XPropertySet2 to XPropertySetOption" et al Change-Id: I684736ffafc4642548b7c24171cc52c1acb32252
2015-01-07-Werror=array-boundsStephan Bergmann1-2/+1
Change-Id: I6766ccc5e760b34a4e276c1322745533a00131fa
2015-01-07drop crashrep unused since start of LibreOfficeCaolán McNamara1-1/+0
Change-Id: I3df1216054c133314b2317849744a0a37e9fbc8f Reviewed-on: https://gerrit.libreoffice.org/13733 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07Variadic cppu::WeakImplHelperStephan Bergmann1-2/+2
Change-Id: Ia02a7c94ca282f28fa3c191dd65a71b6bf031792
2014-12-27boost::unordered_map -> c++11 std::unordered_mapCaolán McNamara2-3/+2
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
2014-12-22-Werror,-Winfinite-recursionStephan Bergmann1-1/+1
Change-Id: I483cd3f3a3ba87c416985fd86b9d5b711a2a18fb
2014-12-16cppuhelper: Use appropriate OUString functions on string constantsStephan Bergmann2-6/+3
Change-Id: I52a38a07982801087903817ec5b65e992a1d58d1
2014-12-12cppuhelper: Use appropriate OUString functions on string constantsStephan Bergmann1-2/+2
Change-Id: I7957898ed3172e79888bdb793e304359b10d75d7
2014-12-09rhbz#1036877: Join Java AsynchronousFinalizer thread well before exitStephan Bergmann1-0/+16
AsynchronousFinalizer was originally added as 870a4401c05beec3d31c1f6055a64591edd0a9d9 "INTEGRATION: CWS mtg1: #i57753# Avoid long-running finalize methods" referring to <https://issues.apache.org/ooo/show_bug.cgi?id=57753> " Fix JNI-UNO bridge so that the JVM doesn't run out of memory when a destructor locks the SolarMutex." It is unclear to me how relevant "If JVMs are getting more mature and should no longer have problems with long-running finalize methods, this class could be removed again" really is in practice. After all, advice on hotspot-gc-devel is to avoid finalize() if possible (<http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2014-June/010215.html> "Re: History of finalizer execution and gc progress?"). So stick with this approach of home-grown draining for now (where a home-grown approach using PhantomReferencens would need a dedicated draining thread, too, so would not have much benefit over the existing code in practice). Timely termination of AsynchronousFinalizer threads is achieved by using a dedicated thread per bridge and joining it in the remote bridge's dispose() resp. the JNI environment's new java_env_dispose. Change-Id: Idcef2dbf361a1de22f60db73828f59e85711aea7
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl6-1/+7
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18cid#706201: No need to call access prior to realpath hereStephan Bergmann1-17/+12
...and thus silence a TOCTOU warning Change-Id: I17f36181946616747d84aca6d43e44d180dc8741
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl1-0/+2
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini2-3/+2
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-08fdo#80927: css.office.Quickstart should be single-instance service.Matúš Kukan1-1/+0
Incorrectly converted in a384b21cc40818bf3c918951a086a30b5d9d8022 where SFX_IMPL_ONEINSTANCEFACTORY was used. AFAICS it's the first converted single-instance service which implements css::lang::XInitialization. That's kind of strange but can do its job. sbergman@redhat.com: Three things were necessary in order to not call the ~ShutdownIcon code too late during exit now: * Move the relevant code from ~ShutdownIcon to ShutdownIcon::disposing. * Add a dummy <singleton name="com.sun.star.office.theQuickstart"/> so the service manager will eventually dispose the (single) instance. * In cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments do not shortcut updateDisposeSingleton in that odd case of calling createInstanceWithArguments on an implementation that (effectively) is a singleton (as otherwise the service manager would still not dispose it). It looks to me like that "return inst;" was an inadvertent leftover in 874c481801434d4fac3c50f076bff0fe3a3988b6 "Simplify service manager's tracking of singletons" and wasn't intended to serve some subtle purpose. Change-Id: Icd4d3168ec0bbb820b17ac321fe897ac9f9ce7fc
2014-09-30cppuhelper: std::auto_ptr -> std::unique_ptrStephan Bergmann1-1/+1
Change-Id: I601fac44b272671b2763b45c5ef284cdd44d5066
2014-09-29Adapt cppu::bootstrap to new Mac OS X LibreOffice.app layoutStephan Bergmann1-1/+6
Change-Id: I60db70c38d138455230ee56a26d840aa68885b44
2014-09-25Eliminate memory leak due to circular shared_ptrMatthew J. Francis1-11/+20
Without this, a Data::Implementation can have a circular reference of shared_ptr to itself through .factory1 Change-Id: Ie05545e7ecc0ae85256d2c374fe79f0c678ccf64 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-17cppu and cppuhelper: loplugin: cstylecastNoel Grandin2-6/+6
Add a macro in include/cppuhelper/implbase_ex.hxx to make initialising the type_entry classes a little less verbose. Change-Id: I0904b5b9db269c92bc89e7ce3d6c8b09350c9897
2014-09-12fix access to potentiellement empty stringNorbert Thiebaud1-6/+14
Change-Id: I84fc6b7e5528b677411163ee3c9d05d4f2e6feb2
2014-09-09Make the "Mac-like" or "canonical" app bundle structure always used on OS XTor Lillqvist1-1/+1
In other words, only executable files go in the MacOS folder. Dynamic libraries and bundled frameworks (i.e., LibreOfficePython), and nothing else, go in the Frameworks folder, and all other files go in the Resources folder. Especially, note that Java class files and rc (.ini) files also go in Resources. Such an app bundle structure is what Apple strongly suggests one should use, and it has been hinted that future versions of code signing and/or Gatekeeper will require such a structure. There is still some ugliness thanks to traces of the historical separation of URE from "the office". Like there are two separate "unorc" files, one for URE, one for the LibreOffice application. IMHO, this should be cleaned up, but is probably controversial. (Eek! I now see there are actually *three* unorc files in the app bundle. Not intentional. Need to fix that later.) Change-Id: Idcf235038deb5b8e1d061734993e9f31869b7606