Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: Id980379f57590759ebc9b862aad3c6dfb04ddef7
|
|
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it. Cleaned up some, but something like
grep -FwL sal/log.hxx $(git grep -Elw \
'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)
shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.
Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
|
|
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
|
|
Change-Id: I22ee2cbacad8b19bb55db234e816d401edcf4a35
|
|
Change-Id: I834eb4ecd0fa71caf6fa746901367fac8b538305
|
|
and we can include a few less headers
Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
|
|
Change-Id: I5dc00f7b03b51916b1331c4ba64064a5aa5930c9
|
|
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
|
|
Change-Id: Iec1251648031afa9eddd7445135fb08dc74821bd
|
|
Change-Id: I1e166c7e3b58ed565aaf478fa0b6505d1f68b604
|
|
still leaks the handle of course, but c++izes the code and hides
the leak from coverity as a side-effect
Change-Id: Ieaab1545a98da1d699df93d020f0cb452ddf2516
|
|
Change-Id: Iaba8b9b3415c357990b795b6f23b98929ac5e00a
|
|
Change-Id: I185b29c185094176e0992fc84c9cc82ff93de9c2
|
|
Change-Id: Ia98b32bd8451051750fbf810958bdcfe584ea7be
|
|
Change-Id: I77d06a70f9c000f800b9b31d3b04aafe77754446
|
|
Stumbled across such redundant visibility re-specifications when looking at the
odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in
cppu/source/cppu/cppu_opt.cxx and used in inline code in
include/com/sun/star/uno/Reference.hxx with only a declaration lacking
CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows.
However, this plugin is probably not worth it being run all the time, so
committing it to compilerplugins/clang/store/.
Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
|
|
Change-Id: I82ce1030e69f8794c9fdbdc138541e5d7e0541d4
|
|
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
|
|
Change-Id: Ibb38d8b8395300501caa0fc040f03b06770fd42e
|
|
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
|
|
Change-Id: I6497303e1b2d8d5ffd962489657582387ab974b1
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I7099dcf15843a80c25c7fb508dd9c0e8df6447e0
|
|
to avoid expensive function calls until the refcount reaches 0
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, slightly changing it to
add a uno_type_sequence_destroy to uno/sequence2.h instead of a
uno_type_destructSequence to uno/data.h.
Change-Id: I3bbff3294f2b515fc3c68c4c6c1cb16829f5cc44
|
|
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
it seems to have issues with a < token followed by a :: token.
Change-Id: I8cc6a5b6cf00a233182de273ab6aa8609326aca9
|
|
Add a macro in include/cppuhelper/implbase_ex.hxx
to make initialising the type_entry classes a little less verbose.
Change-Id: I0904b5b9db269c92bc89e7ce3d6c8b09350c9897
|
|
Change-Id: Iaa470f710295e65347c9d12a3bce0d0b68b02417
|
|
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
|
|
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
|
|
Change-Id: Ib8ba49e89d03eaf3b3aae94dbbf121898ba9e8de
|
|
Change-Id: I2f1909f953846f0d0b6fb402b4beb373bba8b2a8
|
|
|
|
Change-Id: Ifbb916e72a00a9e9925fd12e7945f178d7ae200b
|
|
Change-Id: Ib776a6e5397eb9731cf908c4015642c29b320ff6
Reviewed-on: https://gerrit.libreoffice.org/8247
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1288f1f6f38d1475b4eb5272509e479bd9f2552d
|
|
Change-Id: Iafaf65e5b25f5d9e00e1dc73db280f6605ad1de5
|
|
This leaves only aborting stubs (for SONAME stability) for
typelib_static_array_type_init
typelib_typedescription_newArray
typelib_typedescription_newUnion
and completely removes corresponding
typelib_ArrayTypeDescription
typelib_UnionTypeDescription
structs and C++ inline
getCppuArrayType*
functions. None of this should ever have been called by client code anyway, so
while technically an API change it should not matter for practical purposes.
Change-Id: I23769d104d545533bf578762b79994e269d78c22
|
|
Change-Id: Ib269314be090d2d65b593b1c47fea1e10ef2582b
|
|
Change-Id: I724632f66d7ec64e165b039e8b9d8c43a9f5aaa7
|
|
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.
Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
|
|
Convert code like:
buf.append( static_cast<sal_Unicode>('!') );
to:
buf.append( '!' );
Change-Id: Iacb03a61de65a895540940953b49620677b3d051
|
|
This is an additional commit to 66397a4fd222757a8bd651c0c297615319eac4a5
Change-Id: I61df7984090e984f50788d0c2573d3bf8bac233b
|
|
Change-Id: I251f93f421972f8e5ab346af29152cebc17ab875
|
|
Change-Id: I5150eec33228e18e274a8ae4effd3f185851b7f4
Reviewed-on: https://gerrit.libreoffice.org/7103
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
|
|
"UNO_ENV_SUBST:" should not be used.
Change-Id: If23b174de792cd69dc79e70dd8f5e8a31badb96d
|
|
Convert code like:
aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
aStrBuf.append( "ln(x)" );
which compiles down to the same code.
Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
|
|
Convert code like:
aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.
Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
|