summaryrefslogtreecommitdiff
path: root/cppcanvas
AgeCommit message (Collapse)AuthorFilesLines
2017-06-23loplugin:oncevar in cppcanvas..drawinglayerNoel Grandin1-3/+1
Change-Id: I5456aad61fb0dfe6830eae62b91d1a6399d6343f Reviewed-on: https://gerrit.libreoffice.org/39128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke1-1/+0
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-05-31clang-tidy readability-redundant-control-flowNoel Grandin1-1/+0
Change-Id: I832f7ef0f1bd55e365db7e49823fe8bc30390c04 Reviewed-on: https://gerrit.libreoffice.org/38215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30teach redundantcast plugin about functional castsNoel Grandin1-5/+4
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-21cppcanvas: this assert can stayThorsten Behrens1-2/+1
Both sequences are supposed to be 4 - input there does not result from parsing the EMF+ file. Change-Id: Idcfa70d717b75ce226a8bae0ebe073002555ef17 Reviewed-on: https://gerrit.libreoffice.org/37861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-16aliasing(?) gives a ever so slightly different color on hidpiCaolán McNamara1-1/+4
e.g. without hidpi this could probably be reproduced with export SAL_USE_VCLPLUGIN=gtk3 export GDK_BACKEND=x11 export GDK_SCALE=2 and CppunitTest_cppcanvas_emfplus fails with 0x00ff00 instead of 0x00fe00 Change-Id: I1ecd7dce7703ed50fe396e007424a3ec4252d063
2017-05-14tdf#43157: convert cppcanvas module away from OSL_ASSERTChris Sherlock3-3/+3
2nd attempt, this time I've decided makes more sense to just produce a warning. Change-Id: Iaf373a2d38e8f47266b00ea869de38a584788d45 Reviewed-on: https://gerrit.libreoffice.org/37598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-12EMF+ tdf#31814 Add support of reading EmfPlusBoundaryPointDataBartosz Kosiorek3-68/+87
The EmfPlusBoundaryPointData object specifies a closed cardinal spline boundary for a gradient brush. This data is starting point for displaying correctly gradients. Change-Id: I91b01417c6dc00a04dabfc5a035afe9085999240 Reviewed-on: https://gerrit.libreoffice.org/37519 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-05-09EMF+ We already implemented most used EMF+ records.Bartosz Kosiorek1-6/+5
Now it's time to enable warnings, to track not implemented cases, to have clear notification what is wrong with imported image. Change-Id: Ic880a5b7df03e4a98d4700bebb3d0f6d77980505 Reviewed-on: https://gerrit.libreoffice.org/37407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-05-09tdf#31814 EMF+ Fix an issue when not all elements were displayedBartosz Kosiorek2-8/+15
On on EMF+ images generated by ChemDraw, some elements were not displayed. After investigation, occurs that position of points was not read properly in same cases. This commit fixes such cases. Change-Id: I1d01d8defc41f4e437a669ef1268b8e33823cfc1 Reviewed-on: https://gerrit.libreoffice.org/37406 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Tested-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-05-07tdf#31814 Introduce minimal value of line width to fix EMF+ import issuesBartosz Kosiorek1-5/+9
Based on observation of different EMF+ files (eg. exported by ChemDraw), there is minimal value of line width. This commit is fixing all such import issues. Change-Id: I5c26a1b511363eb1e429bf770ad0f482b124ecb5 Reviewed-on: https://gerrit.libreoffice.org/37319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-05-07revert OSL_ASSERT changesChris Sherlock3-3/+3
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert cppcanvas module away from OSL_ASSERT to assertChris Sherlock3-3/+3
Change-Id: I1db04c35cc004a33b0d2586f9eb1d21bc545eb81
2017-05-06EMF Replace magic numbers of pen and brush objectsBartosz Kosiorek3-27/+58
Change-Id: Ia3b6208b3d42b46fbdc9d61bbdea1c790aaf3ba0 Reviewed-on: https://gerrit.libreoffice.org/37268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-05-05Fix typosAndrea Gelmini2-2/+2
To complete commit 0ef94e2b559547bc4e906e7f24e57ff5d642e108 and f12096272e684ddcd8ffa4e34dcb0a680cc594c2 Change-Id: Ie86bbfbd58dd728a013bef221e4d5c8fbcaf8e03 Reviewed-on: https://gerrit.libreoffice.org/37199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-04Fix number of EmfPlusEndContainer recordBartosz Kosiorek1-1/+1
EmfPlusEndContainer record closes a graphics state container that was previously opened by a begin container operation. Change-Id: I80d977ba53b98ef87b70e0dca2008c1980f901f9 Reviewed-on: https://gerrit.libreoffice.org/37217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-05-02loplugin:checkunusedparams in cppcanvas and dbaccessNoel Grandin3-3/+3
Change-Id: Ia66e6326f3d1750b4e46a3f9f7127e7ed4aa99ca Reviewed-on: https://gerrit.libreoffice.org/37068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27crashtesting: more crashing on exporting fdo31814-3.emf to odgCaolán McNamara1-3/+6
Change-Id: I4cb359b426daed6c5d83c4ed4b85fe87de9d739a
2017-04-27crashtesting: crash on exporting fdo31814-3.emf to odgCaolán McNamara1-1/+1
since commit f9af0abce2c266a53f536a207a62bc691213f6a0 Date: Sat Apr 15 01:44:46 2017 +0200 EMF+ Add initial support for EmfPlusStringFormat Object The EmfPlusStringFormat object specifies text layout, display manipulations, and language identification. With this commit the support for font language and country was added. Also Bold style is applied, for strings which needs that. elsewhere the pattern is to mask with 0xff to restrict to the hardcoded 256 size, so do that here too Change-Id: Iba5bcc3fabe836c963b3eef47a864e87425675c7
2017-04-27tdf#47243 tdf#39327 tdf#103639 Proper scaling of SetPageTransformBartosz Kosiorek1-13/+6
The EmfPlusSetPageTransform record specifies scaling factors and units for converting page space coordinates to device space coordinates. In previous implementation I made scaling after translating page scaling. For some images it was working correctly (if there wasn't translating). WIth this commit I fixed this issue. Change-Id: I1e9e78ecdab663328f86a960d8547ad0a7fc1314 Reviewed-on: https://gerrit.libreoffice.org/37010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock1-1/+1
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock1-0/+1
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-24tdf#47243 tdf#39327 Add support for SetPageTransformBartosz Kosiorek1-4/+30
Change-Id: Iea78cf1e9ca99c97814d9eaa4a65ad4b83a2bbe2 Reviewed-on: https://gerrit.libreoffice.org/36749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-24EMF+ Add initial support for EmfPlusStringFormat ObjectBartosz Kosiorek5-8/+155
The EmfPlusStringFormat object specifies text layout, display manipulations, and language identification. With this commit the support for font language and country was added. Also Bold style is applied, for strings which needs that. Change-Id: Id9735a9ddb959aebd20d6d4d1bb5da0fa9c1fb85 Reviewed-on: https://gerrit.libreoffice.org/36555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky3-3/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin1-1/+1
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-16tdf#107159 EMF+ Add support for EmfPlusDrawArc recordBartosz Kosiorek1-4/+13
EmfPlusDrawArc record specifies drawing the arc of an ellipse. Change-Id: I87788a9b14f518a383cbc5b804af635427e4c395 Reviewed-on: https://gerrit.libreoffice.org/36537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-13tdf#106084 EMF+ Add support for EmfPlusScaleWorldTransform recordBartosz Kosiorek1-1/+25
The EmfPlusScaleWorldTransform record performs a scaling on the current world space transform. Change-Id: I03717b28a88d574d597174c6ca3446f937c96a15 Reviewed-on: https://gerrit.libreoffice.org/36320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-13tdf#39053 EMF+ Draw an extra line between the last point and the first point.Bartosz Kosiorek3-4/+12
The EmfPlusDrawlLines record specifies drawing a series of connected lines. Bit 0x2000 indicates whether to draw an extra line between the last point and the first point, to close the shape. In this commit support of additional line which close shape was added. Change-Id: I47ae3d8003cbfdd5b8ff5ba78e1ebe10f97af04b Reviewed-on: https://gerrit.libreoffice.org/36317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-13tdf#106084 EMF+ Add support for EmfPlusTranslateWorldTransform recordBartosz Kosiorek2-11/+49
The EmfPlusTranslateWorldTransform record performs a translation on the current world space transform. Change-Id: I3e5744060c8a6d758bcc2804c6798e0208d2191f Reviewed-on: https://gerrit.libreoffice.org/36287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-13tdf#107034 EMF+ Add support for import EmfPlusDrawPie recordBartosz Kosiorek1-8/+25
The EmfPlusDrawPie record specifies drawing a section of the interior of an ellipse. Change-Id: Icd9d64117cc612d348c531932931f31e4d04e567 Reviewed-on: https://gerrit.libreoffice.org/36286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-13tdf#107019 EMF+ Add support for import EmfPlusRecordTypeDrawBeziers recordBartosz Kosiorek1-1/+49
EmfPlusDrawBeziers record defines the pen strokes for drawing a Bezier spline. Change-Id: I6ae08a861bcbadd373741781af0011528947243e Reviewed-on: https://gerrit.libreoffice.org/36280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-12no need to use OUStringToOString in SAL_INFONoel Grandin1-8/+2
Change-Id: I707e0d72aba89b7e644def6f4c251e14f6599ad2 Reviewed-on: https://gerrit.libreoffice.org/36451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-11tdf#107016 EMF+ Add support of import EmfPlusRecordTypeDrawRects recordBartosz Kosiorek1-31/+32
EmfPlusDrawRectss record defines the pen strokes for drawing a series of rectangles. Change-Id: Iaa061f8502fb51de44d2e65a1c92daf297b79d2b Reviewed-on: https://gerrit.libreoffice.org/36261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-07Replace EmfPlusRecordType decimal valuse with hexBartosz Kosiorek1-33/+55
Change-Id: Ia5f248282e663e86b76a8c90fb5dd55d112f6912 Reviewed-on: https://gerrit.libreoffice.org/36260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-04-06loplugin:redundantcast find cstyle double castsNoel Grandin1-4/+4
Change-Id: I5507be190dac781e5cdb545a60acf3d50056c9f8 Reviewed-on: https://gerrit.libreoffice.org/36187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna5-15/+15
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-08make SfxGetpApp just get and move GetOrCreate to the peripheryCaolán McNamara1-0/+2
Change-Id: If3b22635e46dbccf0fad101f51bb653cbbcd3a32 Reviewed-on: https://gerrit.libreoffice.org/34957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-28FontDescription.IsVertical is a tristateNoel Grandin1-2/+1
found by still in progress "UNO scoped enum" change Change-Id: I0a21b89e77be165bc96e914017a402cf8724d218 Reviewed-on: https://gerrit.libreoffice.org/34719 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-23Better make the zero-initialization more explicitStephan Bergmann1-2/+10
...if initializing these members is necessary at all; a bit hard to tell from the code. Change-Id: I3ddb25c35f0d1b44a092bdb2cb0192ce619f947c
2017-02-15Drop :: prefix from std in c*/Tor Lillqvist5-27/+27
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155 Reviewed-on: https://gerrit.libreoffice.org/34324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-02-03new loplugin:unusedenumconstantsNoel Grandin2-3/+3
These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin1-5/+2
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31tdf#101638 diameter and radius were mixed up, devide by twoPatrick J1-2/+2
Change-Id: Iaece1ca3439ab3e1029156a5847768728b53b96e Reviewed-on: https://gerrit.libreoffice.org/33717 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-01-26Remove dynamic exception specificationsStephan Bergmann2-7/+7
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-24loplugin: unnecessary destructor cppcanvas..filterNoel Grandin1-1/+0
Change-Id: I009cdd60869a67d210edf879ddb451663a7b8676 Reviewed-on: https://gerrit.libreoffice.org/33491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23Split emfplus.cxx into multiple filesMark Page16-1033/+1664
This helps make emfplus.cxx more readable. No source code was changed, only moved except these renamed to avoid inheritance warnings:: EMFPBrush::transformation renamed to brush_transformation EMFPPen::transformation renamed to pen_transformation Change-Id: I6952d6300c9c459833c2dda2b715d851b9e80de7 Reviewed-on: https://gerrit.libreoffice.org/31165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-12-22Dispose Window when doneStephan Bergmann1-1/+1
Change-Id: I6b67d12174c3caa0a4bf230d87421f5768a331f8
2016-12-06convert PolyStyle to scoped enumNoel Grandin1-3/+3
Change-Id: Ia35fdbb5e40888db9558988ac069741b31721f0e Reviewed-on: https://gerrit.libreoffice.org/31633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>