summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2015-08-19comphelper: remove unnecessary include <stack>Michael Stahl1-0/+2
Change-Id: I39295d69dd8a48f0f40275830cb6fda4ca0b69f3
2015-08-19Clean up remaining utl::LocalFileHelper::Convert...Stephan Bergmann1-3/+4
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040 "ConvertURLToSystemPath->getSystemPathFromFileURL" and 28f3464a571a23a2c16bd0980e9021b95d011511 "ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those Convert... functionality with direct calls to the corresponding osl::FileBase functions. Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-17o3tl: rename compat_functional headerThorsten Behrens2-2/+2
After the cleanup, the stuff there really stands on its own (and the remaining usage of select1st/2nd is more descriptive than lambdas). Change-Id: I0aba131d5dc550189f8130d167dc94167e404540 Reviewed-on: https://gerrit.libreoffice.org/17806 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-14loplugin: defaultparamsNoel Grandin6-13/+13
Change-Id: Id0a933d3507bc0f8145afa04effadf8475c8e210
2015-08-11tdf#92459 remove o3tl/compat_functional.hxxDaniel Robertson12-20/+1
Replace all uses of deprecated features from the o3tl included in compat_functional.hxx with lambda expressions in connectivity and reportdesign. The patch should not cause any side effects. The change is largely cosmetic. Change-Id: I2042b91bf0fa2b47cce9ea11c97fa4ca6734c5e2 Reviewed-on: https://gerrit.libreoffice.org/17588 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-11loplugin: defaultparamsNoel Grandin3-7/+7
Change-Id: I906912f29448bfc72e8139546aa09525c959867f
2015-08-05OSL_ENSURE always makes the condition visible to the compiler nowStephan Bergmann1-1/+1
Change-Id: Ifc2f4592fdd4cfebdefc0c4b94656ffc06ddf879
2015-08-05loplugin:unusedmethodsNoel Grandin38-290/+24
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-04cui,connectivity: inline some use-once typedefsNoel Grandin2-6/+4
Change-Id: I1b043031014a3e823cd614966984a2ac2be1ac71
2015-08-03tdf#91112: pass by const reference to lambdasJorenz Paragas7-11/+11
Since the function returned by o3tl::compose1 had its parameter passed by const reference, the same should be done for the lambda expressions that replace o3tl::compose1. I overlooked this detail in my previous commits. Change-Id: I0db5eec4e74d4835e786742ee6de3805215f377f Reviewed-on: https://gerrit.libreoffice.org/17465 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-29tdf#91112 replace o3tl::unary_compose with lambdas in connectivityJorenz Paragas1-14/+11
The replaced code used o3tl::unary_compose directly instead of the helper function o3tl::compose1. Change-Id: Idb5cae2e2a2dae5f8bdc572f475ebb76171fd853 Reviewed-on: https://gerrit.libreoffice.org/17249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-28remove unused UStringDescription structNoel Grandin1-20/+0
Change-Id: Ib92e64e9a8d14f755edc8866979aa6196d0b61f3
2015-07-27remove some unused definesNoel Grandin1-7/+0
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188 Reviewed-on: https://gerrit.libreoffice.org/17332 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-26tdf#92792: Register mork driver on windows 64bit and make it workDavid Ostrovsky1-2/+2
Mork service wasn't registred on windows as it was generally excluded on this platform not matter what architecture was used. Pofile discovery was broken, as XP_WIN wasn't define and the code fall back to use UNIX directories for profile discovery on windows that obviously cannot work. Change-Id: I823378a1a094a2172ba2cb3bf9bdacedb27b36a2 Reviewed-on: https://gerrit.libreoffice.org/17349 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2015-07-21coverity#1312084 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I4b4b263f4448c4d3b83cea57635624b31f757576
2015-07-20cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: Ib9373a5a75eea998a86156ff742e7950369ddc88
2015-07-17error C2065: ´bFound´ : undeclared identifierCaolán McNamara1-5/+1
Change-Id: Ibf72f77458d837849fe20361ca751dce2989830c
2015-07-17formatting of public/private/protected section qualifiersNoel Grandin1-1/+1
make it consistent across the codebase, no space between keyword and the colon Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5 Reviewed-on: https://gerrit.libreoffice.org/17148 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17fix evoab2 buildCaolán McNamara1-0/+1
Change-Id: I944494af60b9805d53a2f1c507b9eb99fd935e9c
2015-07-17tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe92-409/+407
with the variadic variants, for connectivity. Change-Id: I3645a2855e903848936520ac854fc1039fc456e8 Reviewed-on: https://gerrit.libreoffice.org/16971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann3-8/+8
Change-Id: Idb1aa3801ab09022f68aea512df1ddd64348a5b0
2015-07-15loplugin:unusedmethods connectivityNoel Grandin12-72/+2
Change-Id: Ie9f3daa49b02dddc7b56d1f5fb58a229f53d4513 Reviewed-on: https://gerrit.libreoffice.org/17043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann1-4/+1
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13tdf#91112 replace o3tl::compose1 with lambdas in connectivityJorenz Paragas6-44/+36
Change-Id: I8f61471e08fe7f620d76bdcd72eb7f5c35931388 Reviewed-on: https://gerrit.libreoffice.org/16940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-07-10Fix an opposite conditionTakeshi Abe1-1/+1
... slipped in at 54013188b24a1a02491a2853f731461253065424. Change-Id: Ib18b2f12d4ad97b9ec5dd771d5f13b35e0274e33 Reviewed-on: https://gerrit.libreoffice.org/16932 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-10cleanup some unnecessary direct usage of the OString/OUString C API.Noel Grandin2-18/+5
Change-Id: I6edee95aae1c169ce70063562a0c1b287e0c4735 Reviewed-on: https://gerrit.libreoffice.org/16861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-08Fix typosAndrea Gelmini2-2/+2
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-05aDBFColumn.db_typ is input controlledCaolán McNamara1-1/+1
so we can't guarantee that it is valid ascii Change-Id: Icdc6162db4405df729e548a836de5662255088ed
2015-07-03Fix typosAndrea Gelmini9-9/+9
Change-Id: Ideb5688a8c9e7cf10038f2e9d00991e8653b1875 Reviewed-on: https://gerrit.libreoffice.org/16706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-02Fix PostgreSQL function nameAndrea Gelmini1-1/+1
Change-Id: Ic089540c07c7fe7c85705fc3513411a7e2571a12 Reviewed-on: https://gerrit.libreoffice.org/16640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-06-30more change in JNI func sigs between Java 6 and 7 workaroundsRene Engelhard3-5/+45
Change-Id: Ie9cbf1b6dfc79df3a74efd3b9bb31ce33e7be3a0
2015-06-29coverity#1308593 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I3cf82f3f0e859b24d75f8ca8e0daf82b02becb0a
2015-06-29coverity#1308573 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: Ie3ecffe0fe91572ffff6e124075e1be1ef978731
2015-06-29coverity#1308601 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I231a5b94ded2c936edf84ff7dc59332e628150cd
2015-06-28coverity#1308559 Uncaught exceptionCaolán McNamara2-3/+3
Change-Id: Ic133aa4f3709b199529d3940369c990e3357ff87
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann1-1/+1
Change-Id: I5af9cc77f0329148925ac1b4f0de1df7634a7e08
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann1-2/+2
Change-Id: I9a10663f1b428d3f6a6a6d5187b5774076aef75b
2015-06-22Fix typosAndrea Gelmini1-1/+1
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-22Work around change in JNI func sigs between Java 6 and 7Stephan Bergmann1-1/+9
(same as dfba745437324b8e1a352ab5280c665c543fc37f) Change-Id: I3c79b406c2bf661717880def94989614860f9cb6
2015-06-18Fix typosAndrea Gelmini2-2/+2
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe2-3/+3
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17parameter handling: fix confusion between column name and realnameLionel Elie Mamane1-10/+24
Change-Id: I81fd45276183b911e4560ca785221894ea2ebc88
2015-06-17postgresql-sdbc: fixup string2intarrayLionel Elie Mamane1-10/+24
this allows getGeneratedValues to work Change-Id: Ia87e87afa8cdb01f1d39c84bc7d7143c101d8891
2015-06-17postgresql-sdbc: include error message in SQLExceptionLionel Elie Mamane1-1/+1
Change-Id: I9d91503e6beb08f11368fc6b80fefb61f60d4486
2015-06-16Fix typosAndrea Gelmini1-1/+1
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini1-1/+1
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini1-1/+1
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15more untranslatable UI stringsAndras Timar1-1/+1
Change-Id: I4c02d7613743a1b11594fd96f6131219afd102ef
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin1-2/+1
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763