summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2017-08-17Related tdf#111634: Multiple memory leaks in libmacabdrv1 (part3)Julien Nabet2-0/+3
Hope it'll fix leak from https://bugs.documentfoundation.org/show_bug.cgi?id=111634#c13 Change-Id: I61a51faf291145c8cafd03339b7bcc7b23072fba Reviewed-on: https://gerrit.libreoffice.org/41268 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-17remove unnecessary use of OUString::getStrNoel Grandin5-11/+9
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin1-1/+1
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from integer constants in initialiser/call expressionsNoel Grandin1-11/+11
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300 Reviewed-on: https://gerrit.libreoffice.org/41214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11Related tdf#111634: Multiple memory leaks in libmacabdrv1 (part2)Julien Nabet1-0/+2
Delete "sub arrays" of headerNames which is macabfield ** before calling delete headerNames [] Change-Id: I11b6d5483ed91eb2805b68ace1b06eafd23b707d Reviewed-on: https://gerrit.libreoffice.org/41054 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-11Related tdf#111634: Multiple memory leaks in libmacabdrv1Julien Nabet1-0/+2
CFRelease multiLabel since has been created from OUStringToCFString Change-Id: Ic997c026737ebf31049682835d4047f3297f077d Reviewed-on: https://gerrit.libreoffice.org/41003 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-11convert std::map::insert to std::map::emplace IINoel Grandin8-9/+15
Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11convert std::map::insert to std::map::emplaceNoel Grandin12-26/+26
which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08loplugin:unusedmethodsNoel Grandin2-4/+0
Change-Id: Id66cf12e3a59aeed1b9a7a111b841e30b248635b Reviewed-on: https://gerrit.libreoffice.org/40876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08loplugin:constantparamNoel Grandin2-11/+5
Change-Id: Ib92aba17c46a4ada75c2a0630f281759d995f32e Reviewed-on: https://gerrit.libreoffice.org/40843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08loplugin:singlevalfieldsNoel Grandin2-4/+2
Change-Id: I8908479ecf513cdf2ecb4bcbe7c1078ef80671cf Reviewed-on: https://gerrit.libreoffice.org/40838 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-07loplugin:oncevarStephan Bergmann1-20/+10
Change-Id: I9bd2e0a3ae1d0dc59c235e47be6ffa4357164a20
2017-08-07loplugin:useuniqueptrStephan Bergmann3-9/+12
Change-Id: Ie6c1cea3850ddf37aa8b9f4731547650a23f5d29
2017-08-07Remove dead DBG_UTIL codeStephan Bergmann1-21/+0
Change-Id: Icb208bc457eaab06bc14e874c70a25308179785d
2017-08-07-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
Change-Id: I42d1c0c2e6a0746c1c97dba9b02abf1d771b3fc7
2017-08-05silence snprintf warningCaolán McNamara1-9/+7
"note: ‘snprintf’ output between 11 and 19 bytes into a destination of size 11" Change-Id: I2ff3661ddd9c2729a76856e576ba83580b0143ea Reviewed-on: https://gerrit.libreoffice.org/40731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-05refactor to remove the gotosCaolán McNamara1-26/+20
no logic change intended Change-Id: Ia787ff543ce7d55511656f5a462438378654f325 Reviewed-on: https://gerrit.libreoffice.org/40774 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-02add a few const purely for documentation reasonsLionel Elie Mamane1-11/+11
Change-Id: I6b7e5dac24e7aa5d48d6661235059ba29207e1d7
2017-08-02tdf#110997 protect calls to implBuildFromRelative from year overflowLionel Elie Mamane1-4/+28
Change-Id: I5c6768766673832b7271292af85db1b76e51042c
2017-08-02remove unnecessary use of 'this->'Noel Grandin2-2/+2
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-02normalize resource locale ctor construction mechanismsCaolán McNamara1-29/+6
make them all the same and share std::locales more various OModuleClient, etc, classes go away Change-Id: I7e3ff01a69332eeacd22e3078f66a60318de62d5 Reviewed-on: https://gerrit.libreoffice.org/40634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-02connectivity: partially merge OWriterTable and OCalcTableMiklos Vajna7-315/+303
Factor out the common code of these into a new OComponentTable. Change-Id: I57abac05c9b64cde69d17568e325e86b3c530b20 Reviewed-on: https://gerrit.libreoffice.org/40648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-01move resmgr to unotoolsCaolán McNamara2-8/+4
and the vast majority of translations is to the ui language so default ctor with that arg and now drop OModuleResourceClient Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
2017-08-01loplugin:checkunusedparamsNoel Grandin4-22/+29
the "check for taking address of function" part was generating false+ Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f Reviewed-on: https://gerrit.libreoffice.org/40613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31make IntlWrapper arg to GetPresentation non-implicit and non-optionalCaolán McNamara1-5/+5
which requires explicitly adding null in 1) SdrItemBrowserControl::SetAttributes(const SfxItemSet* pSet, const SfxItemSet* p2ndSet) where SdrItemBrowserControl is only used by SdrItemBrowser and the only use of that is within DBG_UTIL in SdrPaintView 2) SwCursorShell::GetContentAtPos( const Point& rPt, within a #ifdef DBG_UTIL block in 3) SvxSearchDialog::BuildAttrText_Impl( OUString& rStr, bool bSrchFlag ) const where the other branch uses SvxResId 4) SfxPoolItem::dumpAsXml(xmlTextWriterPtr pWriter) const 5) XFillStyleItem::dumpAsXml(xmlTextWriterPtr pWriter) const looks very much like all uses (outside the dumpers) are intended to be in the ui locale results in that INetContentTypes::GetPresentation always called with UI Locale Change-Id: I5a110c107838b4db3c355476426d6532f2b6ce52 Reviewed-on: https://gerrit.libreoffice.org/40538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-31loplugin:constparams in formula,xmlhelpNoel Grandin1-1/+1
Change-Id: I1c987d991a5b292df327d1bb921099233b5531fe Reviewed-on: https://gerrit.libreoffice.org/40584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-30tdf#96370 rework filtering to be aware of WHERE vs HAVING clauseLionel Elie Mamane3-14/+166
Several bugs (AFAIK not filed into tdf bugzilla) fixed. Remaining problems: When some filter clauses go into WHERE and others in HAVING, they are always logically ANDed (it cannot be any other way), but that is not communicated to the user in the UI. Some things left undone: * DatabaseDataProvider (and its users?) needs to be updated to be HAVING-aware, too. * Form-based filter (.uno:FormFilter) not HAVING-aware it reads the current filter in function svxform::FormController::setFilter in svx/source/form/formcontrollers.cxx That's one place that needs to be updated. The other place is the one that applies the filter. Change-Id: I0e9d30a1927b6739a16ae7627e8d0dae8823b376
2017-07-28loplugin:constparams handle constructorsNoel Grandin15-19/+19
had to change the structure of the plugin considerably, was too messy to structure it to do the calculations on a per-function basis Change-Id: I4edee7735f726101105c607368124a08dba21086 Reviewed-on: https://gerrit.libreoffice.org/40516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28loplugin:checkunusedparams more part2Noel Grandin3-5/+3
Change-Id: Ibb940c2a7098313dfa282734894b1abc1ac40bc2 Reviewed-on: https://gerrit.libreoffice.org/40489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28loplugin:checkunusedparams more part1Noel Grandin3-8/+2
seems I got one of the checks wrong, and was missing a bunch of stuff Change-Id: I2c662fc4e735f8d6cbe56c6f82906a60a580331b Reviewed-on: https://gerrit.libreoffice.org/40481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25loplugin:unusedmethodsNoel Grandin3-5/+0
Change-Id: Ia874baf21257e5fe41e104211068a2bcc50446eb Reviewed-on: https://gerrit.libreoffice.org/40391 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25use more comphelper::InitAnyPropertySequenceNoel Grandin1-14/+6
Found with: git grep -n -A10 'Sequence.*Any' -- *.cxx | grep -B5 -w PropertyValueProvider and: git grep -n 'Sequence.*Any.*( *&' Change-Id: Icb18c98bdd3f8352817e443ff78de5df042859ad Reviewed-on: https://gerrit.libreoffice.org/40389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-24add libebook-1.2.so.19 in EApi.cxxRico Tzschichholz1-0/+1
Change-Id: I900a190948087360bb4c3cd9235c9848333ad66f Reviewed-on: https://gerrit.libreoffice.org/40358 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-24loplugin:unusedfields some untouched fieldsNoel Grandin4-11/+8
which lead to a whole bunch of dead code in vcl/.../i18n_status.cxx Change-Id: Id8eeadeb9cbc6107e1a0dac5801ce20b2b9ae6dc Reviewed-on: https://gerrit.libreoffice.org/40355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-23loplugin:unnecessaryvirtualNoel Grandin1-2/+2
Change-Id: Id3f0bbcae731d777ac7c1fbc9f020ff35833864b Reviewed-on: https://gerrit.libreoffice.org/40323 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:unusedfields in basctl..connectivityNoel Grandin2-3/+1
Change-Id: I2f10daadb84e48eaf96f6cc63899b2f4fce7326e Reviewed-on: https://gerrit.libreoffice.org/40295 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-21Eliminate Date::operator+=() and -=() and replace with Date::AddDays()Eike Rathke1-2/+2
Clarifies code and gets rid of explicitly casting the operand to sal_Int32. Also in preparation of removing DateTime::operator+=(sal_Int32) that is confusingly similar to DateTime::operator+=(double) and just depends on type. Change-Id: I83422e2940fbb017978db9b5734b4966228af3de Reviewed-on: https://gerrit.libreoffice.org/40248 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-21de-hrc various thingsCaolán McNamara10-134/+0
e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
2017-07-21migrate to boost::gettextCaolán McNamara101-1247/+389
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-19Change the most obvious Date+=(long)... to Date+=static_cast<sal_Int32>(...)Eike Rathke1-1/+1
Simple search git grep -l 'Date.*[+-].*[(<] *long *[>)]' Since commit f5b0cc2a3690ba963b3f150886e1d5ddddee9530 Date: Sat Jul 1 16:01:15 2017 +0200 Date operators +,-,+=,-= have sal_Int32 operands instead of long. Change-Id: I2387cbceadcb056831225e4111353980d50a94d4 Reviewed-on: https://gerrit.libreoffice.org/40163 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-19connectivity: merge OCalcColumns and OWriterColumnsMiklos Vajna9-112/+17
Turns out createObject() only needs the base class OFileTable, and then these can be shared. Change-Id: I6e8a83155dbbbc3d85794e190c2e710d01902017 Reviewed-on: https://gerrit.libreoffice.org/40183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19connectivity: merge OCalcPreparedStatement and OWriterPreparedStatementMiklos Vajna9-100/+16
Into a single OComponentPreparedStatement, as both of them just provide prepared statement functionality based on a file loaded into an LO component, so they can share code. Change-Id: Ib1074871d63de83f16861081050e57442ebf0ffa Reviewed-on: https://gerrit.libreoffice.org/40182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19connectivity: merge OCalcStatement and OWriterStatementMiklos Vajna9-103/+16
Into a single OComponentStatement, as both of them just provide statement functionality based on a file loaded into an LO component, so they can share code. Change-Id: Iad2852f93783ec3c4a672f4b86424b4aa0ae8eaf Reviewed-on: https://gerrit.libreoffice.org/40181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19connectivity: merge OCalcResultSet and OWriterResultSetMiklos Vajna11-301/+50
Into a single OComponentResultSet, as both of them just provide data source functionality based on a file loaded into an LO component, so they can share code. Change-Id: I19352e592a45d7a58d834e72645dec72d77ce7c9 Reviewed-on: https://gerrit.libreoffice.org/40180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19loplugin:constparams in connectivityNoel Grandin40-101/+102
Change-Id: I9b81c6227fb3c89a832640058a11444f72019694 Reviewed-on: https://gerrit.libreoffice.org/40155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-18connectivity writer driver: mention Writer in display nameMiklos Vajna1-1/+1
It was just "Document" to be consistent with Calc's "Spreadsheet", but it's confusing as we have a Text driver as well. Change-Id: I9ec10f49c3f2bdab7d8f92a9ee0a44b4536e83eb Reviewed-on: https://gerrit.libreoffice.org/40135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18connectivity writer driver: add Statement implementationMiklos Vajna4-3/+88
Gets rid of the OWriterConnection::createStatement() stub warning. This is the last interface which was not supported by the writer driver, as far as I see. Change-Id: I5d1e6835d30b704d6866f2cc4cd9e82ea0f2139e Reviewed-on: https://gerrit.libreoffice.org/40134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18connectivity writer driver: add ResultSet implementationMiklos Vajna4-2/+255
Now column headers and table data show up on the UI. Change-Id: I84100c5a7ac65c3be1e985be8ae7195835c45145 Reviewed-on: https://gerrit.libreoffice.org/40128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18-Werror,-Wunused-private-fieldStephan Bergmann2-2/+0
Change-Id: Idd356214b553eadf5030115fc60a526e4428b1bb
2017-07-18connectivity writer driver: add PreparedStatement implementationMiklos Vajna4-4/+91
Gets rid of the stub warnings in OWriterConnection::prepareStatement(). Change-Id: I05db81898d8117578130e660932608fcc927edf0 Reviewed-on: https://gerrit.libreoffice.org/40092 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-02 22:10:08 +0000