summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2020-04-28Fix typosAndrea Gelmini1-1/+1
Change-Id: I50a80014addf5fb6a3974139249f45f6a2e67d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92939 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann5-0/+6
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-26update pchesCaolán McNamara2-3/+3
Change-Id: I83a61da7dda6c72552eecd377f1c3744c92a797e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-26tdf#132385: sql parser: don't drop clauses from window specificationJulien Nabet1-8/+10
bison rule window_specification: '(' window_specification_details ')' { $$ = SQL_NEW_RULE; $$->append(newNode("(", SQLNodeType::Punctuation)); $$->append($2); $$->append(newNode(")", SQLNodeType::Punctuation)); } ; makes it look like rule "window_specification_details" is a single node, but in reality it is a sequence of four nodes: window_specification_details: opt_existing_window_name opt_window_partition_clause opt_order_by_clause opt_window_frame_clause ; The result is that only the "opt_existing_window_name" clause was being put in the parse tree, and the other three were simply discarded. Since that will forever be a trap, and this is the only place where window_specification_details is used, we inline it into window_specification and remove it. Change-Id: I568904355174d2bc36155bde1d4dd09f57759cd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92894 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2020-04-25Typo: *Comparsion* -> *Comparison* in dbaccess/connectivityJulien Nabet1-2/+2
Change-Id: I9dfe37b290dbb83b1dfb2f92669ae254898ee72e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92898 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-22uiobject.hxx only needs forward declaresCaolán McNamara4-15/+14
and update pches accordingly Change-Id: I411712532fd85961bffe6678416fcdc1d9c7f53d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-18loplugin:flatten connectivityNoel Grandin45-1809/+1809
Change-Id: Ic1d9eb84b64ebde99e15704a10b27f21447df4d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-14loplugin:buriedassign in c*Noel Grandin10-42/+73
Change-Id: Id14fed7e5c0f588ad3c927f12251432d12c1a7c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-30tdf#131712: fix crash on table with non null float field (mysql native)Julien Nabet1-0/+1
See bt with infinite loop here: http://bugs.documentfoundation.org/attachment.cgi?id=159161 Change-Id: Iaa4e998c640c414dec60a72d5977f8d6a6a8433f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91379 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2020-03-20MSVC hack to avoid multiply defined symbolsStephan Bergmann1-3/+5
...as reported (at least with clang-cl and --disable-pch) now, apparently after e5230535877e30c3b874495e8794faa3a42d8017 "simplify ORefVector code": > [build LNK] Library/filelo.dll > idbtools.lib(dbtoolslo.dll) : error LNK2005: "public: long const & __cdecl std::vector<long,class std::allocator<long> >::operator[](unsigned __int64)const " (??A?$vector@JV?$allocator@J@std@@@std@@QEBAAEBJ_K@Z) already defined in fanalyzer.o > idbtools.lib(dbtoolslo.dll) : error LNK2005: "public: unsigned __int64 __cdecl std::vector<long,class std::allocator<long> >::size(void)const " (?size@?$vector@JV?$allocator@J@std@@@std@@QEBA_KXZ) already defined in fanalyzer.o > Creating library C:/lo-clang/core/workdir/LinkTarget/Library/ifile.lib and object C:/lo-clang/core/workdir/LinkTarget/Library/ifile.exp > C:\lo-clang\core\instdir\program\filelo.dll : fatal error LNK1169: one or more multiply defined symbols found (The fix strategy is the same as in e.g. 177f5c2e505b7978fc232a891577a448e49b290d "Proper fix for multiply defined SfxEnumItem<sal_uInt16> with MSVC".) Change-Id: Ie30fb21471e5cbe492486e3f0b76d50f67686253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90803 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-18avoid clang's unreachable code warningLuboš Luňák1-1/+1
Change-Id: I1a3aa4f560fbc2d41872a634a599226c592ddc18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90715 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-18simplify ORefVector codeNoel Grandin32-368/+364
by making it extend std::vector - it wants to be a ref-counted vector, so let it be, and we can simplify the usage sites Change-Id: I93ff6ee1522da965e16223dca171401d36fd67b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90664 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-15Firebird: TODO already fixed (SYSTEM TABLES filtered)Julien Nabet1-1/+0
TODO added with: commit ec365165ba7f332df479422174899808e1ff4152 Author: Andrzej J.R. Hunt <andrzej@ahunt.org> Date: Mon Aug 12 17:15:46 2013 +0100 Implement refreshTables. (firebird-sdbc) then fixed with: commit c73286f83c64b5216ee430c72a412a2903eee16b Author: Andrzej J.R. Hunt <andrzej@ahunt.org> Date: Wed Aug 14 09:30:52 2013 +0100 Use table type in getTables. (firebird-sdbc) + commit 0506b35c50eddb010097b1359295da2ba6fd3ee1 Author: Andrzej J.R. Hunt <andrzej@ahunt.org> Date: Wed Aug 14 08:49:54 2013 +0100 Avoid selecting system tables for viewing. (firebird-sdbc) Change-Id: I1882f92a63d23a7cfad4a0e1930b57eec0365e9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90540 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-15Firebird: IndexType is OTHER not CLUSTEREDJulien Nabet1-3/+6
Wikipedia indicates: 'Firebird makes all indices of the database behave like well-tuned "clustered indexes" used by other architectures.' but it's not "CLUSTERED", neither "STATISTIC" nor "HASHED" (the other specific types from offapi/com/sun/star/sdbc/IndexType.idl) According to https://www.ibphoenix.com/resources/documents/design/doc_18, it seems another type => OTHER Change-Id: I3eefe9bd025e1cfeaefb75091f7ed03e8642dfea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90537 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-14Firebird: fix TODO use xClob instead of xBlob for REMARKSJulien Nabet1-12/+3
TODO added with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e6ae90b0723ed0cbf8c9c7dab65d235d0b78431a author Andrzej J.R. Hunt <andrzej@ahunt.org> 2013-08-10 12:58:32 +0100 committer Andrzej J.R. Hunt <andrzej@ahunt.org> 2013-08-11 16:05:11 +0100 commit e6ae90b0723ed0cbf8c9c7dab65d235d0b78431a (patch) tree b61ed29963dea3d6fd1c276ab6cc05a143e2058b parent d12ddee812480595745b656113475468bddc4b1a (diff) Reduce verbosity of getTables. (firebird-sdbc) Change-Id: I14c46ab9d36bf40791004941684308011af81b61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90494 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-14tdf#130975 replace `rtl::math::isNan` with `std::isnan`.Yukio Siraichi1-4/+4
Change-Id: I5d53e6369d35093445b2efd8936bbf8c6775ff47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90451 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-09tdf#130334: Firebird deal with array fieldsJulien Nabet1-6/+6
See https://bugs.documentfoundation.org/show_bug.cgi?id=130334#c11 See https://firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-datatypes-bnrytypes.html#fblangref25-datatypes-array Change-Id: I27c53b9c771fcdb3b89e66af325a8234c7de08bb Change-Id: I7b9d27f78e351eda611d13f5a07ef3c80ff00e3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90239 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-09Rephrase an ungrammatical stringAdolfo Jayme Barrientos1-1/+1
Reported by Tuomas Hietala. Change-Id: Ib5f0575681911e258a20e6ca9f6a3ab201820dd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90223 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-08tdf#131217: position arg in Blob::getBytes begins at 1 not 0 (Firebird)Julien Nabet1-2/+2
See part of bt here: https://bugs.documentfoundation.org/show_bug.cgi?id=131217#c5 According to: https://cgit.freedesktop.org/libreoffice/core/commit/?id=38ce989b4f9d2aead097e5a2e95b819def7e2624 position can't be 0 Change-Id: Ia7bf973b820b8642b45eb0bbc125011cab99de9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90186 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-08tdf#131219: workaround for getPrivilege/getGrantablePrivileges in FirebirdJulien Nabet2-0/+16
It must really be implemented. Meanwhile, let's avoid the error popups. Change-Id: If78e7d1b955ba70fd5ad282ba12b26806b7c81b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90184 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-08tdf#131212: Implement change user password in FirebirdJulien Nabet3-6/+16
Command retrieved from https://firebirdsql.org/refdocs/langrefupd25-security-sql-user-mgmt.html Change-Id: Idd16c74cd3b00f8a5c9cc135e11ac032811557f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06tdf#131164: Fix crash on Tools>User Administration (Firebird)Julien Nabet1-2/+2
see https://bugs.documentfoundation.org/show_bug.cgi?id=131164#c8 Change-Id: If55a7b015e4e14575c3933a98c70ed4aaf4d7c73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90123 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-06loplugin:unusedmethodsNoel Grandin1-17/+0
Change-Id: I698981490eb1391930cdd06821a80a5f770e000e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27remove postgresql-sdbc.iniRene Engelhard2-4/+0
reading of it was removed in b11293297e581b87fba7e995d350ba59ecb820f2 Change-Id: I1900082f8e94737111180a21b25de96afa034fdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89615 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-02-27Postgresql: replace specific log mechanism by generic SAL_INFO/SAL_WARNJulien Nabet12-277/+64
Change-Id: I601ff29cede5ef5f594fd00c8bea810080cb8388 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-24Postgresql unused POSTGRE_TRACEJulien Nabet5-12/+0
there was "#ifdef POSTGRE_TRACE", but it was nowhere to be seen except in the following purged files. Change-Id: Id77aef0869d112cb1a5282d8db79da4bc78a56e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89378 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-02-23Postgresql native, fix readLogLevelFromConfigurationJulien Nabet1-1/+1
With: osl_getModuleURLFromFunctionAddress( reinterpret_cast<oslGenericFunction>(readLogLevelFromConfiguration), &fileName.pData ); The method retrieves the path to libpostgresql-sdbc-impllo.so, eg: file:///home/julien/lo/libreoffice/instdir/program/libpostgresql-sdbc-impllo.so but then instead of retrieving path + "postgresql-sdbc.ini" we obtained ".so" filename + "postgresql-sdbc.ini"=> libpostgresql-sdbc-impllo.sopostgresql-sdbc.ini Regression from 1bdb2b6f06c556b9af91dba4f29f3ac73190b09e author Noel Grandin <noel@peralex.com> 2013-11-04 13:51:21 +0200 committer Noel Grandin <noel@peralex.com> 2013-11-11 11:21:25 +0200 commit 1bdb2b6f06c556b9af91dba4f29f3ac73190b09e (patch) tree 1d941e17952cd891f5309fd862215dd09a84b001 parent 2f2416ff060c780ad87b4d3979112f52da2ae902 (diff) remove unnecessary use of OUString constructor in CONNECTIVITY module Change-Id: Ie7be4b1078760f94d34dd1f6cb9932bd7fa70962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89303 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann4-25/+25
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20Move Boost.Spirit usage away from legacy namespaceAdam Majer2-19/+18
Remove BOOST_SPIRIT_USE_OLD_NAMESPACE defines and move all usage of Boost.Spirit to boost::spirit::classic namespace. Change-Id: I7dc5bed4d1b51f4a0bd1a4ae40c2024222127ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89079 Tested-by: Jenkins Reviewed-by: Tomáš Chvátal <tchvatal@suse.com>
2020-02-20tdf#42982: Improve UNO API error reportingFaruk Demirbaş2-3/+3
Change-Id: I36bf1809a296e2d559911f9132fedf84fcd1e249 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87577 Tested-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-16tdf#130708: Firebird: fix wrong precision and scale for DECIMAL and NUMERICJulien Nabet1-6/+6
See https://firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-datatypes.html Change-Id: I2377679bb925425ceb0bf80c5309005421fe2c2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88778 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-13Prefer array over vector for 3 elements containerJohn Zhang1-12/+13
Change-Id: I3d9bb84e067fdda3486ee21cfd5b5ffa59bc8c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86591 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-10-Werror,-Wnon-c-typedef-for-linkageStephan Bergmann1-4/+4
...with recent Clant trunk, see <https://github.com/llvm/llvm-project/commit/ 7ae1b4a0ce9c7f269cf3069e41496a78e3f28d49> " Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes." Change-Id: Ida0bbe8f4be7845b8663ea3c86e1faf1db7f55a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88349 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-10move some headers inside connectivityNoel Grandin51-43/+990
Change-Id: I9a72a9d59db4f198c2261d41143e3b8344845285 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07Remove erroneous whitespace in update_pchMuhammet Kara1-3/+3
This was causing generation of code in violation of clang-format conformance in these files: * xmlsecurity/inc/pch/precompiled_xsec_xmlsec.hxx * connectivity/inc/pch/precompiled_ado.hxx Also remove these 2 files from the clang-format blacklist. Change-Id: I882028c0553a3ff7fb356611f498d50dea984a7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88143 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-06Log swallowed exceptionStephan Bergmann1-0/+2
Change-Id: I6797600b5a661b478c4d9f4e0ad837f961d1fc5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88046 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-04tdf#117331 Merge jurt and unoil into ridlSamuel Mehrbrodt1-2/+0
jurt.jar and unoil.jar are kept as effectively empty jars, each with a Class-Path: ridl.jar in their meta-inf/manifest.mf, so that 3rd-party code loading them (with or without also loading ridl.jar) will still have access to their content. Conceptually, the UNOIDL entities in unoil.jar (corresponding to module offapi) are not part of the URE, but are now made available by URE's ridl.jar. This should probably not cause problems in practice. At least for now, we seal exactly those packages in ridl.jar that were originally sealed in jurt.jar. Ideally, all of ridl.jar could be sealed now, but that would be mildly incompatible, as it would prevent 3rd-party code from introducing additional UNOIDL entities in the relevant namespaces (even if that is something we do not want 3rd-party code to do anyway). However, some JunitTest_jurt_* define classes in those sealed packages. In the past they got away with that by using gb_JunitTest_use_jar_classset,*,jurt. Instead they now need to gb_JunitTest_use_jar_classset,*,ridl and drop the gb_JunitTest_use_jar,*,ridl. But the former only makes available the classes that are specified in ridljar/Jar_ridl.mk with gb_Jar_add_sourcefiles, not the UNOIDL entities specified via gb_Jar_add_packagedirs. But the tests need the udkapi UNOIDL entities, so introduce gb_JunitTest_add_classpath to let the tests get them explicitly. (Curiously, JunitTest_jurt_uno and JnitTest_jurt_util use gb_JunitTest_use_jar_classset,*,jurt but don't seem to acutally need it; lets leave that for a follow-up clean up.) As a follow-up clean up, relevant files could be moved from jurt/ to ridljar/. Change-Id: I836f4e7bb47fb41f1306e3f223da90dba988eb9a Co-authored-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák12-298/+292
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-31new loplugin:namespaceindentationNoel Grandin16-28/+26
check indentation of braces in namespace decls, and the comments that often appear with them. This is my penance for messing up the indentation with clang-tidy-modernize-namespaces. As such I have limited it to new-style namespaces for now, and the check is off by default. Change-Id: I4db7f10a81c79bc0eece8f8e3ee564da8bc7f168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-28tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMesut Çifci1-2/+1
Change-Id: Ic759fd9e741cb2ca305b9bbf3ce71585c6801057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87590 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28New loplugin:unsignedcompareStephan Bergmann9-21/+32
"Find explicit casts from signed to unsigned integer in comparison against unsigned integer, where the cast is presumably used to avoid warnings about signed vs. unsigned comparisons, and could thus be replaced with o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx) o3tl::make_unsigned requires its argument to be non-negative, and there is a chance that some original code like static_cast<sal_uInt32>(n) >= c used the explicit cast to actually force a (potentially negative) value of sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the cast to avoid a false "signed vs. unsigned comparison" warning in a case where n is known to be non-negative. It appears that restricting this plugin to non- equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=) is a useful heuristic to avoid such false positives. The only remainging false positive I found was 0288c8ffecff4956a52b9147d441979941e8b87f "Rephrase cast from sal_Int32 to sal_uInt32". But which of course does not mean that there were no further false positivies that I missed. So this commit may accidentally introduce some false hits of the assert in o3tl::make_unsigned. At least, it passed a full (Linux ASan+UBSan --enable-dbgutil) `make check && make screenshot`. It is by design that o3tl::make_unsigned only accepts signed integer parameter types (and is not defined as a nop for unsigned ones), to avoid unnecessary uses which would in general be suspicious. But the STATIC_ARRAY_SELECT macro in include/oox/helper/helper.hxx is used with both signed and unsigned types, so needs a little oox::detail::make_unsigned helper function for now. (The ultimate fix being to get rid of the macro in the first place.) Change-Id: Ia4adc9f44c70ad1dfd608784cac39ee922c32175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28remove some unused local varsNoel Grandin2-2/+2
found by my new aggressive unused var plugin. these are unused return values from function calls Change-Id: I3359c583f535828f192cb833762dfedc008d82f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-27tdf#54938: Adapt supportsService implementations to cppu::supportsServiceBatuhan Taskaya1-4/+1
Change-Id: I4478002b733ba54c16b5ca428c4a85b7cbc46c05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87484 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-26tdf#124176: Use pragma once instead of include guardsCanberk TURAN1-4/+1
Change-Id: I138b35bab9f4844e6fe1cac9a5c74c2e55d6680b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87382 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-26remove some unused local varsNoel Grandin1-1/+0
found by a more aggressive variant of loplugin:unusedvariables. This is my first pass, committing the simplest and most obviously unnecessary vars Change-Id: I9676a6e39a101937097788548764506c93811c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87414 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-25tdf#130137 Replace remaining uses of WNT define checks with _WIN32A_GAN1-1/+1
Change-Id: If95f1ea5a81de62eb4f725e5fcb30ccb8530062a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87372 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-25Typo ORealObdcDriver->ORealOdbcDriverJulien Nabet1-5/+5
Thank you Terrence Enger for having spotted this! Change-Id: I234ded85edf837e398675427fdf3e9cd3a3969a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87417 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-25tdf#124176: Use pragma once instead of include guardsCanberk TURAN5-20/+5
Change-Id: I7b32821caa1ade54ead49205aded36f4707b3e01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87400 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-25tdf#124176: Use pragma once instead of include guardsEda Nur Var1-3/+1
Change-Id: I1f8764de5ca1ce4aa50d16c8bdf9ff7c55c4bf3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87390 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-24loplugin:makeshared in connectivity..cppuhelperNoel Grandin8-12/+12
Change-Id: Id8064e961a64bb03bc0fb61e375cdcf769b340cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87276 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-16 13:51:52 +0000