summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2017-01-13jdbc clob character stream: return 1 when returning a single odd byteLionel Elie Mamane1-1/+1
if at that point nBytesToRead is 0, it may be that it was 1, but we have read one byte from the buffer (m_buf). So in this case, return 1, not 0 (which would signal EOF). Change-Id: I229e53f1c38c80f709df244a3509caccd69c8ecf Reviewed-on: https://gerrit.libreoffice.org/33028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-23tdf#104858: fix typoJulien Nabet1-1/+1
Thank you to himajin100000@gmail.com for having noticed this. Change-Id: I81da0d4fc91faf95f4f5257d5834a9fdfd2618f7 (cherry picked from commit dbc3cfb011f3bbbc0d95acc362dc7aa5bca6e831) Reviewed-on: https://gerrit.libreoffice.org/32379 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-20tdf#70506 implement getColumnLabel functionWastack1-2/+7
which is responsible for aliasnames defined with the SQL 'AS' keyword. Change-Id: I6aaf1ba6969e2bd738941e41492338382168bc89 Reviewed-on: https://gerrit.libreoffice.org/32042 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit ef1aee0f80d34b75b0d406abc708a0e8316fe5e8) Reviewed-on: https://gerrit.libreoffice.org/32250
2016-12-04tdf#104227: fix subtypes DECIMAL/NUMERIC in resultsetJulien Nabet1-4/+4
bt here: https://bug-attachments.documentfoundation.org/attachment.cgi?id=129298 See also https://bugs.documentfoundation.org/show_bug.cgi?id=104227#c13 for more details Change-Id: Ied497cfff2f71e67161d541b90fe48bb3e2456b9 Reviewed-on: https://gerrit.libreoffice.org/31593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 8d2f58a9922ca7352c626db06f9b8d5ca0bbaead) Reviewed-on: https://gerrit.libreoffice.org/31598
2016-11-24Related: coverity#1371267 copy ctor broken, nPagePos not copiedCaolán McNamara1-0/+1
initially operator= was removed by commit a0a919d2b541c415ad9b81d2ee91895bf106e9bb Date: Fri Oct 3 10:39:28 2014 +0200 remove SvRefBase::QueryDelete and then operator= was restored by commit faa6455995966e41653204779d055b885b27fc4c Date: Fri Oct 10 12:02:32 2014 +0200 add copy constructor for ONDXPagePtr class which I forgot in commit a0a919d2b541c415ad9b81d2ee91895bf106e9bb "remove SvRefBase::QueryDelete" but nPagePos was missed Change-Id: I6497934d4a199f5ea94cf2da840c164910e7a826 (cherry picked from commit 8ceb8b2d141a249127822bd511e66dd855fb1e59)
2016-11-22OPreparedStatement::m_aTypeInfo is unusedStephan Bergmann5-9/+7
Change-Id: I89a43b06a9983e2fac374298db2fef17f3671ab5
2016-11-21loplugin:datamembershadowStephan Bergmann2-12/+11
Change-Id: I773bb19ae33709421fde01426716dcf52065402f
2016-11-21loplugin:datamembershadowStephan Bergmann2-3/+1
shadowed OCatalog::m_xMetaData can be used here directly Change-Id: I1041272b98139fda2413442e4621507655ab67ca
2016-11-21get table name from resultset simplyWastack9-259/+12
There is a much simpler way to access table name in ResultSetMetadata in Firebird sdbc which I didn't notice before. Change-Id: Ib306c04acf38ec86475d8d1a22a67012fe48539e Reviewed-on: https://gerrit.libreoffice.org/30931 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-11-21tdf#74172 ensure prepared while setting numericWastack1-0/+4
Change-Id: I727a0af5c3aa1b2e1f6c251b2dcb32feb46041d6 Reviewed-on: https://gerrit.libreoffice.org/30933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-11-21connectivity, sc: add missing #include <osl/endian.h>Michael Stahl1-0/+1
These files use the macro OSL_BIGENDIAN but did not include the header that defines it. Found via: git grep -l OSL_.*ENDIAN | grep -v -E '\.h(xx)?$' | while read f; do case $f in *cxx) grep -L endian\\.h workdir/Dep/CxxObject/${f%.cxx}.d ;; *) grep -L endian\\.h workdir/Dep/CObject/${f%.c}.d ;; esac ; done Change-Id: Iaf589a8235dbc8062840d2716ab843e64b5cb7a2
2016-11-21add missing dep on affine UNO envDavid Tardon2-0/+6
Change-Id: I0e88c205f4fa34c0001d1fc1f53b9a8bb6dcd2d8
2016-11-21loplugin:datamembershadowStephan Bergmann2-2/+0
shadowed OCatalog::m_xMetaData can be used here directly Change-Id: I5d4436e1aa6f8f74ef6f9af816625044492cbf58
2016-11-18loplugin:datamembershadowNoel Grandin2-2/+0
Change-Id: I8a737a2f22c7be9630a1f7562b4309e687bb85f9 Reviewed-on: https://gerrit.libreoffice.org/30948 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18sync ONDXPagePtr impl with current SvRef implCaolán McNamara2-26/+40
Change-Id: I85e62a8c634a681e2e53745e3bed52731e8740e0
2016-11-18this is copied from SvRefBase, so copy the clang opt fix here tooCaolán McNamara2-13/+11
Change-Id: Ia3a2f086d66b5e15ddd4e7dcc600271d19e5d052
2016-11-18includes should be at the top of the fileNoel Grandin1-1/+1
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16new loplugin finalprotectedNoel Grandin2-2/+1
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15fix build of kde3 addressbookCaolán McNamara1-1/+1
Change-Id: I109f6ff9ca35792d3337bac2a6612ba12d2272fd
2016-11-15fix buildNoel Grandin1-1/+1
after commit 0d051730156f633150fa9e3107fe97cf7be6d8f9 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Nov 15 09:13:33 2016 +0200 loplugin:constantparam Change-Id: Ia3e761168043e5a8d22793689e9f224a85a6b7ca
2016-11-15loplugin:constantparamNoel Grandin5-12/+10
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14Make ~OCode an anchor again for vtable and RTTI emissionStephan Bergmann2-1/+3
...had been lost with dd5fa4cea7b0c6912754e6887a678a050d4a7610 "declare default dtor as virtual" Change-Id: I30acd02c293a5ecc99f5bf4f6b1f6358ae392e93
2016-11-14coverity#1371279 Missing move assignment operatorCaolán McNamara1-44/+58
Change-Id: Ic1c1017184bff54360b0ea3b6f57e53d61cbe1d5
2016-11-12coverity#1394295 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: Ie4edbe91ab4f9b9910fc895e47ea8b9fdfc00b7e
2016-11-12coverity#1371239 Missing move assignment operatorCaolán McNamara1-0/+11
but if _MSC_VER need >= 2015 Change-Id: I730319702ddc589c4fc1d72b20fd200eacfa53e4 Reviewed-on: https://gerrit.libreoffice.org/30785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-12Related tdf#70433: Use subtype to distinguish BLOB/CLOB for FirebirdJulien Nabet2-1/+19
See http://www.firebirdfaq.org/faq48/ Change-Id: If233919daeb02b67d0b3bc42547fbd3030864c37 Reviewed-on: https://gerrit.libreoffice.org/30789 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-11tdf#71251: VARCHAR max length is 32765 for FirebirdJulien Nabet1-2/+2
At least for Firebird 2.5 (see http://www.firebirdsql.org/en/firebird-technical-specifications/) Let's put the same for CHAR Change-Id: I4ab232689093b0418a7c1a9751685f41f2dabbf7 Reviewed-on: https://gerrit.libreoffice.org/30783 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-11Revert "coverity#1371239 Missing move assignment operator"Caolán McNamara1-9/+0
This reverts commit 8909cbeb315e257fbe06dad6caee5db18879b916.
2016-11-11coverity#1371239 Missing move assignment operatorCaolán McNamara1-0/+9
Change-Id: Ie5cddac8b4b0c8eefee82a14c845982600df0455
2016-11-10loplugin:staticmethodsStephan Bergmann2-8/+10
Change-Id: Id7d7bb572466bcc803ac424cd8ddb64205a1c273
2016-11-10loplugin:stringconstantStephan Bergmann1-1/+1
Change-Id: I0eb2b9986840b1bd5bc892da23c56205047bc120
2016-11-10loplugin:cstylecastStephan Bergmann1-1/+1
Change-Id: I6ec274c6c546f60c23fe639002d751f0a9f11d33
2016-11-10WiP tdf#74172 use DECIMAL and NUMERIC data typesWastack9-39/+324
Change-Id: I917cdf6e8d3ebfa7c9e4a52ca61adc5b8707ecfc Reviewed-on: https://gerrit.libreoffice.org/30447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-11-10loplugin:expandablemethods in comphelper..cppuhelperNoel Grandin16-72/+20
Change-Id: I9d5487af4729bd3ee4f6450092e4b77f74a12e6d Reviewed-on: https://gerrit.libreoffice.org/30717 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin4-9/+8
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:oncevar in cui..connectivityNoel Grandin12-81/+40
Change-Id: Ibe9d04932b0a57040db4fee11886dc1701f6ea17 Reviewed-on: https://gerrit.libreoffice.org/30653 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02KAB loplugin:unnecessaryoverrideJan-Marek Glogowski2-6/+1
Change-Id: I62e6f2488554df663e0ae6c72b6af9e2ec9976a1
2016-10-28loplugin:unnecessaryoverrideStephan Bergmann2-6/+1
Change-Id: I70ba8d3b03c56a597785f109f0cb687bd936bc64
2016-10-28coverity#1371275 Missing move assignment operatorCaolán McNamara1-2/+9
Change-Id: I6c47c797d2654506bdc95c35b2558ce812f4070d
2016-10-27Remove bogus comments about ~IPropertyArrayHelper not being virtualStephan Bergmann3-9/+0
...which isn't true at least ever since b525a3115f54576017a576ff842dede5e2e3545d "initial import", but got copy/pasted all over the place Change-Id: I47d3d8a594aef3ac3736d7176ae964a118821014
2016-10-26coverity#1374287 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ieed911b33fe4a5358855b3960b9d4c77c66ceff9
2016-10-26coverity#1374285 Uncaught exceptionCaolán McNamara2-2/+4
Change-Id: I0a3790607fe7db6a8b8093a67e4dbf3548c800bb
2016-10-26coverity#1374283 Uncaught exceptionCaolán McNamara2-2/+4
Change-Id: I658a12da4d30f360f207ca06dcf3650ba18cc7a2
2016-10-26tdf#103373 create and connect with default userWastack1-3/+2
For an embedded Firebird database resolve authentification with a default username and password (hardcoded) instead of trusted authentification. Change-Id: I54ee04898a8b2bedc9a24001c64173400769f416 Reviewed-on: https://gerrit.libreoffice.org/30160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-10-23loplugin:expandablemethodds in include/connectivity..drawinglayerNoel Grandin3-9/+3
Change-Id: Ic58f86422ef8f1e2bb655157850e214fc3a1a9b4 Reviewed-on: https://gerrit.libreoffice.org/30136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-19'>>=' with rhs Any is a copy assignmentJochen Nitschke1-6/+2
replace '>>=' operator with '=' where return value is not checked and simplify. (note: switches lhs with rhs) Change-Id: I0d283e8786ea996ed80d7aa9d8a4ea930a3d52f8 Reviewed-on: https://gerrit.libreoffice.org/30004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18loplugin:unusedmethodsNoel Grandin1-8/+0
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-17loplugin:unnecessaryoverrideStephan Bergmann14-94/+0
Change-Id: Id90a0a3334f4551b926a240b2e06a34337188c07
2016-10-16clang-cl loplugin: connectivityStephan Bergmann66-1201/+1201
Change-Id: I025cf2ad63f08bb58d54983982d7a116fac0ffea Reviewed-on: https://gerrit.libreoffice.org/29874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctornadith1-4/+1
Change-Id: I4abcff5e1bf050bd4e4cf0695f196c418d8229ef Reviewed-on: https://gerrit.libreoffice.org/29778 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-18 23:50:10 +0000