summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2014-07-06JOINs are left-associativeLionel Elie Mamane1-1/+2
Change-Id: I24fdd2ce9bb87cc52a7c84ec8cd300bc13b11461 Reviewed-on: https://gerrit.libreoffice.org/10059 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-06-18Related fdo#79714 OSX-crash opening query or table in embedded Firebird ODBJulien Nabet1-0/+1
See https://bugs.freedesktop.org/attachment.cgi?id=100839 and other comments Change-Id: I1187b171caf54997f5e8850ade4a3fb35ad9ec29 Reviewed-on: https://gerrit.libreoffice.org/9742 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-10Resolves: fdo#79493 Refresh Tables option fails with FirebirdJulien Nabet2-20/+5
Comparing with hsqldb part, sdbcx::OCollection link wasn't present in Tables constructor Also include Catalog.hxx to be able to call "refreshTables" method (cherry picked from commit d7dd4bbf0a54cc780002052a370f835572035f51) Conflicts: connectivity/source/drivers/firebird/Tables.cxx Change-Id: I1d8f2b0b361f8fd90f3065c07b3224894a3700d6 Reviewed-on: https://gerrit.libreoffice.org/9601 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-06-02fdo#73352 firebird don't claim to support interfaces one doesn'tLionel Elie Mamane2-2/+10
and then throw an exception when the interface is used Change-Id: Id5e2c852323d49f51ab55cf46ab54223cf8ccf03 Reviewed-on: https://gerrit.libreoffice.org/9596 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-14fdo#74683: java.lang.System.mapLibraryName dylib vs. jnilib confusionStephan Bergmann1-2/+12
Change-Id: I8fd7b908613a90c983f2244383432dd50ba10cdb (cherry picked from commit a76261ac9e40eb57e942db2c7aea8b8a5e904ff2) Reviewed-on: https://gerrit.libreoffice.org/8034 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-30fdo#74160 firebird XParameters::setString truncate to 65535 charactersLionel Elie Mamane1-2/+3
as opposed to 17 characters Change-Id: I65c82243946c22eee0f033977b1cd0c5a84d226b Reviewed-on: https://gerrit.libreoffice.org/7745 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann1-1/+1
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. (cherry picked from commit a3f32769fc4bb23c64168b412dd10ec769a3854d) Conflicts: sc/source/ui/unoobj/nameuno.cxx sc/source/ui/unoobj/styleuno.cxx sfx2/source/appl/sfxhelp.cxx stoc/source/security/permissions.cxx sw/source/core/unocore/unocrsrhelper.cxx (None of those bogus startsWith calls seem problematic enough to warrant backporting also to libreoffice-4-2-0.) Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21 Reviewed-on: https://gerrit.libreoffice.org/7578 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-08fdo#37167 create statement before execute/wasNull/getBooleanLionel Elie Mamane2-0/+9
This populates "object" member variable. The "createStatement" calls were removed in: commit b9392a36645d8632b97ad79240f483b3a1683b61 Author: Ivo Hinkelmann <ihi@openoffice.org> Date: Thu Apr 23 10:42:05 2009 +0000 CWS-TOOLING: integrate CWS dbaperf1 This was most probably in error since the call is not removed from the other modified member functions in this commit and/or failed to aaccount for the scenario of no parameter (and thus no setXXX call before execute). Change-Id: Ic0e7b7b64ea496791f32c1416aa7d4416f909616 Reviewed-on: https://gerrit.libreoffice.org/7281 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-01-01fdo#70664 Allow reading firebird Blob as InputStream.Andrzej Hunt2-99/+190
Change-Id: Ie0cb93a902961b3f37daf435828263478c9d2997 (cherry picked from commit 2b24eec3d4ca50e676c0c3af86ecb92a8eb0a8a2)
2014-01-01fdo#70664 Implement Blob writing (firebird-sdbc).Andrzej Hunt2-10/+126
Change-Id: Ia95c6e1a0ede2103aae25610baeb3c7a9642113a (cherry picked from commit cb4b290bcfbc5ac73103a557f8de429c3d7d7c3b)
2013-12-24fdo#72916 correct rounding of time part of DateTimeLionel Elie Mamane1-3/+13
Change-Id: I135478755f9e5a844119129b470fef8de2cd0409 Reviewed-on: https://gerrit.libreoffice.org/7163 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-19odbc DBMetaData: NULL pattern equivalent to "%", not "%foo"Lionel Elie Mamane1-9/+9
Change-Id: Ief475a1bf6e65b4786e8ee9c025b204f143a30e0 Reviewed-on: https://gerrit.libreoffice.org/7079 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-17cppcheck: fix statements that begin with string constantJulien Nabet1-2/+2
Change-Id: I42427beeae06f607e60aeeb7142714fd1f5d740d Reviewed-on: https://gerrit.libreoffice.org/7110 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-12-09fdo#72267 boolean_test is subsumed by general case "foo IS [NOT] bar"Lionel Elie Mamane2-39/+50
Change-Id: Ie9666b1c8878dd26593629b4b64d74b7448f98c1 Reviewed-on: https://gerrit.libreoffice.org/6974 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-09fix equalsAscii conversion. Noticed in fdo#72391Noel Grandin1-2/+2
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3 "convert equalsAsciiL calls to startWith calls where possible" I incorrectly converted equalsAsciiL calls to startsWith calls. This commit fixes those places to use the == OUString operator. Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6 Reviewed-on: https://gerrit.libreoffice.org/7008 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-30flat text DB: fix move by bookmarkLionel Elie Mamane1-13/+4
To test whether the range [a,b( is *before* e, compare e to b, not to a. This makes a difference when a==b, which happens for row 0 (header) when there is no header. Change-Id: I629b71936f82a468febe0360909264dd80304437
2013-11-30fdo#72148 if expecting table at begin, explicitly set it soLionel Elie Mamane1-1/+5
Change-Id: Ic876603e5860b987280b73726fd79a071a9c833c
2013-11-20Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"Noel Grandin1-2/+2
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295. I mistakenly converted OUString::equalsL calls to OUString::startsWith calls.
2013-11-20Windows: Require at least Windows XP SP2Thomas Arnhold2-5/+6
* Windows XP SP2 is 0x0502, see http://msdn.microsoft.com/en-us/library/aa383745.aspx * If a module changes the Windows SDK version setting, this is done module wide now. So the overall behavior is as before. This seems to be the best compromise for now. * We need at least SP2 because of the bluetooth stuff used in sd/source/ui/remotecontrol. * Now, we require at least Internet Explorer 7.0. IE6 has been outdated for a long time. * Leave StdAfx.h file definitions, as those are Microsoft project specific precompiled header files. * All local definitions of WINVER are removed, because the global WINVER setting makes them obsolete now. To the relation of the three macros: Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION automatically to the same value as _WIN32_WINNT. WINVER and NTDDI_VERSION can be set idenpendently each for itself. Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb Reviewed-on: https://gerrit.libreoffice.org/6496 Reviewed-by: Thorsten Behrens <thb@documentfoundation.org> Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OUString::matchAsciiL callsNoel Grandin4-9/+9
Convert code like: defaultValue.matchAsciiL( RTL_CONSTASCII_STRINGPARAM( "nextval(" ) ); to: defaultValue.startsWith( "nextval(" ); Change-Id: I77bdcbf46bec6ded3c16a8248634b1424a1eb4f0
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL callsNoel Grandin1-2/+2
Convert code like: if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem"))) to: if (aByteStr.startsWith("rem")) Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OString constructorNoel Grandin1-1/+1
Convert code like: OString aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX")); to: OString aKeyName("NDX"); which compiles down to the same code Change-Id: I1780264cae4484fc78f0586b0750c09f2dce135f
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::appendNoel Grandin1-25/+17
Convert code like: aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") ); to: aOStringBuf.append( " is missing )" ); which compiles down to the same code. Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii callsNoel Grandin8-104/+104
Convert code like: aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" )); to: aStrBuf.append( "ln(x)" ); which compiles down to the same code. Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin1-3/+3
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19convert equalsAsciiL calls to startWith calls where possibleNoel Grandin1-2/+2
Simplify code like: aStr.equalsAsciiL( "%", 1 ) to aStr.startsWith( "%" ) Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin9-17/+17
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin4-9/+7
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-18Fix some wrong copy pasteJulien Nabet1-3/+3
Change-Id: I3ad6f62393cb22b350d6b50086963ebc7d2a8f5e
2013-11-17m_uInt8 not m_nInt8Julien Nabet1-1/+1
Change-Id: I54524b6c7c19202bee049b61edc3f8e0a1e4fde0
2013-11-17bugs.freedesktop.org -> bugs.libreoffice.orgAndras Timar1-1/+1
Change-Id: I56c1190c93333636981acf2dd271515170a8a904
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann3-3/+0
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14make l10n buildable separatelyBjoern Michaelsen1-3/+6
- this renames the 'almost' module target to non-l10n - and adds a l10n target which is intended to only build l10n parts of the product - packagers should then be able to build l10n and non-l10n parts of the product independently, thus: - enable quicker rebuilds - distribution of load - updates to l10n without a full rebuild - security fixes to binaries without rebuilding all l10n - the new targets are called build-l10n-only and build-non-l10n-only - note this is not intended to move a concept of split packages upstream -- while this exsists in distros, the number of test scenarios for this would explode upstream Change-Id: Ib8ccc9bc52718d9b0ebbfee76ad93dc29c260863 Conflicts: filter/Module_filter.mk
2013-11-14connectivity: remove #pragma GCC system_header in mozabdrvMichael Stahl6-18/+0
... which can only be built with MSVC currently anyway. Change-Id: I806be27ec18e4f04e000f0b5d9ea613c3199855c
2013-11-14fdo#70144 Mark database document as modified when data inserted in firebird.Andrzej J.R. Hunt4-0/+26
This only applies to embedded databases where any changes to the database only affect the temporary extracted db which still has to be stored into the .odb. This only fixes the status for modification/insertion/deletion of data in existing tables. Insertion of new tables still does not result in the modified state being set. Change-Id: I553f67127672f2cf49b98ddcdf7d25f22bef5074 Reviewed-on: https://gerrit.libreoffice.org/6621 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-6/+0
Change-Id: Iea28e36ca398018acbae44517c378bb4b188a0b0
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-5/+0
Change-Id: I7f59e3ac50a055486cd1f1dd2d887d38a3ad92c7
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin2-21/+21
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-13Pass Document directly to Driver for embedded databases.Andrzej J.R. Hunt2-47/+25
Change-Id: I346a8ef07c5d695b3aa879f5c25cc4af97e25b99 Reviewed-on: https://gerrit.libreoffice.org/6627 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-11-13remove archaic drop comments referring to STRING_NOTFOUNDCaolán McNamara2-2/+0
Change-Id: Ieb31ca4d3a4dbeae2bc66f9c94b243425805fdb0
2013-11-13xub_StrLen->sal_Int32Caolán McNamara3-9/+9
Change-Id: I4ee33d8c5c564df62ad65cbcaf0d0cb253129fc8
2013-11-11convert STRING_NOTFOUND -> NODE_NOTFOUND in connectivityNoel Grandin2-9/+9
The code was interchangably using the two anyway. Change-Id: I4f3fe8f1d699a9725bbcce0138a9d978a1eff28a
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin7-10/+10
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11convert OUString !compareToAscii to equalsAsciiNoel Grandin6-16/+16
Convert code like if( ! aStr.compareToAscii("XXX") ) to if( aStr.equalsAscii("XXX") ) which is both clearer and faster. Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
2013-11-11convert OUString 0==compareToAscii to equalsAsciiNoel Grandin5-36/+36
Convert code like: 0 == aStr.compareToAscii("XXX") to aStr.equalsAscii("XXX") which is both clearer and faster. Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11remove unnecessary use of OUString constructorNoel Grandin3-11/+11
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11remove unnecessary use of OUString constructor in CONNECTIVITY moduleNoel Grandin62-183/+177
Change-Id: Ie32d03920d996db2793ead9940fc90668cde03dd
2013-11-10clean up #ifdef ICC codeMichael Stahl1-50/+0
According to the dmake documentation, ICC refers to Visual Age C++ for OS/2, which is not a supported compiler (or platform). Change-Id: Ic9e23bc7c44de110a3a312bd007beda3b660927d
2013-11-09fdo#65108 inter-module includes <>Lionel Elie Mamane2-5/+5
Change-Id: Ie8ca0b1aa7b56ea1d62c9eed798c56ca78464c44
2013-11-09make firebird-sdbc an experimental featureLionel Elie Mamane6-2/+15
Change-Id: I0f2453e23d18597cfe1ad2a4cd4902b15f0a8f7d