summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2017-02-02Too dumb to sortStephan Bergmann1-1/+1
Change-Id: I0ba613bff040d07554dc41783aea332d0a597b3c
2017-02-02unnecessary use of OUStringBuffer in throwing exceptionsNoel Grandin17-192/+116
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f Reviewed-on: https://gerrit.libreoffice.org/33788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01Missing includesStephan Bergmann1-0/+2
Change-Id: I287f166291a905c9f4d166bf07c09de93184bf87
2017-02-01loplugin:useuniqueptrStephan Bergmann1-19/+18
Change-Id: Iffab8e3d8ecaad835d5f0cce68ede4eaea1547a4
2017-02-01loplugin:stringconstantStephan Bergmann3-34/+34
Change-Id: I8b7611d6fdc55fc8cd9551e129a2e03e58682229
2017-02-01loplugin:unnecessaryoverrideStephan Bergmann2-9/+0
Change-Id: I53699ef386dad99b38559defe985057492a5df76
2017-02-01-Wunused-macrosJochen Nitschke1-6/+0
Change-Id: I2d3b6f22deee0f2b9ec39592b89e0e4742659593 Reviewed-on: https://gerrit.libreoffice.org/33782 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin21-190/+190
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30ditch fixed length bufferCaolán McNamara1-27/+18
Change-Id: I06bbe4ee92ebeb7d1bc305d5a7da9ee9a4fa0cb8 Reviewed-on: https://gerrit.libreoffice.org/33706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-30tdf#105101 check scale to determine subtypeTamás Bunth5-27/+49
For computed decimal/numeric values firebird's subtype remains 0. In this case we check for the scale of column. If it is not 0 (negative), than imply numeric. Change-Id: Ie5a023d165852fe402b3b4cac817b0bbef58e7cd Reviewed-on: https://gerrit.libreoffice.org/33660 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-01-30tdf#105142 set default charset to UTF8Tamás Bunth1-1/+10
Change-Id: I47dd18a141949f94903297f6e011e7956587b400 Reviewed-on: https://gerrit.libreoffice.org/33663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-26Remove dynamic exception specificationsStephan Bergmann441-9148/+8060
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25Fix typo in comments: relativ -> relativeTakeshi Abe1-1/+1
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09 Reviewed-on: https://gerrit.libreoffice.org/33488 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-23loplugin: unnecessary destructor: comphelper..desktopNoel Grandin1-6/+0
Change-Id: I9df4cb6a4b1734dac6141d6b0ee7a09e3e05f92e Reviewed-on: https://gerrit.libreoffice.org/33453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23loplugin:useuniqueptrStephan Bergmann2-9/+9
Change-Id: Ia0c8c3bb8319b5719bf63a3408d404d9adc681cc
2017-01-23use rtl::Reference in OResultSetNoel Grandin2-17/+11
instead of manual acquire/release Change-Id: I8baa2e7ac64445ea69d4b62566a89b6e42307e51
2017-01-20loplugin:dynexcspec (macOS), connectivityStephan Bergmann6-0/+22
Change-Id: Ic8cd364cd27f7f7669ac8d5553fc3974b5f8c992
2017-01-20loplugin:dynexcspec (clang-cl), connectivityStephan Bergmann11-2/+94
Change-Id: Ia49a11d4f707764640ea497d877d1699183ca56e
2017-01-19New loplugin:dynexcspec: Add @throws documentation, connectivityStephan Bergmann65-8/+325
Change-Id: Id8711eaeac65efaa228b60d5786169016bfb61a3
2017-01-17no special support for MACOSX PPC in master for a while nowCaolán McNamara1-2/+0
Change-Id: I8d5dc878f41939e55ef8995d1da74548faa4711f
2017-01-17remove some unused Java codeNoel Grandin1-18/+0
Change-Id: Ia1663256fc0b92c343ea4ba55a821c969077a0aa Reviewed-on: https://gerrit.libreoffice.org/33174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17new loplugin: useuniqueptr: connectivityNoel Grandin15-23/+19
Change-Id: I016f6a62814f1e93373dc70f59893fa38361464b Reviewed-on: https://gerrit.libreoffice.org/33149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-14coverity#1371289 avoid the need for an assignmentCaolán McNamara3-6/+6
Change-Id: I7f9b8d21652c79642f9a2f916ad0609c8abd430b
2017-01-14loplugin:refcountingStephan Bergmann2-6/+11
Change-Id: Ied9ecabb3cb6b5d629ec72db164df452d8ca114a
2017-01-14tdf#70433 tdf#104734 implement sdbc XClobTamás Bunth6-1/+205
And use it in getClob, so LO can display clob values like the return value of the built-in List function. Change-Id: I395016e945dbeb2c6bb3737b6345d40ff9f48089 Reviewed-on: https://gerrit.libreoffice.org/32938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-01-13coverity#1371289 avoid the need for an assignmentCaolán McNamara1-1/+1
Change-Id: Ia0efc427d9996eb8414821d07f7e760fb1b35246
2017-01-13jdbc clob character stream: return 1 when returning a single odd byteLionel Elie Mamane1-1/+1
if at that point nBytesToRead is 0, it may be that it was 1, but we have read one byte from the buffer (m_buf). So in this case, return 1, not 0 (which would signal EOF). Change-Id: I229e53f1c38c80f709df244a3509caccd69c8ecf Reviewed-on: https://gerrit.libreoffice.org/33029 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-11XBlob::getBytes expects 1-indexed positionTamás Bunth1-3/+4
There was also a wrong relation. Now blob resets its position. Change-Id: I41caf7cdfa261cafa5b9e66c9523c7f15225bfd8 Reviewed-on: https://gerrit.libreoffice.org/32937 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann1-8/+0
Change-Id: Ibbcb8b6dfaf1c979db2e7930c4f6c8475d693ac8
2017-01-11Some loplugin:conststringvar/stringconstant improvements: connectivityStephan Bergmann1-6/+2
Change-Id: I8b026b61b8744e21584bc64d80a957aca08aae2b
2017-01-10remove unused typedefsJochen Nitschke1-3/+0
Change-Id: I99c44caabca3d799c783d57cd2c3a1692c899191 Reviewed-on: https://gerrit.libreoffice.org/32911 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10New loplugin:conststringvar: connectivityStephan Bergmann18-100/+100
Change-Id: I2c38bc842ee07d27a5a2ff084e8a608a858f4faa
2017-01-09New loplugin:externvar: connectivityStephan Bergmann6-75/+71
Change-Id: I7e62a92ee4b019163de797fd4448170a741879dc
2017-01-09hack to silence -Wunused-functionCaolán McNamara2-2/+2
Change-Id: I585839c05ca3b0336ffbe2c60a2f58c34b0aae78
2017-01-06bSilent is unusedStephan Bergmann1-3/+0
...ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import" Change-Id: Iccee867aa9722ced2f66d4d8b8911c5e191502c2
2017-01-06loplugin:salboolStephan Bergmann1-1/+1
Change-Id: I7dfd48a04e2dff1391d10acb75180711b403af9b
2017-01-06Use string literals directlyStephan Bergmann1-25/+12
Change-Id: Ia4ae5c01ae7eb976a0e9638f8bc8fe7ebab8e2cb
2017-01-05Clean up a usage of OUStringBufferStephan Bergmann1-11/+11
Change-Id: I8435865f1a67a3a6d889c1b8a3d30e632ffc61fd
2017-01-05Replace side-effect--only uses of makeStringAndClear() with setLength(0)Stephan Bergmann1-2/+2
Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
2017-01-04Fix loplugin warnings in sqlflex.lStephan Bergmann1-9/+9
(Normally hidden by T_LEXFLAGS containing -L in connectivity/Library_dbtools.mk suppressing #line directives; some loplugin:literaltoboolconversion warning would remain in a flex-provided occurrence of ECHO that is apparently not properly prefixed by #line at least with flex 2.6.0.) Change-Id: Id5693d6bd9e5b565dd9820e3cbea8e88e7967dd5
2017-01-04Fix loplugin warnings in sqlbison.yStephan Bergmann1-31/+31
(Normally hidden by T_YACCFLAGS containing -l in connectivity/Library_dbtools.mk suppressing #line directives; some loplugin:cstylecast would remain in bison- provided expansions of $1 etc. variables.) Change-Id: Ic93bea0b2fe0ec5f741c4bc41f25cc72fec0498f
2016-12-30cleanup tailing backslashesJochen Nitschke3-3/+3
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-24Fix some comment typos.Damjan Jovanovic1-2/+2
Patch by: me (cherry picked from commit 7ac035b2ddf9275085c30d1048bec7da160158f0) Change-Id: Ic5fa1abe69fbf5f656e79fcd5e17ea5f84208ae6
2016-12-23tdf#104858: fix typoJulien Nabet1-1/+1
Thank you to himajin100000@gmail.com for having noticed this. Change-Id: I81da0d4fc91faf95f4f5257d5834a9fdfd2618f7 Reviewed-on: https://gerrit.libreoffice.org/32378 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-20tdf#70506 implement getColumnLabel functionWastack1-2/+7
which is responsible for aliasnames defined with the SQL 'AS' keyword. Change-Id: I6aaf1ba6969e2bd738941e41492338382168bc89 Reviewed-on: https://gerrit.libreoffice.org/32042 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-20always have dbtoolsCaolán McNamara1-1/+8
Change-Id: I6a3658a275c520c95490df2bb4c99ad3e3a15cef Reviewed-on: https://gerrit.libreoffice.org/32208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-17Adapt to no-longer explicit OUStringLiteral ctorStephan Bergmann3-11/+10
...from previous commit Change-Id: I062b7cd212c17e7eb5274476e6859228d0477c7f Reviewed-on: https://gerrit.libreoffice.org/32098 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin2-6/+6
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13-Werror,-Wunused-macrosStephan Bergmann1-6/+0
Change-Id: Idc81dd30502a1968f2f65386575cac1e029f8c64
2016-12-13loplugin:sallogareasStephan Bergmann1-2/+2
Change-Id: I25f793d88a87d94925026fc3de97d02086a0c855