summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin16-145/+22
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12Prevent use of ORowSetValue with sal_Bool as TINYINTStephan Bergmann7-43/+6
sal_Bool and sal_uInt8 are typedefs for the same underlying type, so any use of ORowSetValue with sal_Bool instead of bool, apparently intending to treat the value as a boolean, actually treated it as a TINYINT. (See e.g. recent 7b0c57b2faec875c790051d233d1e9abaed2a3bc "some compilers don't like implicit bool-to-ORowSetValue conversion".) Now that there's no way to create a sal_uInt8 ORowSetValue, getUInt8 and the m_uInt8 union member can probably go away, too. Change-Id: Ia27554f76e7e9edce6410284b578064573e54fd3 Reviewed-on: https://gerrit.libreoffice.org/31909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-12some compilers don't like implicit bool-to-ORowSetValue conversionLionel Elie Mamane1-1/+1
Change-Id: Ic4463db8aeca6ae9a86f7b890f95eb73724c6a1b
2016-12-11tdf#103074 Implement Boolean Type for FB driverWastack4-5/+28
Change-Id: Ibed5435e23730dc901155e79152e9becd3e70566 Reviewed-on: https://gerrit.libreoffice.org/31262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-12-11tdf#104227 query boolean like infos correctlyWastack1-2/+3
Change-Id: Ic862bb1ce3efa61d6a01fc56fb9e84cf98bb7cd0 Reviewed-on: https://gerrit.libreoffice.org/31355 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-12-06cleanup unused includes (related to tdf#88206)Jochen Nitschke2-2/+2
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only implbase*.hxx stuff is used. Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995 Reviewed-on: https://gerrit.libreoffice.org/31686 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05convert FSysStyle to o3tl::typed_flagsNoel Grandin1-1/+1
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin5-21/+21
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin1-1/+1
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-04tdf#104227: fix subtypes DECIMAL/NUMERIC in resultsetJulien Nabet1-4/+4
bt here: https://bug-attachments.documentfoundation.org/attachment.cgi?id=129298 See also https://bugs.documentfoundation.org/show_bug.cgi?id=104227#c13 for more details Change-Id: Ied497cfff2f71e67161d541b90fe48bb3e2456b9 Reviewed-on: https://gerrit.libreoffice.org/31593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-01convert nowParsing_ constants to scoped enumNoel Grandin2-8/+8
Change-Id: I8df9ca0e9317a4d969f492699be926044415f68c Reviewed-on: https://gerrit.libreoffice.org/31483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-29Rewrite some (trivial) assignments inside if/while conditions: connectivityStephan Bergmann3-11/+16
Change-Id: I67d4bb92db04b5103b98a2855ae6069a054f171b
2016-11-28loplugin:unnecessaryoverride (dtors) in connectivityStephan Bergmann2-7/+0
Change-Id: Icba385b3b7f6991f4dab7b2fd57beab5ac184df0
2016-11-25KAB loplugin:datamembershadowJan-Marek Glogowski4-6/+3
Change-Id: I1962ab1d131cf714f8bd540b589e793c4389cfb2
2016-11-24coverity#1371267 Missing move assignment operatorCaolán McNamara2-0/+12
Change-Id: Iefcfd20ac17f24f4fc3faec72b15de6bfb42eeac
2016-11-24Related: coverity#1371267 copy ctor broken, nPagePos not copiedCaolán McNamara1-0/+1
initially operator= was removed by commit a0a919d2b541c415ad9b81d2ee91895bf106e9bb Date: Fri Oct 3 10:39:28 2014 +0200 remove SvRefBase::QueryDelete and then operator= was restored by commit faa6455995966e41653204779d055b885b27fc4c Date: Fri Oct 10 12:02:32 2014 +0200 add copy constructor for ONDXPagePtr class which I forgot in commit a0a919d2b541c415ad9b81d2ee91895bf106e9bb "remove SvRefBase::QueryDelete" but nPagePos was missed Change-Id: I6497934d4a199f5ea94cf2da840c164910e7a826
2016-11-22OPreparedStatement::m_aTypeInfo is unusedStephan Bergmann5-9/+7
Change-Id: I89a43b06a9983e2fac374298db2fef17f3671ab5
2016-11-21loplugin:datamembershadowStephan Bergmann2-12/+11
Change-Id: I773bb19ae33709421fde01426716dcf52065402f
2016-11-21loplugin:datamembershadowStephan Bergmann2-3/+1
shadowed OCatalog::m_xMetaData can be used here directly Change-Id: I1041272b98139fda2413442e4621507655ab67ca
2016-11-21get table name from resultset simplyWastack9-259/+12
There is a much simpler way to access table name in ResultSetMetadata in Firebird sdbc which I didn't notice before. Change-Id: Ib306c04acf38ec86475d8d1a22a67012fe48539e Reviewed-on: https://gerrit.libreoffice.org/30931 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-11-21tdf#74172 ensure prepared while setting numericWastack1-0/+4
Change-Id: I727a0af5c3aa1b2e1f6c251b2dcb32feb46041d6 Reviewed-on: https://gerrit.libreoffice.org/30933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-11-21connectivity, sc: add missing #include <osl/endian.h>Michael Stahl1-0/+1
These files use the macro OSL_BIGENDIAN but did not include the header that defines it. Found via: git grep -l OSL_.*ENDIAN | grep -v -E '\.h(xx)?$' | while read f; do case $f in *cxx) grep -L endian\\.h workdir/Dep/CxxObject/${f%.cxx}.d ;; *) grep -L endian\\.h workdir/Dep/CObject/${f%.c}.d ;; esac ; done Change-Id: Iaf589a8235dbc8062840d2716ab843e64b5cb7a2
2016-11-21add missing dep on affine UNO envDavid Tardon2-0/+6
Change-Id: I0e88c205f4fa34c0001d1fc1f53b9a8bb6dcd2d8
2016-11-21loplugin:datamembershadowStephan Bergmann2-2/+0
shadowed OCatalog::m_xMetaData can be used here directly Change-Id: I5d4436e1aa6f8f74ef6f9af816625044492cbf58
2016-11-18loplugin:datamembershadowNoel Grandin2-2/+0
Change-Id: I8a737a2f22c7be9630a1f7562b4309e687bb85f9 Reviewed-on: https://gerrit.libreoffice.org/30948 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18sync ONDXPagePtr impl with current SvRef implCaolán McNamara2-26/+40
Change-Id: I85e62a8c634a681e2e53745e3bed52731e8740e0
2016-11-18this is copied from SvRefBase, so copy the clang opt fix here tooCaolán McNamara2-13/+11
Change-Id: Ia3a2f086d66b5e15ddd4e7dcc600271d19e5d052
2016-11-18includes should be at the top of the fileNoel Grandin1-1/+1
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16new loplugin finalprotectedNoel Grandin2-2/+1
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15fix build of kde3 addressbookCaolán McNamara1-1/+1
Change-Id: I109f6ff9ca35792d3337bac2a6612ba12d2272fd
2016-11-15fix buildNoel Grandin1-1/+1
after commit 0d051730156f633150fa9e3107fe97cf7be6d8f9 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Nov 15 09:13:33 2016 +0200 loplugin:constantparam Change-Id: Ia3e761168043e5a8d22793689e9f224a85a6b7ca
2016-11-15loplugin:constantparamNoel Grandin5-12/+10
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-14Make ~OCode an anchor again for vtable and RTTI emissionStephan Bergmann2-1/+3
...had been lost with dd5fa4cea7b0c6912754e6887a678a050d4a7610 "declare default dtor as virtual" Change-Id: I30acd02c293a5ecc99f5bf4f6b1f6358ae392e93
2016-11-14coverity#1371279 Missing move assignment operatorCaolán McNamara1-44/+58
Change-Id: Ic1c1017184bff54360b0ea3b6f57e53d61cbe1d5
2016-11-12coverity#1394295 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: Ie4edbe91ab4f9b9910fc895e47ea8b9fdfc00b7e
2016-11-12coverity#1371239 Missing move assignment operatorCaolán McNamara1-0/+11
but if _MSC_VER need >= 2015 Change-Id: I730319702ddc589c4fc1d72b20fd200eacfa53e4 Reviewed-on: https://gerrit.libreoffice.org/30785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-12Related tdf#70433: Use subtype to distinguish BLOB/CLOB for FirebirdJulien Nabet2-1/+19
See http://www.firebirdfaq.org/faq48/ Change-Id: If233919daeb02b67d0b3bc42547fbd3030864c37 Reviewed-on: https://gerrit.libreoffice.org/30789 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-11tdf#71251: VARCHAR max length is 32765 for FirebirdJulien Nabet1-2/+2
At least for Firebird 2.5 (see http://www.firebirdsql.org/en/firebird-technical-specifications/) Let's put the same for CHAR Change-Id: I4ab232689093b0418a7c1a9751685f41f2dabbf7 Reviewed-on: https://gerrit.libreoffice.org/30783 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-11Revert "coverity#1371239 Missing move assignment operator"Caolán McNamara1-9/+0
This reverts commit 8909cbeb315e257fbe06dad6caee5db18879b916.
2016-11-11coverity#1371239 Missing move assignment operatorCaolán McNamara1-0/+9
Change-Id: Ie5cddac8b4b0c8eefee82a14c845982600df0455
2016-11-10loplugin:staticmethodsStephan Bergmann2-8/+10
Change-Id: Id7d7bb572466bcc803ac424cd8ddb64205a1c273
2016-11-10loplugin:stringconstantStephan Bergmann1-1/+1
Change-Id: I0eb2b9986840b1bd5bc892da23c56205047bc120
2016-11-10loplugin:cstylecastStephan Bergmann1-1/+1
Change-Id: I6ec274c6c546f60c23fe639002d751f0a9f11d33
2016-11-10WiP tdf#74172 use DECIMAL and NUMERIC data typesWastack9-39/+324
Change-Id: I917cdf6e8d3ebfa7c9e4a52ca61adc5b8707ecfc Reviewed-on: https://gerrit.libreoffice.org/30447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-11-10loplugin:expandablemethods in comphelper..cppuhelperNoel Grandin16-72/+20
Change-Id: I9d5487af4729bd3ee4f6450092e4b77f74a12e6d Reviewed-on: https://gerrit.libreoffice.org/30717 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin4-9/+8
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:oncevar in cui..connectivityNoel Grandin12-81/+40
Change-Id: Ibe9d04932b0a57040db4fee11886dc1701f6ea17 Reviewed-on: https://gerrit.libreoffice.org/30653 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02KAB loplugin:unnecessaryoverrideJan-Marek Glogowski2-6/+1
Change-Id: I62e6f2488554df663e0ae6c72b6af9e2ec9976a1
2016-10-28loplugin:unnecessaryoverrideStephan Bergmann2-6/+1
Change-Id: I70ba8d3b03c56a597785f109f0cb687bd936bc64
2016-10-28coverity#1371275 Missing move assignment operatorCaolán McNamara1-2/+9
Change-Id: I6c47c797d2654506bdc95c35b2558ce812f4070d
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-13 02:02:04 +0000