summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2018-03-07tdf#116171: Tunnel arbitrary rtl_TextEncoding from sc to sdbc:dbase connectionStephan Bergmann1-8/+16
...including those that have no corresponding textual IANA character set name representation, like RTL_TEXTENCODING_MS_950 which is apparently used in some DBase files. In the past, if eCharSet was RTL_TEXTENCODING_DONTKNOW in lcl_getDBaseConnection it was sent as an empty string CharSet property, which the receiving OConnection::construct translated back to else m_nTextEncoding = RTL_TEXTENCODING_DONTKNOW; so the net effect remains the same for that special case. Reviewed-on: https://gerrit.libreoffice.org/50772 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 5ad62544bce42396faaae2bc79c7517af6ff085b) Conflicts: sc/source/ui/docshell/docsh8.cxx Change-Id: I84eec8a93d000752b3c429976c58721ea9ea32a4 Reviewed-on: https://gerrit.libreoffice.org/50793 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-01-10tdf#114495 ODBC: clear row status buffer *before* we throw away the statementJulien Nabet1-1/+1
Change-Id: I898e9d0e3e2cf1ed41489231d1cd761171bfcea4 Reviewed-on: https://gerrit.libreoffice.org/47514 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-on: https://gerrit.libreoffice.org/47526 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-10-08tdf#112947: fix write to free'd memory (odbc)Julien Nabet1-0/+1
suggested by Nick Gorham Change-Id: I3579caf5192df6e460dea3a5b3728196d75a65f4 Reviewed-on: https://gerrit.libreoffice.org/43234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-on: https://gerrit.libreoffice.org/43236 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-18Related tdf#111634: Multiple memory leaks in libmacabdrv1 (part3)Julien Nabet2-0/+3
Hope it'll fix leak from https://bugs.documentfoundation.org/show_bug.cgi?id=111634#c13 Change-Id: I61a51faf291145c8cafd03339b7bcc7b23072fba Reviewed-on: https://gerrit.libreoffice.org/41268 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 27b1e21913d8119ea27be05954156d15ca069e66) Reviewed-on: https://gerrit.libreoffice.org/41269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-14Related tdf#111634: Multiple memory leaks in libmacabdrv1 (part2)Julien Nabet1-0/+2
Delete "sub arrays" of headerNames which is macabfield ** before calling delete headerNames [] Change-Id: I11b6d5483ed91eb2805b68ace1b06eafd23b707d Reviewed-on: https://gerrit.libreoffice.org/41054 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 84fc4dec5f419cbe30fa6ac4e228f083837f7887) Reviewed-on: https://gerrit.libreoffice.org/41068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-14Related tdf#111634: Multiple memory leaks in libmacabdrv1Julien Nabet1-0/+2
CFRelease multiLabel since has been created from OUStringToCFString Change-Id: Ic997c026737ebf31049682835d4047f3297f077d Reviewed-on: https://gerrit.libreoffice.org/41003 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 5d065a77adf82948909fa76ea0f0ea98f89fd3e6) Reviewed-on: https://gerrit.libreoffice.org/41067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08tdf#110997 protect calls to implBuildFromRelative from year overflowLionel Elie Mamane1-4/+28
Change-Id: I5c6768766673832b7271292af85db1b76e51042c Reviewed-on: https://gerrit.libreoffice.org/40683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-24add libebook-1.2.so.19 in EApi.cxxRico Tzschichholz1-0/+1
Change-Id: I900a190948087360bb4c3cd9235c9848333ad66f Reviewed-on: https://gerrit.libreoffice.org/40359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-04tdf#108789: branch 5.4 onlyLionel Elie Mamane2-41/+85
- Calc: make the complete "what encoding to use" decision before calling the connectivity driver, so that the driver has no ambiguity about whether it should override our setting or not. To this end, factorise the part of the driver that reads the encoding from the file header into dbtools. - Calc: don't ask for encoding when the file's header give the encoding. - don't confuse CP850 (the default) and "don't know", including: * don't ignore CP850 user setting * don't overwrite user setting with CP850 Cherry-pick: - https://cgit.freedesktop.org/libreoffice/core/commit/?id=7f1465a9599e9665159dd2d823a6e9064cca5703 - https://cgit.freedesktop.org/libreoffice/core/commit/?id=857d64ed3ebbeb0ee4e8a75bfeaa4eb406944571 - https://cgit.freedesktop.org/libreoffice/core/commit/?id=9170d10cc57c3f0f3e82b27ce4b2cd9c897e669d Change-Id: Id80b7c505858b88f717b0ce6bd890527909e5fd1 Reviewed-on: https://gerrit.libreoffice.org/39451 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2017-06-12tdf#55631: DBASE import (take 2)Julien Nabet1-0/+5
if we can't read head db_frei part, let's also put by default m_eEncoding = RTL_TEXTENCODING_IBM_850; Change-Id: I97601ba4c782dcfc280e975cc4498ea68407dd48 Reviewed-on: https://gerrit.libreoffice.org/38659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com> (cherry picked from commit 58bb9da339d61981d45cde8e38a2ce1ae33652c4) Reviewed-on: https://gerrit.libreoffice.org/38706 Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-10DBase, encodings mixedJulien Nabet1-2/+2
See https://bz.apache.org/ooo/show_bug.cgi?id=18728#c7 101 - 866 MS-DOS, Russian 102 - 865 MS-DOS, Nordic taken as reference by Muthu Subramanian who also added some other encodings with https://cgit.freedesktop.org/libreoffice/core/commit/?id=b00c4ec0967f8712d721b31ccb2dd0778c9e973b Also https://msdn.microsoft.com/en-us/library/aa975345%28v=vs.71%29.aspx 865 Nordic MS-DOS x66 866 Russian MS-DOS x65 Change-Id: Iea494bed07d8050fd60e24ffea153ce911c27c8c Reviewed-on: https://gerrit.libreoffice.org/38618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 8ab2c4b6807bbdabd2cf72a93e0168220bea79d6) Reviewed-on: https://gerrit.libreoffice.org/38630
2017-05-30Related tdf#108068: Use new name of column when it's been changedJulien Nabet1-11/+11
First fix simple case, the rename of a column which is not a primary key Change-Id: Ia0de8e531021cbec0409408008c541c25a4bcd85 Reviewed-on: https://gerrit.libreoffice.org/38014 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit c751318868f3f0082b2c86df493216d452b8ecc5) Reviewed-on: https://gerrit.libreoffice.org/38022 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-15Translate German comments and debug strings (leftovers in dirs a... to c...)Johnny_M14-104/+104
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "a" to "c". Change-Id: I3b0152ee78ad80a29d714cbd98bf888f31be4763 Reviewed-on: https://gerrit.libreoffice.org/37573 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-05-15remove some unnecessary lockingNoel Grandin1-7/+0
Change-Id: I7da9e82930d3fe8f927c495aeca270b8bb5cf65c Reviewed-on: https://gerrit.libreoffice.org/37602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12remove unused uno::Reference varsNoel Grandin9-14/+3
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke7-7/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09Fix typosAndrea Gelmini1-1/+1
Change-Id: Ie0f67456e5c7d9b7b26b27b4d633881236ceeadb Reviewed-on: https://gerrit.libreoffice.org/37361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-09dump exception message on exceptionCaolán McNamara1-1/+1
Change-Id: I30d942e9e8b240be9033b41142831b018bdfc49f
2017-05-09remove unnecessary empty OUString fields and varsNoel Grandin2-10/+8
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07revert OSL_ASSERT changesChris Sherlock12-15/+15
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert connectivity module away from OSL_ASSERT to assertChris Sherlock12-15/+15
Change-Id: I1f1296836b07df6e147c8be845486ac4acd15abd
2017-05-05connectivity: convert the other OSL_ENSURE to SAL_WARN_IFMichael Stahl1-4/+4
Change-Id: Ie3d84129b73792e1f129d65350bf0e1455b08566
2017-05-05connectivity: replace OSL_ENSURE with assertMichael Stahl1-209/+210
Change-Id: I0a4a16aa5b78383ee23124d7500b9f12e2add8a7
2017-05-04Replace all OUString("") with OUString()Arnaud Versini2-4/+4
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03tdf#107196: fix firebird relationshipJulien Nabet1-12/+12
Let's spread string sanitizing see https://bugs.documentfoundation.org/show_bug.cgi?id=107196#c3 Furthermore, in example file from the bugtracker, relationship between f2 fields were present several times. So I had to delete it several times to really remove it. Change-Id: I4fbe10c479af3d4fa5ccfb290f128fdd2a6d49a9 Reviewed-on: https://gerrit.libreoffice.org/36642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-04-28loplugin:salboolCaolán McNamara1-1/+1
Change-Id: Ic78e1a6fc3fad22f2ffba43730f11b51f555e745
2017-04-28tdf#39486: Translate some randomly found German commentsJens Carl1-4/+4
Change-Id: I4c2950180f504c06666f055d166c51e32a6d5294 Reviewed-on: https://gerrit.libreoffice.org/36969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-28tdf#107457 don't quote columns referred by expression (not by name)Lionel Elie Mamane1-2/+7
Change-Id: I4894313ec27d716e9899c885ddc6be38a2447689
2017-04-28loplugin:checkunusedparams in connectivityNoel Grandin6-15/+7
Change-Id: I302af54f4bcb5807c264f7926cffa025550ccb00 Reviewed-on: https://gerrit.libreoffice.org/37065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27tdf#39468 cleanup source code commentsdennisroczek3-16/+13
* translate German source code comments * remove ascii art * remove bogus source Code comments * remove old StarOffice/Sun internal bug tracker references Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451 Reviewed-on: https://gerrit.libreoffice.org/36005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27remove ResourceBasedEventLogger in favor of its base EventLoggerCaolán McNamara7-11/+11
because there are no resources in use anymore Change-Id: I37e4a100aabbf6214533738da3e528ed2f434eae
2017-04-27the only use of this argument is sdbcl which is a deleted resource fileCaolán McNamara1-1/+1
Change-Id: I31c140dcab9a291c4ede62e56d296a224dcd47c8
2017-04-27another name for a nonlocalized string is a stringCaolán McNamara13-408/+99
Change-Id: Ic4ff92720edd1c10dd6d5eff026e79cb02990005
2017-04-25remove bitmaps from .src filesCaolán McNamara5-30/+19
and into includeable .hlst files, add them to postprocess/CustomTarget_images.mk to continue only including used bitmaps in icon-theme zips Change-Id: I5c24c3eca93a9c4101bcdcacb0e4b2712133968e Reviewed-on: https://gerrit.libreoffice.org/36941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock2-2/+2
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock5-0/+5
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-22revert bits of "remove some old MSVC workarounds"Noel Grandin2-4/+5
in commit 841e1a6f3619054ecc9240e061cd83d4e41d1ca9, since MSVC 2015 still does not pack heterogenous bitfields tightly Change-Id: I251c797492762cbd2381496b2f2c6c3223d563c6 Reviewed-on: https://gerrit.libreoffice.org/36800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky22-22/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin3-4/+3
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21remove some old MSVC workaroundsNoel Grandin2-5/+4
Change-Id: I6abd8aaffb27b3c85df7c0518f7f576be4e32222 Reviewed-on: https://gerrit.libreoffice.org/36660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19loplugin:redundantcast (clang-cl)Stephan Bergmann2-5/+5
Change-Id: I97ff3f7c4ebfb7c9db2ceed234da1095ed0eeed6
2017-04-13Removed duplicated includesAndrea Gelmini1-1/+0
No automatic tools. Manual checked and tested. Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754 Reviewed-on: https://gerrit.libreoffice.org/36371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-11sal_Bool -> boolStephan Bergmann2-2/+2
Change-Id: If632eb547aa5082ad13eac8c2ad39a1742309fc7
2017-04-10tdf#106866 query character size instead of bytesTamás Bunth1-2/+3
Change-Id: I7639fb1accdf728a8170ddb7dc9caf84bad8d3ef Reviewed-on: https://gerrit.libreoffice.org/36289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: connectivityStephan Bergmann1-1/+1
Change-Id: I8156e528b675c5f27c5d6903f17cb62d228d1488
2017-04-06KAB lo:redundantinline pluginJan-Marek Glogowski3-4/+3
Change-Id: I522be5260b8f61afb2b133a6e32bd0b66c1b7522
2017-04-06loplugin:redundantcast find cstyle double castsNoel Grandin1-1/+1
Change-Id: I5507be190dac781e5cdb545a60acf3d50056c9f8 Reviewed-on: https://gerrit.libreoffice.org/36187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04loplugin:redundantcast (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Ie096d75c1bc774e77c589845f61276d1478234ef Reviewed-on: https://gerrit.libreoffice.org/36065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04loplugin:redundantinline (clang-cl)Stephan Bergmann11-22/+21
Change-Id: I03a19b599005f6ef25040889a1e1802445ebf430 Reviewed-on: https://gerrit.libreoffice.org/36063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04make UNO enums scoped for internal LO codeNoel Grandin3-22/+22
this modifies codemaker so that, for an UNO enum, we generate code that effectively looks like: #ifdef LIBO_INTERNAL_ONLY && HAVE_CX11_CONSTEXPR enum class XXX { ONE = 1 }; constexpr auto ONE = XXX_ONE; #else ...the old normal way.. #endif which means that for LO internal code, the enums are scoped. The "constexpr auto" trick acts like an alias so we don't have to use scoped naming everywhere. Change-Id: I3054ecb230e8666ce98b4a9cb87b384df5f64fb4 Reviewed-on: https://gerrit.libreoffice.org/34546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>