summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2015-04-09tdf#39279: Search for Thunderbird address books uses first ones foundJulien Nabet4-8/+18
Thank you Lionel about your advice for this one. Change-Id: I4ec51b694d3b674158cb7fb4efa580e084cffda9 Reviewed-on: https://gerrit.libreoffice.org/15163 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu> (cherry picked from commit 21a8671e24fe19a3ba5ef14c991bae302234b229) Reviewed-on: https://gerrit.libreoffice.org/15191 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-07tdf#90446 Revert "tdf#39279: Prioritise Thunderbird address books..."Julien Nabet2-14/+14
I'll quote Lionel (I hate pretending I did the job when it's not the case :-)): " It was misguided; the order of entries in these arrays is not order of priority, but corresponds to the constants (which are used, with an offset of 1, as indexes into these arrays) in offapi/com/sun/star/mozilla/MozillaProductType.idl " This reverts commit 9b92d8afbabe564de703f8bc083723d97e765011. Change-Id: I166237285f13291083a506852d5217fc3ad59d45 Reviewed-on: https://gerrit.libreoffice.org/15164 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-03-08tdf#39279: Prioritise Thunderbird address books in first-match searchJulien Nabet2-14/+14
stopgap measure until tdf#57873 is fully implemented, since these days by far more people use Thunderbird than Seamonkey (or Firefox address book, if the latter even has any...). Change-Id: I638ec90277063b1e7536c045bffb1052d3b76911 Reviewed-on: https://gerrit.libreoffice.org/14800 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-03-03getAny() is not a safe default, it assumes there is actually an AnyLionel Elie Mamane1-16/+16
at *m_aValue.m_pValue. But there could not even be a pointer there, e.g. if m_aValue.m_nIntXX is in use. Then the pointer dereference usually leads to a crash. Can e.g. be reproduced by calling getBytes() on an integer column of a RowSet. Change-Id: Ib5361d838d2869142fd797d4e3454e2562ea7acf Reviewed-on: https://gerrit.libreoffice.org/14718 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-02-28sdbc:address:kab URLs don't have a trailing ":"Stephan Bergmann1-1/+1
broken since 4bf95c4c31dd871065d4042028a4b3ae476dab70 "make use of startsWith()" where the tricky !url.compareTo(::rtl::OUString("sdbc:address:kab:"), 16) was replaced with url.startsWith("sdbc:address:kab:") even though the original exempted the trailing ":" from the comparison (cherry picked from commit 27e85dd314e02dc97612bf1682fccacaf0244127) Conflicts: connectivity/source/drivers/kab/KDriver.cxx Change-Id: I45175b2669d61eb4cee36d4456ccb69d0f11ef63 Reviewed-on: https://gerrit.libreoffice.org/14670 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-28Adapt code to changed libkabdrv1lo.so nameStephan Bergmann1-1/+2
broken since LO 3.6, commit 07d512eff12fc89adbfb73e546b3946494f21472 "connectivity: convert kab to gbuild" (cherry picked from commit d8a2a0b84a9aa570116febf23a6f1d6430fec287) Conflicts: connectivity/source/drivers/kab/KDriver.cxx Change-Id: I65cc32fa55f1d5c0358585489b8b3dc3aaf8004b Reviewed-on: https://gerrit.libreoffice.org/14669 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-03tdf#89048 Macab initialize record list even for never-match condition.Norbert Thiebaud2-1/+6
Change-Id: I323f6532d00f30cde50616e9399cad6bbe00cb8c Reviewed-on: https://gerrit.libreoffice.org/14309 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-02-03Query Design: use correct name for columns that come from another query.Lionel Elie Mamane1-2/+3
Change-Id: I25b4ccdc2f50ba89687e1f4c871f286251a28e21 Reviewed-on: https://gerrit.libreoffice.org/14232 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-02tdf#88814 parameters are kinda-partially supported, so follow the suggestionLionel Elie Mamane1-4/+1
Change-Id: I1a39378d521f128e6b8f35a0bce781435f94e5a8
2015-01-15PostgreSQL statement: deliver promised XMultipleResults interfaceLionel Elie Mamane1-0/+1
Change-Id: I0bb6df332a6666a0ae96bba38626b2626f880490 Reviewed-on: https://gerrit.libreoffice.org/13923 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-07fdo#88099 PostgreSQL-SDBC: use correct syntax for boolean comparisonsLionel Elie Mamane1-0/+5
Change-Id: Iddb551b62b1ff3fc9ce977483e41faa9ad8aef13 Reviewed-on: https://gerrit.libreoffice.org/13797 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07protect agains past-the-end string accessLionel Elie Mamane1-1/+1
Change-Id: I651c7b062b454fad85eff8852f7e62804a0d0058 Reviewed-on: https://gerrit.libreoffice.org/13796 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-06fdo#80968 file resultset seek table to before beginning on opening resultsetLionel Elie Mamane1-0/+1
Change-Id: I73abbc7cfe0804e729a711a247b6e085b4e41d95 Reviewed-on: https://gerrit.libreoffice.org/13741 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-01-05Related fdo#87789: groups should appear like views and not like tablesJulien Nabet1-2/+9
Cherry-picked from 84e3c5acb07937a073fedbe3d5389fc72123923a Change-Id: I4f8d7e2bec006e6d0a0041e2145aa0920f64aa57 Reviewed-on: https://gerrit.libreoffice.org/13698 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-02fdo#86852 correctly recognise NULL values in query parameter values dialogLionel Elie Mamane1-31/+98
Change-Id: I3c0cf976e0a9fbafe6eee768799a2f48c2ee0ea9 Reviewed-on: https://gerrit.libreoffice.org/13251 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-12-01Resolves: fdo#80938 fix SQL view to be editableCaolán McNamara2-29/+63
regression from commit d60392fb5b387175dbd2e575848993c02c56922f Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Mar 6 12:05:24 2014 +0000 coverity#706316 help out coverity re tortured logic Change-Id: I2ee7bd3b7421ae46878d1b565ef14dd7b0bbd10e (cherry picked from commit 6269b62b525ec22471db56015ac2daed813ec5ff)
2014-11-20further fix mozab build after header cleanupChristian Lohmaier3-0/+3
Change-Id: I7e3c79d854a08c94aa699d86994704b9360b69bf
2014-11-20connectivity: fix the mozab buildMichael Stahl1-0/+1
Change-Id: I299c856814e09a93a71f8acf8745a0590e2ecc72
2014-11-18Build fix on Windows.Kohei Yoshida1-0/+4
Change-Id: I5e4c29ce5a1f427c5642a253f985b42938912075
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl24-0/+25
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18java: make fields final where possibleNoel Grandin8-31/+19
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-17Build fix on WindowsKohei Yoshida1-0/+1
Change-Id: I5c24856bfe48646bc0e9cd00f0849a5db12dfef2
2014-11-17Missing includeStephan Bergmann1-0/+3
Change-Id: I1dbf7a73ec60115f11d3a5455de2871041cd1605
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl8-1/+9
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14coverity#1158396 Uncaught exceptionCaolán McNamara1-2/+29
Change-Id: I6752a534bca8f81627cdd616ac0f2268824299e0
2014-11-14coverity#1242888 Unused valueCaolán McNamara1-2/+2
Change-Id: Idf2709382dc431b6e34c2993d04c41aa8a3786ab
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava10-16/+16
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-13fix connectivity unit test for --enable-mergedlibsNoel Grandin1-0/+10
it's a workaround, but given the conflicting requirements of MSVC not liking duplicate symbols, but the unit test needing to link the objects directly to access internal symbols, there is not much else we can do. Change-Id: I9bdcc5f2b6ab0712cc3317033c4fbae4791cbb6b Reviewed-on: https://gerrit.libreoffice.org/12387 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini14-21/+21
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin2-14/+8
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann12-23/+34
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin12-34/+23
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05new loplugin: use more efficient find() methodsNoel Grandin1-1/+1
(Original idea from Kendy) Look for code that is calling std::find on a sorted container (set/map/vector) and warn about it - the code should be using the find method on the container itself, since that is considerably faster. Change-Id: Ib74e5d3faa836eeb0df16a736d202696626bdfd2
2014-11-05-Werror,-Wpointer-bool-conversionStephan Bergmann1-2/+2
Change-Id: Iae4c439de43fba471916463da8939709bbd068e5
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin32-176/+118
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04coverity#706375 uncaught exceptionDavid Tardon1-1/+1
Change-Id: I3d198d60524224e22d7f609ddde1ed8c3c319da9
2014-11-04coverity#706366 uncaught exceptionDavid Tardon1-1/+1
Change-Id: If89d6613394220fa4ca1da9b5b8820d9dbc205c7
2014-11-04coverity#706363 uncaught exceptionDavid Tardon1-1/+1
Change-Id: I2dde714f847f6df4d9b4ede744bef089a3715d7a
2014-11-04coverity#706362 uncaught exceptionDavid Tardon1-1/+5
Change-Id: I7200fe17c66cd904f0fc243bf8e33d6c24079729
2014-11-04coverity#706361 uncaught exceptionDavid Tardon1-1/+5
Change-Id: Iee569c32569339ec2eeb6ef038e5bdc83e541a8f
2014-10-31Removed duplicated includesAndrea Gelmini3-3/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31coverity#1158395 Uncaught exceptionCaolán McNamara1-5/+51
and coverity#1158394 Uncaught exception Change-Id: I73430678c658202475e0073c3c9bde0a072c1ee9
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini1-1/+1
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30coverity#735298 Unchecked return valueCaolán McNamara1-1/+4
Change-Id: I66499283f4218662146c380f605bb20b8a2ff49a
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin13-23/+2
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-28Resolves: fdo#85081 terminate if can't load kde addressbookCaolán McNamara1-6/+20
Change-Id: I3b1b78127d7d4080a23c0ac9f7d37706197de62c
2014-10-28coverity#706303 Uncaught exceptionCaolán McNamara1-1/+8
Change-Id: If3963e0ae2c6477eb074e89f411c22a82d339634
2014-10-27coverity#706321 Uncaught exceptionCaolán McNamara1-3/+6
Change-Id: Ie3b66520ab0c859272a4b0291f6c907e7fce61e5
2014-10-27coverity#1249674 Missing break in switchCaolán McNamara1-0/+1
Change-Id: I1e957afe1dc35571128fac4432b54e8ae35aa9ab
2014-10-27cid#1249675 Uncaught exceptionNoel Grandin2-2/+2
Change-Id: I3923a6a83bfc0a35f5a5af86cfd0e5308cfda24c
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-04 11:59:33 +0000