summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2013-12-24fdo#72916 correct rounding of time part of DateTimeLionel Elie Mamane1-3/+13
Change-Id: I135478755f9e5a844119129b470fef8de2cd0409
2013-12-16odbc DBMetaData: NULL pattern equivalent to "%", not "%foo"Lionel Elie Mamane1-9/+9
Change-Id: Ief475a1bf6e65b4786e8ee9c025b204f143a30e0 Reviewed-on: https://gerrit.libreoffice.org/7080 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-12-02fdo#72148 if expecting table at begin, explicitly set it soLionel Elie Mamane1-1/+5
Change-Id: Ic876603e5860b987280b73726fd79a071a9c833c Reviewed-on: https://gerrit.libreoffice.org/6863 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-02flat text DB: fix move by bookmarkLionel Elie Mamane1-3/+4
To test whether the range [a,b( is *before* e, compare e to b, not to a. This makes a difference when a==b, which happens for row 0 (header) when there is no header. Conflicts: connectivity/source/drivers/flat/ETable.cxx Change-Id: I629b71936f82a468febe0360909264dd80304437 Reviewed-on: https://gerrit.libreoffice.org/6864 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-19Fix some wrong copy pasteJulien Nabet1-3/+3
Change-Id: I3ad6f62393cb22b350d6b50086963ebc7d2a8f5e Reviewed-on: https://gerrit.libreoffice.org/6715 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-11-17m_uInt8 not m_nInt8Julien Nabet1-1/+1
Change-Id: I54524b6c7c19202bee049b61edc3f8e0a1e4fde0 Reviewed-on: https://gerrit.libreoffice.org/6705 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-10-21fdo#68657 bool->string conversion to 1/0, not "true"/"falseLionel Elie Mamane2-1/+32
This matches what OO.org / older versions of LibreOffice did, and which was inadvertently changed in 2bd856e6 Change-Id: I1d45ea975a096c599a996caafc41e4aa06d35fcd Reviewed-on: https://gerrit.libreoffice.org/6274 Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-04allow to build for Windows XP when using Visual Studio 2012Christian Lohmaier1-0/+11
VS 2012 Update 1 added the possibility to target Windows XP by using a SDK that is based on the Windows 7 one. http://blogs.msdn.com/b/vcblog/archive/2012/10/08/10357555.aspx This patch probably should not be integrated as is, as it disables a test that fails in this configuration (CppunitTest_connectivity_ado) Change-Id: I3ba8723882452950c40049ccdc95b04c60862cbf Reviewed-on: https://gerrit.libreoffice.org/4966 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org> Reviewed-on: https://gerrit.libreoffice.org/6125 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-08-30TPropertyValueLessFunctor must actually compare for "<"Stephan Bergmann1-1/+1
Change-Id: I584a410d90531a0f7b784e62f94c39e715713cf1 (cherry picked from commit 2410b3c3ddc6fea02dadd56b39bb1181312c383a) Reviewed-on: https://gerrit.libreoffice.org/5683 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-08-28odbc insert: adjust buffer size *after* it is written toLionel Elie Mamane1-1/+1
the buffer (aBookmark) is written to by SQLBulkOperations or SQLSetPos, not by SQLBindCol, which merely sets up the instruction that the next call should write there. So its finak size is known only *after* the call that makes the write, obviously. Change-Id: I4faaaeffc060433645188f0eda3d9958b087cf6c Reviewed-on: https://gerrit.libreoffice.org/5650 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-08-28fdo#68315 odbc update *reads* a bookmark, not *writes* a bookmarkLionel Elie Mamane1-21/+39
This code was completely inverted. The row update operation *reads* a bookmark (that is, what row to update), not *writes* a bookmark. So we were passing an empty bookmark, and thus the update was failing because we were refering to a non-existent row. Change-Id: I676b1a7727a88e13a3e465bd96cbbaf18dad2fa6 Reviewed-on: https://gerrit.libreoffice.org/5648 Reviewed-by: Miklos Vajna <vmiklos@suse.cz> Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-08-14fdo#67546 handle unsigned 64 bit integersLionel Elie Mamane1-0/+1
Change-Id: I09453c73303076318b7105a778ff98695b0a3839 Reviewed-on: https://gerrit.libreoffice.org/5418 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-07-31fdo#67387 skip separating space between date and time in timestampLionel Elie Mamane1-0/+6
Change-Id: I3c38d179f8b2f59e79cd889fa88f4582f650c09e Reviewed-on: https://gerrit.libreoffice.org/5166 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-30rhbz#989246: Honor user's JavaDriverClass override in mysql driverStephan Bergmann1-11/+25
Change-Id: Ic7dbddb5b17af0bd23864fd19ab2bd815969d008 (cherry picked from commit 63897351fc4fd31305bef43b649be74e2b6006c4) Reviewed-on: https://gerrit.libreoffice.org/5193 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-25fdo#67269 adapt checkTable to getTableName changeLionel Elie Mamane1-3/+4
getTableName used to return schema.table; now it returns just table But tables are indexed by schema.table in getTables(), so reconstruct that for the lookup. Change-Id: I53da1e43762b3a470e34b5dfdb0e1bb3dc914780 Reviewed-on: https://gerrit.libreoffice.org/5100 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-15i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.Michael Stahl4-9/+16
Add IsUTC member to: com.sun.star.util.DateTime com.sun.star.util.DateTimeRange com.sun.star.util.Time Add new stucts with explicit time zones: com.sun.star.util.DateTimeWithTimezone com.sun.star.util.DateWithTimezone com.sun.star.util.TimeWithTimezone Adapt the sax::Converter to read/write timezones, and fix the unit test. Everything else just uses default (no time zone), this commit is just to fix the API. STRUCT: /UCR/com/sun/star/util/DateTime nFields1 = 7 != nFields2 = 8 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/DateTimeRange nFields1 = 14 != nFields2 = 15 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/Time nFields1 = 4 != nFields2 = 5 Registry2 contains 1 more fields Conflicts: sc/source/filter/oox/unitconverter.cxx Reviewed-on: https://gerrit.libreoffice.org/4833 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 652ccbdf3111766fadc379a8cf4650b744e1e19c) i#108348: fix TimeZone -> Timezone in struct names (cherry picked from commit 604aae1fd240254fe851d93dc35b5408bd13296c) Signed-off-by: Michael Stahl <mstahl@redhat.com> Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu> Signed-off-by: Michael Meeks <michael.meeks@suse.com> Conflicts: forms/source/xforms/convert.cxx offapi/type_reference/offapi.rdb reportdesign/source/core/sdr/RptObject.cxx sc/source/filter/oox/unitconverter.cxx
2013-07-12ORDER BY columns are prioritarily *SELECT* columnsLionel Elie Mamane1-1/+27
as opposed to *table* columns, and notwithstanding HSQLDB 1.8 (our embedded database) bugs. Actually, supporting ORDER BY on non-select (but table) columns is OPTIONAL for DBMSs (but quite common) Conflicts: connectivity/source/parse/sqliterator.cxx Change-Id: I6725dfda36b09429a78262bff6f3d3e3dd9032b6 Reviewed-on: https://gerrit.libreoffice.org/4836 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-07-12sort is ascending by defaultLionel Elie Mamane1-1/+1
Change-Id: I38354405acbbdb27b9e7ce1d19e862b7b352c850 Reviewed-on: https://gerrit.libreoffice.org/4839 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-07-10fdo#58644 fix handling of subqueriesLionel Elie Mamane1-0/+1
don't remove parentheses around subqueries (without the parentheses, it is not valid SQL) Change-Id: I4e9c55cea0276f10b0f97e31bc329949aba5b989 Reviewed-on: https://gerrit.libreoffice.org/4790 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-07-05use proper SQLINTEGER type (fixes build on Illumos)Gabriele Bulfon1-1/+1
Change-Id: I85296600195dd5d74d2a112ce6cfef7f276535ab (cherry picked from commit 12b7ba60b746031f2bbef59758270cc0281f4dab) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2013-06-29fdo#66130 correct "skip column name" condition for LIKE predicateLionel Elie Mamane1-1/+1
When converting a parse tree to SQL snippet for a predicate in the context of a column, we skip the name of the same column in 'simple' cases. This is used mainly in the "Criterion" lines of query design, and in the search/filter dialogs of forms, tables, etc. In all other cases (such as when creating a full SQL command, or for references to *other* columns than the context one), the column name must be printed out. In this respect, the condition "should we skip the column name?" in impl_parseLikeNodeToString_throw was buggy, and different from the one in the general case (in impl_parseNodeToString_throw), leading to generating invalid SQL like: SELECT foo, bar FROM baz LEFT JOIN qux ON LIKE qux.quu instead of SELECT foo, bar FROM baz LEFT JOIN qux ON baz.baa LIKE qux.quu Change-Id: Ie14fce319554a66feb0fd0ce1a03d947a46a820a Reviewed-on: https://gerrit.libreoffice.org/4606 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28Replace buggy pgsql-sdbc datetime functions with dbtools equivalentsLionel Elie Mamane6-123/+22
In particular, the string2time function segfaults when called on an empty string (unconditionally tries to access the n-th character without checking whether the string is that long) this happens in particular when reading a column of type TIME with a NULL value Change-Id: I302044f67a92fe20685ce677ba3affdb9b44cb53 Reviewed-on: https://gerrit.libreoffice.org/4582 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28fix nanosecond computationLionel Elie Mamane1-57/+42
when less/more than nine digits Change-Id: I222ae7c51e37468a01abc9caab91657ea2593d13 Reviewed-on: https://gerrit.libreoffice.org/4592 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28fdo#66216 JDBC no fractional second in time formatLionel Elie Mamane1-1/+2
fractional second allowed in timestamp. But not in time. Don't ask why. Change-Id: I5415889ab4cf4835b8b0db7363b7d9eb0a332393 Reviewed-on: https://gerrit.libreoffice.org/4566 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28fdo#66216 fix DBTypeConversion::toTime overflowLionel Elie Mamane1-2/+2
Change-Id: I0aba2344afde94226cfbac5b3221e827e6774b3a Reviewed-on: https://gerrit.libreoffice.org/4565 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28fdo#66216 fix DBTypeConversion::toTimeString formatLionel Elie Mamane1-4/+7
std::ostringstream::width is not sticky Change-Id: I32d77bec68506b7691a4f86dadb24e62fdc13d42 Reviewed-on: https://gerrit.libreoffice.org/4564 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-24fdo#49708 when there is no Primary Key, there is no Primay KeyLionel Elie Mamane1-2/+9
As opposed to a primary key with empty name and no columns (!) Change-Id: I78ca185947a0e8d37bac64bd50add155afaeed47 Reviewed-on: https://gerrit.libreoffice.org/4431 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-06-18fdo#65653 make columnMatchP saferLionel Elie Mamane1-0/+3
Change-Id: Id994ab5aed6172d8a93fd331a366fca10a663a48 Reviewed-on: https://gerrit.libreoffice.org/4338 Reviewed-by: Zolnai Tamás <zolnaitamas2000@gmail.com> Tested-by: Zolnai Tamás <zolnaitamas2000@gmail.com>
2013-06-15fdo#65653, fdo#65619, fdo#65216: Missing checkZolnai Tamás1-1/+1
Problem caused by commit: 16c9ce4877def18ca4578171a96615a632d08092 This commit contains code deduplication. The deduplication removed one needed check (rParam.xFiled.is()), which causes segfault when member function of rParam.xField is called inside columnMatchP(). Change-Id: Ibbdaa758dbbce4b76094e6cc120022ef276b30c4 (cherry picked from commit 10777b37536be16c6d2e167b59e9e31e37ba3517)
2013-06-03re-base on ALv2 code. Includes:Michael Meeks2-26/+19
Patches contributed by Mathias Bauer gnumake4 work variously http://svn.apache.org/viewvc?view=revision&revision=1394707 http://svn.apache.org/viewvc?view=revision&revision=1394326 http://svn.apache.org/viewvc?view=revision&revision=1397337 http://svn.apache.org/viewvc?view=revision&revision=1397315 http://svn.apache.org/viewvc?view=revision&revision=1396797 Patches contributed by Andre Fischer Fixed getcsym.awk to handle #-comments that contain special regexp chars. http://svn.apache.org/viewvc?view=revision&revision=1230971 118778: Added ADDITIONAL_REPOSITORIES environment variable and its automatic setup in configure. http://svn.apache.org/viewvc?view=revision&revision=1232004 118160: Added external CoinMP library. http://svn.apache.org/viewvc?view=revision&revision=1233909 Patches contributed by Herbert Duerr #i119168# use generic LICENSE file for langpacks and sdks http://svn.apache.org/viewvc?view=revision&revision=1310178 macosxotoolhelper: need to quote perl regexp if it may contain regexp metachars http://svn.apache.org/viewvc?view=revision&revision=1183367 allow gbuild with empty sysroot on linux http://svn.apache.org/viewvc?view=revision&revision=1179186 Patches contributed by Ingo Schmidt native373: #164472# improvements for msi database http://svn.apache.org/viewvc?view=revision&revision=1167540 http://svn.apache.org/viewvc?view=revision&revision=1167539 Patches contributed by Jurgen Schmidt adapt setup package scripts to handle special DS_Store file for developer snapshot builds http://svn.apache.org/viewvc?view=revision&revision=1232430 imported patch extensions_i117681.patch http://svn.apache.org/viewvc?view=revision&revision=1172102 Patches contributed by Michael Stahl gbuild: RepositoryFixes.mk should be optional http://svn.apache.org/viewvc?view=revision&revision=1166123 xslt filter: remove the FLA horror wordml import filter: replace FLA usage with plain XSLT http://svn.apache.org/viewvc?view=revision&revision=1363727 Patch contributed by Oliver-Rainer Wittmann i#88652: applied patch, remove unicows deps http://svn.apache.org/viewvc?view=revision&revision=1177585 Remove lots of OS2 conditionals, re-extract Rhino Java, unwind cppunit pieces, cleanup Mac image bits, remove coin-mp and re-package lpsolve, Oxygen & Crystal, fixup qstart bits, expand MPLv2 subset checking. Change-Id: Iad5c8a76399620b892671633c0d8c29996db3564
2013-05-23RHEL-5 baseline ver of flex doesn't have nounistdCaolán McNamara1-1/+1
lets try this hack, if it fails revert and I'll just manually update the baseline with a newer flex than flex-2.5.4a-41.fc6 Change-Id: If644489e80fc4e4cdba97808af0fe4d544d08646 (cherry picked from commit 2ae6f9d1d27f699a6dcf369ba018c93ea7d5def5)
2013-05-21Some more linking fixingFridrich Štrba1-0/+1
Change-Id: I92fbd3839fea6c730039259ce6f56d8082ffd19b (cherry picked from commit 303b6fe5bacd782dafbe370b472a9b724d782f2f)
2013-05-21Add tl for DbgUnhandledException()Tor Lillqvist1-0/+1
Change-Id: I612f0e473280342f4e406ebee7002a40622fbbf0 (cherry picked from commit 0dfa58bdd9bd2ee12fe00674e7a9a1b55939a84b) Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>
2013-05-21more linking fixNoel Grandin1-0/+1
for my diagose_ex.h change Change-Id: I6f9224942b5ccac0ae6b61a595bfe6a3c7463b7b (cherry picked from commit dbcc5bc9d936533794c194d7d33c59c840e76b68) Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>
2013-05-21fix for linkingNoel Grandin3-0/+3
caused by my commit 863d38fbfa4fb4861e476828c46410602100919e "move DBG_UNHANDLED_EXCEPTION out of line" Change-Id: Idfd84d987ba9151ba476ce0516a9e5fbdb2003ec (cherry picked from commit 6bf00f0f94394c62bddcd77b776e4e3592160201) Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>
2013-05-19flat db driver: reorganise OFlatTableLionel Elie Mamane2-142/+184
Change-Id: I5d522abdffaf1aeb4ae0996d3a19acdcca474f95
2013-05-19flat file db driver: clean up seekRowLionel Elie Mamane1-49/+57
Change-Id: Ib9057944c120522230d5ed00cf5d152e5f0b4726
2013-05-19janitorial: spelling in commentLionel Elie Mamane1-1/+1
Change-Id: I54854765c7ad88f1749d5ae7ad9203f6d29fa2b6
2013-05-19remove unused & suspicious methodLionel Elie Mamane2-32/+32
calls m_pTable->seekRow with m_nRowPos instead of m_nFilePos... Change-Id: Ibf9b4da3dffdd75402deb9e7a371a312e0464613
2013-05-19fdo#47951 flat text table: update m_nRowPos when moving by bookmarkLionel Elie Mamane1-0/+14
Change-Id: Iac154020b4b6309f92b1f68fa5bf79611dfcc91b
2013-05-19use safer/more explicit C++ castsLionel Elie Mamane1-1/+6
Especially in debug mode. Change-Id: I431851bd46da0f46fdb5cfaa19c76cb139823fa8
2013-05-19janitorial: clean up commentsLionel Elie Mamane1-6/+1
Change-Id: Iaa146aad75acdceaeb6701b069f0a538904af298
2013-05-19connectivity::file::OResultSet remove totally unused data memberLionel Elie Mamane2-2/+0
Change-Id: I5c4b2d72b600c8ce9de070dc82bf489d66144342
2013-05-19janitorial: typos in commentsLionel Elie Mamane1-2/+2
Change-Id: I6fbd522e796a8f1b6c13136f65bda11c19ffbda4
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist3-4/+4
2013-05-13fdo#64528 macab URL is sdbc:address:macab, not sdbc:address:macab:*Lionel Elie Mamane1-1/+1
Change-Id: I1e5721815c961e14484f78f449910908ed48aeb1
2013-05-10soltools: remove Package_inc and empty unistd.h nonsenseMichael Stahl1-0/+1
Change-Id: Ic05de69951b28b9cc8d62f0a534b507c424e6b25
2013-05-09coverity#982277: reosurce leakMarkus Mohrhard2-2/+0
Change-Id: I5d2b99645faf18e8af9bc0f0b4bff210f9ee8743
2013-05-08Fix connectivity on WindowsFridrich Štrba1-0/+1
Change-Id: I1db4f6a6c680de2143659040d06d299881d8a9c7
2013-05-07Yet another fix for missing sqlbison.hxxStephan Bergmann1-0/+1
Change-Id: I2fb97a1422ed82c79b7babff793dba700eba2369