summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2016-08-21coverity#1371621 Uncaught exceptionCaolán McNamara1-1/+13
Change-Id: I82e500ce3b6022f7783f645bbcd4e957588f7bae
2016-08-21coverity#1371622 Uninitialized scalar fieldCaolán McNamara1-7/+0
Change-Id: Id1408665b01889eabe449047f2d8f62229aeeb16
2016-08-19Some clang-tidy misc-move-constructor-initStephan Bergmann1-1/+1
...by turning the relevant ctor parameters into "const &". Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc
2016-08-18tdf#72987 GSoC Use Firebird backup formatWastack2-114/+227
Store embedded database files as an archive (.fbk) file. The firebird database file is extracted when opening an odb file, and archived for each saving. Change-Id: I6c985f89a0fb01b2294f728b4581053521ca0c88 Reviewed-on: https://gerrit.libreoffice.org/28045 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-18tdf#69949 GSoC Firebird implement autoincrementWastack17-14/+511
Change-Id: I6fe08b575f01b986f0a3c96b341f254279427b68 Reviewed-on: https://gerrit.libreoffice.org/28062 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-17tdf#91324 correct firebird date formatWastack1-4/+4
Store date inside the embedded firebird database as: Years as the years since 1900. Months from 0 to 11. Change-Id: Ic6269a183261c4c482f91f0d3871b42c54d4b99f Reviewed-on: https://gerrit.libreoffice.org/28173 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-08-17tdf#73073 GSoC Firebird Set autoCommit trueWastack1-0/+4
Use autoCommit for embedded Firebird database. Change-Id: I5633960b8e3d4e6ee8f9b4f29406c7208a059521 Reviewed-on: https://gerrit.libreoffice.org/28047 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-08-17GSoC Upgrade firebird to 3.0Wastack1-2/+17
Embedded firebird is now version 3.0. Supports MSVC 14.0. Instead of fbembed, there are now two libraries: fbclient and Engine12. fbclient is linked as fbembed before, Engine12 is loaded at runtime from fbclient. fb now needs system libtommath, which is supplied as a new ExternalProject of LO. Change-Id: I132939bdee745795b22f675e4265e9590079c45f Reviewed-on: https://gerrit.libreoffice.org/27642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-08-17loplugin:unusedenumconstants in basctl..editengNoel Grandin2-17/+0
Change-Id: I49a23a197969d58a3a2d6b2be1fbe4a647c7fa08
2016-08-16loplugin:stringstaticStephan Bergmann1-4/+4
Change-Id: Ia5d7ca7864dbef1489294783438b9d718159614b
2016-08-16new loplugin to check for static OUStringsNoel Grandin7-37/+30
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: https://gerrit.libreoffice.org/27377 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11tdf#91324 GSoC adapt struct tm correctly for dateWastack1-1/+1
Change-Id: Id0413d735eeeb506b6e706c5d31e7bf989ab5e41 Reviewed-on: https://gerrit.libreoffice.org/27592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-08-07Revert "tdf#67302 Resolving tablesSupplier name clash for postgresql"Lionel Elie Mamane8-33/+10
As explained in https://bugs.documentfoundation.org/67302 this is the right thing to do in that directory, but cannot be comitted in isolation. All callers of that function in all of LibreOffice need to be adapted to the new syntax of the returned value (that is that the value is now properly escaped). This needs to be done at the same time in all drivers and all places that call this API (+documented in the release notes). This reverts commit d43f4390e006716ca538ad92d09bd012179efd66. Change-Id: I8f33fd68ec09d67dd6d38ae50d8ae156f11c5357 Reviewed-on: https://gerrit.libreoffice.org/26593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-08-05loplugin:countusersofdefaultparams in chart2..desktopNoel Grandin3-3/+3
Change-Id: Iaca94acd6ef91f07ed0c0085390500c418099dee Reviewed-on: https://gerrit.libreoffice.org/27896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01tdf#100726: Improve readability of OUString concatenationnadith5-15/+6
this bug fixed in the modules between canvas - cppu Change-Id: I2022b022897dafde20251352376e3facdb9b8d75 Reviewed-on: https://gerrit.libreoffice.org/27663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-29connectivity: fix loplugin:cppunitassertequals warningsMiklos Vajna2-36/+36
Change-Id: Iad115345c061074da89746de8a9d2af2eb78802c Reviewed-on: https://gerrit.libreoffice.org/27679 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-27improve passstuffbyref return analysisNoel Grandin15-43/+43
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25new loplugin overrideparamNoel Grandin3-14/+14
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-22Fix typosAndrea Gelmini1-1/+1
Thanks to Carlo Bertoldi for the german translation. Change-Id: I76f554e757318aed4e28b5a05fae0ba15bd46afb Reviewed-on: https://gerrit.libreoffice.org/27355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-07-15loplugin:redundantcastStephan Bergmann2-4/+4
Change-Id: I2d963eb8395b8eca776032d32d72f5ec85891c70
2016-07-15new loplugin unnecessary overrideNoel Grandin11-60/+2
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15tdf#71009 GSoC firebird metadata functionsWastack1-12/+108
Implement getImportedKeys funtion in order to have a working tools->relationships feature. Change-Id: I7f1660f284bfdc960d3aca034c3d26109770b4cb Reviewed-on: https://gerrit.libreoffice.org/26882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-07-15tdf#91324 GSoC adapt struct tm correctlyWastack1-4/+8
Change-Id: I645ebe888186e550b95dd072e063260bc69aa178 Reviewed-on: https://gerrit.libreoffice.org/27120 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-07-13Remove useless comments (one was even wrong)Stephan Bergmann1-6/+6
Change-Id: I4ef60e11878676b8276f85811e811908242ab1b2
2016-07-12Fix typo relase_ChildImpl -> release_ChildImplStephan Bergmann16-16/+16
Change-Id: I68faf8cfb8eb390e7970383b8a6596a9dd3f95f7
2016-07-12tdf#100866: Don't let exception pass connectivity::releaseStephan Bergmann1-2/+8
...which is only ever called from onexcept XInterface::release overrides: connectivity::release itself appears to be only called from connectivity::OSubComponent::relase_ChildImpl [sic], which in turn is only called from various XInterface::release overrides across connectivity. Change-Id: I94b682ec531acecd0ef9f8c100f67a71c361941e
2016-07-08Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendarEike Rathke1-1/+1
... implementing signed years with year 0 gap. Date(31,12,-1) last day BCE Date(1,1,1) first day CE New class Date member functions: * AddYears(sal_Int16) to be used instead of aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap. * convenience GetNextYear() to be used insted of GetYear()+1 * convenience GetPrevYear() to be used insted of GetYear()-1 * AddMonths(sal_Int32) * operator=(const css::util::Date&) New class DateTime member functions: * operator=(const css::util::DateTime&) Made some conversion ctors explicit, specifically Date(sal_Int32) Adapted hopefully all places that used a sal_uInt16 year to use sal_Int16 where appropriate. Eliminated some quirks in date handling found on the fly. Added era handling to i18npool icu calendar setting interface, which missing was responsible for 0001-01-01 entered in Calc being set as -0001-01-01, hence subtracting one day resulted in -0002-12-31. Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f Reviewed-on: https://gerrit.libreoffice.org/27049 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-08loplugin:redundantcast: redundant static_casts in connectivityStephan Bergmann3-4/+4
Change-Id: I2428e27f04b9f967c21ea0dd29eff6ee63167ec3
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2-3/+3
Change-Id: I9a647ba5c867e2152c204e1da98b5139091e51bd
2016-07-04tdf#43157 clean up OSL_ASSERT in connectivityJochen Nitschke4-4/+4
replace with compile time checks Change-Id: I9f3dd3b44fe0aa953feaa34a1bc0ccbdc3600899 Reviewed-on: https://gerrit.libreoffice.org/26801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04remove comphelper::string::removeNoel Grandin1-1/+1
and replace it with OUString/OString::replaceAll Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a Reviewed-on: https://gerrit.libreoffice.org/26850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin27-43/+46
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-27clang-analyzer-deadcode.DeadStoresStephan Bergmann1-1/+1
regression introduced by e1af7f0c438bc242e4562aa0286c99787b5ad544 "clang-tidy modernize-loop-convert in c*" Change-Id: I2f1fcb324f9bf7e97a8a514f41ac1208f1f1ca74
2016-06-23loplugin:unusedvariablecheckStephan Bergmann1-1/+0
Change-Id: Ia9c5ea707990d03dd4042c2e0a791976cc1b5f74
2016-06-23tdf#67302 Resolving tablesSupplier name clash for postgresqlPrashant8-10/+34
Change-Id: Ic9bedc678699e136c09a51575f1d27131c5ffd29 Reviewed-on: https://gerrit.libreoffice.org/25069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-21connecitivty: [loplugin:nullptr]Michael Stahl4-2/+27
Change-Id: Ic717e1d119e1a5b8a87caca263322d9e58fe6c68
2016-06-10o3tl::tryGet on a temporary is dangerousStephan Bergmann4-44/+44
...so rename to o3tl::tryAccess to make it more obvious that the returned proxy points into the internals of the given Any, and forbid calling o3tl::tryAccess on a temporary Change-Id: Ia412c6b2b06693811b9b7f0076a08bbf97142df9
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko2-8/+2
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09remove some manual ref-counting in connectivityNoel Grandin21-158/+118
Change-Id: I0d00b4566c13817b296f237e993f4ce63ef0c664 Reviewed-on: https://gerrit.libreoffice.org/26053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann1-1/+1
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08tdf#96099 Remove various smart pointer typedefsMark Page6-26/+25
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f Reviewed-on: https://gerrit.libreoffice.org/26014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl3-30/+30
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06Normalize on using @throws instead of @raise[s]Stephan Bergmann2-8/+8
...as the former is used almost exclusively Change-Id: I38ff11cd0d5125534550df99dd427666011c3b7b
2016-06-06connectivity: -Werror=unused-variableMichael Stahl2-3/+6
Change-Id: Idaef923205a5f21d7c4c84cc74d3a369107f7325
2016-06-06loplugin:sallogareasStephan Bergmann1-1/+1
Change-Id: I32a1b278643ab54dd16966d0e41f3cee0bafb024
2016-06-06connectivity: DBase: fix some obvious endian issuesMichael Stahl4-5/+42
These calls to SvStream::Read/Write operate on structs that contain 32-bit integers. Change-Id: I2d45128ad482013cd9ef1fca0dd259dfc09c904f
2016-06-06Use o3tl/any.hxx in connectivityStephan Bergmann4-62/+66
Change-Id: I5c0d84b20b9146c4fc65bfdc0e9c65a05c93d71c
2016-06-06tdf#89329: use unique_ptr for pImpl in TColumnHelperXisco Fauli1-4/+1
Change-Id: I4a7594cb2a9424fddbd79e2b5d77431bf329eec9 Reviewed-on: https://gerrit.libreoffice.org/25903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove some manual ref-countingNoel Grandin5-28/+19
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f Reviewed-on: https://gerrit.libreoffice.org/25806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03loplugin:refcountingStephan Bergmann1-1/+1
Change-Id: I97a2d4538e0667fe7220a94589a4296c02d882a2