summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2018-09-11mysqlc: Fix XResultSet::absolute and previousTamas Bunth1-1/+4
We need to update the actual row position after using absolute or previous. Change-Id: Ie85f9679b7a06649a88ac8ee08436bf7f4a58a22 Reviewed-on: https://gerrit.libreoffice.org/60329 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-09-07mysqlc: ensure cursor is not out of rangeTamas Bunth2-22/+70
when calling getXXX() methods of a simple result set. Change-Id: I9e018385bb73468ea520b03275232c0982cbcba0 Reviewed-on: https://gerrit.libreoffice.org/60095 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-09-03fix for 'mysqlc: Use unique_ptr on C style arrays'Andras Timar1-1/+1
Change-Id: I9460c6f8e52890ebb37ae59264ba9035b063f560
2018-09-03Don't link Library_mysqlc against -lnslStephan Bergmann1-1/+1
At least Fedora 28 glibc-2.27-8.fc28 no longer provides the nis development headers and libraries. (It only still contains some binaries for backwards compatibility, in the libnsl sub-package: "This package provides the legacy version of libnsl library, for accessing NIS services.") The -lnsl was present ever since 4946c62f2943dfb3466cc4214a9c8ccd922669b5 "mysqlconnector: initial import from CWS mysqlnative", but appears to not be necessary (at least any more). Reviewed-on: https://gerrit.libreoffice.org/52536 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 61d57bcebd1a246603cbcd9ad5e0a7df1a8d66cd) Conflicts: mysqlc/Library_mysqlc.mk Change-Id: I10b56cdc1a438fb2978125ae0acde0dbec747e78
2018-09-03mysqlc: implement beforeFirst and fix findColumnTamas Bunth2-4/+3
Change-Id: I9a12ef6c61b83f588be89ed9aff301d570155d74 Reviewed-on: https://gerrit.libreoffice.org/59881 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-09-03mysqlc: Use unique_ptr on C style arraysTamas Bunth4-19/+15
Change-Id: Id65487191c29f7af1a171c06345034d1dc5b20ec Reviewed-on: https://gerrit.libreoffice.org/59856 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/59871 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-09-03mysqlc: implement getImportedKeysTamas Bunth1-6/+58
Change-Id: Ic819389000b5b31de69bece6b280cf89f93db948 Reviewed-on: https://gerrit.libreoffice.org/59851 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/59870 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-09-03mysqlc: Add library to log areas and put someTamas Bunth1-10/+22
warnings into databasemetadata Change-Id: I4c2841e9174e738fff6b8627f8860588c7838c49 Reviewed-on: https://gerrit.libreoffice.org/59755 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/59869 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-08-29Add source for zero stub mysqllo.dll (MSP needs it)cp-6.0-7Andras Timar3-0/+41
Change-Id: Ia36bbd0bd7c1f650366215bfc70b0ced5b96e70a
2018-08-28coverity#1438784 Uninitialized pointer fieldCaolán McNamara1-0/+1
Change-Id: Ic8bc7423765f8610d92ca3ced4c52d4838b7699a Reviewed-on: https://gerrit.libreoffice.org/59653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 15f6a37f97acaa8ea8c5af208d2f16992f349df0)
2018-08-28-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
Change-Id: I8c71fe9a5ae0d228313b6b66752ee93aae72f539 (cherry picked from commit 63f8c506637c910ed1efa572f23ff1af7715e7e3)
2018-08-28drop unnecessary SYSTEM_MYSQL_CONNECTOR_CPPCaolán McNamara1-2/+0
Change-Id: I41cfbf41247270d29e08e5125adc05aac198b175 Reviewed-on: https://gerrit.libreoffice.org/59608 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 5061663ce052087c6d5d0910d6f99358e26dbbd1)
2018-08-28CPPCONN_LIB now unusedCaolán McNamara1-2/+0
since commit 26b40fcfc67480e75bd9959b0c5cb9db10fdf6a1 Author: Tamas Bunth <tamas.bunth@collabora.co.uk> Date: Thu Aug 16 16:35:17 2018 +0200 Moving mysqlc into connectivity as a library Change-Id: Iafc4fb685d8f7b97f8be83dbf26945f9af976f1a Reviewed-on: https://gerrit.libreoffice.org/59604 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 71cbeeee374a416c90df54ef1a0353e04a7ca668)
2018-08-28mysqlc: registry xml: install driverTamas Bunth1-2/+2
Change-Id: I864302cc7ba8f27300e4bf0dd3d8a6cc1896da4b Reviewed-on: https://gerrit.libreoffice.org/59698 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/59718 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-08-28SYSTEM_MYSQL_CPPCONN is never definedStephan Bergmann1-2/+0
...since 5061663ce052087c6d5d0910d6f99358e26dbbd1 "drop unnecessary SYSTEM_MYSQL_CONNECTOR_CPP" Change-Id: I2023baf04dfb050833a0032367fc2dc2cfdb9d92 Reviewed-on: https://gerrit.libreoffice.org/59670 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/59717 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-08-28coverity#1438783 Unchecked return valueCaolán McNamara1-1/+3
Change-Id: Ice56d317087dd24d2eef27f2ace5fdf9f4da946d Reviewed-on: https://gerrit.libreoffice.org/59654 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/59716 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-08-28mysqlc: fix registry configurationTamas Bunth1-4/+5
Change-Id: Iefe1446e5f28471c6cafd256b29612c2457e42fc Reviewed-on: https://gerrit.libreoffice.org/59640 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/59715 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-08-28mysqlc: Fix issue by freeing result setsTamas Bunth2-3/+6
Change-Id: I8a5f886306e028f06243768376b2a6c55df6063c Reviewed-on: https://gerrit.libreoffice.org/59210 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/59714 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-08-28Moving mysqlc into connectivity as a libraryTamas Bunth35-646/+8257
Additionally I erased the remains of the old mysql C++ connector. Also update the code where the clang plugins were unhappy after moving the mysqlc module. Remove mysql-cpp-connector external. Change-Id: I771cc7afacf5012fc349afb6b36828fb0fee5a66 Reviewed-on: https://gerrit.libreoffice.org/59200 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/59713 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-06-27tdf#118112: Use ParameterNameSubstitution for MysqlJulien Nabet1-0/+15
Change-Id: Ic48aee378d0a89466c49de85baa96a3bea127d2f Reviewed-on: https://gerrit.libreoffice.org/55771 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit c179e8a7ea273a48713192c3ba7dfea313149cd8) Reviewed-on: https://gerrit.libreoffice.org/55780 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> (cherry picked from commit 4de33eb2b5a802e8eda36c5806913efeead68441)
2018-04-12SQL string quoting: escape "'" character also at beginning of stringLionel Elie Mamane1-1/+1
Change-Id: I51db43c1a3b6d3c93a04a3419238ea286cab987e Reviewed-on: https://gerrit.libreoffice.org/52577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 1ddb065adcd0c2f5666e86bdf841d818ab7a215e)
2018-03-25Add HSQLDB schema importTamas Bunth1-5/+3
It can be enabled by initializing the DBACCESS_HSQL_MIGRATION variable. Create new library "dbahsql" which is responsible for migrating the embedded hsql database to any database covered by sdbc. The hsqldb schema is stored in a file named "script" in form of SQL statements. The SQL statements used by DBMS's differ mostly by the defined types. Because of that, only the create statements need to be parsed, alter statements will work (with a little luck) without actually modifying it. User / security settings which can occur in the script file (e.g. GRANT statements) are dropped. Statements starting with SET are also dropped (they are hsql specific stuff) Change-Id: I6a22942e8a9a76765f80e50f0ad68f4d72e1ff9d Reviewed-on: https://gerrit.libreoffice.org/48260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 95bece38ac5c943657ad959cad148c84a91d45a4)
2018-03-20tdf#104986: Add MILLISECOND, WEEKDAY, and YEARDAY tokens for FirebirdTor Lillqvist2-2/+5
Change-Id: I2ba866c408dbf49f1655cc08cc5d0df840eaf01e Reviewed-on: https://gerrit.libreoffice.org/47271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 72ff62a13af402d19e6e53b809b29033a985c04a)
2018-03-20tdf#71007: Pass also fractional seconds to/from FirebirdTor Lillqvist2-5/+16
We know that ISC_TIME is simply in units of seconds/ISC_TIME_SECONDS_PRECISION. Change-Id: I2896f53c2d32a773c535e19f55dd1314abd18ec9 Reviewed-on: https://gerrit.libreoffice.org/47266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit e0a22d47d281f61f51ead6d2831cd53c15036ffe)
2018-03-20tdf#104734 Firebird: Add LONGVARBINARY/Image typeTamas Bunth4-1/+19
Implement it as a user-defined Blob subtype. Change-Id: Ia369b6858e7d9191f34032445c1003931273e926 Reviewed-on: https://gerrit.libreoffice.org/47098 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 0217031a98508731f15df9d361a6e5b584db5716)
2018-03-20Firebird: use 32 bitTamas Bunth1-1/+1
Change-Id: I435524d1852a6691b382b93c9b6d2a7705938cd7 Reviewed-on: https://gerrit.libreoffice.org/47130 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 64d4f117447d990ed3215b0dd619e07de26ce417)
2018-03-20tdf#104734 Firebird improve XClob implementationTamas Bunth10-40/+262
Create a more effective implementation of XClob::length() and XClob::getSubString() methods, where string is read segment-by-segment instead of reading the whole underlying blob. That way it is possible to handle big texts which would not fit into memory. Also allow reading Clob data from a resultset with getString() and writing it in a prepared statement with setString(). Implement XPreparedStatement::setClob(). Also implement a private version of setClob() for creating a clob from OUString: Allow the creation of a clob column with GUI by adding a new type in ODataBaseMetaData::getTypeInfo(). Change-Id: Ibcbbdd80e8eed5e2a3fe55b0fa196401f1bcbcdf Reviewed-on: https://gerrit.libreoffice.org/47093 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit f80b51ae441e3483a2e9b77a30b932d4e8fba192)
2018-03-20tdf#104734 Firebird: Add VARBINARY type to driverTamas Bunth4-4/+19
Change-Id: I9a1b3aa9bde855577078fe0db2e31a9c160031d7 Reviewed-on: https://gerrit.libreoffice.org/47092 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit e7a80ddb91c44711296aa996bf00242edbfba32d)
2018-03-20tdf#104734 Firebird: Add Binary (fix) typeTamas Bunth6-139/+245
There is no explicit binary type in Firebird. It can be accomplished using the CHAR type with a special character set, which tells the database that it is binary data and there is no collation. (called OCTETS). Because of that, we also need the character set to decide the exact column type. And also refactor some parts of the driver: - Create class to determine internal type from firebird type, subtype, scale and character set. - Use internal type (DataType::XXX) in XDatabaseMetaData::getTypeInfo() indirectly. (We want to return a Firebird type for each internal type, not in the opposite direction. Change-Id: Ica56a84d89253e11936e7012086fe1d9f61a65f0 Reviewed-on: https://gerrit.libreoffice.org/47091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit bf662904c4b60e93c6b86e06288d41996eed12a2)
2018-03-19Firebird: check isc_blob_info errorTamas Bunth1-1/+1
Change-Id: I398bf195a8cfebe081fd3034d6c539b02aaf6d73 Reviewed-on: https://gerrit.libreoffice.org/46148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 8abda0217dcdfc45fc0f7e74a37d048c5fda395f)
2018-03-19Firebird: Revert not closing cursor,..Tamas Bunth1-0/+15
..but suppress error of closing closed cursor Change-Id: I58f96f02f3f600a089bde361ed3e46a03a4902d4 Reviewed-on: https://gerrit.libreoffice.org/46141 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 032a3e3713af3e308229bd8e1ada17d6d24072f3)
2018-03-19clean code at setObjectWithInfoTamas Bunth1-20/+14
Change-Id: I8cb4eaebd71d8b06523230954da15d73325ac94b Reviewed-on: https://gerrit.libreoffice.org/46130 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 907423a6ec5c2170dbf2ca445c0a1285e9a6adfc)
2018-03-19tdf#70425 do not close cursor explicitlyTamas Bunth1-15/+0
A cursor need only be closed in this manner if it was previously opened and associated with stmt_handle by isc_dsql_set_cursor_name() See Interbase API Guide: isc_dsql_free_statement Reviewed-on: https://gerrit.libreoffice.org/46132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 9585521c28b74dec36522a6501ca670b8e14c7ca) Change-Id: Iadb0dcf83ee58b6196112c44d922528a3f56f7ea
2018-03-19tdf#70425 Firebird: accept integers in setDoubleTamas Bunth1-1/+29
Change-Id: I471197a9c60ca28b93be0974956e5e1d90f843ca Reviewed-on: https://gerrit.libreoffice.org/46125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 9ccc1f59446bc4a16b6d090a3b556e184eb5f159)
2018-03-06tdf#116171: Tunnel arbitrary rtl_TextEncoding from sc to sdbc:dbase connectionStephan Bergmann1-8/+16
...including those that have no corresponding textual IANA character set name representation, like RTL_TEXTENCODING_MS_950 which is apparently used in some DBase files. In the past, if eCharSet was RTL_TEXTENCODING_DONTKNOW in lcl_getDBaseConnection it was sent as an empty string CharSet property, which the receiving OConnection::construct translated back to else m_nTextEncoding = RTL_TEXTENCODING_DONTKNOW; so the net effect remains the same for that special case. Change-Id: I84eec8a93d000752b3c429976c58721ea9ea32a4 Reviewed-on: https://gerrit.libreoffice.org/50772 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 5ad62544bce42396faaae2bc79c7517af6ff085b) Reviewed-on: https://gerrit.libreoffice.org/50780 Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-27tdf#70425 suppress error of closing closed cursorTamas Bunth1-3/+7
Merge of: https://cgit.freedesktop.org/libreoffice/core/commit/?id=9585521c28b74dec36522a6501ca670b8e14c7ca + https://cgit.freedesktop.org/libreoffice/core/commit/?id=032a3e3713af3e308229bd8e1ada17d6d24072f3 Change-Id: Iadb0dcf83ee58b6196112c44d922528a3f56f7ea Reviewed-on: https://gerrit.libreoffice.org/46132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/47543 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-07tdf#114495 ODBC: clear row status buffer *before* we throw away the statementJulien Nabet1-1/+1
Change-Id: I898e9d0e3e2cf1ed41489231d1cd761171bfcea4 Reviewed-on: https://gerrit.libreoffice.org/47514 (cherry picked from commit 964cc98794941dbf7dccce526c4fa88c16b3a26c) Reviewed-on: https://gerrit.libreoffice.org/47525 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-03Don't call getLength() on OUStringBuffer after makeStringAndClear()Tor Lillqvist1-1/+1
It's the length of the OUString that we just made from the OUStringBuffer that we want. Fixes a problem where the code would try to execute an erronoeus SQL statement like: ')EATE TABLE "Tasks" ("Notes" VARCHAR(32765),"TaskID" INTEGER,"EndDate" DATE,"StartDate" DATE,"Description" VARCHAR(65000),' Too lazy to file a bug for this, the error should be obvious by just reading the code. Change-Id: I473cd8a7a9791700ca8b6467a84f4bad5dee4d55 Reviewed-on: https://gerrit.libreoffice.org/47230 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit d48edd1e854e0df012b61f833d83efcd19fbe99b) Reviewed-on: https://gerrit.libreoffice.org/47231
2018-01-02Related tdf#104942: implement setByte on firebirdJulien Nabet2-4/+6
There's no TINYINT or equivalent so let's do the same as setShort Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit f31ccd18f1b142f8c851e7e219f8bc18b157bc52) Change-Id: Ia1154ee068b02f40e7efa21571036d8b49844859 Reviewed-on: https://gerrit.libreoffice.org/47237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-30Disable check for successful file deletion for nowStephan Bergmann1-1/+1
...as it makes JunitTest_dbaccess_complex fail on Windows. Apparently, those files are held open by soffice for whatever reason. Needs further investigation... Change-Id: Id80b6f58288deaa39fc74fe36886e371968f8d82 Reviewed-on: https://gerrit.libreoffice.org/45596 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-11-23Fix an argument for SQLSetDescRec.Damjan Jovanovic1-10/+1
Remove a duplicated and commented T3SQLNativeSql definition. Patch by: me (cherry picked from commit 72c9a57b915e080b4bd27800f30232624172b1c3) Change-Id: I2730ede794f750181075b253f62951d47ec82ddc Reviewed-on: https://gerrit.libreoffice.org/45176 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-23loplugin:useuniqueptr in connectivity/source/drivers/macab/Stephan Bergmann4-55/+34
...which revealed that lcl_CFType.cf should rather be of type CFTypeID (i.e., unsigned long), and required some adaption of for loops to cope with the type differences between old sal_Int32 length vars and new std::vector::size calls. Change-Id: Ic87acbb8b4255627fa976d3615bb319237aa4deb Reviewed-on: https://gerrit.libreoffice.org/45154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-23loplugin:simplifybool for negation of comparison operatorNoel Grandin1-1/+1
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22drop duplicate methodCaolán McNamara3-4/+4
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin1-2/+2
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-18silence some coverity warningsCaolán McNamara3-3/+3
Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d Reviewed-on: https://gerrit.libreoffice.org/44875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-18Assume thread encoding for ODBC status stringMike Kaganski2-4/+3
OTools::ThrowException uses SQLGetDiagRec to get error message. It's not the caller's responsibility to define the encoding of resulting string. Also, using the default setting of RTL_TEXTENCODING_MS_1252 turns returned localized strings into garbage. To allow correct conversion into Unicode string, let's use current thread encoding, and drop the input encoding parameter. Change-Id: Idb02e3ebb4fc407ce5e658fb2137ea2aa3bc127d Reviewed-on: https://gerrit.libreoffice.org/44877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-16Delete test*.odb filesStephan Bergmann2-12/+16
...that are created in java.io.tmpdir (e.g., /tmp on Linux) by connectivity.tools.HsqlDatabase.createDBDocument() during e.g. JunitTest_dbaccess_complex. This revealed that connectivity.tools.AbstractDatabase.delete() (even if it would have been called by the test) would have been non-effective at deleting the file, as the java.io.File constructor used takes a pathname not a file URL as argument, so the call to java.io.File.delete() would not have deleted the relevant file (and returned false, rather). Change-Id: I268e1d1732ac7a0db9ccde7d4ac4f09aa3811e11 Reviewed-on: https://gerrit.libreoffice.org/44801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-14Translate German debug stringsJohnny_M1-2/+2
Change-Id: If4da1df3f7889d2b579fcde4fec5ac3c82026555 Reviewed-on: https://gerrit.libreoffice.org/44627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-13survive building dbaccess+connectivity with --disable-dynamic-loadingCaolán McNamara1-0/+2
Change-Id: I49387d2b6ec1893bf721e3289f2f620a4ce71fb3 Reviewed-on: https://gerrit.libreoffice.org/44668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 17:45:25 +0000