summaryrefslogtreecommitdiff
path: root/connectivity/qa
AgeCommit message (Collapse)AuthorFilesLines
2017-07-21migrate to boost::gettextCaolán McNamara1-1/+1
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-03-19TyposJulien Nabet2-2/+2
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c Reviewed-on: https://gerrit.libreoffice.org/35436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-17remove some unused Java codeNoel Grandin1-18/+0
Change-Id: Ia1663256fc0b92c343ea4ba55a821c969077a0aa Reviewed-on: https://gerrit.libreoffice.org/33174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12Prevent use of ORowSetValue with sal_Bool as TINYINTStephan Bergmann1-23/+0
sal_Bool and sal_uInt8 are typedefs for the same underlying type, so any use of ORowSetValue with sal_Bool instead of bool, apparently intending to treat the value as a boolean, actually treated it as a TINYINT. (See e.g. recent 7b0c57b2faec875c790051d233d1e9abaed2a3bc "some compilers don't like implicit bool-to-ORowSetValue conversion".) Now that there's no way to create a sal_uInt8 ORowSetValue, getUInt8 and the m_uInt8 union member can probably go away, too. Change-Id: Ia27554f76e7e9edce6410284b578064573e54fd3 Reviewed-on: https://gerrit.libreoffice.org/31909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-01Fix typosAndrea Gelmini1-1/+1
Change-Id: I8374d6d08f4eb4ae2821e213371c615b92d7e9ab Reviewed-on: https://gerrit.libreoffice.org/29432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-07-29connectivity: fix loplugin:cppunitassertequals warningsMiklos Vajna2-36/+36
Change-Id: Iad115345c061074da89746de8a9d2af2eb78802c Reviewed-on: https://gerrit.libreoffice.org/27679 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann1-2/+2
Change-Id: I9a647ba5c867e2152c204e1da98b5139091e51bd
2016-05-30com::sun::star->css in connectivityNoel Grandin1-1/+1
Change-Id: I9489e92dc89a6d83a26ff4f0d9aad26acd28ad9f Reviewed-on: https://gerrit.libreoffice.org/25537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann2-2/+2
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-04these fields can be static constantsNoel Grandin1-11/+6
Change-Id: Id56e219782d7f858cdeb26232c7aabd4f643c9d9 Reviewed-on: https://gerrit.libreoffice.org/21020 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-05java: remove ((unnecessary)) parenthesesNoel Grandin1-4/+4
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05java: make inner classes static where possibleNoel Grandin1-4/+4
Change-Id: Icc6444ad15d9f4b50858d8c1b1d3adeaeac40926
2015-10-16convert "continue" flag to an enumNoel Grandin1-2/+2
Change-Id: I160de1152978f301c514d9107c9e9082bab3cf05
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann1-2/+2
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-06-15java: 'final static' to 'static final'Noel Grandin1-2/+2
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-04Finalizers must not access UNO objectsStephan Bergmann1-1/+15
If the object being finalized (A) has the last reference to the UNO object (B), and B is actually a proxy for a remote UNO object, then A and B become eligible for finalization in parallel, and the finalizer of B may already have run when the finalizer for A runs. That means that B may already have been removed from the remote bridge, causing an "unknown OID" error from the remote end when the finalizer of A now tries to make a call on B. (We try to assert that close() has actually been called before finalize() calls delete(), but the corresponding exception may be silently swallowed by the JVM finalization machinery.) This caused spurious "URP: queryInterface request message with unknown OID received" failures during JunitTest_dbaccess_unoapi. Change-Id: Ia47c3ef2c22a6adc75b1b8271eb4b3140accebe7
2015-02-08Typos + simple german translationsJulien Nabet1-3/+3
Change-Id: Icc0e9f028b393abb062a880519211be4fcd1d4b3
2015-01-05java: remove more dead codeNoel Grandin2-4/+3
found by looking for unused parameters (in Eclipse) Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-05java: remove dead codeNoel Grandin6-132/+0
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin1-2/+2
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19java: static fields that should not be staticNoel Grandin1-1/+1
Found by FindBugs. Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-15java: remove some unused fields and variablesNoel Grandin1-8/+0
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-12connectivity: Use appropriate OUString functions on string constantsStephan Bergmann1-4/+4
Change-Id: I10b2ddf9dcc83219fea8eb55783507eed52702e8
2014-12-11java: reduce visibility of fields and methodsNoel Grandin3-25/+25
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25java: remove some comment noiseNoel Grandin1-7/+1
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
2014-11-18java: make fields final where possibleNoel Grandin5-12/+12
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12java: convert fields to local variables where possibleNoel Grandin1-7/+6
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-25java: prevent overflow by using 'long int' arithmetic in multiplicationRobert Antoni Buj i Gelonch1-9/+9
Change-Id: I8dda8f4621f265208c713c9edcfe725f1c9c5998 Reviewed-on: https://gerrit.libreoffice.org/12001 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: final fields that can be staticNoel Grandin2-2/+2
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin2-3/+2
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16java: close ResultSet after useNoel Grandin1-25/+30
Change-Id: I5b2903cf2928e19be203d80243c2ac2e75be28cb
2014-10-16remove unnecessary catch blockNoel Grandin1-8/+2
Change-Id: Id33384cee3444924e7e8de7d496f117f120b1876
2014-10-14connectivity: the value of Math.asin(0.0) is zeroRobert Antoni Buj i Gelonch1-1/+1
Change-Id: Ic72750fcea93edf3457ccea4a357e9d2929a646c Reviewed-on: https://gerrit.libreoffice.org/11941 Reviewed-by: Matthew Francis <mjay.francis@gmail.com> Tested-by: Matthew Francis <mjay.francis@gmail.com>
2014-10-11connectivity: Iterate over each Entry in a Map & Enhanced for-loopsRobert Antoni Buj i Gelonch1-8/+5
Change-Id: Id4a340584fc727058f6e37c1f0d3c5887e931417 Reviewed-on: https://gerrit.libreoffice.org/11917 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01connectivity: the assigned value is never usedRobert Antoni Buj i Gelonch2-12/+7
Change-Id: I6e4d2fc6563f0ff1a65e114d018675c314a04fd6 Reviewed-on: https://gerrit.libreoffice.org/11741 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29connectivity: Use chain of .append methodsRobert Antoni Buj i Gelonch1-3/+3
Change-Id: I15604e97dc38f1fcfa62c3d86208e72a86dda23e Reviewed-on: https://gerrit.libreoffice.org/11688 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-21Fix some typosDavid Ostrovsky2-3/+3
Change-Id: I0f2821c87c03f8d3df2e60bab9e09ce6545e2b2c
2014-08-20remove more unnecessary constructor declarationsNoel Grandin1-5/+0
Change-Id: Ie5a243006b112c2e6daf12992f3dba8baf12748d
2014-08-20java: remove modifiers implied by the contextNoel Grandin2-3/+3
found by PMD Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20remove some dead Java codeNoel Grandin1-2/+0
Change-Id: I03dc362f7302ac8539a4da3dcef9466a7c6d7159
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin2-2/+2
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: classes in java.lang package do not need to be fully qualifiedNoel Grandin1-8/+8
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-14java: remove unused importsNoel Grandin1-1/+0
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14java: remove commented out codeNoel Grandin4-76/+0
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-13java: remove dead methodsNoel Grandin1-18/+0
found by UCDetector Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13java: reduce scope, make some methods privateNoel Grandin1-1/+1
found by UCDetector Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13java: reduce scope, make fields privateNoel Grandin3-4/+4
found by UCDetector Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-12java: remove useless javadoc tagsNoel Grandin1-3/+0
that are not conveying any useful information Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12java: add @Override annotation to overriding methodsNoel Grandin3-0/+3
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-08java: remove exceptions from throws clauses that are notNoel Grandin2-2/+2
.. actually thrown Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-22 06:10:32 +0000