summaryrefslogtreecommitdiff
path: root/connectivity/qa
AgeCommit message (Collapse)AuthorFilesLines
2014-11-18java: make fields final where possibleNoel Grandin5-12/+12
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12java: convert fields to local variables where possibleNoel Grandin1-7/+6
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-25java: prevent overflow by using 'long int' arithmetic in multiplicationRobert Antoni Buj i Gelonch1-9/+9
Change-Id: I8dda8f4621f265208c713c9edcfe725f1c9c5998 Reviewed-on: https://gerrit.libreoffice.org/12001 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: final fields that can be staticNoel Grandin2-2/+2
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin2-3/+2
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16java: close ResultSet after useNoel Grandin1-25/+30
Change-Id: I5b2903cf2928e19be203d80243c2ac2e75be28cb
2014-10-16remove unnecessary catch blockNoel Grandin1-8/+2
Change-Id: Id33384cee3444924e7e8de7d496f117f120b1876
2014-10-14connectivity: the value of Math.asin(0.0) is zeroRobert Antoni Buj i Gelonch1-1/+1
Change-Id: Ic72750fcea93edf3457ccea4a357e9d2929a646c Reviewed-on: https://gerrit.libreoffice.org/11941 Reviewed-by: Matthew Francis <mjay.francis@gmail.com> Tested-by: Matthew Francis <mjay.francis@gmail.com>
2014-10-11connectivity: Iterate over each Entry in a Map & Enhanced for-loopsRobert Antoni Buj i Gelonch1-8/+5
Change-Id: Id4a340584fc727058f6e37c1f0d3c5887e931417 Reviewed-on: https://gerrit.libreoffice.org/11917 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01connectivity: the assigned value is never usedRobert Antoni Buj i Gelonch2-12/+7
Change-Id: I6e4d2fc6563f0ff1a65e114d018675c314a04fd6 Reviewed-on: https://gerrit.libreoffice.org/11741 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29connectivity: Use chain of .append methodsRobert Antoni Buj i Gelonch1-3/+3
Change-Id: I15604e97dc38f1fcfa62c3d86208e72a86dda23e Reviewed-on: https://gerrit.libreoffice.org/11688 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-21Fix some typosDavid Ostrovsky2-3/+3
Change-Id: I0f2821c87c03f8d3df2e60bab9e09ce6545e2b2c
2014-08-20remove more unnecessary constructor declarationsNoel Grandin1-5/+0
Change-Id: Ie5a243006b112c2e6daf12992f3dba8baf12748d
2014-08-20java: remove modifiers implied by the contextNoel Grandin2-3/+3
found by PMD Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20remove some dead Java codeNoel Grandin1-2/+0
Change-Id: I03dc362f7302ac8539a4da3dcef9466a7c6d7159
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin2-2/+2
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: classes in java.lang package do not need to be fully qualifiedNoel Grandin1-8/+8
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-14java: remove unused importsNoel Grandin1-1/+0
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14java: remove commented out codeNoel Grandin4-76/+0
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-13java: remove dead methodsNoel Grandin1-18/+0
found by UCDetector Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13java: reduce scope, make some methods privateNoel Grandin1-1/+1
found by UCDetector Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13java: reduce scope, make fields privateNoel Grandin3-4/+4
found by UCDetector Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-12java: remove useless javadoc tagsNoel Grandin1-3/+0
that are not conveying any useful information Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12java: add @Override annotation to overriding methodsNoel Grandin3-0/+3
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-08java: remove exceptions from throws clauses that are notNoel Grandin2-2/+2
.. actually thrown Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
2014-08-08java: remove unused fieldsNoel Grandin1-5/+0
Change-Id: I25fef9590a34ec8d9aab182b3d267ae3cd649a87
2014-08-05java: remove commented out codeNoel Grandin2-4/+0
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-04java: remove some unused import statementsNoel Grandin3-3/+0
Change-Id: Id6342be66221c81b05aee9af519c800e51a286b3
2014-08-04java: remove some casting in lib.TestParameters#getMSFNoel Grandin4-11/+11
where the return value is always cast to XMultiServiceFactory, so just do the cast in the method and avoid noise at the call sites. Change-Id: I3a2e06ac6edb3c6021eda6442032db57aaa22e13
2014-06-04connectivity: fix includesThomas Arnhold2-2/+2
Change-Id: I5d5dc6871789865189c78fe9135e7f8bff829489
2014-05-30Fix leaks in test codeStephan Bergmann1-0/+7
Change-Id: I435fcfd6d10875565b543ea76fa8bfbf52e5f5d0
2014-04-21remove comments why a file gets includedThomas Arnhold1-4/+0
also remove some commented out code Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-17remove executable bitAndras Timar1-0/+0
Change-Id: I91f6e861f6d0dbea1b57ac73857e0c706b27f681
2014-04-16connectivity: sal_Bool->boolNoel Grandin1-2/+2
Change-Id: I96371121ce6697f153f4e973e65831ea2265eb56
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann1-2/+2
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-02-27Remove visual noise from connectivityAlexander Wilms7-19/+19
Conflicts: connectivity/source/inc/odbc/OConnection.hxx Change-Id: I5ca98359e18cf1b27bf53037dde211774d798626 Reviewed-on: https://gerrit.libreoffice.org/8245 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-01-22bool improvementsStephan Bergmann1-1/+1
Change-Id: I989302c6774c4dd01dff3f682bd4b681fc9141df
2013-12-20typo fixesAndras Timar1-1/+1
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-11-11remove unnecessary use of OUString constructor in CONNECTIVITY moduleNoel Grandin2-2/+2
Change-Id: Ie32d03920d996db2793ead9940fc90668cde03dd
2013-10-20ORowSetValue: adapt test to new behaviour, extend test moreLionel Elie Mamane1-7/+85
Change-Id: If28046653935051303fd487d87655bacbddf4644
2013-10-20Extend test to cover changed toString() conversion for bool typesDavid Ostrovsky1-0/+24
Change-Id: I8becffd0c2f12c17495872a99192c7679380d05f
2013-02-09ORowSetValue: move float and double to unionDavid Ostrovsky1-0/+44
Change-Id: Ic5de8ad2cf9ef1143b1a5468e5fc5c9974aca5ec Reviewed-on: https://gerrit.libreoffice.org/2021 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-05ORowSetValue: clean up sign/unsigned union memberDavid Ostrovsky1-0/+248
Also switch BOOLEAN constructor from sal_Bool to bool. old/new signed/unsigned storage situation: ------------------------------------------------------- SQL type | signed | unsigned old | unsigned new ------------------------------------------------------- TINYINT | sal_Int8 | sal_Int16 | sal_uInt8 SMALLINT | sal_Int16 | sal_Int32 | sal_uInt16 INTEGER | sal_Int32 | sal_Int64 | sal_uInt32 BIGINT | sal_Int64 | pValue (String*) | sal_uInt64 ------------------------------------------------------- When sticking an UNSIGNED TINYINT into an Any, silently promote it to UNSIGNED SMALLINT (that is sal_uInt16), else Any would take it as a sal_Bool and normalise to sal_True (1) or sal_False (0). When constructing an ORowSetValue from a sal_Bool, silently keep it as an unsigned 8 bit integer (that is understand it as a sal_uInt8). This will work in most cases, since when asked back for a bool or sal_Bool, we'll give back the right value. Only code looking at the type tag could possibly make a "wrong" decision. The main (hopefully only?) path through which this would happen is through an implementation of XParameters::setBoolean XRowUpdate::updateBoolean that would use its sal_Bool argument to construct an ORowSetValue. So make sure each implementation constructs a proper BOOLEAN so as not to get confused. For authorship/copyright purposes, this patch is a cooperation between Lionel Elie Mamane <lionel@mamane.lu> and David Ostrovsky <david@ostrovsky.org> Change-Id: I3f1f08716127147f077bff4edb6ec558b1b09e09
2012-11-24fdo#51304 Remove @author annotationJosé Guilherme Vanz1-5/+0
This commit removes @author annotations, some templates comments. It has some cleanup. Change-Id: I995ba7b06d661fcec17f26c368d9449c0bf5ab45 Signed-off-by: José Guilherme Vanz <guilherme.sft@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/1146 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-11-20fdo#57285 restore acceptsURL logicDavid Ostrovsky1-0/+22
Change-Id: Ib03c7e4a78510eb0300d78a0ae3e83ec6a17f72f
2012-11-14source file modes fixEnrico Weigelt, metux ITS1-0/+0
Change-Id: I8975f26f205ba33044285729da54e0210f872fcb Reviewed-on: https://gerrit.libreoffice.org/1065 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2012-11-07enable ado driver unit test againDavid Ostrovsky1-3/+1
The problem is that ado driver creates a link file in the tree leaving it dirty: tinderbox doesn't like it. Instead of reading the mdb file direct from srcdir we copy it first to workdir and read it from there with the new function: getPathFromWorkdir. Thank you Norbert! Change-Id: I504bc26b80686db55a505bac19a95cc9c6022fcc Reviewed-on: https://gerrit.libreoffice.org/1004 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-11-03fdo#53070 add complete unit testDavid Ostrovsky2-0/+147
Change-Id: I34f7a8ae58fa6af4c8cfdd13330420f1576fa2c9
2012-10-10mork driver: add list tables and unit testDavid Ostrovsky2-0/+332
Change-Id: I594b24341eb38c05523f578c1dc2e43d90544f30
2012-10-01fdo#51304: Remove the author of some java source filesAnurag Jain5-17/+0
This patch remove some '@author' for Java souce files, and removes some commented code founded when removing the '@author'. Change-Id: Ic4fcd028a9cdbd85c693d93bcd48e41f36386d22
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-16 10:12:46 +0000