summaryrefslogtreecommitdiff
path: root/configmgr
AgeCommit message (Collapse)AuthorFilesLines
2016-08-05Tell where the colon is missing in the exception messageTor Lillqvist1-1/+1
But sure, it would be surprising if the message was actually displayed even if the exception is caught and causes some failure somewhere... (See previous commit.) Change-Id: I7375b869d08a465d9720a619d5ef49a77c4782e5
2016-08-05configmgr: fix loplugin:cppunitassertequals warningsMiklos Vajna1-5/+5
Change-Id: I19e197db4158939875fab0d9e51d903aa1671b37 Reviewed-on: https://gerrit.libreoffice.org/27893 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-27improve passstuffbyref return analysisNoel Grandin6-6/+6
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann1-1/+1
Change-Id: I7bc9219d2e04e68f8b2bd8802f60098669d28e44
2016-06-15tdf#61396 Possibility to edit a template not in Template RepositoryAkshay Deep1-2/+2
Menu Sequence: Open Template... Save as Template... ---------------------- Manage Templates Change-Id: I0d0c8ca15d8dc38662e7f84a4f598933c13dd512 Reviewed-on: https://gerrit.libreoffice.org/26179 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Akshay Deep <akshaydeepiitr@gmail.com>
2016-05-31tdf#91781 A round of minor tweaks to Writer's menusYousuf Philips1-1/+1
Change-Id: I0c37f9e0349af0cd9dc41c500543da7532fb9198 Reviewed-on: https://gerrit.libreoffice.org/23976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-05-25Convert XmlReader::Result to scoped enumNoel Grandin1-5/+5
Change-Id: I6a0d1dcf5ae51d2ac08aacdfec50865f93e51c21 Reviewed-on: https://gerrit.libreoffice.org/25365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Convert XmlReader::Text to scoped enumNoel Grandin2-4/+4
Change-Id: I4741b13fcf887a95b85886cb41f8236e128e81a2 Reviewed-on: https://gerrit.libreoffice.org/25364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin1-2/+1
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12Silence -Werror,-Wimplicit-fallthrough under NDEBUGStephan Bergmann1-6/+5
Change-Id: I030404b445f310a850e0fee2f7ff06baebc9932a
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann8-11/+11
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-03Remove Edit -> Plug-in as no longer usedBryan Quigley1-8/+0
This functionality seems to only have been used with NPAPI plugins. They've been previously removed. Per the help text, if it is still used by anything, you can use the context menu instead. MN_READONLY_PLUGINOFF also appeared to be unused, so removed. More code might be removable, but would affect activate on click/visible. Change-Id: I12d5bf54edd3a2f716912179b87e798b47b3cc3d Reviewed-on: https://gerrit.libreoffice.org/24500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-04-21clang-tidy modernize-loop-convert in c*Noel Grandin2-36/+32
Change-Id: I77d2548f8be97792660761e6156cd24734a95aaf
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin2-3/+3
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin2-2/+2
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke3-4/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke5-5/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-31Missing includeStephan Bergmann1-1/+2
Change-Id: I0babe806f04aa41110e87f9fd6b6febf892cd66d
2016-03-15tdf#96099 fix trival typedefs, Path to std::vector<OUString>Jakub Trzebiatowski19-101/+50
Change-Id: I23fca48becbfdfd92db02a11b739a668fc1cd8c4 Reviewed-on: https://gerrit.libreoffice.org/23007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-12Let's use the iterator return by erase method (part b)Julien Nabet1-1/+1
std::list seems ok but let's try for std::set and std::multiset Change-Id: I1d4875468517c732680ba98ac9f2e08d1baa61bd Reviewed-on: https://gerrit.libreoffice.org/23161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-08tdf#97703 Removed empty setUp/tearDown methodsChirag Manwani1-5/+0
Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5 Reviewed-on: https://gerrit.libreoffice.org/22985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin3-4/+4
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock4-4/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-02tdf#70998 Termchange: Graphic/Picture->Imageakki951-2/+2
Changed visible terms as required. Change-Id: Id4335629977aa8512c753241d7c2203820716b73 Reviewed-on: https://gerrit.libreoffice.org/21857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-01-07Fix typosAndrea Gelmini3-3/+3
Change-Id: I90b04b8eda6fc3d530c9db72052720cbe9de0343 Reviewed-on: https://gerrit.libreoffice.org/21197 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-12-30Kill remaining plugin bitsMaxim Monastirsky1-24/+0
Change-Id: Icd99757b48626ef43313e8de42c4e5462f85a958 Reviewed-on: https://gerrit.libreoffice.org/21008 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-12-23loplugin:unusedfields in chart2Noel Grandin1-1/+0
Change-Id: I8203f84ad8b138932c990032e17ea5d2daf384bb
2015-11-22cppcheck:useInitializationListNoel Grandin5-14/+14
Change-Id: I744ff3e268fbffca9499121f3567640934aaae51 Reviewed-on: https://gerrit.libreoffice.org/20110 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian1-108/+41
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann16-109/+109
Change-Id: I520c7e35d539ba804da17185353317eca504a582
2015-11-09new loplugin: oncevarNoel Grandin6-12/+6
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09Replace a local functor in configmgr by a lambda.Mario J. Rugiero1-21/+2
Change-Id: Ida4317ec6b96ab8cb3362243b4acace3680bcd31 Reviewed-on: https://gerrit.libreoffice.org/19846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-06loplugin:stringconstant: elide explicit ctor usage (manually due to macros)Stephan Bergmann1-12/+12
Change-Id: I409ea5a7e4b6a8e2886d5b489b66b217b3be58b6
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann1-13/+13
Change-Id: Iab64ec9b325da65b90d79f3c986e97774825f6e2
2015-11-04yyyyyNoel Grandin1-13/+6
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-02tdf#94269: Replace "n" prefix for bool variables with "b"Benjamin Ni3-10/+10
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-11-01no need to use OUString constructor in call to createInstanceNoel Grandin1-4/+2
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296 Reviewed-on: https://gerrit.libreoffice.org/19704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30use uno::Reference::set method instead of assignmentNoel Grandin3-4/+3
Change-Id: I080668f86f0ab8b3bba857ee21411f907ae285c4
2015-10-30Get this remove/re-add dance finally sorted out for goodStephan Bergmann1-1/+6
Change-Id: I16cb3fdd699dcd45de25b49d30e0d1b6392fd82b
2015-10-30loplugin:unusedmethodsNoel Grandin1-2/+0
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f Reviewed-on: https://gerrit.libreoffice.org/19636 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-21configmgr/dconf: Simplify Fleet Commander write-back modeStephan Bergmann3-14/+31
* Get rid of different dconf trees for reading and writing again; the one single tree is /org/libreoffice/registry/. * Trigger the special write-back mode when a file $SYSUSERCONFIG/libreoffice/dconfwrite is present; then, ignore the default user:!... entry in CONFIGURATION_LAYERS (i.e., don't use the UserInstallation's registrymodifications.xcu) and instead write changes back to the dconf tree. Change-Id: I6b4d7251851da3fe7abbc9dcb080d57b278de96b
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann19-219/+219
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann14-31/+31
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-09Create a wrapper to make listening for configmgr changes easy.Michael Meeks2-0/+51
Change-Id: Ib58d04f9e046e604b24e0e338796a7a60aa1d6fd Reviewed-on: https://gerrit.libreoffice.org/19253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-02configmgr: remove unused old dmake fileMiklos Vajna1-84/+0
Change-Id: Idbeadeaebf85c9de84d6fafe4d140c77907c0eeb
2015-10-01Revert function removal that breaks --enable-dconfStephan Bergmann1-0/+2
...from 58aea3f36c14414f95668e229a7350598f6c53a8 "loplugin:unusedmethods" Change-Id: I2b218ca01589f3d2efd583aa4e5fb21d19d6319e
2015-10-01loplugin:unusedmethodsNoel Grandin2-3/+1
- improvements to the plugin to find more method calls - improvements to python script to remove more false+ - fix the FORCE_COMPILE_ALL build flag to include code in the $WORKDIR Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836 Reviewed-on: https://gerrit.libreoffice.org/19064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-29Avoid false -Werror=maybe-uninitializedStephan Bergmann1-1/+1
Change-Id: I5493c49eb97c630e91cdc8368ad8b017557f1fa1
2015-09-23Report nil-valued localized property as suchStephan Bergmann1-2/+1
...regression introduced with 879aa54e895a56cb65f93ae98e6a9e7b08981a47 "configmgr: accelerate simple config key fetches." Change-Id: Ifb732a25d902f58c76e06ebaad3a6178ff102f58
2015-09-07cppcheck: noExplicitCopyMoveConstructorCaolán McNamara1-1/+1
Change-Id: I8718ddd144bec48541e6412a8c9feb74d9391ecc