summaryrefslogtreecommitdiff
path: root/configmgr
AgeCommit message (Collapse)AuthorFilesLines
2015-09-29Avoid false -Werror=maybe-uninitializedStephan Bergmann1-1/+1
Change-Id: I5493c49eb97c630e91cdc8368ad8b017557f1fa1
2015-09-23Report nil-valued localized property as suchStephan Bergmann1-2/+1
...regression introduced with 879aa54e895a56cb65f93ae98e6a9e7b08981a47 "configmgr: accelerate simple config key fetches." Change-Id: Ifb732a25d902f58c76e06ebaad3a6178ff102f58
2015-09-07cppcheck: noExplicitCopyMoveConstructorCaolán McNamara1-1/+1
Change-Id: I8718ddd144bec48541e6412a8c9feb74d9391ecc
2015-09-03Restored missing includes from source files.Ashod Nakashian1-0/+1
These source files relied on pch to include these missing headers (at least on Windows). Also included the script used to find the missing includes. The script is self-contained and includes unittests. It detects superfluous includes and required includes (which was used to restore the includes in this patch). Change-Id: I7ee09e5c712f42d5f6c3524898bc62dda78f5cc0 Reviewed-on: https://gerrit.libreoffice.org/18208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-02Fix documentationStephan Bergmann1-1/+2
Change-Id: I8fc081d3f445a362f5e1ee735ce8baeab1d6cc9b
2015-09-02configmgr: Split dconf in two /org/libreoffice/registry/{system,user}/Stephan Bergmann3-6/+11
...so that the lower-layer "dconf:*" reads from the .../system/ dconf tree while the final-layer "dconf:!" reads from and writes to the .../user/ dconf tree. Using a single tree would not really work: For one, a sysadmin will want to finalize a property so it cannot be changed by extensions; that means that property must be set and finalized in the lower-layer "dconf:*". But for another, a user will want to change a property for which an extension provides a value; that means that property must be set in the final-layer "dconf:!". So the two "dconf:*" and "dconf:!" must store their respective data in different places. Change-Id: I9029e7f779bcb86e8f26cfc22401e97e0cb3362b
2015-09-01configmgr: support writing back to dconf (WIP)Stephan Bergmann4-3/+594
Needs to be enabled manually for now by changing CONFIGURATION_LAYERS's tail from " user:..." to " user:*... dconf:!". Change-Id: I31cd806f21d2ded376832faf98f49167b7243d1c
2015-09-01dconf: Change the way set elements are encodedStephan Bergmann1-96/+136
...to avoid having multiple dconf paths for the same set element (with different template names or operations encoded into the dconf path segment), esp. when introducing write-back into dconf. Change-Id: Ieebad3b1024dd7607022abbfa963850b05c26d65
2015-09-01Handle dconf_client_new failureStephan Bergmann1-0/+4
Change-Id: Ib873ca03a2552dc0405236ed87040672ba359e5e
2015-09-01dconf: fix check for matching templateStephan Bergmann1-36/+36
Change-Id: I8319bf10310d55e2f29de8103d983e34a53f87df
2015-09-01dconf: fix encoding of set element namesStephan Bergmann1-10/+21
Change-Id: I6aba45a70a9ebee65be34af1036bb515fd2a22b7
2015-09-01Rename stuff, in preparation of dconf::writeModificationsStephan Bergmann4-12/+12
Change-Id: Icd472e91b222907e2cdcbdba1b78b33c44eff566
2015-09-01Support modification write-back to other than registrymodifications.xcuStephan Bergmann2-18/+48
...to eventually support writing to dconf (see TODO). Even when writing somewhere else, it may still be useful to read from the current "user:" location, so a new convention was introduced to CONFIGURATION_LAYERS types that support write-back: - A leading "!" indicates that the layer is indeed used for write-back (probably in addition to reading from it). For backwards compatibility (when users use own settings of CONFIGURATION_LAYERS, instead of depending on the value in the shipped fundamental ini-file), no prefix on the "user:" is now interpreted the same as a "!" prefix. - A leading "*" indicates that the layer is not used for write-back (but only for reading from it). Change-Id: I399cc7bfe927db50586834f9630c184aaa2153f2
2015-09-01readdconflayer: avoid deref of null (removed) memberStephan Bergmann1-63/+68
Change-Id: I3b2ce8ef79c4bc0dde8ba43f96ca4e97a71dd2cd
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann2-6/+6
Change-Id: Id852428e7b7cde6eec6eeb9a2a9004d1f2e789b6
2015-08-27Simplify hasModifications checkStephan Bergmann3-12/+5
Change-Id: Idcbd9a20ab13d0717f8728673e2c55e87aa92be4
2015-08-21Generalize CONFIGURATION_LAYERS "winreg:" notationStephan Bergmann1-6/+9
...after 097292feab4fc3c064983e1dd08ac4bebe1fe216 "Add HKEY_CURRENT_USER registry integration" added "winuserreg:". Even though changing from the exisiting "winreg:" to "winreg:LOCAL_MACHINE" should be compatible, as it only ends up in fundamental.ini included in the LO inst set, play it safe it keep treating "winreg" the same as "winreg:LOCAL_MACHINE". ("url" is a misnomer now in configmgr's Components ctor, and should eventually be renamed to something more accurate.) Change-Id: Ifbcf3284d904490891642599468470d03547f92a Reviewed-on: https://gerrit.libreoffice.org/17891 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-08-21Support "finalized" in dconf layerStephan Bergmann1-1/+18
Change-Id: Id33e21b01d8898ea9ff49bc7cc59b573580ab88d
2015-07-28com::sun::star->css in configmgrNoel Grandin16-326/+299
Change-Id: Ief642571ddccbf016fa1625b5859b4889a4a3e8e Reviewed-on: https://gerrit.libreoffice.org/17366 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24loplugin:unusedmethodsNoel Grandin3-1/+4
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-15tdf#92764 - make configmgr write less noisy.Michael Meeks3-58/+102
Re-factor the TempFile abstraction and add a trivial OStringBuffer to avoid emitting so many system calls - for writing small fragments of configuration XML. Change-Id: Ifbf5982ddb44845b2316087cafab4175a40e03cc
2015-07-15loplugin:unusedmethods configmgrNoel Grandin8-21/+0
Change-Id: Ie0338860717630633752a39814057c736d1faee8 Reviewed-on: https://gerrit.libreoffice.org/17059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-14Add HKEY_CURRENT_USER registry integration.Michael Meeks3-5/+11
It seems rather odd that we dump this to a file and parse again to me. Change-Id: Ia32ba9ff3e7878d40032bd7d10fba2c143d11757 Reviewed-on: https://gerrit.libreoffice.org/17033 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2015-07-13tdf#92639: Slashes are allowed in set member names, of courseStephan Bergmann2-8/+9
Change-Id: I30944fe9611e83566c891a7d1461ad02979daddd
2015-07-13tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe7-20/+17
with the variadic variants, in configmgr. Change-Id: I0cf82ab487ed879aa385d6065e908e347c0778e8 Reviewed-on: https://gerrit.libreoffice.org/16964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-08configmgr: support reading from a dconf layer (WIP)Stephan Bergmann5-2/+977
Work in progress to allow integration of LO with <https://wiki.gnome.org/Projects/FleetCommander>. During configuration, dconf support is implicitly enabled when available on the host (which is presumably only available on Linux). It is explicitly disabled for TDF Linux builds for now, though, to avoid accidental dependencies of the distributed installation sets on system dconf libraries. A dconf layer is represented in the CONFIGURATION_LAYERS bootstrap variable with type "dconf" and an empty URL. See the comment at the top of configmgr/source/readdconflayer.cxx for the encoding of component-data in dconf. All of this is still subject to change. Change-Id: I2d08d81c8ea43ba4a99040a8882ae75b91bcfdb9 Reviewed-on: https://gerrit.libreoffice.org/16848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-07-07Validate names of elements added via the APIStephan Bergmann2-0/+74
Change-Id: I052f8ca6a8788665acb1bf87456f7cc67d64c365
2015-07-02Minor clean upStephan Bergmann1-29/+23
Change-Id: I7be5bf1319ac927ffb746d47f9e0d596284e2283
2015-07-01parseFileLeniently is always called with data_ as argumentStephan Bergmann2-10/+9
Change-Id: I1c4f5e468062ced7f76b877939f96435b00d05e3
2015-06-08cppcheck: noExplicitConstructorCaolán McNamara7-7/+7
Change-Id: Ie2ae923ad4c1a66e779711de6ff05328ef144dac
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann3-0/+3
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-02loplugin:staticmethodsNoel Grandin1-1/+1
Change-Id: I3ae555fd9f0dc3c11ea301ee1cb2c799fbec820d
2015-04-01Add isReadOnly() support to simplified configuration accessStephan Bergmann1-0/+13
[API CHANGE]: extends the css.configuration.XReadWriteAccess in an incompatible way, but that is unpublished, has been commented as "still unpublished and unstable," and was specifically introduced for internal use by the simplified configuration access, so should not affect 3rd party code. Change-Id: I99ce045f5bd8c598e689d46fb0d3626dfaa6d0a0
2015-04-01Add support for cppu::UnoType<void>Stephan Bergmann1-2/+2
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
2015-03-11V668 no sense in testing the result of new against nullCaolán McNamara1-59/+56
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-02-16incomplete type error under some compilersCaolán McNamara2-4/+4
Change-Id: I87740d4d035bc4e430d566f4672bfd338511d3a8
2015-02-16restore dependenciesCaolán McNamara2-0/+3
Change-Id: I20645122bc80d729093dff8d1a8094c6fbf7d68a
2015-02-16boost::noncopyable->'= delete'Caolán McNamara16-44/+67
Change-Id: If0f898a1e912fcd2095d8ba88b2b8046596e16ea
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara10-19/+18
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-12coverity#1269597 Uncaught exceptionCaolán McNamara1-4/+4
and coverity#1269596 Uncaught exception Change-Id: I0466e66cd33dd842296131f73376bc95308254e4
2015-02-11loplugin:unreffunStephan Bergmann1-178/+184
Change-Id: I6cfa63043460a5776873087c62cfbb2753c88f83
2015-02-11tdf#46723 - enable configmgr unit testsRadu Ioan2-49/+41
Known limitation: Disabled testThreads because it fails on writerThreads libreoffice/configmgr/qa/unit/test.cxx:500:(anonymous namespace)::Test::testThreads assertion failed - Expression: success Some exception is catched for some writerThread Change-Id: I5b891bec25599c4536827ffa7ea514b1cdf08b46 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-02-10cppcheck: assertWithSideEffectCaolán McNamara1-2/+3
Change-Id: I6601e857394d7b460a105e851529350a62d1a2a6
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage4-22/+21
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2014-12-16configmgr: Use appropriate OUString functions on string constantsStephan Bergmann3-6/+6
Change-Id: I7345234957aab62e884c0e884ac0b3b8a21e9cc5
2014-12-05Revert "Log parsing time of each xcd file"Stephan Bergmann2-4/+3
This reverts commit ca85c87bf66d15e689cb09daf5dab5c4467046bc, c57fb9ea459f08c33a4b8c129938411a59a19b77 "Use xmlreader::XmlReader::getUrl" was meant for real.
2014-12-04Log parsing time of each xcd fileTor Lillqvist2-3/+4
Change-Id: I290e2c84b17b9b5063139c6027b72f6cd3a78a99
2014-12-04SAL_INFO how long parseXcsXcuLayer() and parseResLayer() tookTor Lillqvist1-0/+4
Change-Id: I1e71b8a6348301cd5b3fed0ae8b3346ae3e07d8e
2014-11-18cppu: clean up public headers with include-what-you-useMichael Stahl1-0/+1
Unfortunately iwyu gets quite confused by the weird cyclic dependencies between various foo.h/foo.hxx and cppumaker generated headers, so it's not obvious if any improvement here is realistic... Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava1-1/+1
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>