Age | Commit message (Collapse) | Author | Files | Lines |
|
...otherwise, at least with some --with-system-boost versions and C++11
compilers, like with Fedora's boost-1.50.0-4.fc18.x86_64 and
gcc-c++-4.7.2-8.fc18.x86_64, using this to copy-construct an instance of
boost::unordered::detail::ptr_node<std::pair<rtl::OUString,Bootstrap_Impl*>> in
the call to p_bootstrap_map->insert(...) in rtl_bootstrap_args_open
(sal/rtl/source/bootstrap.cxx) would memcopy the ptr_node and fail to call
rtl_uString_acquire, leading to memory corruption later on when
rtl_uString_release is called one time too often.
It is not entirely clear to me whether this is a shortcoming of the given Boost
version, but this patch solves the problem and brings rtl::Allocator::construct
in line with the (changed) Allocator requirements of C++11 anyway.
The problem potentially lurks with every use of rtl::Allocator, but only showed
now begining with LO 4.0 where e5111574fd904b38a3980ca4ea3d21cfcb22dea6 "Revert
'sb140: sb140: #i116981# clean up memory upon exit'" re-introduced code into
rtl_bootstrap_args_open that inserts into a boost::unordered_map that uses
rtl::Allocator.
(cherry picked from commit c91d353872b7d4e1a39192bff1444b46cab6e5eb)
Conflicts:
config_host/config_global.h.in
...solved by resorting to the old -DHAVE_CXX11_PERFECT_FORWARDING logic spread
across various solenv/.../*.mk instead.
(cherry picked from commit https://gerrit.libreoffice.org/#/c/2166/1)
Conflicts:
configure.ac
solenv/gbuild/platform/com_GCC_defs.mk
solenv/gbuild/platform/com_MSC_defs.mk
Change-Id: I3be22f59a8eb49d31458480c27f3ce15803c7fd4
Reviewed-on: https://gerrit.libreoffice.org/2167
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
Conflicts:
desktop/source/app/sofficemain.cxx
instsetoo_native/util/openoffice.lst
solenv/inc/minor.mk
Change-Id: I3e9510067c7173f6c71368e70ba6dfe168c5318e
|
|
Change-Id: I4b79502121f9cb1577214a2c22ffa20bb599e419
|
|
integreated with mono-climaker-config.diff and
allow building with mono-2
Conflicts:
configure.in
set_soenv.in
Change-Id: If119de1df872fd3fd9ba460e961724b6182b3899
|
|
Change-Id: If6c607fc9f0be1f7a71eda8d555399451938c5fc
Signed-off-by: Jan Holesovsky <kendy@suse.cz>
|
|
Fix typo that had intro bitmap always be default in 3.6 series.
Change-Id: I7822ab75c718040128231f5d50913c3b128d49fd
Reviewed-on: https://gerrit.libreoffice.org/475
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
This reverts commit 4c2e9fc655b6480ffc7f0feb5d07b8106b6b8e22.
Change-Id: Iea84991ee689240fe6e6ddbc47f44b444f582dde
|
|
This commit breaks MinGW builds; the m4 macros probably need some
improvements there.
This reverts commit 5ed17233908c7f87b08b0964b55e4504d964ed71.
|
|
Change-Id: Ie04e4860363dd3db7c363408c6c8c9e80d9315c0
|
|
INCLUDE is used by MSVC (http://msdn.microsoft.com/en-us/library/kezkeayy.aspx)
and make somehow (not sure why) exports the INCLUDE that gbuild uses,
which (again, not sure why) causes MSVC to report a misleading error about
incorrect argument. There actually does not appear to be any (unreasonably)
low path length limit on Windows.
Change-Id: I9329eb668f7a710ec69c8b5262b855f346ed01d2
|
|
Change-Id: I989af1147711f0175bf889bc55043b2d84a49b38
|
|
Change-Id: I38a3dfb14375bb4abee7beaa3127c3a4cce1b9a2
|
|
|
|
Change-Id: I8ed3642aca7581cb50c4be1c519c6664296734b8
|
|
Change-Id: I241be2704a069ec1f6be5861084039569673cc12
|
|
Change-Id: I6f468005c8d8d99d9251a9c4fe4629b98bc4aa5e
|
|
The recent addition of Hebrew line breaking rules apparently does not
work with genbrk from ICU 4.6. Maybe we should just require 4.x (where x
is the first version where it is implemented) as minimum ICU version?
IMHO it would be better than this insane (and fragile) filtering...
Change-Id: Ia2adad3621fa7a2f319a07fb569b1f1c1eb6db7c
|
|
we have both a SYSTEM_LIBJPEG and SYSTEM_JPEG but only SYSTEM_JPEG appears to
be used
Change-Id: Ib1a5da4c907222be33465ce06997f111c4fffe87
|
|
This allows us not to have cups during the build time of libreoffice.
Commit is inspired from patch from Dave Flogeras <dflogeras@gmail.com>.
Change-Id: I I32a14eb6e7bdd13de1a737d4798c852a830ae326
|
|
OOo used to use debug level this way:
0 is default for product build
1 for --enable-dbgutil
2 for environment variable debug=t, regardless of dbgutil setting
in LO these have now morphed into:
0 is default for product build
1 for environment variable debug=t
2 for --enable-dbgutil (at some intermediate stage in the past)
1 for --enable-dbgutil (today)
This has caused a lot of confusion and some things were not converted
properly, including a check in LinkTarget.mk.
Developers should use --enable-debug to get useful information,
including full debug info and assertions.
--enable-symbols is not intended for developers, but for people
who need their builds to be able to produce useful stack traces;
--enable-symbols is for example set unconditionally in the Fedora RPM
spec, and for this purpose disabling of inlining is not wanted.
It is unlikely that somebody wants symbols for only part of the build,
and consequently a different mechanism is used to set the corresponding
flags: they are set into global gb_LinkTarget_C{,XX}FLAGS.
So move the selective symbol feature back to --enable-debug.
(this substantially reverts db8df57acd601ed084bd0122683e1bd066a4f143)
|
|
It is done the same way the beanshell is handled.
Currently it can't be enabled by default as internal version has
patched-in debug interface.
We can choose two paths, rewrite the code to the new rhino debug
interface or just strip the current one out.
Change-Id: I48af18c635816db8269f13a649b62e9c454ee1e6
|
|
|
|
Change-Id: I7d5d8e380e12cc66255ddc3ac3f70bab7713f8b6
|
|
Signed-off-by: Petr Mladek <pmladek@suse.cz>
|
|
|
|
Maybe they'll be supported somewhen in the future, so do not hardcode
them out. Also, gb_DEBUG_C(XX)FLAGS are apparently common GCC options,
not platform-specific.
|
|
the argument given now can
- be 'all', meaning everything
- start with -, meaning not to enable symbols for that item
- end with /, meaning everything in that toplevel directory
- be a target of the form targettype_name, e.g. Library_swui
Note that there is no ordering and removal takes precedence.
|
|
- move using optimization, symbols (i.e. debug) and environment
cflags/cxxflags into one place
- --enable-dbgutils is independent from --enable-debug, and thus
also --enable-symbols, so it should not set debuglevel
- setting -g flag is controlled by --enable-symbols, not --enable-debug,
so it should be used also for selective -g enabling
- setting debug flags depending on debuglevel being 2 is certainly wrong
- do not let environment cflags/cxxflags disable optimization/symbols flags
completely, if one wants, it's possible to explicitly specify e.g. -g0,
but the current way does not make it easily possible to specify e.g.
-fcolor-diagnostics
- do not set debug flag globally now that it can be done selectively
|
|
Even if it does nothing because there is no installation available .-)
|
|
with this you can now do:
./autogen.sh --enable-debug="sw sc"
and your build will have debug version of the libraries sw and sc, but a
non-debug build elsewhere. This currently only works for libraries. It would be
also possible to extend that to excutables, but that would need explicit in the
enable-debug switch then:
./autogen.sh --enable-debug="Library/sw Library/sc Executable/mkunroll"
so I dont know if it is worth it.
|
|
|
|
|
|
This reverts 0c08a84c04b166ab6479716e2c33cd444d7e3dbe and instead strips the
Prepend variable during build time.
|
|
|
|
$(file is a new function that landed in gnu-make cvs
it allow to write a makefile variable directly into a file
bypassing the usual command line size limitiation
|
|
|
|
|
|
|
|
libxslt in Fedora mingw packages depends on it.
|
|
|
|
The idea is to use libo_MINGW_CHECK_DLL for libs that must be available
(typically that would be the "main" library, e.g., libxml2 or libcurl)
and libo_MINGW_TRY_DLL for possible dependencies (that may not be the
same on different systems). All further references to the dlls are
exclusively through the configured variables or defines set from these
variables (e.g., instead of hardcoding libxml2-2.dll, use
$(MINGW_LIBXML2_DLL)).
The macros are documented in m4/mingw.m4 .
Files that must be changed when adding a new dll:
* configure.in
* config_host.mk.in
* external/mingw-dlls/makefile.mk
* scp2/source/ooo/makefile.mk
* scp2/source/ooo/mingw_dlls.scp
|
|
Since OString already has a ctor accepting const char*, I cannot
find out a way to distinguish string literals other than using
a template, otherwise const char* somehow takes precedence
(all of gcc, clang, msvc). But the template requires
the Substitution Is Not A Failure Idiom to actually create
only wanted instances. And the compiler can try evaluate
the OString ctor as a possibility when comparing an int to
an anonymous enum, and anonymous enum as a type without linkage
cannot be a template argument before C++11. SFINAE should still
work, but not with gcc older than 4.0.2 (which we right now
use only on macs). So for that case disable the string literal
ctors, which means macs will have one extra strlen call,
and also that embedded \0's in string literals will be
inconsistent. The tiny performance problem shouldn't matter that
much and will eventually go away, the \0 problem should not
matter, since before string literal ctors were introduced
\0's had not been included anyway unless RTL_CONSTASCII_STRINGPARAM
was used. So we should be safe and when removing the CONSTASCII
macros \0 cases should be handled by explicitly mentioning
the length.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|