summaryrefslogtreecommitdiff
path: root/compilerplugins
AgeCommit message (Collapse)AuthorFilesLines
2020-05-04Adapt test code to Clang 11 trunk changeStephan Bergmann1-2/+2
...<https://github.com/llvm/llvm-project/commit/ 159a9f7e76307734bcdcae3357640e42e0733194> "[AST] Print a<b<c>> without extra spaces in C++11 or later." Change-Id: Ic8a2ab1ee9082e150cf0ebe1f6538a1a1deb7853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93409 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-01improve loplugin:makesharedNoel Grandin2-16/+138
to find places where we are converting stuff to unique_ptr instead of using std::make_shared. As a bonus, this tends to find places where we are using shared_ptr where we can instead be using unique_ptr avoiding the locking overhead. Change-Id: I1b57bbc4a6c766b48bba8e25a55161800e149f62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93207 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-30Fix typosAndrea Gelmini1-1/+1
Change-Id: I8d0e10b08393b7752d55298e0e1ba64e5fd6c422 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93083 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-04-28Silence loplugin:cppunitassertequals when comparing pointer against nullptrStephan Bergmann3-6/+24
I need that for another upcoming commit. Change-Id: If7e567c731e454070bf8ad9efb5c2f28ff9049e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93031 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-25convert excel filter in calc from shared_ptr to rtl::ReferenceNoel Grandin1-0/+11
ref-counting traffic here accounts for 10% of the profile on some of my calc imports. Change-Id: I1b32e0e61d7bf5eb65780ec0e7fcb99f6576050a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-25loplugin:constantparamNoel Grandin4-379/+391
Change-Id: Id6197d72ae136da04dfb22c847623004b797d75d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92840 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-25loplugin:unusedmethodsNoel Grandin1-71/+19
Change-Id: I7ba901c7d6e1e88d9d2821df4a37ebbea3b63084 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-24loplugin:unnecessaryvirtualNoel Grandin2-16/+12
Change-Id: Iec5de34f908ac370302ab51a33f17dfc23ea2446 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-24loplugin:unusedmethodsNoel Grandin1-83/+155
Change-Id: Ieec5099a8ce9fa3f07e36be244071efc1b101cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23Drop Macromedia Flash export filterGabor Kelemen6-23/+0
Flash technology is going to be retired by the end of 2020 by Adobe: https://theblog.adobe.com/adobe-flash-update/ With this ahead doesn't make much sense for LO 7.0 to support exporting presentations and drawings to swf anymore. Change-Id: Ic2c6e95db2f56bcd4eb25abdd0a6748aee9b0e4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92507 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-23Fix typoAndrea Gelmini1-1/+1
Change-Id: I07f828e8a17de03cf15639df8afa0adf5dcaebba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92246 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-21weld FontNameBoxCaolán McNamara1-1/+3
with custom row rendering Change-Id: Ia909b5b9ad56b6ea4611e9ea0a1e2cb0064a8cd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-20compilerplugins: fix building against baseline clang (5.0.2)Miklos Vajna1-2/+2
Where the Optional ctor is explicit. Change-Id: I577661c022f25502260977a6ef6744e4e178acc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92519 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-04-17improve failure mode in flatten lopluginNoel Grandin1-21/+31
rather than asserting, write out a warning so that section of code can be handled manually Change-Id: I1356012f4e480cff9508dad6c2d70cbbba1a5dc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15Related tdf#130778: New About dialogHeiko Tietze1-8/+0
More flexible dialog logo & about images as SVGs Change-Id: Icefa035893e241a7dee6aa28236e6b89b38477de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91908 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-14loplugin:buriedassign in c*Noel Grandin2-122/+479
Change-Id: Id14fed7e5c0f588ad3c927f12251432d12c1a7c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11Adapt loplugin:unnecessaryparen to C++20 CXXRewrittenBinaryOperatorStephan Bergmann1-0/+5
...as is used by GCC trunk libstdc++ std::unique_ptr since <https://gcc.gnu.org/ git/?p=gcc.git;a=commitdiff;h=5b074864f8c593fd4bccee788a023a37b446b2ed> "libstdc++: Add comparison operators to std::unique_ptr", which caused unexpected warnings like > sfx2/source/dialog/tabdlg.cxx:1057:17: error: parentheses immediately inside vardecl statement [loplugin:unnecessaryparen] > bool bSet = ( m_pSet != nullptr ); > ^~~~~~~~~~~~~~~~~~~~~ (CXXRewrittenBinaryOperator was introduced with <https://github.com/llvm/ llvm-project/commit/778dc0f1d49230f53401ae0c190fe460bda4ffd1> "[c++20] Add CXXRewrittenBinaryOperator to represent a comparison", which first appeared in LLVM 10.) Change-Id: I68024d975dc4accbfa9da855baa37bf9f990b99c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92061 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-08loplugin:flatten in i18npoolNoel Grandin1-0/+5
and workaround a clang crash Change-Id: Ida94c8abb4b2e997d38a7f430e59f73aadf8fcc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91844 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-07new loplugin:unusedvariableplusNoel Grandin1-0/+510
a particularly aggressive checker, which is why it is off by default Change-Id: Id5a0faa50b3ecc75e01f4aedc6579c5209e585da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-06remove newly unused stuffCaolán McNamara2-6/+0
Change-Id: Idce9955294372817c0dd1f40ebd38f16fc90eab5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91007 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-03loplugin:finalclasses in xmlsecurity..UnoControlsNoel Grandin1-2/+4
Change-Id: I8e942bf37c9173a01bef6e1403ca21f579e7f608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91612 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-03loplugin:constantparamNoel Grandin4-506/+542
Change-Id: I9cdd15185cfa8347a08402da956eab7cbdd63de6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-03loplugin:singlevalfieldsNoel Grandin2-45/+57
Change-Id: I69c5b28636806e45d7ba5d8c4678caeda09caa50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91607 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-03loplugin:unusedfieldsNoel Grandin4-443/+399
Change-Id: I4abf2df75c54936e02a8a3d8fa26f2b249e69780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91606 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-03loplugin:unnecessaryvirtualNoel Grandin2-48/+56
Change-Id: If50fcacc6710f582281d8030c97c39a5d2201390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91572 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-02loplugin:virtualdeadNoel Grandin3-96/+111
Change-Id: I5698862e5890d3208bc7012b0ce5b60520797c2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91571 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-02loplugin:unusedmethodsNoel Grandin1-153/+135
Change-Id: I906234a38b96c6ba6eaadf7693abd33e98debf50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-28Fix is_typed_flags for BrowseMode (compilerplugins)Julien Nabet2-2/+2
Change-Id: Ia6fecc08b2ee66b3e831f2c6289575ca98976783 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91281 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-26Extend loplugin:cstylecast to certain function-style castsStephan Bergmann2-24/+74
...that are equivalent to const_cast or reinterpret_cast, and should arguably better be written that way for clarity. Drawing inspiration from <https://reviews.llvm.org/D76572> "Replace `T(x)` with `reinterpret_cast<T>(x)` everywhere it means reinterpret_cast. No functional change". Change-Id: I27b8f70d324d32ecba658db4d1c2db03e10d5d3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91086 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-23Fix typosAndrea Gelmini1-2/+2
Change-Id: Iba46fbe8559211403118a23cd198a2217b333a81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90900 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-19loplugin:redundantpointerops add some more smart pointer typesNoel Grandin1-4/+9
Change-Id: Ia7f3441404d8d2e5de501e70da496b6fdc6c9a4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90728 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-10Deref of DynTypedNode* must not outlive owning DynTypedNodeListStephan Bergmann2-4/+6
Change-Id: I8ac4a2f1e442446384b88f38bdef21644409f8a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90303 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-09compilerplugins: remove unused getDeclContext()Miklos Vajna1-18/+0
Change-Id: I523cc2195be5f200b3e416d1ec3b282e3245ebbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90214 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-09Add --disable-compiler-plugins-analyzer-pch for Jenkins/linux_clang_dbgutil_64Stephan Bergmann2-6/+3
<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/54883/> had been a case I noticed of a "Gerrit Linux clang/dbgutil" build failing due to stale PCH information: [...] > [build GEN] compilerplugins/clang/sharedvisitor/makeshared.plugininfo > fatal error: file '/usr/include/asm-generic/errno.h' has been modified since the precompiled header '/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/compilerplugins/clang/sharedvisitor/clang.pch' was built > note: please rebuild precompiled header '/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/compilerplugins/clang/sharedvisitor/clang.pch' [...] and this issue had apparently caused all those Gerrit Jenkins builds to fail for at least a day. For unmaintained builds like those, I think it is better to have a more robust setup, where stale PCH information cannot break the build. Also, as those builds do not make compilerplugins.clean and rather share it across builds, there should not be much of a performance impact when disabling PCH in the analyzer. (It turns out that compilerplugins/clang/sharedvisitor/analyzer.cxx would always have enabled PCH, as compilerplugins/Makefile-clang.mk always passes in some definition of LO_CLANG_USE_ANALYZER_PCH. Fixed that now.) Change-Id: I7b8b24c1049c501634bd59c5fb482bec72427cf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90211 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-03-09improve loplugin:unusedfieldsNoel Grandin7-103/+373
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06loplugin:unusedmethodsNoel Grandin1-158/+180
Change-Id: I698981490eb1391930cdd06821a80a5f770e000e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02Adapt compilerplugins to Clang trunk changeStephan Bergmann6-10/+8
<https://github.com/llvm/llvm-project/commit/ 93184a8eda272c65308906836b47cbf209de779e> "Remove unused parameter from CXXRecordDecl::forallBases [NFC]" Change-Id: I8efdda2a37fd0df3b964401e8851a0f95f8d0ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89781 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-27loplugin:constantparamNoel Grandin4-539/+551
Change-Id: I62a0b760e49e38a4565eebf272492159047dda5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89613 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27loplugin:unusedfieldsNoel Grandin4-88/+76
Change-Id: I0d3941ed2a6f0caadbe080ac8a6273c5ec21462c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89616 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27loplugin:singlevalfieldsNoel Grandin2-71/+89
Change-Id: I3aa19805fab937cd9516ce8127753a0f599c73c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-26new loplugin:xmlimportNoel Grandin2-0/+193
to help me maintain the invariants when updating code to use the FastParser APIs. One weird invariant is that you need to override startFastElement or the createFastChildContext will not get called. Not all of these changes are probably necessary - some of the classes are never constructured themselves, only their subclasses are constructed, and their subclasses maintain the invariants, but it is just easier to scatter a few more startFastElement around Change-Id: I3f70fb5a1e44c311cf4926fa7b0fcda605709eac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-23Revert "loplugin:sequenceloop improve rvalue detection"Noel Grandin2-15/+0
This reverts commit 3aca35f1505fa552eaa316a2d47a60ef52646525. Reason for revert: see commentary at https://gerrit.libreoffice.org/c/core/+/89184 I misunderstood - even though this is a local copy, we will still call non-const begin()/end() and cause further allocations internal to the Sequence Change-Id: Ia9ecacc6312afc2c9c80ca72afe6182d9b70241b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89137 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann2-2/+2
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-21loplugin:sequenceloop improve rvalue detectionNoel Grandin2-0/+15
to avoid false positives Change-Id: Id20eb0837fa6764139af3fc4481c768700ec2dad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89184 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-21loplugin:unusedmethodsNoel Grandin1-150/+172
Change-Id: I2194158d555958f0192d8d6c18e4c093608b8fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20Adapt structurallyIdentical to current needsStephan Bergmann1-0/+3
...since aad94d48b19135a2e46ac7b2c0f41f3bb29bb5a7 "Silence warnings in salvtables.hxx", where --enable-compiler-plugins=debug had started to fail with > In file included from vcl/source/app/salvtables.cxx:75: > vcl/inc/salvtables.hxx:128:69: fatal error: TODO: Unexpected 'IdenticalDefaultArgumentsResult::Maybe' [loplugin:overrideparam] > weld_drawing_area(const OString& id, const a11yref& rA11yImpl = nullptr, > ^~~~~~~ > include/vcl/weld.hxx:2138:69: note: TODO: second argument is here [loplugin:overrideparam] > weld_drawing_area(const OString& id, const a11yref& rA11yImpl = nullptr, > ^~~~~~~ > MaterializeTemporaryExpr 0x7fdff3111360 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' lvalue > `-CXXBindTemporaryExpr 0x7fdff3111340 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' (CXXTemporary 0x7fdff3111340) > `-CXXConstructExpr 0x7fdff3111308 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' 'void (class com::sun::star::accessibility::XAccessible *)' > `-ImplicitCastExpr 0x7fdff31112f0 'class com::sun::star::accessibility::XAccessible *' <NullToPointer> > `-CXXNullPtrLiteralExpr 0x7fdff31112b0 'nullptr_t' > MaterializeTemporaryExpr 0x7fdff39275d8 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' lvalue > `-CXXBindTemporaryExpr 0x7fdff39275b8 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' (CXXTemporary 0x7fdff39275b8) > `-CXXConstructExpr 0x7fdff3927580 'const a11yref':'const class com::sun::star::uno::Reference<class com::sun::star::accessibility::XAccessible>' 'void (class com::sun::star::accessibility::XAccessible *)' > `-ImplicitCastExpr 0x7fdff3927568 'class com::sun::star::accessibility::XAccessible *' <NullToPointer> > `-CXXNullPtrLiteralExpr 0x7fdff3927528 'nullptr_t' Change-Id: I2603180571df2248d4697ba63e1a8391d0dfc596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89157 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20loplugin:unusedfieldsNoel Grandin4-122/+132
Change-Id: Ic036265f4e0b41108c5b72f0142b0aaf88d10713 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89118 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20loplugin:unnecessaryvirtualNoel Grandin2-39/+237
Change-Id: I47f0bfe8b1968ea33b0c20b06ef7d3eea3f29a61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20loplugin:singlevalfieldsNoel Grandin2-47/+41
Change-Id: I9ff752b06facfbb04c10c8f9b46b650143b02ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89117 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-19drop newly unused methodsCaolán McNamara1-4/+0
Change-Id: I390134b3cd0187f0adcced3625ad0a3a26f8fe28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 11:36:02 +0000