summaryrefslogtreecommitdiff
path: root/compilerplugins
AgeCommit message (Collapse)AuthorFilesLines
2016-08-21Move loplugin:returnbyref to storeStephan Bergmann1-0/+0
...it complains about SbxValues * data() { return &aData; } (include/basic/sbxvar.hxx) returning by pointer rather than reference, but I see nothing wrong with that. Change-Id: I1e65ed47322d3b52d0e34a8233f146af86e209f3
2016-08-17loplugin:unusedenumvalues in swNoel Grandin2-7/+15
Change-Id: Ia5faa65cd7824183cead2634edab96b5d23a6c02 Reviewed-on: https://gerrit.libreoffice.org/28072 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-16Fix check for aMinusSign in chart2/inc/SpecialUnicodes.hxxStephan Bergmann1-3/+6
Change-Id: I15e344874d90cc38acb219e7c07579d68af89043
2016-08-16new loplugin to check for static OUStringsNoel Grandin1-0/+140
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: https://gerrit.libreoffice.org/27377 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-12loplugin:unusedenumconstants in package..svtoolsNoel Grandin1-0/+10
Change-Id: I8136b93b9303ebecafd791159e813c335b1bc172 Reviewed-on: https://gerrit.libreoffice.org/28052 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11new loplugin unusedenumvaluesNoel Grandin2-0/+226
Change-Id: I2efcb0332cca23bd53088121b4cbfc702011d0b9
2016-08-11loplugin:constantparamNoel Grandin1-1/+1
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-10clang3.9 compatibilityNoel Grandin1-2/+2
Change-Id: Idbba88f1a890c068c9813aff2287f0983d1b8742
2016-08-08loplugin:unnecessaryvirtualNoel Grandin3-30/+39
Change-Id: If25d9307efda5f57b0f80a0cf5c2c5cab6a752d6 Reviewed-on: https://gerrit.libreoffice.org/27981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-29sfx2: introduce SfxViewShell::GetViewShellId()Miklos Vajna1-3/+0
This is quite similar to SwFrame::GetFrameId(), i.e. it assigns a numeric identifier to each instance to help debugging, as those identifiers are stable accross runs. Change-Id: I9cc57e316435f0284a1d481a956a703be859d67e Reviewed-on: https://gerrit.libreoffice.org/27669 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-27improve passstuffbyref return analysisNoel Grandin1-10/+84
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25loplugins: more consistent naming of output filesNoel Grandin12-26/+27
Change-Id: Ia26f697cb16078f235c94e4cff449a60c1bbd74e
2016-07-25clang 3.8 does not seem to have EvaluateAsFloatNoel Grandin1-0/+6
Change-Id: I0d846a2e9bc6db192cbf8f5dbce104c11ff409b4
2016-07-25fix for overrideparam lopluginNoel Grandin1-1/+1
Change-Id: Ibf4d3ffee0bfe335c479a15fcd183dfd8c207335
2016-07-25loplugin:overrideparam enable checking that default values matchNoel Grandin1-2/+11
Change-Id: I4ca21d12d6f5dd4bb0b2705f7e36249082b0838c
2016-07-25new loplugin overrideparamNoel Grandin1-0/+179
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-19improve unnecessaryoverride pluginNoel Grandin1-1/+8
to ignore ImplicitCastExpr when calling superclass method Change-Id: I76a3068446acfee85aa1baeb216e57f63c7099c1 Reviewed-on: https://gerrit.libreoffice.org/27279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-18Adapt to older Clang that don't have CompoundStmt::body_frontStephan Bergmann1-1/+1
Change-Id: I41555c0a2b35ad950797f65e02ed1ee060c4bf0a
2016-07-15Improve loplugin:unnecessaryoverrideStephan Bergmann1-7/+55
<sberg> thorsten, remember what that "TODO" in SvxAccessibleTextPropertySet::getSupportedServiceNames was to be about exactly, in a909acb7009acadffa53e74ea05ddb88803490f1 ? <thorsten> sberg: that's a nonsense, prolly copy'n'pasted, or a 'please review me' <sberg> thorsten, OK, thanks (that override will eventually go away with loplugin:unnecessaryoverride, and the TODO comment be lost) Change-Id: Iba964c61768459aac4067bbd4e1f7d4f78f6adac Reviewed-on: https://gerrit.libreoffice.org/27232 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15new loplugin unnecessary overrideNoel Grandin1-0/+114
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-12loplugin:cstylecast: Better heuristic...Stephan Bergmann1-29/+39
to determine code shared between C and C++ Change-Id: I1fadf69bf9d0a2bde527b7c3f2ec4c687d70e4ae
2016-07-12Fix typo relase_ChildImpl -> release_ChildImplStephan Bergmann1-1/+1
Change-Id: I68faf8cfb8eb390e7970383b8a6596a9dd3f95f7
2016-07-12only traverse the dtor's statements onceNoel Grandin1-8/+7
rather than twice, once implicitly from TraverseCXXDestructorDecl and explicitly from VisitCXXDestructorDecl Change-Id: I62a794faa530f2b54b82c86de0629afa28f30091 Reviewed-on: https://gerrit.libreoffice.org/27139 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-12new plugin constparamsNoel Grandin1-0/+407
very basic detection of pointer and reference params that can be const. Off by default until the relevant changes have landed. Change-Id: I88bba4e67307e3fb0e11dad252ec59c913828763
2016-07-12new loplugin fragiledestructorNoel Grandin1-0/+113
fix up a small number of places that it finds Change-Id: Iedc91e141edfb28f727454f698cd2155a7fd5bf4 Reviewed-on: https://gerrit.libreoffice.org/26566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-11loplugin:literaltoboolconversion: Better heuristic...Stephan Bergmann1-3/+30
to determine code shared between C and C++ Change-Id: Ib1f3892b388ebd6a67cc88831a99dfb4ccdfbc2f
2016-07-11Adapt to Clang 3.4 againStephan Bergmann1-7/+11
Change-Id: I33c1cee01593b06efca6e1aae283ce80d5cd77be
2016-07-11loplugin:salbool: Better heuristic to determine code shared between C and C++Stephan Bergmann1-7/+33
Change-Id: I09c9c57d5adeb665cc2508fad9727085a3289bfb
2016-07-11loplugin:nullptr: Better heuristic to determine code shared between C and C++Stephan Bergmann1-3/+32
Change-Id: I51e1c5fa4639e51fac90f92adf3d87d12960d589
2016-07-08loplugin:redundantcast: redundant static_castsStephan Bergmann3-0/+147
Change-Id: I4d50b77745d68a23136221ef06f327137e89fa7e
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann1-28/+45
Change-Id: I76cfdcd031430dc10c464896af2e79221e9da0c3
2016-07-06restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin1-0/+96
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05merge LineProperties with chart::ErrorBarNoel Grandin1-1/+0
Change-Id: Ic3490a15339ff981e90a86cb69c206c231db9161 Reviewed-on: https://gerrit.libreoffice.org/26932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05merge BibTabPage with BibGeneralPageNoel Grandin1-1/+0
Change-Id: I16a80e7e98fdd2be08b5a8ce586b709a3720e694 Reviewed-on: https://gerrit.libreoffice.org/26929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05merge tdoc_ucp::OfficeDocumentsEventListener withNoel Grandin1-1/+0
tdoc_ucp::ContentProvider Change-Id: I4c743ce3d61d048ae9cf762462d9042337cd9d47 Reviewed-on: https://gerrit.libreoffice.org/26903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05merge CGMOutAct with CGMImpressOutActNoel Grandin1-1/+0
Change-Id: I4d3d59b6c34edef9cd5bfd460f6379e4d1afa460 Reviewed-on: https://gerrit.libreoffice.org/26930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05merge svt::StoreString with svt::StoreContentURLNoel Grandin1-1/+0
Change-Id: I6f2a7102c697cecc96e8b950b499bc9b0f91240e Reviewed-on: https://gerrit.libreoffice.org/26904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04merge sdr::event::EventHandler with sdr::event::TimerEventHandlerNoel Grandin1-1/+0
Change-Id: Id81c6b67d95d976dae417cf225bd43347c716d06 Reviewed-on: https://gerrit.libreoffice.org/26905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04merge sfx2::IXmlIdRegistrySupplier with SfxObjectShellNoel Grandin1-1/+0
Change-Id: I7e8bad6b1c944f14b850b91b902b82613c26faeb Reviewed-on: https://gerrit.libreoffice.org/26899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04merge vcl::DisplayConnectionDispatch with vcl::DisplayConnectionNoel Grandin1-1/+0
Change-Id: I0eb83905896e1d7549a5bd4adde45e9d69209401 Reviewed-on: https://gerrit.libreoffice.org/26888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04merge ftp::ResultSetFactory with ResultSetFactoryINoel Grandin1-1/+0
Change-Id: I061145fefef33aa3e7349adf7da03222c3b2a911 Reviewed-on: https://gerrit.libreoffice.org/26898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04merge toolkit::NameContainer_Impl with toolkit::ScriptEventContainerNoel Grandin1-1/+0
Change-Id: I14e9401056e31ee9d4ad5945a73ca31969430b4c Reviewed-on: https://gerrit.libreoffice.org/26891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30loplugin:badstatics: new static only found with libc++Stephan Bergmann1-0/+3
Change-Id: I93f12629fe6aa4bddae7379a5a7ac4f4c42c7923
2016-06-30loplugin:badstatics: further (Linux-only) static only found with libc++Stephan Bergmann1-0/+2
Change-Id: I048212e3feb3f548d5a65940dd71ccb71cade778
2016-06-30Explain usage of -isystem instead of -IStephan Bergmann1-1/+2
Change-Id: Ib7153db5c2c1542ff7e9a0daa6d7124225c7701c
2016-06-30Who needs that $(CLANGDIR)/tools/clang/include anyway?Stephan Bergmann1-2/+1
It was included ever since 02a8d36ebf3d54784903f2899eafe010bedf2f4c "initial support for clang compiler plugins" but will probably point at either a non- existing dir or a dir in the Clang source tree (that does not even contain all the include files that the corresponding installation dir would contain, as some include files are generated during the build). For a properly installed LLVM/ Clang, all include files should be found underneath a single include/ dir. Change-Id: Ie23cb1ae701eed1ee78448eb6c828d07b15121c2
2016-06-29compilerplugins: -isystem /usr/include breaks the buildMichael Stahl1-1/+2
... on Fedora 24, and it's a Bad Idea in general because it breaks "#include_next" ordering of GCC's and glibc's variously distributed headers. Change-Id: I0c8b51a6d7191ec9cc5187636ea2717e8fd97715
2016-06-29loplugin:badstatics: whitelist some more staticsStephan Bergmann1-0/+6
...which use std containers and are only found at all with the libc++ container implementations, not the libstdc++ ones. Change-Id: Ic9af06139823befad4af1a9a825cba10c115aceb
2016-06-29Further clean-upStephan Bergmann1-226/+313
Change-Id: I884acbc85108f9cbd5e244c73a1f4c58a8c89613
2016-06-29Further clean-upStephan Bergmann1-46/+71
Change-Id: I2b867a93fd8c5cf3c1e4f53863c441478d9201e1