summaryrefslogtreecommitdiff
path: root/compilerplugins
AgeCommit message (Collapse)AuthorFilesLines
2014-06-17Fix logic to obtain callee's FunctionProtoType (if any)Stephan Bergmann1-6/+11
Change-Id: I1bfdd865429cc6fa89ea3b6b4fc132b5d5b57b0d
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin1-53/+57
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-13loplugin:staticcallStephan Bergmann1-0/+49
Change-Id: Id46b391c09555c9ec30916fdd93b05455835d81b
2014-06-11New loplugin:derefnullptr (all violations already fixed)Stephan Bergmann1-0/+44
Change-Id: I32cd8e740855699036c420a091c282029f8d4a08
2014-06-09compile fixNoel Grandin1-2/+28
after my commit 184a00b96235f6432294ded63ce4a4a318effdb5 "loplugin: inlinesimplememberfunctions" Change-Id: Ib46d862b90566506c3035a12eeb01892b225ed51
2014-06-09improve safety of loplugin inlinesimplememberfunctionsNoel Grandin1-0/+13
don't try and move functions containing comments Change-Id: I2de8fc8be851af979acf9d1a91e7cdd9a5dc6a32
2014-06-04new loplugin: inlinesimpleaccessmethodsNoel Grandin1-0/+282
Create a rewriting plugin for finding methods that simply return object fields, and should therefore be declared in the header, so that the compiler can reduce method calls into a simple fixed-offset load instruction. Change-Id: I7a620fc54250b79681918dc31ed9a8f21118c037 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-30New loplugin:inlinevisible to flag inline functions marked DLLEXPORTStephan Bergmann1-0/+53
...which does not make sense. On Linux and Mac OS X, they potentially end up exported from multiple libs (weakly, though), while on Windows the potentially even end up not emitted at all, which could cause link errors. Change-Id: I092c9ba39e686c17b6e91581cdd4753f1c4d582f
2014-05-22Filter out all -fsanitize= args when building compilerpluginsStephan Bergmann1-1/+1
Change-Id: Ic809ddad81608f107749498c1432606403ee2314
2014-05-22loplugin-passbyref: ignore non-base declarationsNoel Grandin1-0/+7
Only consider base declarations, not overriden ones, or we warn on methods that are overriding stuff from external libraries. Change-Id: I08791c96f7adba5997ad237a98e7c08a759042ad
2014-05-20enhance pass-by-ref plugin to detect large argumentsNoel Grandin1-14/+20
Detect arguments larger than 64 chars passed by value. Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante1-1/+1
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-16combine the pass-by-ref clang pluginsNoel Grandin2-70/+14
Change-Id: Idac24afb7cb67fa2d539553fb9fa049c2d61ecf0
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin1-0/+63
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-09compilerplugins/clang: filter out -fsanitize=addressStephan Bergmann1-1/+1
Change-Id: I3e78bd86c8010124a2d006f288095aac26e60797
2014-04-17compilerplugins: Build them in parallel.Jan Holesovsky1-1/+5
Change-Id: Idddc9a2b76e33c7e90ca51cb2c53e0d9f34d3906
2014-04-15salbool: fix commentThomas Arnhold1-1/+1
accidently removed by 5babf1b9037eb283798322eecd8334e6ff1db655 maybe obsolete now Change-Id: Id1b8ce21e08ce2df5668252406bad6fb549b5206
2014-04-15Flag unreferrenced functions only declared in the main file, not an includeStephan Bergmann2-0/+172
...which appears to be a good heuristic to identify functions that are either unused or should better be declared just once in an include file. (It also filters out SAL_DLLPUBLIC extern "C" function definitions, which are most likely meant to be referenced dynamically via dlsym.) Change-Id: I7fb78cb836b971791704851535dcfbda2b2f5bc0
2014-04-15Better be specificStephan Bergmann1-2/+2
Change-Id: Ibb9b5b8f53ab8fdeba6d3db295339ead4bde7b6e
2014-04-15add "include/comphelper" to list of includes to ignoreNoel Grandin1-0/+1
since it only contains a single sal_Bool site now, and we want to leave that alone since it's a copy of similar stuff in cppuhelper. Change-Id: I3cf4cf5f67e95d5b6f70371181f77c5451fcbf50
2014-04-03remove unnecessary scope qualifier from sal_Bool usesNoel Grandin1-1/+1
i.e. convert "::sal_Bool" to "sal_Bool" Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-02Add compat::isInMainFileStephan Bergmann2-11/+16
Change-Id: I0e155c6c68a43020110a8e1c0cb29cabdcade454
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann1-1/+19
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-27Plugin to warn about/fix verriding functions not marked SAL_OVERRIDEStephan Bergmann1-0/+158
Change-Id: I1d49aa9ad238cd5bd2e04479c2eb916f010417df
2014-03-27More compat stuffStephan Bergmann1-0/+16
(currently only used by a not-yet committed plugin, though) Change-Id: I4cff7eb97dbe10a44a911be9db090ea8cd10d8f0
2014-03-23fix filename detection in clang pluginsLuboš Luňák2-3/+3
SourceManager::getFilename() returns "<stdin>" whenever icecream is used. Change-Id: I4e3e1b90880c5fd2b53f20e4ce3e38e3a0486973
2014-03-19improve warning message in passstringbyref compiler pluginNoel Grandin1-2/+2
Change-Id: Ia8470bbd04c841e6c44c182493fede3dc312f635
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin1-0/+71
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-14More compat stuffStephan Bergmann1-0/+8
(currently only used by a not-yet committed plugin, though) Change-Id: Id62ea41031ad8ba4495ef46877ad7a10bc58fb05
2014-02-28Save the stdexception rewriter plugin used in...Stephan Bergmann1-0/+199
...5e21a413c788f839a66d9e4c14e745ed18058db8 "retrofit std::exception into overriding exception specs." Change-Id: If802bbd26b91438f3f46fe18bc763d27967bac5c
2014-02-27Remove visual noise from compilerpluginsAlexander Wilms6-9/+0
Change-Id: Ibfed0b64bd60804fa377b5e25e5f197a7772d605 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-02-25isIntegerConstantExpr is more general than IntegerLiteralStephan Bergmann1-17/+12
...and subsumes not only the use of __builtin_expect in assert, but also the use of __builtin_constant_p (nested) in htonl on Mac OS X. Change-Id: I62ab6c71c42948c4ec1e2f1e1d23223cbb13416b
2014-02-25Move plain rewriters to store/ (so they don' get built needlessly)Stephan Bergmann4-0/+0
Change-Id: I62d21e9a579bcb9c116bb272fc1236a890216cd9
2014-02-25Drop CLANGBUILD in addition to CLANGDIRStephan Bergmann1-2/+2
...see <http://lists.freedesktop.org/archives/libreoffice/2014-February/059654.html> "Drop CLANGBUILD in addition to CLANGDIR?" Change-Id: I8d68aa0f2298240c8e7265cab273c602f5b6881a
2014-02-25salbool: a rewriting plugin that flags most uses of sal_BoolStephan Bergmann2-0/+584
...that would not lead to silent changes of the code. That is, it does not warn about sal_Bool parameters of virtual functions, so that (not yet rewritten) overrides do not silently become overloads instead. The plugin is in store/ for now, because not all of the code has been cleaned up yet. Change-Id: I6e9b3847eb26c3090f375045188d38097052defe
2014-02-25...but Flags parameter was plain unsigned int prior to Clang 3.4Stephan Bergmann2-5/+23
Change-Id: Ife39abda6b5274ae196dcbf591d02fa3f36f6072
2014-02-25raw_fd_ostream Flags parameter no longer defaultedStephan Bergmann1-1/+1
...at least on trunk r202077. Change-Id: Ieb59cc7ac70e2a57ac13eefdfcbb6bfa42e25218
2014-02-24implicitboolconversion: warn about implicit conversion of call args to boolStephan Bergmann1-11/+41
...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f "sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it" earlier when converting occurrences of sal_Bool to bool. Restricting this check to function call arguments avoids too much noise while hopefully still catching all the relevant problems. (This check partially overlaps the pointertobool check, so implicit conversions from pointers to bool call arguments will now generate two loplugin warnings, but that's harmless.) Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
2014-02-21Adapt to Clang <= 3.4Stephan Bergmann2-1/+11
Change-Id: If9c9d63d85ce29629e6453f2d69355bd64ac2fc5
2014-02-21Special handling of __builtin_expect in boolean expressionsStephan Bergmann2-8/+16
...as found in Mac OS X' assert macro definition, __builtin_expect(!(e), 0) ? ... : ... with type long __builtin_expect(long, long) The code in literaltoboolconversion.cxx is needed for assert(false); Change-Id: I42f87482c56986af74b2ec849db9852f74c7c938
2014-02-21implicitboolconversion: support for Objective C BOOLStephan Bergmann1-2/+3
Change-Id: Id63f42fa8875211af9f41c21f3fa128403f8a880
2014-02-21Handle ImplicitCastExpr w/ invalid loc from Objective C codeStephan Bergmann1-1/+3
Change-Id: I82cb8aa53ea5fd86d6ff46af876dd3f55e1123d1
2014-02-21ParentBuilder needs support for ObjCMethodDeclStephan Bergmann1-0/+15
Change-Id: I8883649da31eabbc5a0f9780fb953ad58f154e1e
2014-02-21Allow building compilerplugins/clang on Mac OS XStephan Bergmann1-1/+5
(at least against a self-built Clang configured --enable-keep-symbols) Change-Id: I6e38688c78f78aca1864530042159cdcef7a0694
2014-02-20Don't attempt to actually do double code removalsStephan Bergmann4-12/+27
...that easily works around the problem that in a rewriter rewriting types of VarDecls like T x, y; it would try to replace T twice. Also, keep the list of removals globally with the (global) rewriter. Change-Id: I55b8d11986c2a29e09ff40132fd114a0cc48dc90
2014-02-20EXTERNAL_WARNINGS_NOT_ERRORS -> ENABLE_WERROR and be "TRUE"/""Matúš Kukan1-1/+1
It's easier to type 'make ENABLE_WERROR= <module>' if one wants that. Change-Id: I2bb9911259f41ecae27dc110723f3364b3ff09cf
2014-02-17Run the non-rewriter plugins even when rewriters are specifiedStephan Bergmann2-24/+11
Change-Id: I8262091c52522c54f84c0fac5fd180871d4a3a9f
2014-02-14const improvementStephan Bergmann2-2/+2
Change-Id: I03815f33117a2927b1882d221f159a5de8d3ba78
2014-02-14one more -Werror,-Wsign-compareMatúš Kukan1-1/+1
Change-Id: I3139021c07db6efe16895e10c0539a8bc60aac9c
2014-02-14-Wsign-compareStephan Bergmann1-1/+3
Change-Id: I81a7fac291c46a0ee6da76ab3e29c53ad0678b66