summaryrefslogtreecommitdiff
path: root/compilerplugins
AgeCommit message (Collapse)AuthorFilesLines
2016-04-28move stylepolice back to storeNoel Grandin1-0/+0
recent updates did not meet with universal approval Change-Id: Ic059729797049361c7a8a4ae000cd39a5993f6af
2016-04-28loplugin:stylepoliceNoel Grandin1-0/+1
Change-Id: I151e4d94f1f5dc84ef3f91218686ca9d1b9bc36f
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin1-11/+58
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-27cppcheck: silence warnings in compilerpluginsJochen Nitschke7-7/+7
mostly missing explicit before ctors and uninitialized member vars one odd use of std::find > compilerplugins/clang/implicitboolconversion.cxx > 800 stlIfFind warning Suspicious condition. > The result of find() is an iterator, but it is not properly checked. Change-Id: Iade53494cd7fe8ddb0e110e431449ae5a517fe3b Reviewed-on: https://gerrit.libreoffice.org/24398 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-27loplugin:stylepolice: adapt to libc++Stephan Bergmann1-0/+6
Change-Id: I8a471d0fb7a206f1a235c3019ae9d07b44056e01
2016-04-26Enable Clang plugin warnings in Bison source codeStephan Bergmann2-1/+5
-Werror is generally suppressed in Bison-generated C/C++ code (as in all other generated code) to silence warnings from the Bison skeleton code. And the Clang plugins suppress warnings in generated WORKDIR code based on the presumed source location (i.e., taking #line directives into account). So introduce a new PLUGIN_WARNINGS_AS_ERRORS mode where warnings from Clang plugins are reported as errors even if -Werror is suppressed. That way, any warnings in the Bison skeleton code still do not lead to compilation errors, while (at least plugin- emitted) warnings in the genuine source code do. Unfortunately this cannot also be enabled for Flex source code, as at least Flex 2.5.39 generates poor code that does not properly prefix all skeleton code with appropriate #line directives, so that some skeleton code would be mistaken for genunie source code, and compilation would fail due to errors. Also, %glr-parser Bison input appears to generate no #line directives at all (at least with Bison 3.0.4), so all of connectivity/source/parse/sqlbison.y is considered generated code and plugin warnings are still suppressed throughout. Change-Id: Id746e81cbfa5f77628b0a34c7b82780948e7db08
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin2-80/+142
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25Lots of violations in gcc3_linux_x86-64/share.hxx, too, when using libc++Stephan Bergmann1-8/+4
Change-Id: I6f32f7b1dcb97c9651bba2c03c495fb70448e524
2016-04-25Just don't bother with Clang <= 3.6Stephan Bergmann1-0/+2
...where Preprocessor::macros and Preprocessor::getLocalMacroDirectiveHistory would need to be done slightly differently Change-Id: Id46b05ac42012597c91a556b17ed008b6c7c5912
2016-04-22loplugin:reservedidStephan Bergmann1-0/+261
Change-Id: Ifa75d3f228db87f7a899612964bf08e9573fb5be
2016-04-22Avoid reserved identifiersStephan Bergmann1-1/+1
Change-Id: I263603fb81d368ebc8450b2d8cc01752fcd3f29d
2016-04-22Avoid reserved identifiersStephan Bergmann1-1/+1
Change-Id: I27ff0f4f0eb395d7e0a60dd604758c220a3134c4
2016-04-21loplugin:salbool: sal_Bool[] -> bool[]Stephan Bergmann1-11/+78
Change-Id: I3c5bf7a53c9ae173f8fce885ecf022f092aa43a9
2016-04-21Use Sequence ctor taking initializer_listStephan Bergmann1-0/+39
needed adapting loplugin:implicitboolconversion to not warn about Sequence<sal_Bool> arBool({true, false, true}); Change-Id: I971918aab7c958ef8f1e4e0548a84314e95f8325
2016-04-21typoStephan Bergmann1-1/+1
Change-Id: I67721e86073bd2f67bee3ffbbb81fd5d143997d8
2016-04-21Better fix for 13758a3d154e8e450fdfe8bcdeb6b3a03996c53aStephan Bergmann2-4/+22
"SourceManager::isMacroArgExpansion has only one param in older Clang", which caused false positives like warning about sal_False in CPPUNIT_ASSERT_EQUAL(guard.p->m1, sal_False); in cppu/qa/cppumaker/test_cppumaker.cxx Change-Id: I1c5a67527aef381e336d71cb8fefbb87961bbf96
2016-04-21move stylepolice plugin into store/Noel Grandin1-0/+0
seems std::regex is not too well supported yet, at least in libstdc++-4.8 Change-Id: Ib9feb33d2f197d40fc67dc93468aa2f7dae05bac
2016-04-21SourceManager::isMacroArgExpansion has only one param in older ClangStephan Bergmann1-3/+3
Change-Id: I5aa4f7cca70b8196263613b92c018323152411a1
2016-04-21new plugin stylepoliceNoel Grandin1-0/+80
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Warn about uses of sal_False/TrueStephan Bergmann1-0/+61
...that can generally be rewritten as false/true, and sometimes could hide errors, see e.g. <5be5f00fe16b0e255b31fbaba5f119773d1cd071> "So this is apparently about right-to-left levels, not a boolean flag". Change-Id: Ib39a936a632c2aab206f24c346252e31dcbb98f3
2016-04-20Use cast to bool to normalize sal_Bool valuesStephan Bergmann1-0/+13
Change-Id: I8a886f752d2a16ec4c10656bcd0b3631647971b2
2016-04-18Ignore external codeStephan Bergmann1-1/+2
Change-Id: Ie527703e9687a42bfc39439952b9d1a83d7cad24
2016-04-18tdf#99352 - Some VclPtrs leak past DeInitVCLNoel Grandin1-6/+2
Change-Id: I74b27b1d8b662a644df580ae128643b8495355f8 Reviewed-on: https://gerrit.libreoffice.org/24204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15update badstatics plugin to look for VclPtr<> staticsNoel Grandin1-0/+17
maybe we should create a "StaticVclPtr<>" class that checks if VCL is still "alive" before destructing the object? Change-Id: If8619f689c29294efa19c37ec782fa07acec728d Reviewed-on: https://gerrit.libreoffice.org/24085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-14turn on the passstuffbyref plugin againNoel Grandin1-1/+1
now that I have committed all of the changes to return types it found Change-Id: Iaee121037ce83e94001e4591d232b075dfeade7c
2016-04-13update loplugin passstuffbyref to check return typesNoel Grandin1-22/+88
of methods like Foo getFoo() const { return m_foo; } where we can rather do const Foo& getFoo() const { return m_foo; } and let the client code decide if it wants copy Foo. Inspired by a performance problem where we were unwittingly copy constructing a large struct repeatedly just so client code could interrogate the members of the struct. When all of the changes this plugin finds are applied, I find that 'perf stat make check' shows on average a 1.7% reduction in CPU cycles. Change-Id: Ic27b4f817aa98f2a2a009f2d4e4a962cbe9c613e
2016-04-07Avoid reserved identifiersStephan Bergmann1-1/+1
Change-Id: I438a7f28ba6bc68ec4e6244a4343e4040ab1b997
2016-04-01tdf#97966 Compiler pluginWastack1-0/+67
Warns about redundant 'static' keywords in unnamed namespace. Change-Id: Iecab69161e24d73e39a8dd5baaba6929e12d4f29 Reviewed-on: https://gerrit.libreoffice.org/23679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31loplugin:nullptr: Check for more pointer typesStephan Bergmann1-6/+11
(but did not turn up further matches) Change-Id: I7e4843d00a2e3b46edec46c5b56b6ba1b2e098fd
2016-03-30loplugin:nullptr: Find some more cases in templatesStephan Bergmann1-10/+62
Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
2016-03-29Rename OfficeIPCThread to RequestHandlerStephan Bergmann1-2/+2
Change-Id: I2076d903e83a0b8eb3aa0ce2413630e2c5415b15
2016-03-23constantparam loplugin improvementsNoel Grandin1-33/+38
clean up the python code, filter out setter methods Change-Id: I8294dd305a30708cf0e81c5328935ec8f6cdc8d4 Reviewed-on: https://gerrit.libreoffice.org/23466 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-20Ambiguity between clang:: and llvm::PointerTypeStephan Bergmann1-9/+9
Change-Id: I2727ef17b9ab780c608878aaca9ce0fda01b9c22
2016-03-16loplugin:constantparams in vcl/Noel Grandin1-32/+83
also some improvements to the plugin Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871 Reviewed-on: https://gerrit.libreoffice.org/23289 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15loplugin:constantparamNoel Grandin1-2/+9
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-11tdf#97966: Remove 'static' keywordsWastack8-15/+15
Change-Id: Id991cead4f01830eafd9cf8dd63b519ef07c9451 Reviewed-on: https://gerrit.libreoffice.org/23134 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-10MenuDispatcher::m_pMenuManager is always nullptrMaxim Monastirsky1-2/+1
... as shown by 7da15debe39b50255cc08b3fef7ae38185a9174f. Which means that MenuManager is unused, and MenuDispatcher does nothing useful. Change-Id: Ic85619531054a573d971d38b52609e1cbcaf780c Reviewed-on: https://gerrit.libreoffice.org/23117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-08Extract checking code to its own check.cxxStephan Bergmann1-1/+1
Change-Id: I9d5b14c374ce62ac7b970faa30c38a5a76568ed4
2016-03-08TODO: Work around loplugin:salbool in cppu/source/uno/data.cxx for nowStephan Bergmann1-5/+14
Change-Id: I1730c09669426e049aba941ef27341581ce31887
2016-03-08new loplugin:constantparamNoel Grandin2-0/+276
finds parameters that are only ever being called with a single value Change-Id: Ibd0c9b6e6dbc1d1b5d5a005eaa19959560a6e50f
2016-03-07loplugin:unuseddefaultparamsNoel Grandin1-1/+1
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07improve defaultparams lopluginNoel Grandin1-9/+32
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07loplugin:unuseddefaultparam in variousNoel Grandin1-1/+3
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0 Reviewed-on: https://gerrit.libreoffice.org/22900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-05fix crash in cppunitassertequals pluginMarkus Mohrhard1-4/+4
Change-Id: I0427c70aa3a7f55aba4bbe0fe571aab08596541a Reviewed-on: https://gerrit.libreoffice.org/22922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-04loplugin:unuseddefaultparam in oox/reportdesign/sdNoel Grandin1-1/+1
Change-Id: Ia26cf182ddc7c903d86bf74a8175858adb88121c
2016-03-04loplugin:unuseddefaultparam in toolsNoel Grandin1-1/+1
Change-Id: I027f4d53e3aa793bd61bf110899e464a9b6430ec Reviewed-on: https://gerrit.libreoffice.org/22891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04loplugin:unuseddefaultparam in sfx2Noel Grandin1-2/+19
and fix an issue with calls to templated methods in the plugin Change-Id: I9c9537a0690ff671286c007846d5f4cfb7d2982b
2016-03-04loplugin:unuseddefaultparams in vcl and xmloffNoel Grandin1-0/+15
and teach the plugin about code that takes the address of a function Change-Id: Ia9d5afef44520aca236659e8176f1e27135ef4fc Reviewed-on: https://gerrit.libreoffice.org/22861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-01OSingletonRegistration is dead nowMatúš Kukan1-3/+0
Change-Id: I64a5ffa8790496bd39ba26e0c789db9eedc51071 Reviewed-on: https://gerrit.libreoffice.org/22788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2016-02-29compilerplugins: fix clang-3.7 buildMiklos Vajna1-3/+3
Change-Id: I2d845d3e008cec085ce2b355c9a058363bd021cb
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 04:23:55 +0000