Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I67721e86073bd2f67bee3ffbbb81fd5d143997d8
|
|
"SourceManager::isMacroArgExpansion has only one param in older Clang", which
caused false positives like warning about sal_False in
CPPUNIT_ASSERT_EQUAL(guard.p->m1, sal_False);
in cppu/qa/cppumaker/test_cppumaker.cxx
Change-Id: I1c5a67527aef381e336d71cb8fefbb87961bbf96
|
|
seems std::regex is not too well supported yet, at least in
libstdc++-4.8
Change-Id: Ib9feb33d2f197d40fc67dc93468aa2f7dae05bac
|
|
Change-Id: I5aa4f7cca70b8196263613b92c018323152411a1
|
|
check for local variables which follow our member field naming
convention, which is highly confusing
Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
|
|
...that can generally be rewritten as false/true, and sometimes could hide
errors, see e.g. <5be5f00fe16b0e255b31fbaba5f119773d1cd071> "So this is
apparently about right-to-left levels, not a boolean flag".
Change-Id: Ib39a936a632c2aab206f24c346252e31dcbb98f3
|
|
Change-Id: I8a886f752d2a16ec4c10656bcd0b3631647971b2
|
|
Change-Id: Ie527703e9687a42bfc39439952b9d1a83d7cad24
|
|
Change-Id: I74b27b1d8b662a644df580ae128643b8495355f8
Reviewed-on: https://gerrit.libreoffice.org/24204
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
maybe we should create a "StaticVclPtr<>" class that checks if VCL is
still "alive" before destructing the object?
Change-Id: If8619f689c29294efa19c37ec782fa07acec728d
Reviewed-on: https://gerrit.libreoffice.org/24085
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
now that I have committed all of the changes to return types it
found
Change-Id: Iaee121037ce83e94001e4591d232b075dfeade7c
|
|
of methods like
Foo getFoo() const { return m_foo; }
where we can rather do
const Foo& getFoo() const { return m_foo; }
and let the client code decide if it wants copy Foo.
Inspired by a performance problem where we were unwittingly
copy constructing a large struct repeatedly just so client code
could interrogate the members of the struct.
When all of the changes this plugin finds are applied, I find
that 'perf stat make check' shows on average a 1.7% reduction
in CPU cycles.
Change-Id: Ic27b4f817aa98f2a2a009f2d4e4a962cbe9c613e
|
|
Change-Id: I438a7f28ba6bc68ec4e6244a4343e4040ab1b997
|
|
Warns about redundant 'static' keywords in unnamed namespace.
Change-Id: Iecab69161e24d73e39a8dd5baaba6929e12d4f29
Reviewed-on: https://gerrit.libreoffice.org/23679
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
(but did not turn up further matches)
Change-Id: I7e4843d00a2e3b46edec46c5b56b6ba1b2e098fd
|
|
Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
|
|
Change-Id: I2076d903e83a0b8eb3aa0ce2413630e2c5415b15
|
|
clean up the python code, filter out setter methods
Change-Id: I8294dd305a30708cf0e81c5328935ec8f6cdc8d4
Reviewed-on: https://gerrit.libreoffice.org/23466
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I2727ef17b9ab780c608878aaca9ce0fda01b9c22
|
|
also some improvements to the plugin
Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871
Reviewed-on: https://gerrit.libreoffice.org/23289
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
|
|
Change-Id: Id991cead4f01830eafd9cf8dd63b519ef07c9451
Reviewed-on: https://gerrit.libreoffice.org/23134
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
... as shown by 7da15debe39b50255cc08b3fef7ae38185a9174f.
Which means that MenuManager is unused, and MenuDispatcher
does nothing useful.
Change-Id: Ic85619531054a573d971d38b52609e1cbcaf780c
Reviewed-on: https://gerrit.libreoffice.org/23117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I9d5b14c374ce62ac7b970faa30c38a5a76568ed4
|
|
Change-Id: I1730c09669426e049aba941ef27341581ce31887
|
|
finds parameters that are only ever being called with a single value
Change-Id: Ibd0c9b6e6dbc1d1b5d5a005eaa19959560a6e50f
|
|
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795
Reviewed-on: https://gerrit.libreoffice.org/22971
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
to catch calling params with defaults like "= OUSString()"
Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9
Reviewed-on: https://gerrit.libreoffice.org/22932
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0
Reviewed-on: https://gerrit.libreoffice.org/22900
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I0427c70aa3a7f55aba4bbe0fe571aab08596541a
Reviewed-on: https://gerrit.libreoffice.org/22922
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ia26cf182ddc7c903d86bf74a8175858adb88121c
|
|
Change-Id: I027f4d53e3aa793bd61bf110899e464a9b6430ec
Reviewed-on: https://gerrit.libreoffice.org/22891
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
and fix an issue with calls to templated methods in the plugin
Change-Id: I9c9537a0690ff671286c007846d5f4cfb7d2982b
|
|
and teach the plugin about code that takes the address of a function
Change-Id: Ia9d5afef44520aca236659e8176f1e27135ef4fc
Reviewed-on: https://gerrit.libreoffice.org/22861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I64a5ffa8790496bd39ba26e0c789db9eedc51071
Reviewed-on: https://gerrit.libreoffice.org/22788
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matúš Kukan <matus@libreoffice.org>
|
|
Change-Id: I2d845d3e008cec085ce2b355c9a058363bd021cb
|
|
Change-Id: I340a066881b1962a4bcd5a2b7d9a0425d8b9557c
|
|
Change-Id: I24d2dc570070a55f39dcd708eb7c47cd71dc0d02
|
|
...instead of trying to second-guess what to strip off $(CXX) to make it fit.
Keep the old way for existing build scripts that rely on it.
Change-Id: I145bdcba6d02002a9b653b4deb6e7f5a9c76cc8f
|
|
Change-Id: I44e627fa9de9c48a534cbc9ade6cc9d567553709
|
|
Change-Id: I7691fa50d827b688cab299c85c933adabb29994c
|
|
Change-Id: Ib456e717b65c3dce3aaca73b2d55872a53d30828
|
|
Change-Id: I19f09c7d253bb86bbe3b10083f762a5791e2f370
|
|
...not the (Clang) compiler they are being built /with/. (Also simplifies the
checking #if code.)
Change-Id: I416321be4ef4478785be40571f81500fd3b6feb8
|
|
This reverts commit 4101fa184150663ddee6688c19eb4a44e341e8d4.
Just configure --without-parallelism and always use an explicit make -jN, and be
done with it. I just can't stand that "make[1]: Entering/Leaving directory"
noise around each "[build CXX] compilerplugins/clang/*.cxx" line any more.
|
|
Change-Id: I019405884dec5767de733e3fa0114b3b461e777d
|
|
add fix the method override logic
Change-Id: Ia75bc70aa1b8d26a65a4082956dc88a0fd17be9e
|
|
Change-Id: I2c3e7d66be9e3883ea2801ff394948cc580d1e44
|
|
look for places we should be calling CPPUNIT_ASSERT_EQUALS instead of
CPPUNIT_ASSERT
Change-Id: Ia836555d569069c6d0dce592f1c9a78bf8d8adb8
|
|
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
|